Commit Graph

132 Commits

Author SHA1 Message Date
Doug Bunting fef33ad4a2 Quarantine tests based on recent failures 2020-05-22 11:13:07 -07:00
Justin Kotalik 41eb22a0ac
Unquarantine tests (#21895)
* Unquarantine tests

* Update ShutdownTests.cs

* Update ShutdownTests.cs

* Update HubConnectionHandlerTests.cs

* Update src/SignalR/server/SignalR/test/HubConnectionHandlerTests.cs

Co-authored-by: Brennan <brecon@microsoft.com>

* Update HubConnectionTests.cs

Co-authored-by: Sébastien Ros <sebastienros@gmail.com>
Co-authored-by: Brennan <brecon@microsoft.com>
2020-05-18 19:04:48 +00:00
dotnet-maestro[bot] d5849f3534
[master] Update dependencies from dotnet/arcade dotnet/aspnetcore-tooling (#21630)
* Update dependencies from https://github.com/dotnet/arcade build 20200511.9
- Microsoft.DotNet.Arcade.Sdk: 5.0.0-beta.20228.4 => 5.0.0-beta.20261.9
- Microsoft.DotNet.GenAPI: 5.0.0-beta.20228.4 => 5.0.0-beta.20261.9
- Microsoft.DotNet.Helix.Sdk: 5.0.0-beta.20228.4 => 5.0.0-beta.20261.9

* Update dependencies from https://github.com/dotnet/aspnetcore-tooling build 20200514.6

Microsoft.AspNetCore.Mvc.Razor.Extensions , Microsoft.AspNetCore.Razor.Language , Microsoft.CodeAnalysis.Razor , Microsoft.NET.Sdk.Razor
 From Version 5.0.0-preview.5.20261.4 -> To Version 5.0.0-preview.6.20264.6

* Pre-emptively take -nobl change

* Disable binlogs in CI

* Fix build.sh to know about -nobl

* Align build.ps1|sh with latest Arcade parameters
- do not enable binary logs by default in CI builds
- leave `-binaryLog` and `-excludeCIBinaryLog` handling to eng/common/tools.ps1|sh
  - was unnecessary since `-bl /bl:{some name}` worked fine, ignoring OOMs

nit: document `-excludeCIBinarylog` a bit more

* Do not pass unknown options into CodeCheck.ps1

* Pass `-ci -nobl` into remaining CI build jobs

* Switch default TFM to `net5.0`

* Update missing project templates tfms

* Add more `-ci -nobl`
- needed because _all_ builds in the pipeline are implicitly CI builds
  - default-build.yml adds `-ci` when script wasn't explicit

* Default templates to net5.0

* PR feedback

* Update TFMs in explicit .nuspec files

* Update TFMs in test projects

* Update TFMs in test C# code

* Update TFMs in infrastructure files

* Future-proof a check for `net5.0` or later
- avoid comparisons involving `$(TargetFramework)` in .targets files
  - fine to compare it with `''` or `$(DefaultNetCoreTargetFramework)`

* !fixup! Undo a couple of earlier fixes
- remove a duplicate `$()` setting
- correct the one remaining versioned `#if` define
  - did not make it `#if NETCOREAPP` because benchmarks test numerous .NET Core TFMs

* Disable binary logs in CodeCheck.ps1

* Specify `-ci -nobl` just once when using `parameters.buildArgs`

* Restore `$binaryLog` default logic

Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
Co-authored-by: Will Godbe <wigodbe@microsoft.com>
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
2020-05-15 00:17:02 +00:00
N. Taylor Mullen b419ec07d6 Quarantine Microsoft.Extensions.SecretManager.Tools.Tests.SecretManagerTests.Clear_Secrets
- https://dev.azure.com/dnceng/public/_build/results?buildId=640828&view=ms.vss-test-web.build-test-results-tab&runId=19910360&resultId=108857&paneView=debug
2020-05-12 15:29:41 -07:00
Brennan 5fd4f87977
Avoid crashing in PollingFileWatcher (#21544) 2020-05-06 15:47:50 -07:00
Ajay Bhargav B 3eb812a3f5
Quarantined dotnet user-secrets test (#21412) 2020-05-01 17:49:48 -07:00
Stephen Halter 49b4f418d5
Quarantine dotnet-user-secrets InitCommandTests (#21338) 2020-04-29 20:56:43 -07:00
Andrew Stanton-Nurse 8fe81d9182
unquarantine some user secrets tests (#21304) 2020-04-29 01:20:02 +00:00
Doug Bunting 2e970f8e4f Quarantine recent test failures
- see also #21080 for another recent failure
2020-04-21 22:27:15 -07:00
Javier Calvarro Nelson 8e1e81ae78
[HTTPS] Update certificate strategy for Mac OS (#20022)
* Fixes and improvements for dotnet-dev-certs:
* Revamps the HTTPS developer certificate tool implementation.
  * It accumulated a lot of cruft during the past few years and that has made making changes harder.
* Separated the CertificateManager implementation into different classes per platform.
  * This centralizes the decision point of choosing a platform in a single place.
  * Makes clear what the flow is for a given platform.
  * Isolates changes needed for a given platform in the future.
* Moved CertificateManager to a singleton
  * No more statics!
* Updates logging to use EventSource
  * We didn't have a good way of performing logging as the code is shared and must run in multiple contexts and the set of dependencies need to be kept to a minimum.
  * Adding ETW allow us to log/monitor the the tool execution and capture the logs with `dotnet trace` without having to invent our own logging.
  * We can decide to write an EventListener in `dotnet-dev-certs` to write the results to the console output.
* Updates the way we handle the dev-cert in Mac OS to use the security tool to import the certificate into the store instead of using the certificate store.
2020-04-16 13:52:10 -07:00
John Luo 84a04c9df1
Quarantining tests (#20631)
* Quarantining tests

* Namespace collision
2020-04-08 12:53:53 -07:00
Hao Kung cc79bcc67b
Reenable cert tests on helix (#20372) 2020-04-04 13:02:22 -07:00
Ryan Brandenburg cb523d73e2
Remove test that hits HTTP (#20476) 2020-04-03 11:28:27 -07:00
Scott Addie e75ff49869
Preserve new lines and whitespace when adding secret (#19504) 2020-04-03 17:37:46 +00:00
Ryan Nowak 2c1de1621e Social distancing for tests that are symptomatic
These tests failed in official builds last night.
2020-04-02 12:52:51 -07:00
Ryan Brandenburg 7d450bba80
OpenAPI Flaky fix (#20383)
Don't use network in tests unless we have to
2020-04-01 12:52:33 -07:00
Kevin Pilch f34033a415 Add .vsconfig files in root and beside slns 2020-03-31 14:25:44 -07:00
William Godbe aff01ebd7f
Correct permalink to publishing.props (#20011) 2020-03-19 14:45:32 -07:00
William Godbe 6301eefbc3
Add comments cautioning against changing DeveloperCertificates.XPlat (#19923)
* Add comments cautioning against changing DeveloperCertificates.XPlat

* Fix bad comment ending
2020-03-19 12:27:28 -07:00
Brennan 9112030a3c
Quarantine some tests (#19932) 2020-03-17 16:31:24 -07:00
Brennan 2a1cc04a32
Ignore bad restore sources (dotnet-watch tests) (#19893) 2020-03-16 12:59:50 -07:00
Artak 5af0c471dd
Unquarantined the OpenApi tests (#19684) 2020-03-07 22:15:53 -08:00
Brennan f910345469
Enable detailed msbuild verbosity for user secrets (#19516) 2020-03-05 08:39:58 -08:00
Brennan 56fb4b4d2f
Rename Flaky attribute (#19469) 2020-03-04 08:10:18 -08:00
Andrew Stanton-Nurse e65408a36c
unquarantine a pile of long-passing tests (#19440) 2020-02-28 19:02:58 +00:00
Brennan 169f07c667
Capture test output for tools tests (#19240) 2020-02-25 09:35:29 -08:00
John Luo 5f9f1ce183 Merge branch 'master' into johluo/migrating-extensions 2020-02-20 16:44:06 -08:00
Brennan b125c76d5f
Fix watch tests again (#19155) 2020-02-20 16:03:48 -08:00
Brennan 3787d7e7f0
Merge pull request #19122 from dotnet/halter73/mega-merge
Merge branch release/3.1 --> master
2020-02-20 15:19:27 -08:00
John Luo 7d1f5d8c0b Updates for extensions migrations
- Multi-target ObjectPool
- Move Embedded.Manifest.Task.Internal.Entry to the public namespace
- Remove ref assemblies from AspNetCore.Testing
- Skip TestPathUtilitiesTest since it's a pattern we want to migrate away from
- Fix FileProviders.Abstractions version in Embedded.*.nuspec
- Add workarounds for project references to FileProviders.Embedded
2020-02-20 14:00:29 -08:00
Kahbazi d597e08518
Make user-secrets treat unmatched options as arguments (#18256) 2020-02-20 17:16:05 +00:00
Brennan 1e03d57deb
Merge branch 'master' into halter73/mega-merge 2020-02-19 14:20:10 -08:00
Brennan Conroy 2d066dcd3e Apply some fixes 2020-02-19 14:18:29 -08:00
Scott Addie e937884eb4
Secret Manager: Save project file without XML declaration (#14354) 2020-02-19 10:25:28 -08:00
Hao Kung 607a6b4f8a
Merge branch 'master' into halter73/mega-merge 2020-02-18 16:51:15 -08:00
Stephen Halter 88073f86ff Merge branch 'release/3.1' into master 2020-02-18 13:46:51 -08:00
Ryan Brandenburg 211bc40384
Revert flaky tests that seems to have been fixed (#19065) 2020-02-18 09:26:51 -08:00
Brennan 50ef4faf14
Fix dotnet watch tests on Helix (#19021) 2020-02-14 11:34:11 -08:00
Andrew Stanton-Nurse c5dd4ce7e3
Quarantining outstanding test failures (#18964)
* quarantining outstanding test failures

* look, what is CI even for anyway?

* shhhh

* who uses who?
2020-02-12 18:58:17 +00:00
Andrew Stanton-Nurse 36267e8baf
More quarantining (#18698)
* quarantine more

* actually quarantine signalr test

* more quarantining
2020-02-03 21:51:26 +00:00
Ryan Brandenburg b2e1218346
Quarantine OpenAPI tests (#18727) 2020-01-31 21:45:17 -08:00
Ryan Brandenburg b49dd9869e
Include the ExitCode in the error message (#17663)
Include the ExitCode in the error message
2020-01-31 14:00:57 -08:00
Andrew Stanton-Nurse c08221ffbe
quarantine dsome tests (#18671) 2020-01-30 05:01:03 +00:00
Will 保哥 28b0e67320 Update RemoveCommand.cs (#17848)
fix a typo
2020-01-24 15:01:54 -08:00
Kevin Pilch 91d17f6c2d
Update links from aspnet/AspNetCore-Internal -> dotnet/aspnetcore-internal (#18540) 2020-01-23 12:21:06 -08:00
dotnet-maestro-bot 2dc908d502 [automated] Merge branch 'release/2.1' => 'release/3.1' (#18396)
* [Platform] Detect and fix certificates with potentially inaccessible keys on Mac OS (2.1) (#17560)

* [Https] Detects and fixes HTTPS certificates where the key is not guaranteed to be accessible across security partitions

* Fix dotnet dev-certs https --check

* Update logic for detecting missing certs

* Fix security command

* Update warning logic

* Check that the key is accessible in Kestrel

* Add correct link to docs

* Update src/Tools/dotnet-dev-certs/src/Program.cs

Co-Authored-By: Daniel Roth <daroth@microsoft.com>

* Update src/Tools/dotnet-dev-certs/src/Program.cs

Co-Authored-By: Daniel Roth <daroth@microsoft.com>

* Add test for 2.1

* Update src/Tools/dotnet-dev-certs/src/Program.cs

Co-Authored-By: Chris Ross <Tratcher@Outlook.com>

* Address feedback

* Fix non-interctive path

* Fix tests

* Remove a couple of test from an unshipped product

* Check only for certificates considered valid

* Switch the exception being caught, remove invalid test

Co-authored-by: Daniel Roth <daroth@microsoft.com>
Co-authored-by: Chris Ross <Tratcher@Outlook.com>

* Fix patchconfig merge (#18389)

* Fix flaky HubConnectionHandler test (#18391)

Co-authored-by: Javier Calvarro Nelson <jacalvar@microsoft.com>
Co-authored-by: Daniel Roth <daroth@microsoft.com>
Co-authored-by: Chris Ross <Tratcher@Outlook.com>
Co-authored-by: Brennan <brecon@microsoft.com>
2020-01-17 08:30:12 -08:00
Javier Calvarro Nelson 8e5767bdf1 [Platform] Detect and fix certificates with potentially inaccessible keys on Mac OS (3.1) (#17581)
* [Platform] Add logic to dotnet-dev-certs to detect and fix certificates with inaccessible keys on Mac OS

* Update the docs link
2020-01-16 10:29:37 -08:00
Kevin Pilch 0517745c08 aspnet/AspNetCore -> dotnet/aspnet
Except aspnet/AspNetCore-Internal.
2020-01-08 16:40:11 -08:00
Kevin Pilch f3215fd881 aspnet/AspNetCore-Tooling -> dotnet/aspnetcore-tooling 2020-01-08 16:40:11 -08:00
Kahbazi b56f84131a Use Count instead of Any() on List (#18022) 2020-01-02 07:55:29 -08:00