Unquarantine tests (#21895)

* Unquarantine tests

* Update ShutdownTests.cs

* Update ShutdownTests.cs

* Update HubConnectionHandlerTests.cs

* Update src/SignalR/server/SignalR/test/HubConnectionHandlerTests.cs

Co-authored-by: Brennan <brecon@microsoft.com>

* Update HubConnectionTests.cs

Co-authored-by: Sébastien Ros <sebastienros@gmail.com>
Co-authored-by: Brennan <brecon@microsoft.com>
This commit is contained in:
Justin Kotalik 2020-05-18 12:04:48 -07:00 committed by GitHub
parent dad96ff373
commit 41eb22a0ac
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
11 changed files with 2 additions and 13 deletions

View File

@ -433,7 +433,6 @@ namespace Microsoft.AspNetCore.TestHost
}
[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/20164")]
public async Task ClientStreaming_ResponseCompletesWithoutResponseBodyWrite()
{
// Arrange

View File

@ -40,7 +40,6 @@ namespace Microsoft.AspNetCore.Identity.Test
[Theory]
[MemberData(nameof(ScriptWithIntegrityData))]
[QuarantinedTest]
public async Task IdentityUI_ScriptTags_SubresourceIntegrityCheck(ScriptTag scriptTag)
{
var integrity = await GetShaIntegrity(scriptTag);
@ -80,7 +79,6 @@ namespace Microsoft.AspNetCore.Identity.Test
[Theory]
[MemberData(nameof(ScriptWithFallbackSrcData))]
[QuarantinedTest("https://github.com/dotnet/aspnetcore-internal/issues/2267")]
public async Task IdentityUI_ScriptTags_FallbackSourceContent_Matches_CDNContent(ScriptTag scriptTag)
{
var wwwrootDir = Path.Combine(GetProjectBasePath(), "wwwroot", scriptTag.Version);

View File

@ -49,7 +49,6 @@ namespace Microsoft.AspNetCore.Authentication.DataHandler
}
[Fact]
[QuarantinedTest]
public void UnprotectWithDifferentPurposeFails()
{
var provider = ServiceProvider.GetRequiredService<IDataProtectionProvider>();

View File

@ -100,7 +100,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests.Http2
}
[ConditionalFact]
[QuarantinedTest]
[QuarantinedTest] // Test still quarantined due to Sockets.Functional tests.
public async Task GracefulTurnsAbortiveIfRequestsDoNotFinish()
{
var requestStarted = new TaskCompletionSource<object>(TaskCreationOptions.RunContinuationsAsynchronously);

View File

@ -108,7 +108,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
}
}
[Theory]
[QuarantinedTest("https://github.com/dotnet/aspnetcore-internal/issues/2489")]
[MemberData(nameof(LargeUploadData))]
public async Task LargeUpload(long? maxRequestBufferSize, bool connectionAdapter, bool expectPause)
{
@ -203,7 +202,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
}
[Fact]
[QuarantinedTest]
public async Task ServerShutsDownGracefullyWhenMaxRequestBufferSizeExceeded()
{
// Parameters

View File

@ -500,7 +500,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
[Theory]
[MemberData(nameof(ConnectionMiddlewareData))]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/20163")]
public async Task ConnectionClosedTokenFiresOnClientFIN(ListenOptions listenOptions)
{
var testContext = new TestServiceContext(LoggerFactory);

View File

@ -812,7 +812,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
[Fact]
[CollectDump]
[QuarantinedTest]
public async Task ConnectionNotClosedWhenClientSatisfiesMinimumDataRateGivenLargeResponseHeaders()
{
var headerSize = 1024 * 1024; // 1 MB for each header value

View File

@ -1336,7 +1336,6 @@ namespace Microsoft.AspNetCore.SignalR.Client.FunctionalTests
}
[Theory]
[QuarantinedTest]
[MemberData(nameof(HubProtocolsList))]
public async Task ServerLogsErrorIfClientInvokeCannotBeSerialized(string protocolName)
{
@ -1384,7 +1383,6 @@ namespace Microsoft.AspNetCore.SignalR.Client.FunctionalTests
}
[Theory]
[QuarantinedTest]
[MemberData(nameof(HubProtocolsList))]
public async Task ServerLogsErrorIfReturnValueCannotBeSerialized(string protocolName)
{

View File

@ -2782,7 +2782,6 @@ namespace Microsoft.AspNetCore.SignalR.Tests
}
[Fact]
[QuarantinedTest]
public async Task ReceivingMessagesPreventsConnectionTimeoutFromOccuring()
{
using (StartVerifiableLog())

View File

@ -26,6 +26,7 @@ namespace Microsoft.Extensions.Logging.Testing.Tests
}
[Fact]
// Keep this test in quarantine, it verifies that quarantined test logs are preserved
[QuarantinedTest]
public void FunctionalLogs_LogsPreservedFromQuarantinedTest()
{

View File

@ -420,7 +420,6 @@ namespace Microsoft.DotNet.OpenApi.Add.Tests
}
[Fact]
[QuarantinedTest]
public async Task OpenAPi_Add_URL_InvalidUrl()
{
var project = CreateBasicProject(withOpenApi: false);