More quarantining (#18698)

* quarantine more

* actually quarantine signalr test

* more quarantining
This commit is contained in:
Andrew Stanton-Nurse 2020-02-03 13:51:26 -08:00 committed by GitHub
parent 9ce01623c7
commit 36267e8baf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 12 additions and 2 deletions

View File

@ -520,6 +520,7 @@ namespace Microsoft.AspNetCore.SignalR.Client.FunctionalTests
[Theory]
[MemberData(nameof(HubProtocolsAndTransportsAndHubPaths))]
[LogLevel(LogLevel.Trace)]
[Flaky("<No longer used; tracked in Kusto>", FlakyOn.All)]
public async Task StreamAsyncTest(string protocolName, HttpTransportType transportType, string path)
{
var protocol = HubProtocols[protocolName];

View File

@ -99,6 +99,7 @@ namespace Microsoft.AspNetCore.SignalR.Client.FunctionalTests
[Theory]
[MemberData(nameof(TransportTypes))]
[Flaky("<No longer used; tracked in Kusto>", FlakyOn.All)]
public async Task ClientUsingNewCallWithNewProtocol(HttpTransportType transportType)
{
using (var server = await StartServer<VersionStartup>())

View File

@ -128,7 +128,8 @@ namespace Microsoft.AspNetCore.SignalR.Tests
messages.Add(message);
return messages;
default:
throw new NotSupportedException("TestClient does not support receiving invocations!");
// Message implement ToString so this should be helpful.
throw new NotSupportedException($"TestClient recieved an unexpected message: {message}.");
}
}
}
@ -161,7 +162,8 @@ namespace Microsoft.AspNetCore.SignalR.Tests
// Pings are ignored
break;
default:
throw new NotSupportedException("TestClient does not support receiving invocations!");
// Message implement ToString so this should be helpful.
throw new NotSupportedException($"TestClient recieved an unexpected message: {message}.");
}
}
}

View File

@ -19,6 +19,7 @@ using Microsoft.AspNetCore.Http.Connections.Features;
using Microsoft.AspNetCore.Http.Connections.Internal;
using Microsoft.AspNetCore.SignalR.Internal;
using Microsoft.AspNetCore.SignalR.Protocol;
using Microsoft.AspNetCore.Testing;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Logging;
using Microsoft.Extensions.Logging.Testing;
@ -1037,6 +1038,7 @@ namespace Microsoft.AspNetCore.SignalR.Tests
}
[Fact]
[Flaky("<No longer used; tracked in Kusto>", FlakyOn.All)]
public async Task HubMethodCanBeRenamedWithAttribute()
{
using (StartVerifiableLog())

View File

@ -39,6 +39,7 @@ namespace Microsoft.Extensions.SecretManager.Tools.Tests
[Theory]
[InlineData(null)]
[InlineData("")]
[Flaky("<No longer used; tracked in Kusto>", FlakyOn.All)]
public void Error_MissingId(string id)
{
var project = Path.Combine(_fixture.CreateProject(id), "TestProject.csproj");
@ -84,6 +85,7 @@ namespace Microsoft.Extensions.SecretManager.Tools.Tests
[Theory]
[InlineData(true)]
[InlineData(false)]
[Flaky("<No longer used; tracked in Kusto>", FlakyOn.All)]
public void SetSecrets(bool fromCurrentDirectory)
{
var secrets = new KeyValuePair<string, string>[]
@ -209,6 +211,7 @@ namespace Microsoft.Extensions.SecretManager.Tools.Tests
}
[Fact]
[Flaky("<No longer used; tracked in Kusto>", FlakyOn.All)]
public void List_Flattens_Nested_Objects()
{
string secretId;

View File

@ -24,6 +24,7 @@ namespace Microsoft.DotNet.Watcher.Tools.Tests
}
[Fact]
[Flaky("<No longer required; Tracked in Kusto>", FlakyOn.All)]
public async Task ConsoleCancelKey()
{
_tempDir