huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

unquarantine a pile of long-passing tests (#19440)

This commit is contained in:
Andrew Stanton-Nurse 2020-02-28 11:02:58 -08:00 committed by GitHub
parent ce05792551
commit e65408a36c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
21 changed files with 4 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/Hosting/Hosting/test/Internal/HostingEventSourceTests.cs
View File

@ -106,7 +106,6 @@ namespace Microsoft.AspNetCore.Hosting
[Theory]
[MemberData(nameof(RequestStartData))]
[Flaky("https://github.com/dotnet/aspnetcore-internal/issues/2230", FlakyOn.All)]
public void RequestStart(DefaultHttpContext httpContext, string[] expected)
{
// Arrange

1
src/Hosting/Hosting/test/WebHostTests.cs
View File

@ -238,7 +238,6 @@ namespace Microsoft.AspNetCore.Hosting
}
[ConditionalFact]
[Flaky("https://github.com/dotnet/aspnetcore-internal/issues/2244", FlakyOn.Helix.All)]
public async Task WebHostStopAsyncUsesDefaultTimeoutIfNoTokenProvided()
{
var data = new Dictionary<string, string>

1
src/Middleware/WebSockets/test/UnitTests/WebSocketMiddlewareTests.cs
View File

@ -550,7 +550,6 @@ namespace Microsoft.AspNetCore.WebSockets.Test
}
[Fact]
[Flaky("https://github.com/dotnet/aspnetcore/issues/8187", FlakyOn.Helix.All)]
public async Task OriginIsNotValidatedForNonWebSocketRequests()
{
using (var server = KestrelWebSocketHelpers.CreateServer(LoggerFactory, out var port, context =>

5
src/Servers/Kestrel/Kestrel/test/GeneratedCodeTests.cs
View File

@ -13,15 +13,14 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
public class GeneratedCodeTests
{
[ConditionalFact]
[Flaky("https://github.com/dotnet/aspnetcore-internal/issues/2223", FlakyOn.Helix.All)]
public void GeneratedCodeIsUpToDate()
{
var httpHeadersGeneratedPath = Path.Combine(AppContext.BaseDirectory, "shared", "GeneratedContent", "HttpHeaders.Generated.cs");
var httpProtocolGeneratedPath = Path.Combine(AppContext.BaseDirectory, "shared", "GeneratedContent", "HttpProtocol.Generated.cs");
var httpUtilitiesGeneratedPath = Path.Combine(AppContext.BaseDirectory, "shared", "GeneratedContent", "HttpUtilities.Generated.cs");
var http2ConnectionGeneratedPath = Path.Combine(AppContext.BaseDirectory, "shared", "GeneratedContent", "Http2Connection.Generated.cs");
var transportMultiplexedConnectionGeneratedPath = Path.Combine(AppContext.BaseDirectory,"shared", "GeneratedContent", "TransportMultiplexedConnection.Generated.cs");
var transportConnectionGeneratedPath = Path.Combine(AppContext.BaseDirectory,"shared", "GeneratedContent", "TransportConnection.Generated.cs");
var transportMultiplexedConnectionGeneratedPath = Path.Combine(AppContext.BaseDirectory, "shared", "GeneratedContent", "TransportMultiplexedConnection.Generated.cs");
var transportConnectionGeneratedPath = Path.Combine(AppContext.BaseDirectory, "shared", "GeneratedContent", "TransportConnection.Generated.cs");
var testHttpHeadersGeneratedPath = Path.GetTempFileName();
var testHttpProtocolGeneratedPath = Path.GetTempFileName();

3
src/Servers/Kestrel/test/BindTests/AddressRegistrationTests.cs
View File

@ -596,7 +596,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
}
[Fact]
[Flaky("https://github.com/dotnet/aspnetcore-internal/issues/2178", FlakyOn.All)]
public async Task DoesNotOverrideDirectConfigurationWithIServerAddressesFeature_IfPreferHostingUrlsFalse()
{
var useUrlsAddress = $"http://127.0.0.1:0";
@ -881,7 +880,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
var exception = Assert.Throws<IOException>(() => host.Start());
var thisAddressString = $"http://{(addressFamily == AddressFamily.InterNetwork ? "127.0.0.1" : "[::1]")}:{port}";
var otherAddressString = $"http://{(addressFamily == AddressFamily.InterNetworkV6? "127.0.0.1" : "[::1]")}:{port}";
var otherAddressString = $"http://{(addressFamily == AddressFamily.InterNetworkV6 ? "127.0.0.1" : "[::1]")}:{port}";
if (exception.Message == CoreStrings.FormatEndpointAlreadyInUse(otherAddressString))
{

1
src/Servers/Kestrel/test/FunctionalTests/ConnectionMiddlewareTests.cs
View File

@ -14,7 +14,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
{
public class ConnectionMiddlewareTests : LoggedTest
{
[Flaky("<No longer needed; tracked in Kusto>", FlakyOn.All)]
[Fact]
public async Task ThrowingSynchronousConnectionMiddlewareDoesNotCrashServer()
{

2
src/Servers/Kestrel/test/FunctionalTests/Http2/ShutdownTests.cs
View File

@ -45,7 +45,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests.Http2
[CollectDump]
[ConditionalFact]
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/9985", Queues = "Fedora.28.Amd64;Fedora.28.Amd64.Open")]
[Flaky("https://github.com/dotnet/aspnetcore/issues/9985", FlakyOn.All)]
public async Task GracefulShutdownWaitsForRequestsToFinish()
{
var requestStarted = new TaskCompletionSource<object>(TaskCreationOptions.RunContinuationsAsynchronously);
@ -101,7 +100,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests.Http2
}
[ConditionalFact]
[Flaky("https://github.com/dotnet/aspnetcore-internal/issues/2667", FlakyOn.All)]
public async Task GracefulTurnsAbortiveIfRequestsDoNotFinish()
{
var requestStarted = new TaskCompletionSource<object>(TaskCreationOptions.RunContinuationsAsynchronously);

7
src/Servers/Kestrel/test/FunctionalTests/RequestTests.cs
View File

@ -132,9 +132,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
[ConditionalFact]
[IPv6SupportedCondition]
#if LIBUV
[Flaky("https://github.com/dotnet/aspnetcore-internal/issues/1977", FlakyOn.Helix.All)] // https://github.com/dotnet/aspnetcore/issues/8109
#endif
public Task RemoteIPv6Address()
{
return TestRemoteIPAddress("[::1]", "[::1]", "::1");
@ -538,7 +535,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
}
[Theory]
[Flaky("https://github.com/dotnet/aspnetcore-internal/issues/2181", FlakyOn.Helix.All)]
[MemberData(nameof(ConnectionMiddlewareData))]
public async Task ConnectionClosedTokenFiresOnServerFIN(ListenOptions listenOptions)
{
@ -791,9 +787,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
}
[Theory]
#if LIBUV
[Flaky("https://github.com/dotnet/aspnetcore-internal/issues/1971", FlakyOn.Helix.All)]
#endif
[MemberData(nameof(ConnectionMiddlewareData))]
public async Task AppCanHandleClientAbortingConnectionMidRequest(ListenOptions listenOptions)
{

5
src/Servers/Kestrel/test/FunctionalTests/ResponseTests.cs
View File

@ -339,7 +339,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
}
[Theory]
[Flaky("https://github.com/dotnet/aspnetcore-internal/issues/1972", FlakyOn.All)]
[MemberData(nameof(ConnectionMiddlewareData))]
public async Task AppCanHandleClientAbortingConnectionMidResponse(ListenOptions listenOptions)
{
@ -640,7 +639,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
}
[Fact]
[Flaky("<no longer needed; tracked in Kusto>", FlakyOn.All)]
public async Task ConnectionClosedWhenBothRequestAndResponseExperienceBackPressure()
{
const int bufferSize = 65536;
@ -735,7 +733,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
}
[ConditionalFact]
[Flaky("https://github.com/dotnet/aspnetcore-internal/issues/2181", FlakyOn.All)]
public async Task ConnectionNotClosedWhenClientSatisfiesMinimumDataRateGivenLargeResponseChunks()
{
var chunkSize = 64 * 128 * 1024;
@ -815,7 +812,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
[Fact]
[CollectDump]
[Flaky("<No longer needed; tracked in Kusto>", FlakyOn.All)]
public async Task ConnectionNotClosedWhenClientSatisfiesMinimumDataRateGivenLargeResponseHeaders()
{
var headerSize = 1024 * 1024; // 1 MB for each header value
@ -903,7 +899,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
}
[Fact]
[Flaky("https://github.com/dotnet/aspnetcore/issues/13219", FlakyOn.AzP.Linux, FlakyOn.Helix.All)]
public async Task ClientCanReceiveFullConnectionCloseResponseWithoutErrorAtALowDataRate()
{
var chunkSize = 64 * 128 * 1024;

3
src/Servers/Kestrel/test/InMemory.FunctionalTests/HttpsConnectionMiddlewareTests.cs
View File

@ -310,7 +310,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.InMemory.FunctionalTests
}
[Theory]
[Flaky("<no longer needed; tracked in Kusto>", FlakyOn.All)]
[InlineData(HttpProtocols.Http1)]
[InlineData(HttpProtocols.Http1AndHttp2)] // Make sure Http/1.1 doesn't regress with Http/2 enabled.
public async Task CertificatePassedToHttpContext(HttpProtocols httpProtocols)
@ -391,7 +390,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.InMemory.FunctionalTests
}
[Theory]
[Flaky("https://github.com/dotnet/aspnetcore-internal/issues/1976", FlakyOn.All)]
[InlineData(ClientCertificateMode.AllowCertificate)]
[InlineData(ClientCertificateMode.RequireCertificate)]
public async Task ClientCertificateValidationGetsCalledWithNotNullParameters(ClientCertificateMode mode)
@ -426,7 +424,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.InMemory.FunctionalTests
}
[ConditionalTheory]
[Flaky("https://github.com/dotnet/aspnetcore-internal/issues/1950", FlakyOn.Helix.All)]
[InlineData(ClientCertificateMode.AllowCertificate)]
[InlineData(ClientCertificateMode.RequireCertificate)]
public async Task ValidationFailureRejectsConnection(ClientCertificateMode mode)

1
src/Servers/Kestrel/test/InMemory.FunctionalTests/LoggingConnectionMiddlewareTests.cs
View File

@ -14,7 +14,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.InMemory.FunctionalTests
public class LoggingConnectionMiddlewareTests : LoggedTest
{
[Fact]
[Flaky("https://github.com/dotnet/aspnetcore-internal/issues/2276", FlakyOn.Helix.All)]
public async Task LoggingConnectionMiddlewareCanBeAddedBeforeAndAfterHttps()
{
await using (var server = new TestServer(context =>

1
src/Servers/Kestrel/test/InMemory.FunctionalTests/RequestTests.cs
View File

@ -790,7 +790,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.InMemory.FunctionalTests
}
[Fact]
[Flaky("https://github.com/dotnet/aspnetcore-internal/issues/2176", FlakyOn.All)]
public async Task ContentLengthReadAsyncSingleBytesAtATime()
{
var testContext = new TestServiceContext(LoggerFactory);

1
src/Servers/Kestrel/test/InMemory.FunctionalTests/ResponseTests.cs
View File

@ -2541,7 +2541,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.InMemory.FunctionalTests
}
[Fact]
[Flaky("https://github.com/dotnet/aspnetcore/issues/12401", FlakyOn.All)]
public async Task AppAbortViaIConnectionLifetimeFeatureIsLogged()
{
var testContext = new TestServiceContext(LoggerFactory);

1
src/SignalR/clients/csharp/Client/test/FunctionalTests/HubConnectionTests.cs
View File

@ -520,7 +520,6 @@ namespace Microsoft.AspNetCore.SignalR.Client.FunctionalTests
[Theory]
[MemberData(nameof(HubProtocolsAndTransportsAndHubPaths))]
[LogLevel(LogLevel.Trace)]
[Flaky("<No longer used; tracked in Kusto>", FlakyOn.All)]
public async Task StreamAsyncTest(string protocolName, HttpTransportType transportType, string path)
{
var protocol = HubProtocols[protocolName];

2
src/SignalR/clients/csharp/Client/test/FunctionalTests/HubProtocolVersionTests.cs
View File

@ -65,7 +65,6 @@ namespace Microsoft.AspNetCore.SignalR.Client.FunctionalTests
[Theory]
[MemberData(nameof(TransportTypes))]
[Flaky("<No longer needed; tracked in Kusto>", FlakyOn.All)]
public async Task ClientUsingOldCallWithNewProtocol(HttpTransportType transportType)
{
using (var server = await StartServer<VersionStartup>())
@ -99,7 +98,6 @@ namespace Microsoft.AspNetCore.SignalR.Client.FunctionalTests
[Theory]
[MemberData(nameof(TransportTypes))]
[Flaky("<No longer used; tracked in Kusto>", FlakyOn.All)]
public async Task ClientUsingNewCallWithNewProtocol(HttpTransportType transportType)
{
using (var server = await StartServer<VersionStartup>())

1
src/SignalR/common/Http.Connections/test/HttpConnectionDispatcherTests.cs
View File

@ -1295,7 +1295,6 @@ namespace Microsoft.AspNetCore.Http.Connections.Tests
}
[Fact]
[Flaky("<No longer needed; tracked in Kusto>", FlakyOn.All)]
public async Task RequestToActiveConnectionIdKillsPreviousConnectionLongPolling()
{
using (StartVerifiableLog())

1
src/SignalR/server/SignalR/test/EndToEndTests.cs
View File

@ -308,7 +308,6 @@ namespace Microsoft.AspNetCore.SignalR.Tests
}
[ConditionalTheory]
[Flaky("https://github.com/dotnet/aspnetcore-internal/issues/1383", FlakyOn.All)]
[WebSocketsSupportedCondition]
[InlineData(5 * 4096)]
[InlineData(1000 * 4096 + 32)]

1
src/SignalR/server/SignalR/test/HubConnectionHandlerTests.cs
View File

@ -1039,7 +1039,6 @@ namespace Microsoft.AspNetCore.SignalR.Tests
}
[Fact]
[Flaky("<No longer used; tracked in Kusto>", FlakyOn.All)]
public async Task HubMethodCanBeRenamedWithAttribute()
{
using (StartVerifiableLog())

1
src/Tools/dotnet-user-secrets/test/InitCommandTest.cs
View File

@ -57,7 +57,6 @@ namespace Microsoft.Extensions.SecretManager.Tools.Tests
}
[Fact]
[Flaky("<no longer needed; tracked in Kusto>", FlakyOn.All)]
public void AddsEscapedSpecificSecretIdToProject()
{
const string SecretId = @"<lots of XML invalid values>&";

3
src/Tools/dotnet-watch/test/GlobbingAppTests.cs
View File

@ -104,11 +104,10 @@ namespace Microsoft.DotNet.Watcher.Tools.FunctionalTests
}
[Fact]
[Flaky("<No longer needed; tracked in Kusto>", FlakyOn.All)]
public async Task ListsFiles()
{
await _app.PrepareAsync();
_app.Start(new [] { "--list" });
_app.Start(new[] { "--list" });
var cts = new CancellationTokenSource();
cts.CancelAfter(TimeSpan.FromSeconds(30));
var lines = await _app.Process.GetAllOutputLinesAsync(cts.Token);

1
src/Tools/dotnet-watch/test/ProgramTests.cs
View File

@ -24,7 +24,6 @@ namespace Microsoft.DotNet.Watcher.Tools.Tests
}
[Fact]
[Flaky("<No longer required; Tracked in Kusto>", FlakyOn.All)]
public async Task ConsoleCancelKey()
{
_tempDir