Commit Graph

20286 Commits

Author SHA1 Message Date
Pranav K f6a6e4bd07
Replat blazor on net5 (#23078)
* Replat blazor on net5

* Make all e2e tests pass

* Fixup

* Update js files

* Fixups

* Fixup

* Fixup

* Skip globalization tests

* Undo workarounds

* PR feedback

* Update dependencies from https://github.com/dotnet/runtime build 20200622.6

System.ComponentModel.Annotations , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging , Microsoft.Extensions.Internal.Transport , Microsoft.Extensions.Http , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Configuration.Xml , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry , Microsoft.Win32.SystemEvents , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Ref , System.Drawing.Common , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.Channels , System.Windows.Extensions , System.Security.Principal.Windows , System.Security.Permissions , System.Security.Cryptography.Xml , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Net.WebSockets.WebSocketProtocol , System.Reflection.Metadata , System.Runtime.CompilerServices.Unsafe , System.Security.Cryptography.Cng , System.Security.Cryptography.Pkcs
 From Version 5.0.0-preview.7.20321.2 -> To Version 5.0.0-preview.7.20322.6

* Update js file

* Fix version

* Fixup

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
2020-06-23 18:19:55 -07:00
Stephan Troyer 7aa91ffd62
SpaProxy: Fix proxying of WebSocket protocol (#23250) 2020-06-23 16:20:00 -07:00
Pranav K f5709b4080
Add nullable annotations to Microsoft.AspNetCore.Mvc.Abstractions (#22993)
* Add nullable annotations to Microsoft.AspNetCore.Mvc.Abstractions
Contributes to https://github.com/dotnet/aspnetcore/issues/5680

* Changes per PR comments

* Changes per PR comments

* Fixup
2020-06-23 22:56:25 +00:00
Brennan a1c226e4f3
[SignalR] Move to generic host (#22602) 2020-06-23 10:46:03 -07:00
Pranav K baf7e6c4d6
Add support for optional FromBody parameters (#22634) (#23246)
* Add support for optional FromBody parameters (#22634)

* Add support for optional FromBody parameters

Fixes https://github.com/dotnet/aspnetcore/issues/6878

* Fixup nullable

* Changes per API review

* Fixup doc comment (#23229)
2020-06-23 08:06:14 -07:00
Brennan 6a4d79cfb8
Fix java pack on local builds (#23237) 2020-06-22 20:21:13 -07:00
Tanay Parikh 26cc3b43a2
Unquarantine Tests (#23098)
Found a bunch of tests running for 30+ days with 100% pass rate.
2020-06-22 17:54:52 -07:00
Ivan Zub 93e9e1f9e1
Fix urls of @microsoft/dotnet-js-interop package (#23239) 2020-06-22 16:42:21 -07:00
Filip Staffa 94941438d3
Add TagBuilder copy constructor (#10955) (#22729)
Co-authored-by: Filip Staffa <git@filipstaffa.net>
2020-06-22 15:43:25 -07:00
Pranav K 827751ffe1
Fixup doc comment (#23229) 2020-06-22 15:39:39 -07:00
James Newton-King ce80965454
HPackDecoder performance (#23083) 2020-06-23 09:20:06 +12:00
ccvca efeb8508dc
Fix: 'https://' is also supported as scheme. (#23194) 2020-06-22 13:26:30 -07:00
Pranav K f7d2fac8a2
Add support for optional FromBody parameters (#22634)
* Add support for optional FromBody parameters

Fixes https://github.com/dotnet/aspnetcore/issues/6878

* Fixup nullable

* Changes per API review
2020-06-22 19:11:55 +00:00
Sourabh Shirhatti c97a0020d8
Use implicit logging scope for Activity (#22376)
* Revert "Hoist activity fields to the logging scope (#11211)"

This reverts commit f7a2d3c26c.

* Remove tests with Activity

* Remove ActivityId from HostingLogScope

* Enable propogation in CreateDefaultBuilder

* Clean up

* s/logging/loggingBuilder

* Enable Activity propogation for generichost

* Replace with runtime/pull/37892
2020-06-22 10:12:22 -07:00
Steve Sanderson 36be16b640
Fix binding <select> to a null value (#23221) 2020-06-22 17:27:02 +01:00
Artak adbedd2cfb
Render aria-invalid if the state is invalid (#23131)
* Render aria-invalid if the state is invalid

Co-authored-by: Pranav K <prkrishn@hotmail.com>
2020-06-21 21:43:29 -07:00
Hao Kung 8541bf6c98
Flow endpoint and httpcontext always from authz middleware (#22672) 2020-06-19 18:14:47 -07:00
Chris Ross 4d7a79ad64
Change HttpSys default client cert mode to Allow Cert #14840 (#23162) 2020-06-19 16:34:56 -07:00
Pranav K 724c2e75a7
Add nullable annotations to Microsoft.AspNetCore.Components (#22944)
* Add nullable for Microsoft.AspNetCore.Components
Contributes to https://github.com/dotnet/aspnetcore/issues/5680

* Fixup
2020-06-19 18:38:37 +00:00
Safia Abdalla 52de5ee4df
Fix up rendering for select elements with options component (#22978)
* Fix up rendering for select  elements with options component
* Commit updated compiled JS
* Update test case with more scenarios
2020-06-19 08:43:05 -07:00
Filip Staffa a77e68f1c5
Kestrel Endpoints' "SslProtocols" settable via config (#22663) (#22910) 2020-06-19 08:09:56 -07:00
John Luo bb92c602d8
Fix Windows 7/8 Kestrel tests (#23069) 2020-06-19 00:24:21 -07:00
Pranav K f3b370c1ac
Annotate Authorization.Core, Authorization.Policy with nullable (#22990)
Contributes to https://github.com/dotnet/aspnetcore/issues/5680
2020-06-18 23:43:35 +00:00
Safia Abdalla a173be28fb
Add support for <BlazorWebAssemblyLazyLoad /> item group (#23071)
* Add support for <BlazorLazyLoad /> item group
* Respond to feedback from peer review
2020-06-18 16:05:34 -07:00
Doug Bunting ab7f3f2018
Enable `/warnAsError` (#23072)
* Enable `/warnAsError` in Windows builds
  - already enabled in non-Windows builds because override existed only in build.ps1
* Allow some warnings related to closed issues
  - common `<NoWarn>$(NoWarn);CS1591</NoWarn>` case unchanged
    - /Directory.Build.props ensures that warning remains a warning but doesn't hide it
* !fixup! Root build.sh _does_ disable warnings as errors
  - variable eng/common/tools.sh uses named `warn_as_error`
2020-06-18 15:59:34 -07:00
Stephen Halter 6abc3c759f
Fix Kestrel HTTP/2 debug assert failure (#23062) 2020-06-18 15:13:18 -07:00
Safia Abdalla f627352387
Fix authorization setup in Razor pages template (#23029) 2020-06-18 13:30:08 -07:00
Doug Bunting 214df1c8ef
Merge pull request #22902 from dotnet-maestro-bot/merge/release/3.1-to-master
[automated] Merge branch 'release/3.1' => 'master'
2020-06-18 12:24:36 -07:00
Pranav K a44c1ad78c
Fix null reference errors in tests (#23091)
Fixes https://github.com/dotnet/aspnetcore/issues/22992
2020-06-18 11:05:54 -07:00
Justin Kotalik cbb8c6d915
Update FormsTest.cs 2020-06-18 09:48:40 -07:00
John Luo c83fd8951a
Add sharedfx and targeting pack tests (#23045)
* Add test for assembly versions

* Add test for framework list

* Add some hardcoded lists for sharedfx and targeting pack content
2020-06-17 17:06:04 -07:00
John Luo 45e6571649
Downgrade or throw when HTTP/2 over TLS is configured on older Windows versions (#22859)
HTTP/2 over TLS is not compatible with Windows versions strictly older than Windows 10 or Windows Server 2016. Update kestrel to:
- Downgrade to HTTP/1.1 when Http1AndHttp2 is configured.
- Throw NotSupportedException when Http2 is configured.
- Allow HTTP/2 over TLS to be enabled if AppContext switch Microsoft.AspNetCore.Server.Kestrel.EnableWindows81Http2 is set. This allows users who have configured cipher suites on Windows 8.1 and Windows Server 2012 R2 to continue using HTTP/2 over TLS.
2020-06-17 16:50:48 -07:00
Safia Abdalla 7a82a48a20
Fix build issues in Blazor WASM template tests (#23052) 2020-06-17 15:31:00 -07:00
Justin Kotalik 855a73816d
Update Microsoft.AspNetCore.Server.HttpSys.FunctionalTests.csproj 2020-06-17 13:54:53 -07:00
Justin Kotalik c5b7eab345
Update Microsoft.AspNetCore.Server.HttpSys.csproj 2020-06-17 13:53:19 -07:00
Doug Bunting c4c6e25a06
Add missing doc files and cleanup nits (#22931)
* nit: Remove useless `$(HasReferenceAssembly)` settings
  - set in /Directory.Build.targets
    - `true` only in `$(IsAspNetCoreApp)` projects
* nit: Remove useless `$(CompileUsingReferenceAssemblies)` settings
  - no current versioning differences between ref/ and src/ assemblies when targeting default TFM
* Add more `$(GenerateDocumentationFile)` settings
  - increases the number of generated doc files, mostly without problems
- !fixup! correct typo in `DebugProxyHost` doc comments
    - was not generating a doc file before
  - remove previous (ineffective) src/Components/Directory.Build.targets setting
  - nit: remove a duplicate `$(GenerateDocumentationFile)` setting
* nit: Remove useless `$(IsPackable)` settings
  - only analyzers and implementation projects are packable by default
    - main use case for explicit setting is projects shipping only in shared framework
  - conditional setting in src/Mvc/Directory.Build.props just subset logic in /Directory.Build.targets
* nit: Remove useless `$(IsProjectReferenceProvider)` settings
  - only implementation projects are providers by default
* nit: Remove useless `$(IsTestAssetProject)` settings
  - set in src/Mvc/test/WebSites/Directory.Build.props
* !fixup! Looks like `InProcessNewShimWebSite` must compile w/o ref/ assemblies
  - restore `$(CompileUsingReferenceAssemblies)` in this one project
2020-06-17 13:04:45 -07:00
N. Taylor Mullen 538c462c05 Enable Helix tests for Microsoft.AspNetCore.Mvc.Razor.Extensions.* projects.
- Enabled Helix for:
    - `Microsoft.AspNetCore.Mvc.Razor.Extensions.Test`
    - `Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X.Test`
    - `Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X.Test`
- These tests depended on our MVC shim project's deps.json's to exist in the test bin directory during publish. Therefore added an additional target copy over those assets at publish time.
- There were some tests that were relying on source positions from a string to match a runtime generated source position. In Helix dll's are built on Windows (string's get compiled with \r\n) and then deployed to potentially non-Windows boxes resulting in mismatches of expectations. To address this I changed the test that had this dependency to dynamically generate the input string.
- Our common language test project used to rely on test files being on disk. At some point in the past those test files started being embedded in the assembly but we maintained directory checking logic to ensure various directories existed on disk (no longe required). Changed the logic to not enforce directories to be on disk (they aren't in Helix) and instead only rely on the embedded TestFiles.

dotnet/aspnetcore#22100
2020-06-17 11:49:49 -07:00
Safia Abdalla 952a19682d
Quarantine failing test (#23044) 2020-06-17 18:49:43 +00:00
dotnet-maestro[bot] 632aa8a95c
[master] Update dependencies from dotnet/runtime (#23040)
* Update dependencies from https://github.com/dotnet/runtime build 20200617.2

System.ComponentModel.Annotations , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging , Microsoft.Extensions.Internal.Transport , Microsoft.Extensions.Http , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Configuration.Xml , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry , Microsoft.Win32.SystemEvents , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Ref , System.Drawing.Common , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.Channels , System.Windows.Extensions , System.Security.Principal.Windows , System.Security.Permissions , System.Security.Cryptography.Xml , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Net.WebSockets.WebSocketProtocol , System.Reflection.Metadata , System.Runtime.CompilerServices.Unsafe , System.Security.Cryptography.Cng , System.Security.Cryptography.Pkcs
 From Version 5.0.0-preview.7.20315.3 -> To Version 5.0.0-preview.7.20317.2

* null

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: BrennanConroy <brecon@microsoft.com>
2020-06-17 18:46:34 +00:00
Justin Kotalik b8de65dbac
Update Microsoft.AspNetCore.Shared.Tests.csproj 2020-06-17 11:18:22 -07:00
Justin Kotalik bccaa41ca8
Update Http2Utilities.cs 2020-06-17 11:17:35 -07:00
ZeBobo5 b8d090b983
Fix #23038 (#23039) 2020-06-17 06:50:31 -07:00
David Melendez d1ae0e6e3e
adding community identity providers (#17051)
Adding Azure Table Storage and CosmosDB SQL providers to the list.
2020-06-17 06:23:48 -07:00
Ken Dale 28ed208022
Add SetIsOriginAllowedToAllowWildcardSubdomains_DoesNotAllowRootDomain test (#23001)
This test makes it clear root domains are not included in CORS subdomain wildcards
2020-06-17 06:22:20 -07:00
Dan Friedman f6fee9b4b8
Link to maintained identity provider (#21015) 2020-06-17 06:21:35 -07:00
Artak 2434047663
Quarantined tests which were not running (skipped on Helix) (#23023) 2020-06-17 04:22:17 +00:00
Adam Sitnik 580a6cce0f
BDN workaround for netcoreapp5.0->net5.0 moniker rebranding (#23000) 2020-06-17 13:43:40 +12:00
James Newton-King 29bbf06c77
Turn off gRPC interop test console color logging (#22923) 2020-06-17 12:38:32 +12:00
Pranav K 65e933ec70
Update PhoneNumberTokenProvider.cs (#22766)
* Update PhoneNumberTokenProvider.cs

Add license header.
Hyphenate two-factor authentication in documentation.
Add line breaks before return statements.
Use string interpolation instead of string concatenation.
2020-06-16 17:22:26 -07:00
Safia Abdalla 51f977db2f
Unquarantine tests that have passed for 30+ days (#23011) 2020-06-16 16:23:50 -07:00
Safia Abdalla ac0b0ee063
Quarantine failing E2E circuit test (#23016) 2020-06-16 22:01:40 +00:00
Hao Kung c330c0b37d
Cookie renew ticket if it already exists (#22732) 2020-06-16 14:51:57 -07:00
John Luo b40b1bb7b2
Fix helix-matrix tests (#22918)
* Update SslProtocols to use system defaults
2020-06-16 13:37:49 -07:00
Luke Pfeiffer 89e387ee88
Fixed mistype in the `VarInt` examples (#23007)
The second `VarInt` example has `0x80 0x25` is represented as (`%10000000 %00101001`) which when decoded becomes 0x1480 (5248)

When trying to implement `VarInt` encoding and decoding myself I found that `0x25` is actually `%00100101` instead of `%00101001` which causes the final decoded `VarInt` to be incorrect.

The proper hex value for the binary `%00101001` is `0x29`
2020-06-16 13:07:41 -07:00
Pranav K b6bde6cbc9
Annotate ObjectPool with nullable (#22823)
* Annotate ObjectPool with nullable

* fixup
2020-06-16 19:43:24 +00:00
Safia Abdalla b484680092
Update how default auth policy is set in templates (#22884)
* Update how default auth policy is set in templates
* Respond to feedback from peer review
2020-06-15 20:27:33 -07:00
John Luo 675fd1413c
Quarantine test (#22981) 2020-06-15 19:48:33 -07:00
Brennan 49aecc3efe
Use non-generic TaskCompletionSource in SignalR and Kestrel (#22925) 2020-06-15 17:35:19 -07:00
Stephen Halter a67c217976
Abort request when returning a completed FlushResult (#22086) 2020-06-15 16:36:55 -07:00
Justin Kotalik dc3cb10f2b
Update Microsoft.AspNetCore.Shared.Tests.csproj 2020-06-15 16:31:32 -07:00
Pranav K 8efcca43ce
Annotate Microsoft.AspNetCore.Http with nullable attributes (#22928)
* Annotate Microsoft.AspNetCore.Http with nullable attributes

* Annotate Hosting with nullable
2020-06-15 23:29:19 +00:00
Pranav K c93b61156d
Annotate webencoders with nullable (#22927) 2020-06-15 23:11:20 +00:00
John Luo b284229790
Consume host resolver source package from dotnet/runtime (#22962) 2020-06-15 15:21:58 -07:00
James Newton-King a861d18d24
Add HTTP/2 keep alive pings (#22565) 2020-06-16 10:13:09 +12:00
brianchance a0827ace5e
Change default for queryStringDelete (#21586) 2020-06-15 14:46:40 -07:00
Huei Feng 7cdbaeeccf
Update Async To MigrationsEndPointMiddleware (#22573) 2020-06-15 14:42:55 -07:00
Todd Grunke ef0eff7089
Merge pull request #22903 from dotnet/dev/toddgrun/NoMoreLineTrackingStringBuffer
Get rid of LineTrackingStringBuffer class and instead use the line in…
2020-06-15 14:38:37 -07:00
Pranav K 122cf4ee4c
Delete Microsoft.AspNetCore.Components.WebAssembly.Templates.csproj 2020-06-15 14:03:18 -07:00
Justin Kotalik 9288627fed Fixing up build issues 2020-06-15 13:31:09 -07:00
Pavel Voronin dc3398ca59
Fix xmldoc typo (#22938)
Just removed 'for'  in

> Adds middleware _for_ needed for debugging Blazor WebAssembly applications
2020-06-15 13:19:23 -07:00
Todd Grunke 56374ab393 use var where appropriate 2020-06-15 13:15:38 -07:00
Justin Kotalik afb1f48143 Merge branch 'release/3.1' 2020-06-15 13:03:14 -07:00
Sébastien Ros dc472b737e
Unquarantine tests (#22851) 2020-06-15 12:15:54 -07:00
Pranav K bab5a8f1b8
Add an option to configure the NewtonsoftJson buffer size (#22735)
* Add an option to configure the NewtonsoftJson buffer size
Contributes to https://github.com/dotnet/aspnetcore/issues/21245

* Update src/Mvc/Mvc.NewtonsoftJson/src/MvcNewtonsoftJsonOptions.cs

Co-authored-by: Stephen Halter <halter73@gmail.com>

Co-authored-by: Stephen Halter <halter73@gmail.com>
2020-06-15 19:07:26 +00:00
Hao Kung ef5ab43b6f
Use redirect helper (#22847) 2020-06-15 11:34:56 -07:00
Scott Addie 11fb7b67d1
Add detail to InvalidOperationException in Exception Handler Middleware (#22858) 2020-06-15 11:31:23 -07:00
John Luo 11c8ad4010
Consolidate RazorSdkDirectory logic (#22836)
* Consolidate RazorSdkDirectory logic
2020-06-15 09:08:13 -07:00
Pranav K f04992fab5
Add nullable to DataProtection (#22591)
* Add nullable to DataProtection

Contributes to https://github.com/dotnet/aspnetcore/issues/5680
2020-06-13 20:39:41 -07:00
John Luo 0f70380524
Quarantine tests (#22919) 2020-06-13 14:28:40 -07:00
Todd Grunke 2c594199c3 Fix a bug in DefaultRazorSourceLineCollection.GetLineStarts 2020-06-12 17:56:19 -07:00
Todd Grunke a1dd898994 Get rid of LineTrackingStringBuffer class and instead use the line information provided by RazorSourceDocument.
This additionally gets rid of an extra whole buffer allocation in the ParserContext. The most complex bit of the change is around avoiding TextLineCollection.GetLocation.

Overall, I'm seeing a pretty big win here, about 35% less time spent in RazorSyntaxTree.Parse for the typing scenario I was doing in a very large file.
2020-06-12 17:22:24 -07:00
Pranav K 350540d0af
Make WebAssembly templates use the same version as the rest of the WASM product (#22896)
We've already shipped a 3.2.0 version of the package. The build's currently producing
3.1.6 version of the package. This changes the package version to 3.2.1
2020-06-12 16:30:28 -07:00
James Newton-King 3dc39cc2dc
Improve gRPC interop test failure logging (#22856) 2020-06-13 09:14:12 +12:00
Todd Grunke 073cd0aa40
Merge pull request #22877 from dotnet/dev/toddgrun/MorePerfOptimizations
Dev/toddgrun/more perf optimizations
2020-06-12 13:25:31 -07:00
Todd Grunke b13cb76c0a
Merge pull request #22887 from dotnet/dev/toddgrun/TrySplitNamespaceAndTypeAllocatesTooMuch
Small memory allocation optimization in DefaultRazorTagHelperBinderPh…
2020-06-12 13:18:12 -07:00
William Godbe 0343af108a
Merge pull request #22840 from dotnet-maestro-bot/merge/release/3.1-to-master
[automated] Merge branch 'release/3.1' => 'master'
2020-06-12 13:03:12 -07:00
Todd Grunke 43a628e9fb Small memory allocation optimization in DefaultRazorTagHelperBinderPhase.TrySplitNamespaceAndType
This method allocated multiple strings on every invocation when they were rarely needed. With this change, I see a reduction in memory allocated during RazorProjectEngine.ProcessDesignTime of 1.4%.
2020-06-12 12:04:47 -07:00
Justin Kotalik dcd1250f43
[3.1] Add latin1 support to IIS (#22798)
Co-authored-by: Chris Ross <Tratcher@Outlook.com>
2020-06-12 11:10:00 -07:00
Pranav K 8c1bf1f1a3
Add nullable annotations to Healthchecks (#22785)
* Add nullable annotations to Healthchecks

* Update HealthCheckContext.cs
2020-06-12 17:17:28 +00:00
Javier Calvarro Nelson 53696e4228
Quarantine static web assets tests so we can capture more data for diagnostics (#22876) 2020-06-12 10:14:22 -07:00
Javier Calvarro Nelson 3679a01e4d
Unquarantine tests since they haven't failed in 30 days (#22878) 2020-06-12 10:12:51 -07:00
Sébastien Ros 0ec79c5196
Quarantining InputDateInteractsWithEditContext_NonNullableDateTime (#22857)
https://github.com/dotnet/aspnetcore-internal/issues/3616
2020-06-12 10:02:33 -07:00
Pranav K c30638b829
Fixup nullable (#22861) 2020-06-12 15:32:41 +00:00
Todd Grunke 9cf611b9e2 Revert change to EndLocation as it was incorrectly changed. 2020-06-12 08:28:32 -07:00
John Luo ef9a3662d6
Also set no-store when we set no-cache in response cache control headers (#22842) 2020-06-11 20:38:54 -07:00
Pranav K 20770811a4
Add nullability to antiforgery (#22279)
* Add nullability to antiforgery

Addresses #5680

* Rebase
2020-06-12 03:23:33 +00:00
Todd Grunke 904fd19605 A couple more perf optimizations focused around memory allocations.
This is the last of the easy wins that I could find for typing in large razor files (minus the logged bug to move the divergence checker code off the UI thread). In the profile for the large document editing, these changes reduce allocated memory during RazorSyntaxTree.Parse by about 25%. CPU wise, the win isn't quite as dramatic, only a couple percent improvement under RazorSyntaxTree.Parse.
2020-06-11 18:11:29 -07:00
Pranav K a99dd0d312
Update js 2020-06-11 17:10:19 -07:00
Pranav K ea4b52ccba
Merge remote-tracking branch 'origin/release/3.1' 2020-06-11 15:52:06 -07:00
Pranav K 0a42cca945
Razor SDK build ordering issues (#22684)
* Razor SDK build ordering issues

* Build the SDK completely regardless of the MSBuild runtime type
* Split SDK integration tests into a separate project. Clean up project file

* Add project to sln

* Update Microsoft.NET.Sdk.Razor.csproj

* Fixup tests

* Avoid rebuilding dependencies if they appear up to date. Fixup tests

* Fixup

* Update CSharp.Common.props

* Cleanup the build
2020-06-11 21:16:05 +00:00
Pranav K 596f93324d
Fix nullable build warning (#22838) 2020-06-11 20:48:55 +00:00
Pranav K 75b27754d6
Ensure FileBufferingReadStream created by formatters are always disposed (#22746) 2020-06-11 13:14:15 -07:00
Javier Calvarro Nelson 5a9a98543f
[Blazor] Switches Error.razor to Error.cshtml (#22777)
* [Blazor] Switch to use a cshtml file for errors

* Update template tests
2020-06-11 13:13:05 -07:00
Javier Calvarro Nelson 9d7018544a
[Blazor] Fix manifest integrity computation (#22771)
* [Blazor] Fix manifest integrity computation

* Add a couple of tests to validate incrementalism
2020-06-11 13:12:53 -07:00
Javier Calvarro Nelson ce533485f0
[Blazor] Register HttpClient as a scoped instance (#22770)
This avoid the container holding on to transient HttpClient instances for the lifetime of the application.
2020-06-11 13:12:43 -07:00
Pranav K 8e813eea24
Workaround for DomException when invoking cache.put (#22756)
* Workaround for DomException when invoking cache.put

Invoking cache.put could sometimes result in exceptions being thrown. While this seems to have been fixed in Chromium - https://bugs.chromium.org/p/chromium/issues/detail?id=968444,
we've had several reports of this in our repo. The fix here is to write defensively when working with the cache apis since they appear to behave in unexpected ways..

Fixes https://github.com/dotnet/aspnetcore/issues/20256

* Fixup
2020-06-11 13:12:33 -07:00
msftbot[bot] 62e6d93f5c
Merge pull request #22833 from dotnet-maestro-bot/merge/release/3.1-to-master
[automated] Merge branch 'release/3.1' => 'master'
2020-06-11 19:32:33 +00:00
Todd Grunke 73f04eecac
Add mechanism where IR token generation can defer allocation of it's … (#22792)
* Add mechanism where IR token generation can defer allocation of it's content.

It turns out that many IR tokens access their content, and thus allocating it is unnecessary. In particular, with this change against a large file, I've seen allocations under SyntaxNodeExtensions.GetContent reduced by about 33%. Performance wise, I've seen the number of CPU samples in the profile under GetContent reduce by about 40% (in my sample I typed 26 characters and there was about 600 ms less spent in GetContent)

* ContentGetter => ContentFactory

* Make tests happy with the switch from IntermediateToken to IntermediateTokenWithDeferreedContentAllocation

* IntermediateTokenWithDeferredContentAllocation => LazyIntermediateToken
2020-06-11 18:20:41 +00:00
Brennan 812f2f8145
Fixes NullRef exception in IIS in-proc (#22806) 2020-06-11 10:57:36 -07:00
Pranav K 3e6495fde3
Bump up the wasm template precedence (#22802) 2020-06-11 10:10:10 -07:00
David Fowler 9e55787b84
Add support for listening to tcp handles to in the Sockets transport (#22618)
* Add support for listening to tcp handles to in the Sockets transport
- Make ListenHandleTests shared across both transports

Fixes #20842
2020-06-11 09:36:27 -07:00
Sébastien Ros 5f26302eaa
Quarantining CanDispatchAsyncWorkToSyncContext (#22803)
* Quarantining CanDispatchAsyncWorkToSyncContext

* Missing using

* Make method virtual
2020-06-11 09:30:26 -07:00
Ryan Brandenburg b61e9b0125
Remove PubTernal APIs (#22290)
Remove PubTernal APIs
2020-06-11 09:21:39 -07:00
Sébastien Ros fe24d85356
Merge pull request #22790 from dotnet-maestro-bot/merge/release/3.1-to-master
[automated] Merge branch 'release/3.1' => 'master'
2020-06-10 18:19:19 -07:00
Stephen Halter 6c31da5b1f
Enable Kestrel config reload in ConfigureWebHostDefaults (#22528) 2020-06-10 17:47:17 -07:00
Will Godbe 97f3ea1453 Fixup .sln 2020-06-10 13:40:08 -07:00
Will Godbe 3d79c2b319 Fixup 2020-06-10 13:08:11 -07:00
Tanya e929dab496
Replace favicon.ico with smaller size (#22533)
Co-authored-by: Tanya Do <tad@microsoft.com>
2020-06-10 12:17:25 -07:00
Pranav K 07b1bf4f71
Fixup error 2020-06-10 12:07:17 -07:00
Pranav K 71853a4640
Merge branch '3.1merge' 2020-06-10 11:30:40 -07:00
Safia Abdalla a529b4c70c
Add nan as dev dependency to React templates (#22089) (#22205) 2020-06-10 09:59:39 -07:00
Safia Abdalla 55822ca516
Upgrade jQuery in samples to version 3.5.1 (#21577) (#21792)
Fixes #21572

Co-authored-by: Christian Wenz <info@christianwenz.de>
2020-06-10 09:59:29 -07:00
Jonathan edf73e084b
Update TotpSecurityStampBasedTokenProvider.cs 2020-06-10 13:36:49 +02:00
Jonathan 6b761eaeab
Update PhoneNumberTokenProvider.cs 2020-06-10 13:36:32 +02:00
Jonathan 9db52fac7a
Update EmailTokenProvider.cs 2020-06-10 13:36:16 +02:00
Jonathan 103a305c25
Update TotpSecurityStampBasedTokenProvider.cs
Add line breaks before return statement.
Use string interpolation instead of string concatenation.
Hyphenate the documentation.
2020-06-10 12:12:09 +02:00
Jonathan 9b8cd29087
Hyphenate documentation
Hyphenate "two-factor authentication" in documentation.
Add line break before return statements.
2020-06-10 12:07:30 +02:00
Jonathan d1793dda5f
Hyphenate documentation
Hyphenate two-factor authentication in the documentation.
2020-06-10 12:05:45 +02:00
Jonathan 5972fa0004
Update EmailTokenProvider.cs 2020-06-10 12:02:18 +02:00
Jonathan be334b0d00
Update PhoneNumberTokenProvider.cs
Add license header.
Hyphenate two-factor authentication in documentation.
Add line breaks before return statements.
Use string interpolation instead of string concatenation.
2020-06-10 11:57:29 +02:00
Pranav K c58ab9247c
Add nullable to JSInterop (#22326) 2020-06-10 05:39:01 +00:00
Pranav K b3ad812c14
Mark Wasm benchmark app as a test asset 2020-06-09 19:24:03 -07:00
Pranav K ae8f67f201
Use randomized ports in dotnet-serve 2020-06-09 19:20:12 -07:00
Justin Kotalik c1a3a2f10c
Change debug information format (#22734) 2020-06-09 18:03:19 -07:00
Safia Abdalla fbb70b12de
Fix startvs.cmd for Components solution (#22739) 2020-06-10 00:32:42 +00:00
Pranav K dd62a699f7
Merge remote-tracking branch 'origin/release/3.1' into prkrishn/merge-blazor-wasm 2020-06-09 16:54:36 -07:00
William Godbe 99e90f5782
Produce non-stable version of targeting pack (#22372)
* Produce non-stable version of targeting pack

* Fix tag

* Fix indentation

* Fixup proj file

* Move Internal proj to separate folder

* Remove redundant proj

* Start moving files

* finish moving files

* Set IsReferenceAssemblyProject=true in targeting pack proj
2020-06-09 16:40:00 -07:00
Justin Kotalik b19d9d9540
Enable control flow guard for IIS dlls (#22609) 2020-06-09 16:26:18 -07:00
Pranav K 758ca19edc
Build against the local JSInterop (#22526) 2020-06-09 14:38:13 -07:00
Todd Grunke 4d367898b3
Merge pull request #22686 from dotnet/dev/toddgrun/expand_cached_tokens
Expand the SyntaxTokenCache to contain more than just whitespace tokens.
2020-06-09 13:00:10 -07:00
William Godbe 64f7f5a883
Unquarantine test that's not flaky anymore (#22664) 2020-06-09 10:21:07 -07:00
Pranav K 0794d6077d
Make AuthenticateAsync return non-null result (#22708)
* Make AuthenticateAsync return non-null result

* NoResult
2020-06-09 17:05:26 +00:00
Javier Calvarro Nelson a27356078f
Disable Yarn warnings on CI builds for restore and Blazor WebAssembly projects (#22703)
Disables warnings when running the Yarn task in CI environments. You'll still get the warnings on developer builds.
2020-06-09 09:53:50 -07:00
Pranav K 21f47cdf22
Ship JSInterop.WebAssembly package (#22685)
Fixes https://github.com/dotnet/aspnetcore/issues/22674
2020-06-09 16:32:00 +00:00
Ondřej Štorc 9ce4a970a2
Parsing extension-av on Set Cookie header (#22181) 2020-06-09 08:48:39 -07:00
Pranav K 25e21df3a7
Set the correct tfm in Wasm template.json (#22678) 2020-06-09 15:39:42 +00:00
Pranav K 11ac23c65d
Changes per PR 2020-06-08 22:19:34 -07:00
Brennan 4a66e2d1ab
[Java] Observe error to avoid crash (#22016) 2020-06-08 18:25:49 -07:00
Scott Addie eee77a8f10
Improve XML docs for ActionResultStatusCodeAttribute (#22598) 2020-06-08 15:57:11 -07:00
Todd Grunke 837c639041 Expand the SyntaxTokenCache to contain more than just whitespace tokens. 2020-06-08 15:37:35 -07:00
Todd Grunke f56cad003f
Merge pull request #22660 from dotnet/dev/toddgrun/StopBoxingSyntaxKindDuringTokenization
Stop boxing to compare the SyntaxKind enum during tokenization
2020-06-08 14:14:21 -07:00
github-actions[bot] 52fdd8f2a2
Sync shared code from runtime (#22619)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2020-06-08 20:17:43 +00:00
William Godbe a1360e98f3
Quarantine flaky test (#22662) 2020-06-08 12:53:57 -07:00
Pranav K 6188933c89
Fixup warnings in test (#22665) 2020-06-08 19:39:50 +00:00
Doug Bunting ee80cd5ccd
Build native assets by default (#22611)
* Build native assets by default
  - #22556
  - make `-BuildNative` primarily useful when you want _only_ native assets
    - can also build `-Projects` with desktop `msbuild` using `-BuildNative`
  - remove `-ForceCoreMsbuild` option
  nit: extra `Remove-Item`s caused `MSBuild` function to do redundant work

* !fixup! Get `/bl` options working again
  nit: Place SiteExtensions .binlogs correctly wherever script is run from
* !fixup! Remove *.vcxproj from Servers build
  - native projects are built implicitly
* !fixup! Remove `-buildNative` from IIS build script
2020-06-08 12:39:10 -07:00
Pranav K cd81d48766
Add nullable to WebUtilities (#22543) 2020-06-08 17:48:43 +00:00
Todd Grunke a5d433103c Stop boxing to compare the SyntaxKind enum during tokenization
This accounts for a significant portion of razor's allocations during parsing.
2020-06-08 10:45:11 -07:00
Brennan aeb28d4b83
Keep building packages that are marked packable (#22616) 2020-06-08 10:13:36 -07:00
Smit Patel 3cdc7164e7 Add pragma disable to older migration files
Resolves #22630
2020-06-07 11:17:45 -07:00
Victor Lindespång d4a4c25607
Typo in XML comments for AuthorizationMessageHandler (#22371)
I'm not a native english speaker but I'm pretty sure something is wrong here, or it's a condition too complicated for me to understand ;- )
2020-06-07 00:05:45 -07:00
Pranav K 6e54e06cfa
Add nullable to Auth.Abstractions, and Auth.Core (#22541) 2020-06-06 21:43:39 +00:00
Smit Patel a963bbebf9 Add obsolete disable in older model snapshot
Revert to using older API

Resolves #22610
2020-06-06 12:01:31 -07:00
Brennan e657de4b77
Fix null warnings (#22615) 2020-06-06 09:33:25 -07:00
dotnet-maestro[bot] b6e593bbbb
[master] Update dependencies from dotnet/efcore (#22558)
* Update dependencies from https://github.com/dotnet/efcore build 20200604.3

Microsoft.EntityFrameworkCore.Tools , Microsoft.EntityFrameworkCore.SqlServer , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.InMemory
 From Version 5.0.0-preview.7.20304.1 -> To Version 5.0.0-preview.7.20304.3

* Update dependencies from https://github.com/dotnet/efcore build 20200604.5

Microsoft.EntityFrameworkCore.Tools , Microsoft.EntityFrameworkCore.SqlServer , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.InMemory
 From Version 5.0.0-preview.7.20304.1 -> To Version 5.0.0-preview.7.20304.5

* Update dependencies from https://github.com/dotnet/efcore build 20200604.6

Microsoft.EntityFrameworkCore.Tools , Microsoft.EntityFrameworkCore.SqlServer , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.InMemory
 From Version 5.0.0-preview.7.20304.1 -> To Version 5.0.0-preview.7.20304.6

* Update dependencies from https://github.com/dotnet/efcore build 20200605.1

Microsoft.EntityFrameworkCore.Tools , Microsoft.EntityFrameworkCore.SqlServer , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.InMemory
 From Version 5.0.0-preview.7.20304.1 -> To Version 5.0.0-preview.7.20305.1

* Update dependencies from https://github.com/dotnet/efcore build 20200605.2

Microsoft.EntityFrameworkCore.Tools , Microsoft.EntityFrameworkCore.SqlServer , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.InMemory
 From Version 5.0.0-preview.7.20304.1 -> To Version 5.0.0-preview.7.20305.2

* Update Identity for breaking changes in EF Core

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Smit Patel <smitpatel@users.noreply.github.com>
2020-06-06 01:49:33 +00:00
Justin Kotalik 8a4af4f212
Enable control flow guard for IIS native dlls (#22480) 2020-06-05 17:34:54 -07:00
John Luo 836001cf96
Set PublishWindowsPdb for Razor tooling packages (#22605) 2020-06-05 23:38:17 +00:00
dotnet-maestro[bot] cdb87ee776
[master] Update dependencies from dotnet/runtime (#22571)
* Update dependencies from https://github.com/dotnet/runtime build 20200605.1

System.ComponentModel.Annotations , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Extensions.Logging , Microsoft.Extensions.Internal.Transport , Microsoft.Extensions.Http , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Hosting , Microsoft.Extensions.Configuration.Json , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.Win32.Registry , Microsoft.Win32.SystemEvents , Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Ref , System.Drawing.Common , System.Text.Encodings.Web , System.Text.Json , System.Threading.Channels , System.Windows.Extensions , System.ServiceProcess.ServiceController , System.Security.Principal.Windows , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Net.WebSockets.WebSocketProtocol , System.Reflection.Metadata , System.Runtime.CompilerServices.Unsafe , System.Security.Cryptography.Cng , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions
 From Version 5.0.0-preview.7.20303.11 -> To Version 5.0.0-preview.7.20305.1

* Use the array overload of Task.WhenAny

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Ajay Bhargav Baaskaran <ajbaaska@microsoft.com>
2020-06-05 21:22:58 +00:00
Kirill Osenkov 0e7ca749de
Add a Mime Type for .exe and .dll files. (#21805)
* Add a Mime Type for .exe and .dll files.

Useful for serving downloads of installers.
Could be application/octet-stream, but I hear application/vnd.microsoft.portable-executable is specified by IANA here:

https://www.iana.org/assignments/media-types/application/vnd.microsoft.portable-executable

* Update src/Middleware/StaticFiles/src/FileExtensionContentTypeProvider.cs

Co-authored-by: Chris Ross <Tratcher@Outlook.com>

* Update src/Middleware/StaticFiles/src/FileExtensionContentTypeProvider.cs

Co-authored-by: Chris Ross <Tratcher@Outlook.com>

Co-authored-by: Chris Ross <Tratcher@Outlook.com>
2020-06-05 20:21:31 +00:00
Pranav K 1656b4bfcf
Update SDK tests (#22560)
* Add some test for MVC 3.1 \ Blazor 3.1
* Remove tests and testapps for 1.1 \ 2.2
2020-06-05 11:19:17 -07:00
John Luo bce19c211a
Remove unused parameter in control template for Deb installers (#22546) 2020-06-05 11:05:00 -07:00
Pranav K f37fa30683
Add nullable annotations to Http.Abstractions, Http.Features, Connections.Abstractions (#22337)
* Add nullable annotations to Http.Abstractions, Http.Features, Connections.Abstractions

Co-authored-by: James Newton-King <james@newtonking.com>
2020-06-05 06:54:07 -07:00
Hao Kung 8e4dadc0dd
Add certificate validation cache (#21847) 2020-06-05 00:58:47 -07:00
Stephen Halter b454da498c
Merge branch 'master' into merge/release/5.0-preview6-to-master 2020-06-04 19:48:43 -07:00
James Newton-King ce32892387
Remove allocations by changing AsTask to GetAsTask (#22557) 2020-06-05 13:39:44 +12:00
Chris Ross 2bf3960dea
Optional client certificates sample (#21484)
* Add an optional client certs example

* Add the Challenge event

* PR cleanup
2020-06-05 01:34:21 +00:00
Todd Grunke da52d6b636
Move IsSpacingToken perf optimizations down to base class (#22555)
This gives the HtmlMarkupParser the same non-allocating behavior for it's IsSpacing* method invocations. Profile from following feedback ticket showed ~100ms time spent doing these allocations: https://developercommunity.visualstudio.com/content/problem/1006207/vs-2019-constant-freezing-please-wait-for-an-edito.html?childToView=1065769
2020-06-04 23:56:50 +00:00
Stephen Halter a50f94e8ff
Use default SslProtocols in Kestrel (#22437) 2020-06-04 16:44:27 -07:00
Ajay Bhargav B c329dc555a
Quarantined flaky RazorSDK tests (#22553) 2020-06-04 22:24:23 +00:00
Pranav K a352ac4bb8
Update blazor benchmarks to point to master (#22524) 2020-06-04 15:04:30 -07:00
Hao Kung 5a856437d0
Show logout button if logged in on logout (#22444)
* Show logout button if logged in on logout

* Remove stuff
2020-06-04 14:54:17 -07:00
William Godbe e5a52c1f4a
Don't pack duplicate deps.json files in SiteExtension package (#22519)
* Don't pack duplicate deps.json files in SiteExtension package

* Change exclude
2020-06-04 09:57:40 -07:00
Pranav K e89abd13d4
Reduce Razor SDK copy retries (#22448)
* Retry fewer times when building locally
* Fail as usual when building in CI
2020-06-03 16:04:29 -07:00
Steve Gordon eccd6272b3
Fix comment typo (#22409) 2020-06-03 13:26:24 -07:00
Martin Costello 675bceca57
Reuse model binders (#22391)
* Reuse model binders

Reuse the same model binders for CancellationTokens and services, rather than allocating a new one for every request with such a parameter.
2020-06-03 13:25:23 -07:00
Pranav K 9eaef28b31
Attempt to capture binlogs when test times out (#22468) 2020-06-03 10:02:03 -07:00
Huei Feng 544afc0078
Added `#nullable enable` with `StackTraceHelper` (#22419)
* Added `#nullable enable` with `StackTraceHelper`
2020-06-03 09:54:10 -07:00
Huei Feng 77ef004db4
Update async Dispose and methods references (#22407)
* Update async Dispose and methods references

- `Dispose` can be changed to  `DisposeAsync`
- The methods in the following code snippet are not available, it causes duplicate references

```
        /// <summary>
        /// <see cref="HelperResult.WriteTo(TextWriter)"/> is invoked
        /// </summary>
        /// <param name="result">The <see cref="HelperResult"/> to invoke</param>
        protected void Write(HelperResult result)
        {
            Write(result);
        }

```

* Update BaseView.cs
2020-06-03 15:43:08 +00:00
Brennan 381ac51af6
Fix nullable warning in IntegrationTestBase (#22487) 2020-06-03 07:48:35 -07:00
Matt Mitchell d8733c2a55
Build time changes (#22362)
* Build time changes
A few changes for build time
- Don't build tests with SkipTestBuild=true and use that for official
  build legs. This cuts 40%-50% off the msbuild invocations for build.
  The longest build leg drops by about 30 mins.
- Skip logging of some task parameters and their metadata.
  This reduces overall binlog size, which is a major contributor to
  build time.

Unfortunately, this does not mean we can yet turn binlogs back on. This
change can actually increase the overall binlog size due to logging of
more project started arguments. There is another optimization for this
in progress.

Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
2020-06-03 07:14:38 -07:00
Scott Addie e7ca49c95e
Improve XML docs for ActionResultObjectValueAttribute (#22479) 2020-06-03 06:42:53 -07:00
dotnet-maestro[bot] 1c908e5920
[release/5.0-preview6] Update dependencies from dotnet/runtime (#22481)
* Update dependencies from https://github.com/dotnet/runtime build 20200602.4

System.ComponentModel.Annotations , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging , Microsoft.Extensions.Internal.Transport , Microsoft.Extensions.Http , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry , Microsoft.Win32.SystemEvents , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Ref , System.Drawing.Common , System.Text.Encodings.Web , System.Text.Json , System.Threading.Channels , System.Windows.Extensions , System.ServiceProcess.ServiceController , System.Security.Permissions , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Net.WebSockets.WebSocketProtocol , System.Reflection.Metadata , System.Runtime.CompilerServices.Unsafe , System.Security.Cryptography.Cng , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Principal.Windows
 From Version 5.0.0-preview.6.20278.9 -> To Version 5.0.0-preview.6.20302.4

* Update dependencies from https://github.com/dotnet/runtime build 20200602.5

System.ComponentModel.Annotations , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging , Microsoft.Extensions.Internal.Transport , Microsoft.Extensions.Http , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry , Microsoft.Win32.SystemEvents , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Ref , System.Drawing.Common , System.Text.Encodings.Web , System.Text.Json , System.Threading.Channels , System.Windows.Extensions , System.ServiceProcess.ServiceController , System.Security.Permissions , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Net.WebSockets.WebSocketProtocol , System.Reflection.Metadata , System.Runtime.CompilerServices.Unsafe , System.Security.Cryptography.Cng , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Principal.Windows
 From Version 5.0.0-preview.6.20278.9 -> To Version 5.0.0-preview.6.20302.5

* Fixup test

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Pranav K <prkrishn@hotmail.com>
2020-06-03 08:33:37 +00:00
msftbot[bot] 912ab2bcb3
Merge pull request #22453 from dotnet-maestro-bot/merge/release/5.0-preview6-to-master
[automated] Merge branch 'release/5.0-preview6' => 'master'
2020-06-03 02:41:08 +00:00
Pranav K 902e735b27
Configure the page handler / controller instance as the container when validating top-level properties (#22164)
Validation attributes such as a CompareAttribute require a container to be configured in ValidationContext. This change
configures uses the controller or page handler instance that the property is being bound on when binding top-level properties.

Fixes https://github.com/dotnet/aspnetcore/issues/4895
2020-06-03 00:48:56 +00:00
Pranav K 646dfc63e4
Minor tweaks for better Ignitor debugability (#22446) 2020-06-02 17:45:52 -07:00
Hao Kung bdc051a08a
Clarify summary for ValidateSecurityStamp (#22483) 2020-06-02 17:06:57 -07:00
Pranav K faf60675fe
Add nullability to HtmlAbstractions (#22275)
Addresses #5680
2020-06-02 23:27:54 +00:00
James Newton-King 8009350176
Log message when connection reaches maximum concurrent streams (#22452) 2020-06-03 10:11:06 +12:00
dotnet-maestro[bot] 7de516e750
[master] Update dependencies from dotnet/runtime (#22387)
* Update dependencies from https://github.com/dotnet/runtime build 20200529.7

System.ComponentModel.Annotations , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.Drawing.Common , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging , Microsoft.Extensions.Internal.Transport , Microsoft.Extensions.Http , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry , Microsoft.Win32.SystemEvents , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Ref , System.IO.Pipelines , System.Text.Encodings.Web , System.Text.Json , System.Threading.Channels , System.Windows.Extensions , System.ServiceProcess.ServiceController , System.Security.Principal.Windows , System.Security.Permissions , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Net.WebSockets.WebSocketProtocol , System.Reflection.Metadata , System.Runtime.CompilerServices.Unsafe , System.Security.Cryptography.Cng , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml
 From Version 5.0.0-preview.6.20278.9 -> To Version 5.0.0-preview.6.20279.7

* Update dependencies from https://github.com/dotnet/runtime build 20200530.5

System.ComponentModel.Annotations , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging , Microsoft.Extensions.Internal.Transport , Microsoft.Extensions.Http , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry , Microsoft.Win32.SystemEvents , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Ref , System.Drawing.Common , System.Text.Encodings.Web , System.Text.Json , System.Threading.Channels , System.Windows.Extensions , System.ServiceProcess.ServiceController , System.Security.Permissions , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Net.WebSockets.WebSocketProtocol , System.Reflection.Metadata , System.Runtime.CompilerServices.Unsafe , System.Security.Cryptography.Cng , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Principal.Windows
 From Version 5.0.0-preview.6.20278.9 -> To Version 5.0.0-preview.6.20280.5

* Update dependencies from https://github.com/dotnet/runtime build 20200531.6

System.ComponentModel.Annotations , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging , Microsoft.Extensions.Internal.Transport , Microsoft.Extensions.Http , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry , Microsoft.Win32.SystemEvents , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Ref , System.Drawing.Common , System.Text.Encodings.Web , System.Text.Json , System.Threading.Channels , System.Windows.Extensions , System.ServiceProcess.ServiceController , System.Security.Permissions , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Net.WebSockets.WebSocketProtocol , System.Reflection.Metadata , System.Runtime.CompilerServices.Unsafe , System.Security.Cryptography.Cng , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Principal.Windows
 From Version 5.0.0-preview.6.20278.9 -> To Version 5.0.0-preview.6.20281.6

* Fixup test

* Update dependencies from https://github.com/dotnet/runtime build 20200602.1

System.ComponentModel.Annotations , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Extensions.Logging , Microsoft.Extensions.Internal.Transport , Microsoft.Extensions.Http , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Hosting , Microsoft.Extensions.Configuration.Json , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.Win32.Registry , Microsoft.Win32.SystemEvents , Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Ref , System.Drawing.Common , System.Text.Encodings.Web , System.Text.Json , System.Threading.Channels , System.Windows.Extensions , System.ServiceProcess.ServiceController , System.Security.Principal.Windows , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Net.WebSockets.WebSocketProtocol , System.Reflection.Metadata , System.Runtime.CompilerServices.Unsafe , System.Security.Cryptography.Cng , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions
 From Version 5.0.0-preview.6.20278.9 -> To Version 5.0.0-preview.7.20302.1

* React to ReferenceHandling rename

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Pranav K <prkrishn@hotmail.com>
2020-06-02 21:47:53 +00:00
Brennan 7af5e5d25a
Move all quarantined tests to the aspnetcore-quarantined-tests pipeline (#22445) 2020-06-02 13:02:26 -07:00
Brennan b5e37866d5
Quarantine flaky tests (#22450) 2020-06-02 13:01:54 -07:00
Ajay Bhargav B d68ff6182e
Add IVT from Razor.Language to LanguageServerClient.Razor assembly (#22474) 2020-06-02 19:21:44 +00:00
Doug Bunting 256045729a
Add `SuccessfulTests` to ensure something runs in every non-Helix run (#22406)
* Remove extra `[SkipOnHelix]` attribute
- only need the one compiled into Microsoft.AspNetCore.Testing
- update the documentation to reflect this
  - nit: address Markdown warnings that VS Code showed

* Add `SuccessfulTests` to ensure something runs in every non-Helix runs
- #22241
- cleans up hundreds of warnings but leaves a couple for the Blazor tests assembly
  - see comments about xUnit runner command line in the new class
2020-06-02 12:19:28 -07:00
William Godbe bcd4fc0598
Don't pack .version file in SiteExtensions pkg (#22430) 2020-06-02 09:51:14 -07:00
James Newton-King 4c7e313c89
Add JSON extension methods to request and response (#21731) 2020-06-01 21:00:50 -07:00
Safia Abdalla e66ad54db4
Improve handling for shared values in Blazor Server (#21299) 2020-06-01 15:45:07 -07:00
John Luo 79d3e3e701
Add migrated projects to Razor.sln (#22378) 2020-06-01 13:17:55 -07:00
Brennan 12949b7cb7
Quarantine flaky tests (#22424) 2020-06-01 18:54:34 +00:00
Pranav K c87d14afbc
Add nullability to Localization (#22323)
* Changes to support nullable for ns2.0
* Change ref assembly project to use nullable context
2020-06-01 11:32:31 -07:00
BrennanConroy 648c15dbe9 Skip some tests on Ubuntu 16 2020-06-01 09:49:42 -07:00
Ajay Bhargav B 5c155d4147
Remove workaround for templating encoding issue (#22367) 2020-05-29 22:26:33 -07:00
Tanay Parikh 51cbcbc477
Merge pull request #22379 from dotnet/taparik/grammar_fix
Minor Documentation Grammar Fix
2020-05-29 19:40:44 -07:00
Doug Bunting 14d6b6e286
Build primarily with `dotnet msbuild` (#22017)
* Make `dotnet msbuild` the default on Windows too
  - add step using desktop `msbuild` when native builds may be involved
    - `-All` (without `-NoBuildNative`), `-BuildNative` or `-BuildInstallers` run this step
    - but `-ForceCoreMsbuild` unconditionally skips this step

nits:
- add binary log for RepoTasks build if `$BinaryLog` (echoes the `dotnet msbuild` command)
- add blank lines between build steps

* Enable building managed projects depending on native assets
  - splitting native builds out confuses these projects
  - use `$(BuildNative)` less, only to control actual building (not bundling)
  - build both native platforms in one `msbuild` invocation

* Adjust generation scripts to explicitly choose the MSBuild engine
  - ensure native assets are included in GenerateReferenceAssemblies.ps1 build
  - clean up the global state that tools.ps1 corrupts

* Revert move to VS2019.Pre queues

This reverts part of commit b67d161e03
- was "[release/5.0-preview5] Update dependencies from dotnet/aspnetcore-tooling (#21710)"

* Revert "!temporary! Require `msbuild` from VS2019 16.6"
  - this reverts commit 58cf2304a6

* Reduce build duplication in pipelines
  - build native assets and repo tasks once per CI job
  - only cleanup framework references after packing managed projects

nits:
- wrap a few long lines
- remove extra `-forceCoreMsbuild` options in SiteExtensions' build.cmd

* Fix Helix jobs
  - restore.cmd doesn't work well with `-projects`; script unconditionally adds `-all`

* !fixup! Reduce duplications further
  - missed a couple of places `-noBuildRepoTasks` helps

* Cleanup: Remove a few dangling binary logs

* !fixup! Correct typos in generation scripts

* !fixup! Another typo in the generation scripts
2020-05-29 19:02:03 -07:00
Tanay Parikh d117dde356
Minor Documentation Grammar Fix 2020-05-29 17:53:29 -07:00
Youssef Victor eab9005e6b
Make H3StaticTable static class (#21705)
* Update H3StaticTable.cs

* Update QPackEncoder.cs

* Update Http3TestBase.cs

* Update EncoderStreamReader.cs

* Update QPackDecoder.cs

* Update Http3Stream.cs

* Use s_ prefix for static fields
2020-05-29 21:36:35 +00:00
Huei Feng 22c36ad0f0
fix processex.cs possible problems (#22347)
- `_output ` May be executed in synchronous and asynchronous situations
- Process Is a nullable
2020-05-29 11:45:48 -07:00
Pranav K 78d6ce201f
Merge pull request #22296 from dotnet/prkrishn/merge-into-master
Merge blazor-wasm in to master
2020-05-29 10:37:32 -07:00
John Luo a65a466173
Add a transport package for Mvc.Razor.Extensions pdbs (#22299)
* Add a transport package for Mvc.Razor.Extensions pdbs

* Feedback

* Add two more pdbs
2020-05-28 19:45:52 -07:00
Pranav K 592dfe165b
Changes to build in master
* Cleanup bad merge
* Update to dotnet-serve that supports arbitrary ports
2020-05-28 15:43:55 -07:00
Ryan Brandenburg 26ddefca5e
Quarantine cert test (#22320)
* Quarantine cert test
* Quarantine HttpsHelloWorld test
2020-05-28 14:56:57 -07:00
John Luo b73662ec4f
Always copy Mvc.Razor.Extensions.dll to razor sdk output (#22327) 2020-05-28 14:36:20 -07:00
Huei Feng 3064728c05
Update Http3Connection lock objects to be readonly (#22263) 2020-05-28 14:18:14 -07:00
John Luo 68fea5b9c2 Remove files that should stay in aspnetcore-tooling
Also address some lingering feedback
2020-05-27 16:05:14 -07:00
John Luo 7b56497d5e Merge branch 'master' of ..\aspnetcore-tooling2\ 2020-05-27 15:14:25 -07:00
John Luo 07bab0310a
Merge pull request #22264 from dotnet/johluo/tooling-mopup
Mopup for aspnetcore-tooling migration.
2020-05-27 14:44:56 -07:00
John Luo 297c82f7a4 Fix build 2020-05-27 12:23:09 -07:00
Pranav K dc29f03548
Replace usages of Assembly.CodeBase with Assembly.Location (#22258)
Fixes https://github.com/dotnet/aspnetcore/issues/14827
2020-05-27 12:01:34 -07:00
Pranav K 4c50b6cb16
Merge blazor-wasm in to master 2020-05-27 11:00:38 -07:00
Safia Abdalla 0394a4520e
Fix logging config and output redirection in DebugProxy (#22157)
* Fix logging config and output redirection in DebugProxy
* Log all messages from DebugProxy
2020-05-27 10:32:15 -07:00
lark 5b5c3f3934
Modify the path error in the comment. (#22168) 2020-05-27 09:52:01 -07:00
Pranav K 53edc767a7
Listen to the internet 2020-05-27 08:58:44 -07:00
Pranav K 58cc148ada Skipping flaky tests (dotnet/aspnetcore-tooling#1926)
* Skipping flaky tests

* Update StaticWebAssetsIntegrationTest.cs\n\nCommit migrated from beba53c682
2020-05-26 22:17:26 -07:00
Pranav K ed132be5fe Update StaticWebAssetsIntegrationTest.cs (dotnet/aspnetcore-tooling#1923)
\n\nCommit migrated from aa8bade12e
2020-05-26 22:17:26 -07:00
Pranav K 81007200b5
Quality of life improvements 2020-05-26 18:26:07 -07:00
John Luo 335364165f Fix race in build 2020-05-26 18:10:34 -07:00
John Luo 50d914f1af Merge branch 'master' into johluo/tooling-consolidation-fixup 2020-05-26 15:02:12 -07:00
Doug Bunting 9d7ce5ea75
Quarantine a couple more tests (#22235) 2020-05-26 14:58:25 -07:00
John Luo 50f3a16571 aspnetcore-tooling migration fixups 2020-05-26 12:31:49 -07:00
Michelle Tan 6afd6f40c0
Fix tiny typo in ErrorContext summary. (#22190) 2020-05-24 19:41:19 -07:00
Hao Kung a806ae62c3
Add helix-matrix.yml and windows arm 64 helix queue (#22002) 2020-05-23 17:08:18 -07:00
James Newton-King d58947f1ba
Capture gRPC interop test client output (#22163) 2020-05-23 11:22:15 +12:00
Doug Bunting 5e65e399be
Merge branch 'master' into merge/release/5.0-preview5-to-master 2020-05-22 13:51:55 -07:00
Doug Bunting fef33ad4a2 Quarantine tests based on recent failures 2020-05-22 11:13:07 -07:00
Pranav K ae2017f31e
Changes to allow building in 3.1 branch
* Undo overzealous merge choices
* Undo temporary changes applied when part of the repo was building in the blazor-wasm branch
* Skip SPA template tests in 3.1
2020-05-22 09:20:54 -07:00
James Newton-King 3132e5c6ce
Support quarantine on individual gRPC interop tests (#22124) 2020-05-22 15:47:32 +12:00
dotnet-maestro[bot] b37ebf51e3
[master] Update dependencies from dotnet/aspnetcore-tooling (#22076)
* Update dependencies from https://github.com/dotnet/aspnetcore-tooling build 20200521.1

Microsoft.AspNetCore.Mvc.Razor.Extensions , Microsoft.AspNetCore.Razor.Language , Microsoft.CodeAnalysis.Razor , Microsoft.NET.Sdk.Razor
 From Version 5.0.0-preview.6.20270.11 -> To Version 5.0.0-preview.6.20271.1

Dependency coherency updates

Microsoft.Extensions.Caching.Abstractions,Microsoft.Extensions.Caching.Memory,Microsoft.Extensions.Configuration.Abstractions,Microsoft.Extensions.Configuration.Binder,Microsoft.Extensions.Configuration.CommandLine,Microsoft.Extensions.Configuration.EnvironmentVariables,Microsoft.Extensions.Configuration.FileExtensions,Microsoft.Extensions.Configuration.Ini,Microsoft.Extensions.Configuration.Json,Microsoft.Extensions.Configuration.UserSecrets,Microsoft.Extensions.Configuration.Xml,Microsoft.Extensions.Configuration,Microsoft.Extensions.DependencyInjection.Abstractions,Microsoft.Extensions.DependencyInjection,Microsoft.Extensions.FileProviders.Abstractions,Microsoft.Extensions.FileProviders.Composite,Microsoft.Extensions.FileProviders.Physical,Microsoft.Extensions.FileSystemGlobbing,Microsoft.Extensions.Hosting.Abstractions,Microsoft.Extensions.Hosting,Microsoft.Extensions.Http,Microsoft.Extensions.Logging.Abstractions,Microsoft.Extensions.Logging.Configuration,Microsoft.Extensions.Logging.Console,Microsoft.Extensions.Logging.Debug,Microsoft.Extensions.Logging.EventSource,Microsoft.Extensions.Logging.EventLog,Microsoft.Extensions.Logging.TraceSource,Microsoft.Extensions.Logging,Microsoft.Extensions.Options.ConfigurationExtensions,Microsoft.Extensions.Options.DataAnnotations,Microsoft.Extensions.Options,Microsoft.Extensions.Primitives,Microsoft.Extensions.Internal.Transport,Microsoft.Win32.Registry,Microsoft.Win32.SystemEvents,System.ComponentModel.Annotations,System.Diagnostics.EventLog,System.Drawing.Common,System.IO.Pipelines,System.Net.Http.WinHttpHandler,System.Net.WebSockets.WebSocketProtocol,System.Reflection.Metadata,System.Runtime.CompilerServices.Unsafe,System.Security.Cryptography.Cng,System.Security.Cryptography.Pkcs,System.Security.Cryptography.Xml,System.Security.Permissions,System.Security.Principal.Windows,System.ServiceProcess.ServiceController,System.Text.Encodings.Web,System.Text.Json,System.Threading.Channels,System.Windows.Extensions,Microsoft.Extensions.DependencyModel,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Internal,Microsoft.NETCore.Platforms
 From Version 5.0.0-preview.6.20264.1 -> To Version 5.0.0-preview.6.20270.12 (parent: Microsoft.AspNetCore.Razor.Language

* React to changes

* Update dependencies from https://github.com/dotnet/aspnetcore-tooling build 20200521.3

Microsoft.AspNetCore.Mvc.Razor.Extensions , Microsoft.AspNetCore.Razor.Language , Microsoft.CodeAnalysis.Razor , Microsoft.NET.Sdk.Razor
 From Version 5.0.0-preview.6.20270.11 -> To Version 5.0.0-preview.6.20271.3

Dependency coherency updates

Microsoft.Extensions.Caching.Abstractions,Microsoft.Extensions.Caching.Memory,Microsoft.Extensions.Configuration.Abstractions,Microsoft.Extensions.Configuration.Binder,Microsoft.Extensions.Configuration.CommandLine,Microsoft.Extensions.Configuration.EnvironmentVariables,Microsoft.Extensions.Configuration.FileExtensions,Microsoft.Extensions.Configuration.Ini,Microsoft.Extensions.Configuration.Json,Microsoft.Extensions.Configuration.UserSecrets,Microsoft.Extensions.Configuration.Xml,Microsoft.Extensions.Configuration,Microsoft.Extensions.DependencyInjection.Abstractions,Microsoft.Extensions.DependencyInjection,Microsoft.Extensions.FileProviders.Abstractions,Microsoft.Extensions.FileProviders.Composite,Microsoft.Extensions.FileProviders.Physical,Microsoft.Extensions.FileSystemGlobbing,Microsoft.Extensions.Hosting.Abstractions,Microsoft.Extensions.Hosting,Microsoft.Extensions.Http,Microsoft.Extensions.Logging.Abstractions,Microsoft.Extensions.Logging.Configuration,Microsoft.Extensions.Logging.Console,Microsoft.Extensions.Logging.Debug,Microsoft.Extensions.Logging.EventSource,Microsoft.Extensions.Logging.EventLog,Microsoft.Extensions.Logging.TraceSource,Microsoft.Extensions.Logging,Microsoft.Extensions.Options.ConfigurationExtensions,Microsoft.Extensions.Options.DataAnnotations,Microsoft.Extensions.Options,Microsoft.Extensions.Primitives,Microsoft.Extensions.Internal.Transport,Microsoft.Win32.Registry,Microsoft.Win32.SystemEvents,System.ComponentModel.Annotations,System.Diagnostics.EventLog,System.Drawing.Common,System.IO.Pipelines,System.Net.Http.WinHttpHandler,System.Net.WebSockets.WebSocketProtocol,System.Reflection.Metadata,System.Runtime.CompilerServices.Unsafe,System.Security.Cryptography.Cng,System.Security.Cryptography.Pkcs,System.Security.Cryptography.Xml,System.Security.Permissions,System.Security.Principal.Windows,System.ServiceProcess.ServiceController,System.Text.Encodings.Web,System.Text.Json,System.Threading.Channels,System.Windows.Extensions,Microsoft.Extensions.DependencyModel,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Internal,Microsoft.NETCore.Platforms
 From Version 5.0.0-preview.6.20264.1 -> To Version 5.0.0-preview.6.20270.12 (parent: Microsoft.AspNetCore.Razor.Language

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Pranav K <prkrishn@hotmail.com>
2020-05-22 01:57:56 +00:00
Pranav K 09da906106
Quarantine InteropTest (#22102) 2020-05-21 23:33:08 +00:00
Safia Abdalla 024130e94a
Add nan as dev dependency to React templates (#22089) 2020-05-21 14:43:36 -07:00
DotNet Bot 844a82e37c Merged PR 8040: [internal/release/3.1] Update dependencies from dnceng/internal/dotnet-efcore
This pull request updates the following dependencies

[marker]: <> (Begin:e908e90a-0c22-4c54-b254-08d79557a113)
## From https://github.com/dotnet/efcore
- **Subscription**: e908e90a-0c22-4c54-b254-08d79557a113
- **Build**: 20200520.1
- **Date Produced**: 5/20/2020 5:36 PM
- **Commit**: 85b57af827aa71b77d673e813e046d081c8027ed
- **Branch**: refs/heads/internal/release/3.1
- **Updates**:
  - **Microsoft.EntityFrameworkCore.Tools**: from 3.1.4 to 3.1.5
  - **Microsoft.EntityFrameworkCore.InMemory**: from 3.1.4 to 3.1.5
  - **Microsoft.EntityFrameworkCore**: from 3.1.4 to 3.1.5
  - **Microsoft.EntityFrameworkCore.Relational**: from 3.1.4 to 3.1.5
  - **Microsoft.EntityFrameworkCore.Sqlite**: from 3.1.4 to 3.1.5
  - **dotnet-ef**: from 3.1.4 to 3.1.5
  - **Microsoft.EntityFrameworkCore.SqlServer**: from 3.1.4 to 3.1.5

[marker]: <> (End:e908e90a-0c22-4c54-b254-08d79557a113)
2020-05-21 19:47:40 +00:00
Brennan 8af935684a
Unquarantine test (#22082) 2020-05-21 18:13:53 +00:00
Brennan b277dab236
Fix accidental obsolete (#22065) 2020-05-20 21:57:45 -07:00