huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Use redirect helper (#22847)

This commit is contained in:
Hao Kung 2020-06-15 11:34:56 -07:00 committed by GitHub
parent 11fb7b67d1
commit ef5ab43b6f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Security/Authentication/Core/src/RemoteAuthenticationHandler.cs
View File

@ -276,7 +276,7 @@ namespace Microsoft.AspNetCore.Authentication
{
uri = QueryHelpers.AddQueryString(uri, context.ReturnUrlParameter, context.ReturnUrl);
}
Response.Redirect(uri);
Response.Redirect(BuildRedirectUri(uri));
return HandleRequestResult.Handle();
}

2
src/Security/Authentication/test/GoogleTests.cs
View File

@ -417,7 +417,7 @@ namespace Microsoft.AspNetCore.Authentication.Google
var transaction = await server.SendAsync("https://example.com/signin-google?error=access_denied&error_description=SoBad&error_uri=foobar&state=protected_state",
".AspNetCore.Correlation.Google.correlationId=N");
Assert.Equal(HttpStatusCode.Redirect, transaction.Response.StatusCode);
Assert.Equal("/custom-denied-page?rurl=http%3A%2F%2Fwww.google.com%2F", transaction.Response.Headers.GetValues("Location").First());
Assert.Equal("https://example.com/custom-denied-page?rurl=http%3A%2F%2Fwww.google.com%2F", transaction.Response.Headers.GetValues("Location").First());
}
[Fact]

2
src/Security/Authentication/test/OAuthTests.cs
View File

@ -274,7 +274,7 @@ namespace Microsoft.AspNetCore.Authentication.OAuth
".AspNetCore.Correlation.Weblie.correlationId=N");
Assert.Equal(HttpStatusCode.Redirect, transaction.Response.StatusCode);
Assert.Equal("/access-denied?ReturnUrl=http%3A%2F%2Ftesthost%2Fredirect", transaction.Response.Headers.Location.ToString());
Assert.Equal("https://www.example.com/access-denied?ReturnUrl=http%3A%2F%2Ftesthost%2Fredirect", transaction.Response.Headers.Location.ToString());
}
[Fact]

2
src/Security/Authentication/test/TwitterTests.cs
View File

@ -211,7 +211,7 @@ namespace Microsoft.AspNetCore.Authentication.Twitter
var response = await client.SendAsync(request);
Assert.Equal(HttpStatusCode.Redirect, response.StatusCode);
Assert.Equal("/access-denied?ReturnUrl=%2Fchallenge", response.Headers.Location.ToString());
Assert.Equal("http://localhost/access-denied?ReturnUrl=%2Fchallenge", response.Headers.Location.ToString());
}
[Fact]