Unquarantine Tests (#23098)

Found a bunch of tests running for 30+ days with 100% pass rate.
2020-06-22 17:54:52 -07:00 · 2020-06-22 17:54:52 -07:00 · 26cc3b43a2
parent 7b707c9006
commit 26cc3b43a2
16 changed files with 1 additions and 28 deletions
--- a/src/Components/Components/test/Rendering/RendererSynchronizationContextTest.cs
+++ b/src/Components/Components/test/Rendering/RendererSynchronizationContextTest.cs
@ -26,7 +26,7 @@ namespace Microsoft.AspNetCore.Components.Rendering
            Thread capturedThread = null;

            var e = new ManualResetEventSlim();
-            
+
            // Act
            context.Post((_) =>
            {
@ -766,7 +766,6 @@ namespace Microsoft.AspNetCore.Components.Rendering
        }

        [Fact]
-        [QuarantinedTest]
        public async Task InvokeAsync_SyncWorkInAsyncTaskIsCompletedFirst()
        {
            // Simplified version of ServerComponentRenderingTest.CanDispatchAsyncWorkToSyncContext
--- a/src/Identity/Specification.Tests/src/UserManagerSpecificationTests.cs
+++ b/src/Identity/Specification.Tests/src/UserManagerSpecificationTests.cs
@ -1450,7 +1450,6 @@ namespace Microsoft.AspNetCore.Identity.Test
        /// </summary>
        /// <returns>Task</returns>
        [Fact]
-        [QuarantinedTest]
        public async Task ChangePhoneNumberFailsWithWrongPhoneNumber()
        {
            var manager = CreateManager();
@ -1471,7 +1470,6 @@ namespace Microsoft.AspNetCore.Identity.Test
        /// </summary>
        /// <returns>Task</returns>
        [Fact]
-        [QuarantinedTest]
        public async Task CanVerifyPhoneNumber()
        {
            var manager = CreateManager();
@ -1519,7 +1517,6 @@ namespace Microsoft.AspNetCore.Identity.Test
        /// </summary>
        /// <returns>Task</returns>
        [Fact]
-        [QuarantinedTest]
        public async Task CanChangeEmailOnlyIfEmailSame()
        {
            var manager = CreateManager();
--- a/src/Mvc/Mvc.TagHelpers/test/CacheTagHelperTest.cs
+++ b/src/Mvc/Mvc.TagHelpers/test/CacheTagHelperTest.cs
@ -887,7 +887,6 @@ namespace Microsoft.AspNetCore.Mvc.TagHelpers
        }

        [Fact]
-        [QuarantinedTest]
        public async Task ProcessAsync_AwaitersUseTheResultOfExecutor()
        {
            // Arrange
--- a/src/Servers/IIS/IIS/test/Common.FunctionalTests/ClientCertificateTests.cs
+++ b/src/Servers/IIS/IIS/test/Common.FunctionalTests/ClientCertificateTests.cs
@ -34,7 +34,6 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests
                .WithAllHostingModels();

        [ConditionalTheory]
-        [QuarantinedTest]
        [MemberData(nameof(TestVariants))]
        [MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win8)]
        public Task HttpsNoClientCert_NoClientCert(TestVariant variant)
--- a/src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2ConnectionTests.cs
+++ b/src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2ConnectionTests.cs
@ -300,7 +300,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
        }

        [Fact]
-        [QuarantinedTest]
        public async Task StreamPool_MultipleStreamsInSequence_PooledStreamReused()
        {
            TaskCompletionSource appDelegateTcs = null;
@ -365,7 +364,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
        }

        [Fact]
-        [QuarantinedTest]
        public async Task StreamPool_StreamIsInvalidState_DontReturnedToPool()
        {
            var serverTcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
@ -4010,7 +4008,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
        [Theory]
        [InlineData(true)]
        [InlineData(false)]
-        [QuarantinedTest]
        public async Task CONTINUATION_Received_WithTrailers_Available(bool sendData)
        {
            await InitializeConnectionAsync(_readTrailersApplication);
--- a/src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2TimeoutTests.cs
+++ b/src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2TimeoutTests.cs
@ -371,7 +371,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
        }

        [Fact]
-        [QuarantinedTest]
        public async Task DATA_Sent_TooSlowlyDueToFlowControlOnSmallWrite_AbortsConnectionAfterGracePeriod()
        {
            var mockSystemClock = _serviceContext.MockSystemClock;
@ -426,7 +425,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
        }

        [Fact]
-        [QuarantinedTest]
        public async Task DATA_Sent_TooSlowlyDueToOutputFlowControlOnLargeWrite_AbortsConnectionAfterRateTimeout()
        {
            var mockSystemClock = _serviceContext.MockSystemClock;
--- a/src/Servers/Kestrel/test/InMemory.FunctionalTests/HttpsTests.cs
+++ b/src/Servers/Kestrel/test/InMemory.FunctionalTests/HttpsTests.cs
@ -220,7 +220,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.InMemory.FunctionalTests

        [Fact]
        [Repeat(20)]
-        [QuarantinedTest]
        public async Task DoesNotThrowObjectDisposedExceptionFromWriteAsyncAfterConnectionIsAborted()
        {
            var tcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
--- a/src/Servers/Kestrel/test/InMemory.FunctionalTests/RequestHeaderLimitsTests.cs
+++ b/src/Servers/Kestrel/test/InMemory.FunctionalTests/RequestHeaderLimitsTests.cs
@ -23,7 +23,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.InMemory.FunctionalTests
        [InlineData(5, 0)]
        [InlineData(5, 1)]
        [InlineData(5, 1337)]
-        [QuarantinedTest]
        public async Task ServerAcceptsRequestWithHeaderTotalSizeWithinLimit(int headerCount, int extraLimit)
        {
            var headers = MakeHeaders(headerCount);
--- a/src/Servers/Kestrel/test/InMemory.FunctionalTests/RequestTests.cs
+++ b/src/Servers/Kestrel/test/InMemory.FunctionalTests/RequestTests.cs
@ -559,7 +559,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.InMemory.FunctionalTests
        }

        [Fact]
-        [QuarantinedTest]
        public async Task TraceIdentifierIsUnique()
        {
            const int identifierLength = 22;
--- a/src/SignalR/clients/csharp/Client/test/UnitTests/TimerAwaitableTests.cs
+++ b/src/SignalR/clients/csharp/Client/test/UnitTests/TimerAwaitableTests.cs
@ -13,7 +13,6 @@ namespace Microsoft.AspNetCore.SignalR.Client.Tests
    public class TimerAwaitableTests
    {
        [Fact]
-        [QuarantinedTest]
        public async Task FinalizerRunsIfTimerAwaitableReferencesObject()
        {
            var tcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
--- a/src/Tools/dotnet-watch/test/AppWithDepsTests.cs
+++ b/src/Tools/dotnet-watch/test/AppWithDepsTests.cs
@ -20,7 +20,6 @@ namespace Microsoft.DotNet.Watcher.Tools.FunctionalTests
        }

        [Fact]
-        [QuarantinedTest]
        public async Task ChangeFileInDependency()
        {
            await _app.StartWatcherAsync();
--- a/src/Tools/dotnet-watch/test/DotNetWatcherTests.cs
+++ b/src/Tools/dotnet-watch/test/DotNetWatcherTests.cs
@ -23,7 +23,6 @@ namespace Microsoft.DotNet.Watcher.Tools.FunctionalTests
        }

        [Fact]
-        [QuarantinedTest]
        public async Task RunsWithDotnetWatchEnvVariable()
        {
            Assert.True(string.IsNullOrEmpty(Environment.GetEnvironmentVariable("DOTNET_WATCH")), "DOTNET_WATCH cannot be set already when this test is running");
@ -36,7 +35,6 @@ namespace Microsoft.DotNet.Watcher.Tools.FunctionalTests
        }

        [Fact]
-        [QuarantinedTest]
        public async Task RunsWithIterationEnvVariable()
        {
            await _app.StartWatcherAsync();
--- a/src/Tools/dotnet-watch/test/GlobbingAppTests.cs
+++ b/src/Tools/dotnet-watch/test/GlobbingAppTests.cs
@ -24,7 +24,6 @@ namespace Microsoft.DotNet.Watcher.Tools.FunctionalTests
        [Theory]
        [InlineData(true)]
        [InlineData(false)]
-        [QuarantinedTest]
        public async Task ChangeCompiledFile(bool usePollingWatcher)
        {
            _app.UsePollingWatcher = usePollingWatcher;
@ -43,7 +42,6 @@ namespace Microsoft.DotNet.Watcher.Tools.FunctionalTests
        }

        [Fact]
-        [QuarantinedTest]
        public async Task DeleteCompiledFile()
        {
            await _app.StartWatcherAsync();
@ -60,7 +58,6 @@ namespace Microsoft.DotNet.Watcher.Tools.FunctionalTests
        }

        [Fact]
-        [QuarantinedTest]
        public async Task DeleteSourceFolder()
        {
            await _app.StartWatcherAsync();
@ -77,7 +74,6 @@ namespace Microsoft.DotNet.Watcher.Tools.FunctionalTests
        }

        [Fact]
-        [QuarantinedTest]
        public async Task RenameCompiledFile()
        {
            await _app.StartWatcherAsync();
@ -90,7 +86,6 @@ namespace Microsoft.DotNet.Watcher.Tools.FunctionalTests
        }

        [Fact]
-        [QuarantinedTest]
        public async Task ChangeExcludedFile()
        {
            await _app.StartWatcherAsync();
--- a/src/Tools/dotnet-watch/test/MsBuildFileSetFactoryTest.cs
+++ b/src/Tools/dotnet-watch/test/MsBuildFileSetFactoryTest.cs
@ -77,7 +77,6 @@ namespace Microsoft.DotNet.Watcher.Tools.Tests
        }

        [Fact]
-        [QuarantinedTest]
        public async Task SingleTfm()
        {
            _tempDir
--- a/src/Tools/dotnet-watch/test/NoDepsAppTests.cs
+++ b/src/Tools/dotnet-watch/test/NoDepsAppTests.cs
@ -24,7 +24,6 @@ namespace Microsoft.DotNet.Watcher.Tools.FunctionalTests
        }

        [Fact]
-        [QuarantinedTest]
        public async Task RestartProcessOnFileChange()
        {
            await _app.StartWatcherAsync(new[] { "--no-exit" });
@ -43,7 +42,6 @@ namespace Microsoft.DotNet.Watcher.Tools.FunctionalTests
        }

        [Fact]
-        [QuarantinedTest]
        public async Task RestartProcessThatTerminatesAfterFileChange()
        {
            await _app.StartWatcherAsync();
--- a/src/Tools/dotnet-watch/test/ProgramTests.cs
+++ b/src/Tools/dotnet-watch/test/ProgramTests.cs
@ -24,7 +24,6 @@ namespace Microsoft.DotNet.Watcher.Tools.Tests
        }

        [Fact]
-        [QuarantinedTest]
        public async Task ConsoleCancelKey()
        {
            _tempDir