Commit Graph

20286 Commits

Author SHA1 Message Date
Pranav K 71e388eab7
Unquaratine blazor template tests (#23521)
* Ensure BlazorWebAssembly.js is present

* Unquaratine blazor template tests

* The failure issue https://github.com/dotnet/aspnetcore/issues/20479 was resolved, but the assembly level quarantine was
missed being removed.
* Use shorter project file names to avoid long path issues.
* Update blazorwasm template tests to react to net5 updates

* Update src/ProjectTemplates/Shared/ProjectFactoryFixture.cs
2020-06-30 21:58:54 +00:00
John Luo c4eaad5df5
Fix TLS test (#23489) 2020-06-30 14:46:21 -07:00
Kahbazi 71fef28e47
Remove user id from logs in order to comply GDPR (#17491) 2020-06-30 13:27:53 -07:00
Ajay Bhargav B 7f4b846e9f
Made the encodings of .razor and .cshtml files in the repo consistent (#23502)
* Added UTF8 BOMs to .razor and .cshtml files

* Fixes and unquarantined BOM tests

* Update .editorconfig
2020-06-30 12:03:01 -07:00
Pranav K 3fe6b07412
Ensure BlazorWebAssembly.js is present (#23518) 2020-06-30 11:38:20 -07:00
kapsiR 408b1ac443
Add autocomplete attributes to Identity UI (#14953)
* Add autocomplete attributes to Identity UI V3

* Add autocomplete attributes to Identity UI V4
2020-06-30 09:21:33 -07:00
Steve Sanderson eb76931578
Strip insignificant whitespace at compile time (#23385)
* Define @preservewhitespace directive attribute

* Have ComponentWhitespacePass respect preservewhitespace option

* Tests for overriding the preservewhitespace option (and fix implementation)

* Begin adding test infrastucture for ComponentWhitespacePass

* Remove leading/trailing whitespace from markup elements recursively

* Update baselines

* Add test showing we don't remove whitespace between sibling elements

* Remove whitespace before/after C# code statements (not expressions)

* Update baselines

* Slight improvements to test

* Remove leading/trailing whitespace inside component child content

* Update baselines

* Fix Razor tests

* Fix MVC test

* Better fix for MVC test

* CR: Make ComponentPreserveWhitespaceDirective conditional on langversion >= 5.0
2020-06-30 07:49:28 -07:00
Pranav K 4a93863b8d
Fix the blazorwasm benchmark app (#23498)
Specifying the RID and PublishDir when publishing the driver app causes all sorts of
build issues. This change moves specifying the RID in to the driver app and ensures PublishDir
does not flow to the referenced RazorSDK project.

* Fix docker build
* Update readme typos
2020-06-30 06:31:41 -07:00
Pranav K 7da6931209
Revert "Undo use of pipewriter in FileBufferingWriteStream (#21833)" (#23391)
This reverts commit 48261fdada.
2020-06-30 06:22:33 -07:00
Martin Costello acabbbc61b
Remove QueuePolicy locks (#23187)
* Use field rather than property

Operate on a field directly, rather than through a property.

* Make field readonly

Make field read-only as its value is never changed.

* Remove lock

Use Interlocked.Decrement() instead of taking a lock.

* Remove lock for increment

This removes the need for the lock in the success case at the cost of an extra  Interlocked.Decrement() call for the failed case.

* Fix typos

Change "availible" to "available".

* Add unit test for full queue

Add a unit test that validates request is not queued if the queue is already full.
2020-06-30 05:11:58 +00:00
Hao Kung 1c27ba1bbd
Add compat switch to opt out of breaking change in AuthZ (#23324) 2020-06-29 21:50:27 -07:00
Kevin Pilch 197f156fcd
Obsolete the Libuv transport (#23480) 2020-06-29 19:36:14 -07:00
Pranav K b93db41b5e
Merge branch 'master' into merge/release/5.0-preview7-to-master 2020-06-29 13:29:53 -07:00
Chris Ross e906c2067b
Quarantine Publish_HostedApp_WithSatelliteAssemblies (#23479) 2020-06-29 19:34:09 +00:00
Pranav K 126f14dbd2
Component package updates (#23371)
* Stop cross-compiling Component packages
* Remove Microsoft.JSInterop reference from M.A.Components
* Update RCL template

Fixes https://github.com/dotnet/aspnetcore/issues/23124
Fixes https://github.com/dotnet/aspnetcore/issues/23351
2020-06-29 11:36:59 -07:00
Justin Kotalik b724aa62bf
Update HttpsTests.cs (#23406) 2020-06-29 05:46:25 +00:00
pagan-gerbil cc3d47f550
Fixing a type (hubConnetion -> hubConnection) (#23440) 2020-06-28 03:38:42 +00:00
github-actions[bot] 5a22c49ff3
Sync shared code from runtime (#23430)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2020-06-27 08:09:39 -07:00
Brennan 646de19f1d
Update HubProtocol.md (#23389) 2020-06-26 21:33:29 -07:00
Stephen Halter b446ab7c6f
Add custom request header decoder API to Kestrel (#23233) 2020-06-26 19:49:35 -07:00
Pranav K 04ecd5539f
Merge pull request #23365 from dotnet-maestro-bot/merge/release/5.0-preview7-to-master
[automated] Merge branch 'release/5.0-preview7' => 'master'
2020-06-26 18:36:03 -07:00
Justin Kotalik 73555970ee
Quarantine dotnet-watch test (#23395)
* Quarantine dotnet-watch test

* Update ProgramTests.cs
2020-06-27 01:16:29 +00:00
Pranav K 23a3e845e5
Add RazorLangVersion 5.0 (#23408)
* Add RazorLangVersion 5.0

* Fixup more tests. Add a test for 3.1
2020-06-26 17:49:29 -07:00
Brennan e4158e8a59
Quarantine Publish_HostedApp_VisualStudio_WithSatelliteAssemblies and Publish_UpdatesFilesWhenSourcesChange (#23398)
* Update WasmPublishIntegrationTest.cs

* Update WasmCompressionTests.cs
2020-06-26 22:42:48 +00:00
Pranav K 8e8f0b447b
Merge branch 'master' into merge/release/5.0-preview7-to-master 2020-06-26 13:07:19 -07:00
Chris Ross eeaa85b8d0
Do not cache 304 responses (#23367)
* Do not cache 304 responses #23345

* More guids
2020-06-26 18:28:27 +00:00
Mackinnon Buck 36c6c2c2a6
ElementReference FocusAsync API (#23316)
* Added working focus extension method.

* Added return value documentation for FocusAsync().

* Removed IJSRuntime argument from FocusAsync().

* Removed ElementReference.JSRuntime in favor of IServiceProvider.

* Updated Web.JS release binaries.

* Implemented ElementReferenceContext.

* Made ElementReferenceContext a non-abstract property in Renderer.

* Made ElementReference.Context explicitly nullable.

* Removed useless IServiceProvider dependency in RemoteJSRuntime.

* Updated Microsoft.AspNetCore.Components reference assemblies.

* Improved documentation and limited public API.
2020-06-26 09:19:50 -07:00
Pranav K 65d9429a7d
Add workaround for https://github.com/mono/linker/issues/1298 (#23368) 2020-06-26 08:54:38 -07:00
Eric Erhardt 4891eadbbc
Remove the file extension in CreateBlazorTrimmerRootDescriptorFile (#23330)
The linker doesn't resolve assemblies correctly if the file extension (.dll) is included in the assembly name in the descriptor xml file.

See also https://github.com/mono/linker/issues/1294
2020-06-26 08:34:03 -07:00
John Luo ef1e47d7db
Fix unquarantined test (#23356)
This test was unquarantined but needed a fix to pass on Win7
2020-06-26 07:18:30 +00:00
Justin Kotalik 4ee3644166
Skip dotnet watch tests on arm (#23361) 2020-06-25 20:24:34 -07:00
Justin Kotalik d8a7cedff8
Quarantining blazor tests (#23364) 2020-06-25 18:11:30 -07:00
Pranav K 1f56e82732
Annotate Components.Forms \ Components.Web \ Component.Server with nullable attributes (#23204) (#23355)
* Annotate Components.Forms \ Components.Web with nullable attributes
Contributes to https://github.com/dotnet/aspnetcore/issues/5680

* Fixup

* Fixup rebase

* Undo nullable

* Fixup
2020-06-25 14:32:43 -07:00
Hao Kung be0b9e48b5
Update System.IdentityModel.Tokens.Jwt to 6.6 (#22846)
* Update System.IdentityModel.Tokens.Jwt to 6.6

* Update Versions.props

* Add newtonsoft refs

* Update OIDC instructions

* Fixup JwtBearerSample TFM

Co-authored-by: John Luo <johluo@microsoft.com>
2020-06-25 14:25:59 -07:00
Stephen Halter 71af57fdc0
Remove ConcurrentDictionary in HandshakeProtocol (#23315) 2020-06-25 12:31:38 -07:00
Justin Kotalik 10baccefb4
Merge pull request #23321 from dotnet-maestro-bot/merge/release/5.0-preview7-to-master
[automated] Merge branch 'release/5.0-preview7' => 'master'
2020-06-25 10:41:33 -07:00
Pranav K c42d1a3858
Annotate Components.Forms \ Components.Web \ Component.Server with nullable attributes (#23204)
* Annotate Components.Forms \ Components.Web with nullable attributes
Contributes to https://github.com/dotnet/aspnetcore/issues/5680

* Fixup

* Fixup rebase

* Undo nullable

* Fixup
2020-06-25 17:36:24 +00:00
Pranav K a93ff60904
SDK fixes (#23317)
* Fix up Blazor ILLink Descriptor files

1. Add the typegranularity file to TrimmerRootDescriptor.
2. Remove the application assembly descriptor file, since the application assembly is passed in as a RootAssembly already.

* Razor SDK fixups for blazor

* Only include dlls when generating type granular assemblies
* Write server-worker to the obj directory

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
2020-06-25 08:52:53 -07:00
Pranav K 55b5f959ce
Move RenderRegistryTest (#23327) 2020-06-25 14:23:01 +00:00
Steve Sanderson 1998a06bdc
Blazor grid performance scenarios (#23301)
* Add complex table benchmark

* Add FastGrid scenario too

* Make the two grids consistent with each other

* Add scenario for PlainTable

* Empty commit to trigger re-rerun on CI. Clicking retry doesn't seem to be working.
2020-06-25 09:32:09 +01:00
Brennan 38f9b9abdb
[SignalR] Fix new flaky test (#23326) 2020-06-24 17:53:30 -07:00
Pranav K ac291877c7
Remove WebAssemblyHttpHandler ref-assembly package (#23245)
* Remove WebAssemblyHttpHandler ref-assembly package

Fixes https://github.com/dotnet/aspnetcore/issues/22283

* Fixup
2020-06-24 23:58:18 +00:00
Martin Costello c19f3d29ca
Only look-up Cache-Control once (#23329)
Only look-up the Cache-Control header once, rather than twice if non-empty.
2020-06-24 22:48:36 +00:00
William Godbe cd9da1c350
Fixup kestrel config tests after feedback (#23308) 2020-06-24 12:59:33 -07:00
Brennan dad1ca68d7
Make RequestServices work for cloned longpolling HttpContext (#23014) 2020-06-24 12:29:11 -07:00
Safia Abdalla 4465a8efc8
Disconnect circuit on `beforeunload` event (#23224) 2020-06-24 11:35:28 -07:00
Martin Costello 5155e11120
Two minor perf tweaks in CORS and Localization middleware (#23190)
* Use char instead of char[] for string.Split

Use the newer overload for string.Split() that accepts a char instead of creating a char array.

* Remove redundant bounds check

Remove redundant bounds check for count of exactly 1 as that has already been checked to be true by the previous check.
2020-06-24 07:17:33 -07:00
William Godbe e34469482c
Make Kestrel config case-insensitive for certificates (#23268)
* Make Kestrel config case-insensitive for certificates

* Move tests to ConfigurationReaderTests
2020-06-24 06:40:38 +00:00
Brennan cc15b1bb43
[SignalR] Implement IConnectionLifetimeFeature (#20604) 2020-06-23 22:14:12 -07:00
Pranav K 30472b113e
Merge branch 'master' into merge/release/5.0-preview7-to-master 2020-06-23 20:38:38 -07:00
Pranav K f6a6e4bd07
Replat blazor on net5 (#23078)
* Replat blazor on net5

* Make all e2e tests pass

* Fixup

* Update js files

* Fixups

* Fixup

* Fixup

* Skip globalization tests

* Undo workarounds

* PR feedback

* Update dependencies from https://github.com/dotnet/runtime build 20200622.6

System.ComponentModel.Annotations , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging , Microsoft.Extensions.Internal.Transport , Microsoft.Extensions.Http , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Configuration.Xml , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry , Microsoft.Win32.SystemEvents , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Ref , System.Drawing.Common , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.Channels , System.Windows.Extensions , System.Security.Principal.Windows , System.Security.Permissions , System.Security.Cryptography.Xml , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Net.WebSockets.WebSocketProtocol , System.Reflection.Metadata , System.Runtime.CompilerServices.Unsafe , System.Security.Cryptography.Cng , System.Security.Cryptography.Pkcs
 From Version 5.0.0-preview.7.20321.2 -> To Version 5.0.0-preview.7.20322.6

* Update js file

* Fix version

* Fixup

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
2020-06-23 18:19:55 -07:00
Stephan Troyer 7aa91ffd62
SpaProxy: Fix proxying of WebSocket protocol (#23250) 2020-06-23 16:20:00 -07:00
Pranav K f5709b4080
Add nullable annotations to Microsoft.AspNetCore.Mvc.Abstractions (#22993)
* Add nullable annotations to Microsoft.AspNetCore.Mvc.Abstractions
Contributes to https://github.com/dotnet/aspnetcore/issues/5680

* Changes per PR comments

* Changes per PR comments

* Fixup
2020-06-23 22:56:25 +00:00
Brennan a1c226e4f3
[SignalR] Move to generic host (#22602) 2020-06-23 10:46:03 -07:00
Pranav K baf7e6c4d6
Add support for optional FromBody parameters (#22634) (#23246)
* Add support for optional FromBody parameters (#22634)

* Add support for optional FromBody parameters

Fixes https://github.com/dotnet/aspnetcore/issues/6878

* Fixup nullable

* Changes per API review

* Fixup doc comment (#23229)
2020-06-23 08:06:14 -07:00
Brennan 6a4d79cfb8
Fix java pack on local builds (#23237) 2020-06-22 20:21:13 -07:00
Tanay Parikh 26cc3b43a2
Unquarantine Tests (#23098)
Found a bunch of tests running for 30+ days with 100% pass rate.
2020-06-22 17:54:52 -07:00
Ivan Zub 93e9e1f9e1
Fix urls of @microsoft/dotnet-js-interop package (#23239) 2020-06-22 16:42:21 -07:00
Filip Staffa 94941438d3
Add TagBuilder copy constructor (#10955) (#22729)
Co-authored-by: Filip Staffa <git@filipstaffa.net>
2020-06-22 15:43:25 -07:00
Pranav K 827751ffe1
Fixup doc comment (#23229) 2020-06-22 15:39:39 -07:00
James Newton-King ce80965454
HPackDecoder performance (#23083) 2020-06-23 09:20:06 +12:00
ccvca efeb8508dc
Fix: 'https://' is also supported as scheme. (#23194) 2020-06-22 13:26:30 -07:00
Pranav K f7d2fac8a2
Add support for optional FromBody parameters (#22634)
* Add support for optional FromBody parameters

Fixes https://github.com/dotnet/aspnetcore/issues/6878

* Fixup nullable

* Changes per API review
2020-06-22 19:11:55 +00:00
Sourabh Shirhatti c97a0020d8
Use implicit logging scope for Activity (#22376)
* Revert "Hoist activity fields to the logging scope (#11211)"

This reverts commit f7a2d3c26c.

* Remove tests with Activity

* Remove ActivityId from HostingLogScope

* Enable propogation in CreateDefaultBuilder

* Clean up

* s/logging/loggingBuilder

* Enable Activity propogation for generichost

* Replace with runtime/pull/37892
2020-06-22 10:12:22 -07:00
Steve Sanderson 36be16b640
Fix binding <select> to a null value (#23221) 2020-06-22 17:27:02 +01:00
Artak adbedd2cfb
Render aria-invalid if the state is invalid (#23131)
* Render aria-invalid if the state is invalid

Co-authored-by: Pranav K <prkrishn@hotmail.com>
2020-06-21 21:43:29 -07:00
Hao Kung 8541bf6c98
Flow endpoint and httpcontext always from authz middleware (#22672) 2020-06-19 18:14:47 -07:00
Chris Ross 4d7a79ad64
Change HttpSys default client cert mode to Allow Cert #14840 (#23162) 2020-06-19 16:34:56 -07:00
Pranav K 724c2e75a7
Add nullable annotations to Microsoft.AspNetCore.Components (#22944)
* Add nullable for Microsoft.AspNetCore.Components
Contributes to https://github.com/dotnet/aspnetcore/issues/5680

* Fixup
2020-06-19 18:38:37 +00:00
Safia Abdalla 52de5ee4df
Fix up rendering for select elements with options component (#22978)
* Fix up rendering for select  elements with options component
* Commit updated compiled JS
* Update test case with more scenarios
2020-06-19 08:43:05 -07:00
Filip Staffa a77e68f1c5
Kestrel Endpoints' "SslProtocols" settable via config (#22663) (#22910) 2020-06-19 08:09:56 -07:00
John Luo bb92c602d8
Fix Windows 7/8 Kestrel tests (#23069) 2020-06-19 00:24:21 -07:00
Pranav K f3b370c1ac
Annotate Authorization.Core, Authorization.Policy with nullable (#22990)
Contributes to https://github.com/dotnet/aspnetcore/issues/5680
2020-06-18 23:43:35 +00:00
Safia Abdalla a173be28fb
Add support for <BlazorWebAssemblyLazyLoad /> item group (#23071)
* Add support for <BlazorLazyLoad /> item group
* Respond to feedback from peer review
2020-06-18 16:05:34 -07:00
Doug Bunting ab7f3f2018
Enable `/warnAsError` (#23072)
* Enable `/warnAsError` in Windows builds
  - already enabled in non-Windows builds because override existed only in build.ps1
* Allow some warnings related to closed issues
  - common `<NoWarn>$(NoWarn);CS1591</NoWarn>` case unchanged
    - /Directory.Build.props ensures that warning remains a warning but doesn't hide it
* !fixup! Root build.sh _does_ disable warnings as errors
  - variable eng/common/tools.sh uses named `warn_as_error`
2020-06-18 15:59:34 -07:00
Stephen Halter 6abc3c759f
Fix Kestrel HTTP/2 debug assert failure (#23062) 2020-06-18 15:13:18 -07:00
Safia Abdalla f627352387
Fix authorization setup in Razor pages template (#23029) 2020-06-18 13:30:08 -07:00
Doug Bunting 214df1c8ef
Merge pull request #22902 from dotnet-maestro-bot/merge/release/3.1-to-master
[automated] Merge branch 'release/3.1' => 'master'
2020-06-18 12:24:36 -07:00
Pranav K a44c1ad78c
Fix null reference errors in tests (#23091)
Fixes https://github.com/dotnet/aspnetcore/issues/22992
2020-06-18 11:05:54 -07:00
Justin Kotalik cbb8c6d915
Update FormsTest.cs 2020-06-18 09:48:40 -07:00
John Luo c83fd8951a
Add sharedfx and targeting pack tests (#23045)
* Add test for assembly versions

* Add test for framework list

* Add some hardcoded lists for sharedfx and targeting pack content
2020-06-17 17:06:04 -07:00
John Luo 45e6571649
Downgrade or throw when HTTP/2 over TLS is configured on older Windows versions (#22859)
HTTP/2 over TLS is not compatible with Windows versions strictly older than Windows 10 or Windows Server 2016. Update kestrel to:
- Downgrade to HTTP/1.1 when Http1AndHttp2 is configured.
- Throw NotSupportedException when Http2 is configured.
- Allow HTTP/2 over TLS to be enabled if AppContext switch Microsoft.AspNetCore.Server.Kestrel.EnableWindows81Http2 is set. This allows users who have configured cipher suites on Windows 8.1 and Windows Server 2012 R2 to continue using HTTP/2 over TLS.
2020-06-17 16:50:48 -07:00
Safia Abdalla 7a82a48a20
Fix build issues in Blazor WASM template tests (#23052) 2020-06-17 15:31:00 -07:00
Justin Kotalik 855a73816d
Update Microsoft.AspNetCore.Server.HttpSys.FunctionalTests.csproj 2020-06-17 13:54:53 -07:00
Justin Kotalik c5b7eab345
Update Microsoft.AspNetCore.Server.HttpSys.csproj 2020-06-17 13:53:19 -07:00
Doug Bunting c4c6e25a06
Add missing doc files and cleanup nits (#22931)
* nit: Remove useless `$(HasReferenceAssembly)` settings
  - set in /Directory.Build.targets
    - `true` only in `$(IsAspNetCoreApp)` projects
* nit: Remove useless `$(CompileUsingReferenceAssemblies)` settings
  - no current versioning differences between ref/ and src/ assemblies when targeting default TFM
* Add more `$(GenerateDocumentationFile)` settings
  - increases the number of generated doc files, mostly without problems
- !fixup! correct typo in `DebugProxyHost` doc comments
    - was not generating a doc file before
  - remove previous (ineffective) src/Components/Directory.Build.targets setting
  - nit: remove a duplicate `$(GenerateDocumentationFile)` setting
* nit: Remove useless `$(IsPackable)` settings
  - only analyzers and implementation projects are packable by default
    - main use case for explicit setting is projects shipping only in shared framework
  - conditional setting in src/Mvc/Directory.Build.props just subset logic in /Directory.Build.targets
* nit: Remove useless `$(IsProjectReferenceProvider)` settings
  - only implementation projects are providers by default
* nit: Remove useless `$(IsTestAssetProject)` settings
  - set in src/Mvc/test/WebSites/Directory.Build.props
* !fixup! Looks like `InProcessNewShimWebSite` must compile w/o ref/ assemblies
  - restore `$(CompileUsingReferenceAssemblies)` in this one project
2020-06-17 13:04:45 -07:00
N. Taylor Mullen 538c462c05 Enable Helix tests for Microsoft.AspNetCore.Mvc.Razor.Extensions.* projects.
- Enabled Helix for:
    - `Microsoft.AspNetCore.Mvc.Razor.Extensions.Test`
    - `Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X.Test`
    - `Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X.Test`
- These tests depended on our MVC shim project's deps.json's to exist in the test bin directory during publish. Therefore added an additional target copy over those assets at publish time.
- There were some tests that were relying on source positions from a string to match a runtime generated source position. In Helix dll's are built on Windows (string's get compiled with \r\n) and then deployed to potentially non-Windows boxes resulting in mismatches of expectations. To address this I changed the test that had this dependency to dynamically generate the input string.
- Our common language test project used to rely on test files being on disk. At some point in the past those test files started being embedded in the assembly but we maintained directory checking logic to ensure various directories existed on disk (no longe required). Changed the logic to not enforce directories to be on disk (they aren't in Helix) and instead only rely on the embedded TestFiles.

dotnet/aspnetcore#22100
2020-06-17 11:49:49 -07:00
Safia Abdalla 952a19682d
Quarantine failing test (#23044) 2020-06-17 18:49:43 +00:00
dotnet-maestro[bot] 632aa8a95c
[master] Update dependencies from dotnet/runtime (#23040)
* Update dependencies from https://github.com/dotnet/runtime build 20200617.2

System.ComponentModel.Annotations , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging , Microsoft.Extensions.Internal.Transport , Microsoft.Extensions.Http , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Configuration.Xml , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry , Microsoft.Win32.SystemEvents , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Ref , System.Drawing.Common , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.Channels , System.Windows.Extensions , System.Security.Principal.Windows , System.Security.Permissions , System.Security.Cryptography.Xml , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Net.WebSockets.WebSocketProtocol , System.Reflection.Metadata , System.Runtime.CompilerServices.Unsafe , System.Security.Cryptography.Cng , System.Security.Cryptography.Pkcs
 From Version 5.0.0-preview.7.20315.3 -> To Version 5.0.0-preview.7.20317.2

* null

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: BrennanConroy <brecon@microsoft.com>
2020-06-17 18:46:34 +00:00
Justin Kotalik b8de65dbac
Update Microsoft.AspNetCore.Shared.Tests.csproj 2020-06-17 11:18:22 -07:00
Justin Kotalik bccaa41ca8
Update Http2Utilities.cs 2020-06-17 11:17:35 -07:00
ZeBobo5 b8d090b983
Fix #23038 (#23039) 2020-06-17 06:50:31 -07:00
David Melendez d1ae0e6e3e
adding community identity providers (#17051)
Adding Azure Table Storage and CosmosDB SQL providers to the list.
2020-06-17 06:23:48 -07:00
Ken Dale 28ed208022
Add SetIsOriginAllowedToAllowWildcardSubdomains_DoesNotAllowRootDomain test (#23001)
This test makes it clear root domains are not included in CORS subdomain wildcards
2020-06-17 06:22:20 -07:00
Dan Friedman f6fee9b4b8
Link to maintained identity provider (#21015) 2020-06-17 06:21:35 -07:00
Artak 2434047663
Quarantined tests which were not running (skipped on Helix) (#23023) 2020-06-17 04:22:17 +00:00
Adam Sitnik 580a6cce0f
BDN workaround for netcoreapp5.0->net5.0 moniker rebranding (#23000) 2020-06-17 13:43:40 +12:00
James Newton-King 29bbf06c77
Turn off gRPC interop test console color logging (#22923) 2020-06-17 12:38:32 +12:00
Pranav K 65e933ec70
Update PhoneNumberTokenProvider.cs (#22766)
* Update PhoneNumberTokenProvider.cs

Add license header.
Hyphenate two-factor authentication in documentation.
Add line breaks before return statements.
Use string interpolation instead of string concatenation.
2020-06-16 17:22:26 -07:00
Safia Abdalla 51f977db2f
Unquarantine tests that have passed for 30+ days (#23011) 2020-06-16 16:23:50 -07:00
Safia Abdalla ac0b0ee063
Quarantine failing E2E circuit test (#23016) 2020-06-16 22:01:40 +00:00
Hao Kung c330c0b37d
Cookie renew ticket if it already exists (#22732) 2020-06-16 14:51:57 -07:00
John Luo b40b1bb7b2
Fix helix-matrix tests (#22918)
* Update SslProtocols to use system defaults
2020-06-16 13:37:49 -07:00
Luke Pfeiffer 89e387ee88
Fixed mistype in the `VarInt` examples (#23007)
The second `VarInt` example has `0x80 0x25` is represented as (`%10000000 %00101001`) which when decoded becomes 0x1480 (5248)

When trying to implement `VarInt` encoding and decoding myself I found that `0x25` is actually `%00100101` instead of `%00101001` which causes the final decoded `VarInt` to be incorrect.

The proper hex value for the binary `%00101001` is `0x29`
2020-06-16 13:07:41 -07:00
Pranav K b6bde6cbc9
Annotate ObjectPool with nullable (#22823)
* Annotate ObjectPool with nullable

* fixup
2020-06-16 19:43:24 +00:00
Safia Abdalla b484680092
Update how default auth policy is set in templates (#22884)
* Update how default auth policy is set in templates
* Respond to feedback from peer review
2020-06-15 20:27:33 -07:00
John Luo 675fd1413c
Quarantine test (#22981) 2020-06-15 19:48:33 -07:00
Brennan 49aecc3efe
Use non-generic TaskCompletionSource in SignalR and Kestrel (#22925) 2020-06-15 17:35:19 -07:00
Stephen Halter a67c217976
Abort request when returning a completed FlushResult (#22086) 2020-06-15 16:36:55 -07:00
Justin Kotalik dc3cb10f2b
Update Microsoft.AspNetCore.Shared.Tests.csproj 2020-06-15 16:31:32 -07:00
Pranav K 8efcca43ce
Annotate Microsoft.AspNetCore.Http with nullable attributes (#22928)
* Annotate Microsoft.AspNetCore.Http with nullable attributes

* Annotate Hosting with nullable
2020-06-15 23:29:19 +00:00
Pranav K c93b61156d
Annotate webencoders with nullable (#22927) 2020-06-15 23:11:20 +00:00
John Luo b284229790
Consume host resolver source package from dotnet/runtime (#22962) 2020-06-15 15:21:58 -07:00
James Newton-King a861d18d24
Add HTTP/2 keep alive pings (#22565) 2020-06-16 10:13:09 +12:00
brianchance a0827ace5e
Change default for queryStringDelete (#21586) 2020-06-15 14:46:40 -07:00
Huei Feng 7cdbaeeccf
Update Async To MigrationsEndPointMiddleware (#22573) 2020-06-15 14:42:55 -07:00
Todd Grunke ef0eff7089
Merge pull request #22903 from dotnet/dev/toddgrun/NoMoreLineTrackingStringBuffer
Get rid of LineTrackingStringBuffer class and instead use the line in…
2020-06-15 14:38:37 -07:00
Pranav K 122cf4ee4c
Delete Microsoft.AspNetCore.Components.WebAssembly.Templates.csproj 2020-06-15 14:03:18 -07:00
Justin Kotalik 9288627fed Fixing up build issues 2020-06-15 13:31:09 -07:00
Pavel Voronin dc3398ca59
Fix xmldoc typo (#22938)
Just removed 'for'  in

> Adds middleware _for_ needed for debugging Blazor WebAssembly applications
2020-06-15 13:19:23 -07:00
Todd Grunke 56374ab393 use var where appropriate 2020-06-15 13:15:38 -07:00
Justin Kotalik afb1f48143 Merge branch 'release/3.1' 2020-06-15 13:03:14 -07:00
Sébastien Ros dc472b737e
Unquarantine tests (#22851) 2020-06-15 12:15:54 -07:00
Pranav K bab5a8f1b8
Add an option to configure the NewtonsoftJson buffer size (#22735)
* Add an option to configure the NewtonsoftJson buffer size
Contributes to https://github.com/dotnet/aspnetcore/issues/21245

* Update src/Mvc/Mvc.NewtonsoftJson/src/MvcNewtonsoftJsonOptions.cs

Co-authored-by: Stephen Halter <halter73@gmail.com>

Co-authored-by: Stephen Halter <halter73@gmail.com>
2020-06-15 19:07:26 +00:00
Hao Kung ef5ab43b6f
Use redirect helper (#22847) 2020-06-15 11:34:56 -07:00
Scott Addie 11fb7b67d1
Add detail to InvalidOperationException in Exception Handler Middleware (#22858) 2020-06-15 11:31:23 -07:00
John Luo 11c8ad4010
Consolidate RazorSdkDirectory logic (#22836)
* Consolidate RazorSdkDirectory logic
2020-06-15 09:08:13 -07:00
Pranav K f04992fab5
Add nullable to DataProtection (#22591)
* Add nullable to DataProtection

Contributes to https://github.com/dotnet/aspnetcore/issues/5680
2020-06-13 20:39:41 -07:00
John Luo 0f70380524
Quarantine tests (#22919) 2020-06-13 14:28:40 -07:00
Todd Grunke 2c594199c3 Fix a bug in DefaultRazorSourceLineCollection.GetLineStarts 2020-06-12 17:56:19 -07:00
Todd Grunke a1dd898994 Get rid of LineTrackingStringBuffer class and instead use the line information provided by RazorSourceDocument.
This additionally gets rid of an extra whole buffer allocation in the ParserContext. The most complex bit of the change is around avoiding TextLineCollection.GetLocation.

Overall, I'm seeing a pretty big win here, about 35% less time spent in RazorSyntaxTree.Parse for the typing scenario I was doing in a very large file.
2020-06-12 17:22:24 -07:00
Pranav K 350540d0af
Make WebAssembly templates use the same version as the rest of the WASM product (#22896)
We've already shipped a 3.2.0 version of the package. The build's currently producing
3.1.6 version of the package. This changes the package version to 3.2.1
2020-06-12 16:30:28 -07:00
James Newton-King 3dc39cc2dc
Improve gRPC interop test failure logging (#22856) 2020-06-13 09:14:12 +12:00
Todd Grunke 073cd0aa40
Merge pull request #22877 from dotnet/dev/toddgrun/MorePerfOptimizations
Dev/toddgrun/more perf optimizations
2020-06-12 13:25:31 -07:00
Todd Grunke b13cb76c0a
Merge pull request #22887 from dotnet/dev/toddgrun/TrySplitNamespaceAndTypeAllocatesTooMuch
Small memory allocation optimization in DefaultRazorTagHelperBinderPh…
2020-06-12 13:18:12 -07:00
William Godbe 0343af108a
Merge pull request #22840 from dotnet-maestro-bot/merge/release/3.1-to-master
[automated] Merge branch 'release/3.1' => 'master'
2020-06-12 13:03:12 -07:00
Todd Grunke 43a628e9fb Small memory allocation optimization in DefaultRazorTagHelperBinderPhase.TrySplitNamespaceAndType
This method allocated multiple strings on every invocation when they were rarely needed. With this change, I see a reduction in memory allocated during RazorProjectEngine.ProcessDesignTime of 1.4%.
2020-06-12 12:04:47 -07:00
Justin Kotalik dcd1250f43
[3.1] Add latin1 support to IIS (#22798)
Co-authored-by: Chris Ross <Tratcher@Outlook.com>
2020-06-12 11:10:00 -07:00
Pranav K 8c1bf1f1a3
Add nullable annotations to Healthchecks (#22785)
* Add nullable annotations to Healthchecks

* Update HealthCheckContext.cs
2020-06-12 17:17:28 +00:00
Javier Calvarro Nelson 53696e4228
Quarantine static web assets tests so we can capture more data for diagnostics (#22876) 2020-06-12 10:14:22 -07:00
Javier Calvarro Nelson 3679a01e4d
Unquarantine tests since they haven't failed in 30 days (#22878) 2020-06-12 10:12:51 -07:00
Sébastien Ros 0ec79c5196
Quarantining InputDateInteractsWithEditContext_NonNullableDateTime (#22857)
https://github.com/dotnet/aspnetcore-internal/issues/3616
2020-06-12 10:02:33 -07:00
Pranav K c30638b829
Fixup nullable (#22861) 2020-06-12 15:32:41 +00:00
Todd Grunke 9cf611b9e2 Revert change to EndLocation as it was incorrectly changed. 2020-06-12 08:28:32 -07:00
John Luo ef9a3662d6
Also set no-store when we set no-cache in response cache control headers (#22842) 2020-06-11 20:38:54 -07:00
Pranav K 20770811a4
Add nullability to antiforgery (#22279)
* Add nullability to antiforgery

Addresses #5680

* Rebase
2020-06-12 03:23:33 +00:00
Todd Grunke 904fd19605 A couple more perf optimizations focused around memory allocations.
This is the last of the easy wins that I could find for typing in large razor files (minus the logged bug to move the divergence checker code off the UI thread). In the profile for the large document editing, these changes reduce allocated memory during RazorSyntaxTree.Parse by about 25%. CPU wise, the win isn't quite as dramatic, only a couple percent improvement under RazorSyntaxTree.Parse.
2020-06-11 18:11:29 -07:00
Pranav K a99dd0d312
Update js 2020-06-11 17:10:19 -07:00
Pranav K ea4b52ccba
Merge remote-tracking branch 'origin/release/3.1' 2020-06-11 15:52:06 -07:00
Pranav K 0a42cca945
Razor SDK build ordering issues (#22684)
* Razor SDK build ordering issues

* Build the SDK completely regardless of the MSBuild runtime type
* Split SDK integration tests into a separate project. Clean up project file

* Add project to sln

* Update Microsoft.NET.Sdk.Razor.csproj

* Fixup tests

* Avoid rebuilding dependencies if they appear up to date. Fixup tests

* Fixup

* Update CSharp.Common.props

* Cleanup the build
2020-06-11 21:16:05 +00:00
Pranav K 596f93324d
Fix nullable build warning (#22838) 2020-06-11 20:48:55 +00:00
Pranav K 75b27754d6
Ensure FileBufferingReadStream created by formatters are always disposed (#22746) 2020-06-11 13:14:15 -07:00
Javier Calvarro Nelson 5a9a98543f
[Blazor] Switches Error.razor to Error.cshtml (#22777)
* [Blazor] Switch to use a cshtml file for errors

* Update template tests
2020-06-11 13:13:05 -07:00
Javier Calvarro Nelson 9d7018544a
[Blazor] Fix manifest integrity computation (#22771)
* [Blazor] Fix manifest integrity computation

* Add a couple of tests to validate incrementalism
2020-06-11 13:12:53 -07:00
Javier Calvarro Nelson ce533485f0
[Blazor] Register HttpClient as a scoped instance (#22770)
This avoid the container holding on to transient HttpClient instances for the lifetime of the application.
2020-06-11 13:12:43 -07:00
Pranav K 8e813eea24
Workaround for DomException when invoking cache.put (#22756)
* Workaround for DomException when invoking cache.put

Invoking cache.put could sometimes result in exceptions being thrown. While this seems to have been fixed in Chromium - https://bugs.chromium.org/p/chromium/issues/detail?id=968444,
we've had several reports of this in our repo. The fix here is to write defensively when working with the cache apis since they appear to behave in unexpected ways..

Fixes https://github.com/dotnet/aspnetcore/issues/20256

* Fixup
2020-06-11 13:12:33 -07:00
msftbot[bot] 62e6d93f5c
Merge pull request #22833 from dotnet-maestro-bot/merge/release/3.1-to-master
[automated] Merge branch 'release/3.1' => 'master'
2020-06-11 19:32:33 +00:00
Todd Grunke 73f04eecac
Add mechanism where IR token generation can defer allocation of it's … (#22792)
* Add mechanism where IR token generation can defer allocation of it's content.

It turns out that many IR tokens access their content, and thus allocating it is unnecessary. In particular, with this change against a large file, I've seen allocations under SyntaxNodeExtensions.GetContent reduced by about 33%. Performance wise, I've seen the number of CPU samples in the profile under GetContent reduce by about 40% (in my sample I typed 26 characters and there was about 600 ms less spent in GetContent)

* ContentGetter => ContentFactory

* Make tests happy with the switch from IntermediateToken to IntermediateTokenWithDeferreedContentAllocation

* IntermediateTokenWithDeferredContentAllocation => LazyIntermediateToken
2020-06-11 18:20:41 +00:00
Brennan 812f2f8145
Fixes NullRef exception in IIS in-proc (#22806) 2020-06-11 10:57:36 -07:00
Pranav K 3e6495fde3
Bump up the wasm template precedence (#22802) 2020-06-11 10:10:10 -07:00
David Fowler 9e55787b84
Add support for listening to tcp handles to in the Sockets transport (#22618)
* Add support for listening to tcp handles to in the Sockets transport
- Make ListenHandleTests shared across both transports

Fixes #20842
2020-06-11 09:36:27 -07:00
Sébastien Ros 5f26302eaa
Quarantining CanDispatchAsyncWorkToSyncContext (#22803)
* Quarantining CanDispatchAsyncWorkToSyncContext

* Missing using

* Make method virtual
2020-06-11 09:30:26 -07:00
Ryan Brandenburg b61e9b0125
Remove PubTernal APIs (#22290)
Remove PubTernal APIs
2020-06-11 09:21:39 -07:00
Sébastien Ros fe24d85356
Merge pull request #22790 from dotnet-maestro-bot/merge/release/3.1-to-master
[automated] Merge branch 'release/3.1' => 'master'
2020-06-10 18:19:19 -07:00
Stephen Halter 6c31da5b1f
Enable Kestrel config reload in ConfigureWebHostDefaults (#22528) 2020-06-10 17:47:17 -07:00
Will Godbe 97f3ea1453 Fixup .sln 2020-06-10 13:40:08 -07:00
Will Godbe 3d79c2b319 Fixup 2020-06-10 13:08:11 -07:00
Tanya e929dab496
Replace favicon.ico with smaller size (#22533)
Co-authored-by: Tanya Do <tad@microsoft.com>
2020-06-10 12:17:25 -07:00
Pranav K 07b1bf4f71
Fixup error 2020-06-10 12:07:17 -07:00
Pranav K 71853a4640
Merge branch '3.1merge' 2020-06-10 11:30:40 -07:00
Safia Abdalla a529b4c70c
Add nan as dev dependency to React templates (#22089) (#22205) 2020-06-10 09:59:39 -07:00
Safia Abdalla 55822ca516
Upgrade jQuery in samples to version 3.5.1 (#21577) (#21792)
Fixes #21572

Co-authored-by: Christian Wenz <info@christianwenz.de>
2020-06-10 09:59:29 -07:00
Jonathan edf73e084b
Update TotpSecurityStampBasedTokenProvider.cs 2020-06-10 13:36:49 +02:00
Jonathan 6b761eaeab
Update PhoneNumberTokenProvider.cs 2020-06-10 13:36:32 +02:00
Jonathan 9db52fac7a
Update EmailTokenProvider.cs 2020-06-10 13:36:16 +02:00
Jonathan 103a305c25
Update TotpSecurityStampBasedTokenProvider.cs
Add line breaks before return statement.
Use string interpolation instead of string concatenation.
Hyphenate the documentation.
2020-06-10 12:12:09 +02:00
Jonathan 9b8cd29087
Hyphenate documentation
Hyphenate "two-factor authentication" in documentation.
Add line break before return statements.
2020-06-10 12:07:30 +02:00
Jonathan d1793dda5f
Hyphenate documentation
Hyphenate two-factor authentication in the documentation.
2020-06-10 12:05:45 +02:00
Jonathan 5972fa0004
Update EmailTokenProvider.cs 2020-06-10 12:02:18 +02:00
Jonathan be334b0d00
Update PhoneNumberTokenProvider.cs
Add license header.
Hyphenate two-factor authentication in documentation.
Add line breaks before return statements.
Use string interpolation instead of string concatenation.
2020-06-10 11:57:29 +02:00
Pranav K c58ab9247c
Add nullable to JSInterop (#22326) 2020-06-10 05:39:01 +00:00
Pranav K b3ad812c14
Mark Wasm benchmark app as a test asset 2020-06-09 19:24:03 -07:00
Pranav K ae8f67f201
Use randomized ports in dotnet-serve 2020-06-09 19:20:12 -07:00
Justin Kotalik c1a3a2f10c
Change debug information format (#22734) 2020-06-09 18:03:19 -07:00
Safia Abdalla fbb70b12de
Fix startvs.cmd for Components solution (#22739) 2020-06-10 00:32:42 +00:00
Pranav K dd62a699f7
Merge remote-tracking branch 'origin/release/3.1' into prkrishn/merge-blazor-wasm 2020-06-09 16:54:36 -07:00
William Godbe 99e90f5782
Produce non-stable version of targeting pack (#22372)
* Produce non-stable version of targeting pack

* Fix tag

* Fix indentation

* Fixup proj file

* Move Internal proj to separate folder

* Remove redundant proj

* Start moving files

* finish moving files

* Set IsReferenceAssemblyProject=true in targeting pack proj
2020-06-09 16:40:00 -07:00
Justin Kotalik b19d9d9540
Enable control flow guard for IIS dlls (#22609) 2020-06-09 16:26:18 -07:00
Pranav K 758ca19edc
Build against the local JSInterop (#22526) 2020-06-09 14:38:13 -07:00
Todd Grunke 4d367898b3
Merge pull request #22686 from dotnet/dev/toddgrun/expand_cached_tokens
Expand the SyntaxTokenCache to contain more than just whitespace tokens.
2020-06-09 13:00:10 -07:00
William Godbe 64f7f5a883
Unquarantine test that's not flaky anymore (#22664) 2020-06-09 10:21:07 -07:00
Pranav K 0794d6077d
Make AuthenticateAsync return non-null result (#22708)
* Make AuthenticateAsync return non-null result

* NoResult
2020-06-09 17:05:26 +00:00
Javier Calvarro Nelson a27356078f
Disable Yarn warnings on CI builds for restore and Blazor WebAssembly projects (#22703)
Disables warnings when running the Yarn task in CI environments. You'll still get the warnings on developer builds.
2020-06-09 09:53:50 -07:00
Pranav K 21f47cdf22
Ship JSInterop.WebAssembly package (#22685)
Fixes https://github.com/dotnet/aspnetcore/issues/22674
2020-06-09 16:32:00 +00:00
Ondřej Štorc 9ce4a970a2
Parsing extension-av on Set Cookie header (#22181) 2020-06-09 08:48:39 -07:00
Pranav K 25e21df3a7
Set the correct tfm in Wasm template.json (#22678) 2020-06-09 15:39:42 +00:00
Pranav K 11ac23c65d
Changes per PR 2020-06-08 22:19:34 -07:00
Brennan 4a66e2d1ab
[Java] Observe error to avoid crash (#22016) 2020-06-08 18:25:49 -07:00
Scott Addie eee77a8f10
Improve XML docs for ActionResultStatusCodeAttribute (#22598) 2020-06-08 15:57:11 -07:00
Todd Grunke 837c639041 Expand the SyntaxTokenCache to contain more than just whitespace tokens. 2020-06-08 15:37:35 -07:00