e54da5e6f6
Remove dead code in invoker (SetStage)
2015-10-06 13:28:33 -07:00
761c7e6751
Optimize allocations for creating ActionConstraints
2015-10-06 12:35:13 -07:00
1ed22e5939
Avoid state machine and allocation for 0-parameters
2015-10-06 12:02:49 -07:00
04d72d8894
Simplify FileResult
...
Fixes #3249
2015-10-06 11:26:56 -07:00
04c6fceb94
React to aspnet/Routing#215
2015-10-06 10:37:56 -07:00
a0764faa86
Bring arguments inline between before/after events
2015-10-05 16:42:25 -07:00
32c174c791
CR feedback from attribute dictionary
2015-10-05 10:38:46 -07:00
ad3c257ef5
Fix for #3252 - Issues with pooled buffer + unicode
...
- Dispose buffers when Flush throws inside the Dispose method
- Compute size of buffers correctly
- Throw earlier when handed invalid-sized buffers
2015-10-05 09:45:23 -07:00
f57e180971
Renaming Microsoft.Framework.* -> Microsoft.Extensions.*
2015-10-03 15:44:53 -07:00
6185b16795
Custom dictionary type for attributes
2015-10-02 18:08:58 -07:00
4e08eda58d
Use pooled memory for the streamwriter
2015-10-02 14:35:15 -07:00
306776ff63
Minor cleanup/refactor of ViewResult
...
- Make ViewExecutor a service
- Add facades for ViewResult/PartialViewResult
- Add eventing for ViewFound/NotFound in PartialViewResult
- Add eventing around view execution
- Cleanup of some various eventing & our tests code
2015-10-02 08:18:00 -07:00
eef6c3883a
Renamed PhysicalFileProviderResult and VirtualFileProviderResult to PhysicalFileResult and VirtualFileResult respectively
2015-10-01 19:57:35 -07:00
130d94eb7e
[ Fixes #3068 ] TempData fails silently without sessions middleware
2015-10-01 19:28:46 -07:00
2028351bb8
React to WriteAttribute \ AddHtmlAttribute API changes
2015-10-01 10:19:14 -07:00
5a705d820d
Replacing NotNullAttribute with thrown exceptions
2015-10-01 08:23:21 -07:00
3a876e387f
Replacing NotNullAttribute with thrown exceptions
2015-10-01 06:19:18 -07:00
02c36a1c48
Replace NotNullAttribute with thrown exceptions
2015-09-30 17:18:16 -07:00
eefa58e617
[ Fixes #3043 ] Overflow exceptions converted to invalid value messages
2015-09-29 16:24:19 -07:00
f162f70c1e
Fixed typo (occured to occurred) in comments and resources.
2015-09-29 10:19:26 -07:00
13af6f8e1a
Wrap rather long line in 9243d83
2015-09-29 09:58:23 -07:00
c713aa92ca
Making the HtmlHelper.GetEnumSelectList take DisplayAttribute.GroupName into account to create select groups.
2015-09-29 09:53:48 -07:00
d37f5aeb31
Fix #3217 - Optimize IList.GetEnumerator allocations
...
This change fixes call sites on the main request path for a simple site
(model binding, validation, views) that allocate boxed list enumerators.
Some cases aren't addressed by this change because the fix is too invasive
or requires changing an important contract to take IList instead of
IEnumerable. Will follow up on those case by case in order of importance.
2015-09-28 16:17:48 -07:00
28aec3f5cc
Support user overrides of system-provided `ModelError` messages
...
- #2969
- add `ModelBindingMessages` for configuration and `IBindingMetadataProvider` overrides
- use `interface` to avoid `new` oddities when adding a setter to an `abstract` property
- add `IModelBindingMessages` to `ModelMetadata` for use in rest of the product code
- plumb the various bits through the system
- add integration tests using a custom `IBindingMetadataProvider`s to override messages
nits:
- remove unused resources
- use `AttemptedValue` and not `model` in `SimpleTypeModelBinder`
2015-09-28 15:50:21 -07:00
0d6edf240a
Move ModelExplorer to ViewFeatures
2015-09-28 14:14:40 -07:00
ec18b35123
Add FormatterCollection<T>
...
#2945
2015-09-28 13:23:19 -07:00
67b43b4cfe
Workaround Mono bugs to fix travis
...
This change works around two mono issues that are blocking travis. I'd
like to have tests skip instead, but unfortunately that would mean not
running any validation tests on mono so this seems better.
- RuntimeHelpers.GetHashCode will sometimes crash the runtime
- PropertyHelper sometimes returns throws null-ref
2015-09-28 12:58:45 -07:00
18c80d156c
Replace NotNullAttribute with thrown exceptions
2015-09-26 23:48:43 -07:00
eff10cdd66
Move `ModelStateDictionaryExtensions` into `Microsoft.AspNet.Mvc.ModelBinding` namespace
...
- missed the inconsistency when reviewing
- kept class in ViewFeatures assembly because it depends on `ExpressionHelper`
nit: wrap some long lines
2015-09-26 18:15:04 -07:00
b28debf442
Generic ModelStateDictionary add and remove extensions
...
- Added generic add model error and remove extensions for
ModelStateDictionary, to avoid using hard coded strings then specifying
model state dictionary keys.
- Added generic removal all extension for ModelStateDictionary, to
support removing all the model state keys for given expression.
aspnet/Mvc#3164
2015-09-26 18:14:58 -07:00
6a0a24481a
Asynchronously flush the HttpResponseStreamWriter after a view has been rendered.
...
This solves a perf issue for views which produce content that is smaller
than the buffer size of HttpResponseStreamWriter. In this case, the writer
ends up synchronously writing to the Response as part of Dispose which
affects perf.
2015-09-25 21:07:15 -07:00
8a502dbe5d
Rewrite of validation
2015-09-25 16:56:42 -07:00
0889b18f95
Add localizers to validation attributes
2015-09-25 16:13:21 -07:00
49acfd562e
Adds common interfaces around Models (Implements #3158 )
2015-09-25 11:10:59 -07:00
9c81b95d1b
Renamed Controller.Context to Controller.HttpContext
...
- #3165
2015-09-25 11:01:30 -07:00
5a80435534
API Review - Move ModelBindingHelper
2015-09-25 09:59:56 -07:00
ed509f65a2
fix #2747 : Fix Mvc localization test once dnx support reading resources
2015-09-24 12:53:20 -07:00
1833e06984
TModel substitution in Razor pages has broken intellisense
...
Fixes #3185
2015-09-23 17:47:52 -07:00
ff4100e292
Generate an expression to create line mappings for ModelChunk directives
2015-09-23 16:14:29 -07:00
89f58aa49f
Allow @model specified in a page work with @inherits directive in
...
_ViewImports
Fixes #3144
2015-09-23 12:10:10 -07:00
80add92de8
React to removal of TagHelperContent.ToString()
...
Avoid calling ToString on a TagHelperContent.
Also react to new properties on TagHelperCodeGenerationContext
2015-09-23 11:09:27 -07:00
d8d0a1ab89
Rename `ModelMetadata.IsCollectionType` and add "real" `ModelMetadata.IsCollectionType`
...
- #3022
- existing `IsCollectionType` -> `IsEnumerableType`
- use new `IsCollectionType` in a few places
2015-09-22 19:05:40 -07:00
1574637a6a
Reacting to Microsoft.AspNet.Cors version change
2015-09-22 11:26:04 -07:00
9eb2c5b810
Reacting to IExpirationTrigger -> IChangeToken rename
2015-09-22 08:14:34 -07:00
b544aabfdb
Fix #3111 - Don't trounce content-type in VCR
...
This change makes ViewComponentResult respect an existing Content-Type
setting on the HttpResponse. Code is very similar to the code in
ViewExector, and includes the same quirks.
2015-09-21 23:20:20 -07:00
a318c4599a
API Review - Split up .Actions
...
Abstractions - Core MVC extensibility
Controllers - MVC implementations of .Abstractions and supporting
contracts
Infrastructure - General purpose support APIs. Metadata APIs that don't
fit clearly with a feature or with .Abstraction
2015-09-21 21:54:02 -07:00
00b6e71e31
Changes per NotNull PR comments
2015-09-21 17:22:27 -07:00
498d209949
Remove chaining from HashCodeCombiner.
...
Reacting to https://github.com/aspnet/Common/issues/40
2015-09-21 17:11:08 -07:00
f045c6792b
Allow _ViewImports to remove default inherited tag helpers.
...
Additionally simplifying the contract for
ChunkInheritaceUtility\IChunkMerger so we don't have to understand the
order in which CodeTrees appear.
2015-09-21 14:53:24 -07:00
b95dcd5f1c
Fix #3102 - Add an AddMvcOptions to builders
...
This makes it easier/possible for any third party code that extends
IMvcBuilder to set options.
2015-09-21 12:54:59 -07:00
f4c5e31ec1
Remove JsonPatch from MVC
...
JsonPatch is moving to https://github.com/aspnet/JsonPatch
2015-09-21 11:14:40 -07:00
66a04c2fd6
Replacing NotNullAttribute with thrown exceptions
2015-09-21 10:26:14 -07:00
00c436b0e1
[Perf] Remove use of [FromServices] on Controller
...
[FromServices] requires modelbinding to run for each of these four
properties, which allocates a lot, and ultimately just ends up calling
GetRequiredService in the end.
Also, retrieving these services is now lazy, which should be very
beneficial as few of them aren't used often.
2015-09-21 08:53:12 -07:00
9badd9386e
API-Review Strongly-typed collections for a few options types.
...
We don't want these extensions methods defined in a wierd namespace, it's
straightforward and future-proof to just make these strongly-typed
collections.
2015-09-20 22:11:22 -07:00
10ec9144ca
Remove extra registration of TelemetrySource
...
This is now provided by hosting.
2015-09-20 21:16:01 -07:00
4d55a6e62d
API review - remove DefaultOrder
...
No change in behavior intended, removing this from our public API.
2015-09-20 21:11:57 -07:00
ccb5ead450
Api-Review - put uri complexity in CreatedResult
2015-09-20 19:44:32 -07:00
42017faa21
Add `InputFormatterResult` and `InputFormatterContext.ModelName`
...
- #2722
- make communication of errors from formatters to `BodyModelBinder` explicit
- `JsonInputFormatter` now adds errors to `ModelStateDictionary` with correct key
- change `InputFormatter.SelectCharacterEncoding()` to add an error and return `null` when it fails
- one less `Exception` case and removes some duplicate code
nits:
- improve some doc comments (more `<inheritdoc/>`, `<paramref/>` and `<see/>`)
- add another two `BodyValidationIntegrationTests` tests
2015-09-19 21:36:38 -07:00
0fb09908d3
[Build break] Correct doc comment references to match current namespaces
...
- local command line builds fail consistently during `xml-docs-test`
- bit buried on the CI machine but repo is not testing successfully there
2015-09-17 23:12:26 -07:00
7b433820b1
Changes per PR comments
...
Reformatting parameter identation
2015-09-17 15:42:58 -07:00
a68d9e4cb1
Replace NotNullAttribute with thrown exceptions
2015-09-17 11:56:44 -07:00
538cd9c191
Move less-commonly used types out of .Rendering
2015-09-16 23:52:29 -07:00
046cb976b3
Move ActionResult classes back to main namespace
2015-09-16 21:42:31 -07:00
1c4614c219
Avoid allocating strings in DefaultViewLocationCache
...
Fixes #3135
2015-09-16 17:28:40 -07:00
00075520b4
Razor CompilerCache allocates too much in NormalizePath
...
Fixes #3035
2015-09-16 16:55:51 -07:00
9a15b54d30
Flow IHtmlContent through to the razor buffer
2015-09-16 16:17:40 -07:00
a707311d9e
Fix #3087 - use IHtmlContentBuilder in TagBuilder
...
Improves authoring experience when using TagBuilder by taking advantage of
IHtmlContentBuilder an its extension methods.
TagBuilder.InnerHtml is no longer settable.
2015-09-16 10:03:03 -07:00
887ab64d75
Throw an exception if layouts have circular references.
...
Fixes #3100
2015-09-14 12:57:06 -07:00
29a25b2ed1
No need to add an instance in `WebApiCompatShimMvcBuilderExtensions`
...
- DI has changed since this class was written
2015-09-13 22:25:04 -07:00
93735a5be6
React to Razor `TargetElementAttribute` rename.
...
aspnet/Razor#516
2015-09-13 19:14:30 -07:00
94388a8804
React to BufferedHtmlContent changes
2015-09-13 13:51:53 -07:00
85bb33a62a
Fixing formatting in RoslynCompilationService
2015-09-11 12:22:34 -07:00
345021d822
Set RazorError code to null
2015-09-11 12:08:23 -07:00
bc10a17107
Reacting to DNX changes
2015-09-10 17:51:59 -07:00
0350f6ed48
Adding NeutralResourcesLanguageAttribute to Mvc assemblies
2015-09-10 16:17:42 -07:00
87c15bb6dc
Adds/updates some docs for the FromServicesAttribute with examples
2015-09-10 08:03:50 -07:00
2e32ffc004
Use PrecompilationTagHelperTypeResolver to locate TagHelpers during
...
precompilation.
Fixes #2298
2015-09-09 18:25:11 -07:00
894574d04e
Implement Replace Move and Copy for dynamic objects
2015-09-08 22:09:44 -07:00
67eb16dc67
Fixing RazorViewEngine formatting
2015-09-08 15:52:53 -07:00
1c8f22058c
Make RazorViewEngine.GetNormalizedRouteValue public
...
Fixes #3108
2015-09-08 15:41:44 -07:00
a6aaef0d63
Optimize async code in model binders
...
Optimize the 'no-op' path for our model binders to return a cached task
where possible without going async.
2015-09-08 09:42:34 -07:00
ab08e27a4b
Simplify CompositeModelBinder
...
Also adds a diagnostic ToString to ModelBindingResult to make testing
easier.
2015-09-08 08:47:21 -07:00
382c9ab86a
Test Cleanup: Fix Assert.NotNulls with ModelBindingResult
2015-09-07 17:15:31 -07:00
465b4ce0df
Use TelemetrySource
2015-09-06 20:23:05 -07:00
5afadf6998
Fix documentation error
2015-09-03 17:11:47 -07:00
076ce6a8a1
Make ModelBindingResult a struct.
2015-09-03 12:52:50 -07:00
e4fe31a602
Nuke extra curly
2015-09-02 21:21:41 -07:00
a786eaa9e4
Resolve merge issue
2015-09-02 21:10:43 -07:00
76dceaef76
Fix build breaks
2015-09-02 16:22:02 -07:00
bc2bce8bd6
Curly's are important
2015-09-02 16:14:25 -07:00
1d865afe7f
React to Razor error length change.
...
aspnet/Razor#386
2015-09-02 15:38:18 -07:00
8e57fa5350
React to options
2015-09-02 15:07:16 -07:00
3ebdcc5f6f
React to options changes
2015-09-02 14:07:06 -07:00
dd94d54e1d
[ Fixes #2929 ] Moving IsLocalUrl implementation to UrlHelper
2015-09-02 09:30:26 -07:00
a0e0df87de
[ Fixes #3016 ] Disable response buffering in places where the content is already built/available
2015-09-02 09:22:36 -07:00
7a3f34089f
fix build break due to dnx resource change
2015-09-01 23:31:09 -07:00
229724c4ea
Reorganize MVC namespaces
2015-09-01 22:28:33 -07:00
a2e53e8d1a
Explicitly check if URI is file when checking for an absolute URI
2015-09-01 16:33:00 -07:00
55fc7ded36
Don't invoke async state machine unnecessarily
...
Return task rather than awaiting when no extra work needs to be done
after await
2015-08-31 17:48:57 -07:00
98b3f055e1
Change ModelBinding to use a single pass
2015-08-31 11:58:53 -07:00
Ryan Nowak
Pranav K
Anthony van der Hoorn
Kiran Challa
Ajay Bhargav Baaskaran
Gerardo Melendrez
Doug Bunting
Stefán Jökull Sigurðarson
Søren Kruse
Muchiachio
Kirthi Krishnamraju
Nero Sule
N. Taylor Mullen
Shannon Deminick
KevinDockx
Hao Kung
Sebastien Ros
Daniel Lo Nigro
Ben Adams