huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Avoid state machine and allocation for 0-parameters

This commit is contained in:
Ryan Nowak 2015-10-03 23:48:14 -07:00
parent 04d72d8894
commit 1ed22e5939
1 changed files with 24 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/Microsoft.AspNet.Mvc.Core/Controllers/DefaultControllerActionArgumentBinder.cs
View File

@ -35,7 +35,7 @@ namespace Microsoft.AspNet.Mvc.Controllers
_validator = validator;
}
public async Task<IDictionary<string, object>> BindActionArgumentsAsync(
public Task<IDictionary<string, object>> BindActionArgumentsAsync(
ActionContext actionContext,
ActionBindingContext actionBindingContext,
object controller)
@ -64,6 +64,29 @@ namespace Microsoft.AspNet.Mvc.Controllers
nameof(actionContext));
}
// Perf: Avoid allocating async state machines when we know there's nothing to bind.
if (actionDescriptor.BoundProperties.Count == 0 &&
actionDescriptor.Parameters.Count == 0)
{
return Task.FromResult<IDictionary<string, object>>(
new Dictionary<string, object>(StringComparer.Ordinal));
}
else
{
return BindActionArgumentsCoreAsync(
actionContext,
actionBindingContext,
controller,
actionDescriptor);
}
}
private async Task<IDictionary<string, object>> BindActionArgumentsCoreAsync(
ActionContext actionContext,
ActionBindingContext actionBindingContext,
object controller,
ControllerActionDescriptor actionDescriptor)
{
var operationBindingContext = GetOperationBindingContext(actionContext, actionBindingContext);
var controllerProperties = new Dictionary<string, object>(StringComparer.Ordinal);
await PopulateArgumentsAsync(