Commit Graph

20835 Commits

Author SHA1 Message Date
Pranav K da3f97b0ad
Fix client validation for record types (#26159)
* Fix client validation for record types

Server validation for record types uses metadata from parameters
when validating record type properties. However client validation
does not use the parameter to harvest client validation attributes.

In the absence of this change, validation on parameters would require server
round trips which is unexcepted and not at parity with validation applied
to properties on regular classes or record types.

Validation experience with record types is subpar and requires server
round trips.

No. This feature is new to 5.0.

Low. The change is isolated to record types and does not affect other code paths. We have
unit and functional test coverage to verify this change.

* Correctly dispose app after use
2020-09-22 22:02:49 -07:00
William Godbe c34d1dceac
Include all .xml files in targeting pack (#26147)
* Include all .xml files in targeting pack

* Better syntax

* Remove distinct
2020-09-22 12:54:28 -07:00
Steve Sanderson 7140f7cae7
Virtualize component: method to trigger data refresh (#26177)
* E2E test cases for Virtualize data refresh

* Expose public RefreshDataAsync API

* Optimize: don't instantiate CancellationTokenSource when it won't be used

* For in-memory data, refresh automatically on each render cycle

* Fix typo
2020-09-22 11:52:16 -07:00
Safia Abdalla 93f73c7764
Add support for debugging lazy-loaded assemblies (#25943)
* Add support for debugging lazy-loaded assemblies

* Address feedback from peer review

* Increase wait for output on tests
2020-09-22 08:23:39 -07:00
Sayed Ibrahim Hashimi d97ef5ccd4
Updated icons for projects that appear in VS with icons that have the (#25974)
* Updated icons for projects that appear in VS with icons that have the
language adornment.
This PR should fix #25973.

* updating icons for asp.net core templates in vs
2020-09-21 13:04:31 -07:00
Justin Kotalik 02d81add81
Increase Http2Timeout (#26075) 2020-09-21 10:55:08 -07:00
Hao Kung 6bfffda734
Remove ComponentsWebAssembly shared layout (#26078) 2020-09-19 11:12:38 -07:00
Pranav K bf91253cd3
Increase more SignalR Java client test timeouts (#26036)
Co-authored-by: Stephen Halter <halter73@gmail.com>
2020-09-18 17:00:43 -07:00
Pranav K 140f177d9e
Converge implementations of AwaitableProcess and ProcessEx (#26069)
* Converge implementations of AwaitableProcess and ProcessEx

* dotnet-watch tests are running in to the same issue as GRPC tests (https://github.com/dotnet/aspnetcore/pull/20341/files).
This change carries over some of the patterns from the other type to remedy this issue.

* Revive dotnet-watch tests on OSX

* Remove build artifacts that were accidentally commited to source.
2020-09-18 16:32:06 -07:00
Pranav K 611ee61e0e
Quarantine tests (#26062) 2020-09-18 13:08:30 -07:00
dotnet-maestro[bot] 7e0e801bb4
[release/5.0-rc2] Update dependencies from dotnet/arcade dotnet/efcore (#26058)
[release/5.0-rc2] Update dependencies from dotnet/arcade dotnet/efcore


 - Update installers task location
2020-09-18 19:58:16 +00:00
Matt Mitchell b1b3d5474f
Enable PostBuildSign flag and include signing information in the manifest (#26033)
This change is prep for post build signing. When PostBuildSign=true, signing is not performed during the build. Instead, pass the top-level artifacts that are signable to PushToAzureDevOpsArtifacts (via Publish.proj).
Also fix up ArtifactsDir. As far as I can tell, it's been fixed up in Arcade to always include the trailing \, and Publish.proj should no longer be messed up.
2020-09-18 11:07:42 -07:00
Doug Bunting b592cf6610
Place ref/ layout where SDK can find it (#25987)
- correct Helix test failures with stable versions, where SDK's packs aren't enough

E.g. from https://dev.azure.com/dnceng/internal/_build/results?buildId=813814
``` text
...\.dotnet\sdk\5.0.100-rc.1.20379.10\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(318,5): error MSB4018: The "ResolveTargetingPackAssets" task failed unexpectedly. [...\src\ProjectTemplates\test\bin\Release\net5.0\TestTemplates\AspNet.m0yq3xrporu\AspNet.m0yq3xrporu.csproj]
...\.dotnet\sdk\5.0.100-rc.1.20379.10\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(318,5): error MSB4018: System.IO.DirectoryNotFoundException: Could not find a part of the path '...\.dotnet\packs\Microsoft.AspNetCore.App.Ref\5.0.0\data\FrameworkList.xml'. [...\src\ProjectTemplates\test\bin\Release\net5.0\TestTemplates\AspNet.m0yq3xrporu\AspNet.m0yq3xrporu.csproj]
```
2020-09-17 21:03:07 -07:00
Doug Bunting 6418c8f78a
Pin PackageOverrides.txt Extensions versions at Major.Minor.0 in servicing (#25986)
- set the package version of Extensions assemblies using NETCore.App version
  - ignore Microsoft.Extensions.Internal.Transport package version
    - transport package has a non-stable version and isn't shipped
    - just got lucky this worked before versions stabilize
- update test expectations when checking PackageOverrides.txt
  - use NuGet.Versioning to make this easier
2020-09-17 21:02:46 -07:00
Brennan 3ee23fb771
Refactor transient state in Java client (#24219)
* Refactor transient state in Java client

* some fb

* fix nullref

* fixup rebase

* fb

* apply some fb

* fix flaky

* lock

* check previous state
2020-09-17 17:59:27 -07:00
Brennan 899deacb22
Fix SignalR+WebSockets on WASM (#25922)
* Fix SignalR+WebSockets on WASM

* fb

* move stuff

* select
2020-09-17 11:30:31 -07:00
Pranav K 2921f5514a
dotnet-watch: continue printing output to console after the app is ready (#25984)
dotnet-watch redirects standard out to detect when the app is launched and
prints these redirected messages to the console. Unfortunately once the app
is launched, redirected messages are no longer printed. This wasn't caught earlier
since ASP.NET Core is very quiet by default.

ASP.NET Core apps launched via dotnet watch do not print output to the console.

Yes. This was introduced as part of changes to dotnet-watch to launch a browser in 5.0-preview8.

Low.
2020-09-16 18:53:59 -07:00
Steve Sanderson 8c23b53bef
Make timezone and ICU data available offline for PWA (#25954) 2020-09-16 16:49:09 -07:00
dotnet-maestro[bot] 9675fdb455
[release/5.0-rc2] Update dependencies from dotnet/arcade (#25963)
[release/5.0-rc2] Update dependencies from dotnet/arcade


 - Update create light/light command package drop task

 - Create output directory
2020-09-16 22:08:01 +00:00
Brennan ce76ae75f6
Fix Java packaging (#25838)
* Fix Java packaging

* fix flaky test
2020-09-15 10:20:43 -07:00
John Luo d14e273015
[5.0.0-rc2] Backport Fix chrome/selenium tests (#25330) (#25840)
* Fix chrome/selenium tests (#25330)

* Revert "Disable failing/hanging tests due to Chrome/Selenium issue (#25323)"

This reverts commit 332f1504128a63431cb67830703922cdeefee525.

* Update Selenium to latest

* Update API

* Try specifying a version

* Update Selenium to 4.0.0-beta5

* Disable browser log tests

* Fix components e2e tests and disable blazor standalone template test

* Disable tests using browser log

* Disable template test

* Avoid using .NET formatted strings in tests

* Annotate BasicTestApp suggesting that it needs the all globalization data

* Culture specific formatting relies on the ICU data carried by the OS. This
causes issues in our tests if WebAssembly carries a different set than the OS. Instead
updating these tests to use hardcoded strings.

* Additionally fixing an issue where some projects in the solution were using tasks from
the .dotnet SDK rather than the local copy of the SDK. This was causing issues building locally.

Co-authored-by: Pranav K <prkrishn@hotmail.com>
2020-09-14 18:43:42 -07:00
Kevin Pilch e3a52ee3de
Merge pull request #25881 from dotnet-maestro-bot/merge/release/5.0-to-release/5.0-rc2
[automated] Merge branch 'release/5.0' => 'release/5.0-rc2'
2020-09-14 15:24:14 -07:00
Pranav K a6f667bbb3
Add SkipAnalyzers=true to component declaration compilation (#25736)
* Update to latest SDK

* React to platform compatibility analyzer warnings
* React to new warnings
* Add platform compatibility attributes

* Add SkipAnalyzers=true to component declaration compilation
Fixes https://github.com/dotnet/aspnetcore/issues/25365

* Update eng/Version.Details.xml

* Update Versions.props

* Update Version.Details.xml

* Update Versions.props

* Update Version.Details.xml
2020-09-14 12:41:37 -07:00
Martin Costello a0ede85a61
Fix MSB4109 (#25880)
Fix MSB4109 error when the Microsoft.Extensions.ApiDescription.Server NuGet package is installed.
2020-09-14 12:07:15 -07:00
Doug Bunting 6c29f44a0b
Reduce references to Microsoft.AspNetCore.App.Runtime.csproj (#25836)
- dotnet-watch builds against runtime in the SDK
- other projects build after runtime project due to Ref.csproj reference
  - but, when the targeting packs aren't building, there's no reason to use Ref.csproj
- followup on 76fbd1a283 and 84962660a3, reducing parallelism in build
2020-09-14 11:34:07 -07:00
Steve Sanderson ccbc46c076
Fix RCL template to have correct filename for scoped CSS (#25870) 2020-09-14 09:13:49 -07:00
John Luo 472e8297a7
Update identity web templates (#25834)
* Update identity web templates

* Do not generate scopeRequiredByApi if not needed
2020-09-14 07:58:03 -07:00
Doug Bunting e3b632894d
Fix Helix testing issues with stable versions and local builds (#25865)
- include all shipping packages in Helix payloads that need runtime
  - remove hard-coded `-ci` that broke Helix tests with stable versions or local builds
  - for local builds, do not assume `$(Configuration)` is Release
- support `$(HelixTargetQueues)` property used in RunHelix.ps1
  - lost somewhere along the lines; script ran full matrix

nits:
- clean up redundant addition of runtime and ref/ packages
  - `@(HelixContent)` additions in `_CreateHelixWorkItem` target are ignored
- mention '+' separation of `-HelixQueues` argument to RunHelix.ps1
- allow `$(IsUnitTestProject)` override in case we need it in the future
2020-09-13 21:45:23 -07:00
Pranav K ab5dfe5374
Allow dotnet-watch to look for changes to .razor.css files (#25792)
Fixes https://github.com/dotnet/aspnetcore/issues/25483
2020-09-13 14:46:47 -07:00
Doug Bunting b760d35b54
Support override of PlatformManifest.txt content in servicing (#25849)
- copied from release/3.1; not sure why this wasn't merged forward
- doing now ensures we don't forget if we need to service targeting packs
2020-09-13 11:40:09 -07:00
Pranav K 99496b41a0
Nullability feedback for public types in Components (#25821)
* EventCallback.InvokeAsync can pass a null value
* Remove unused BindFormatterWithFormat
2020-09-13 10:01:21 -07:00
Javier Calvarro Nelson b1e1aabc9d [Mvc] Fix global state in controller and action endpoint data sources.
* Create data sources "per router" instance.
* Make a global shared order sequence "per router" for conventional and
  controller and page routes.
* Create DynamicControllerEndpointSelector and DynamicPageEndpointSelector
  instances per data source.
2020-09-12 10:03:32 -07:00
Javier Calvarro Nelson a17842a2e4 [Mvc] Add support for order in dynamic controller routes (#25073)
* Order defaults to 1 same as conventional routes
* An incremental order is applied to dynamic routes as they are defined.
2020-09-12 10:03:32 -07:00
James Newton-King 340ee72715
Update gRPC version in template to 2.32.0-pre1 (#25587)
* Update gRPC version in template to 2.32.0-pre1

* Log server timeout detail

* Only run interop tests on windows queues

Co-authored-by: John Luo <johluo@microsoft.com>
2020-09-11 20:23:16 -07:00
Doug Bunting 326507bb01
Correct `$(SharedFxVersion)` and `$(TargetingPackVersion)` values (#25790)
* Correct `$(SharedFxVersion)` and `$(TargetingPackVersion)` values
- Ensure `$(SharedFxVersion)` doesn't change in `$(NoSemVer20)` projects
- Ignore current project's `$(VersionSuffix)` in `$(TargetingPackVersion)`
    - Never assume `$(AspNetCoreBaselineVersion)` matches released targeting pack
- Stabilize both versions correctly
- Use these properties more widely
    - Remove other mechanisms to get the same values
    - Reduce use of the `_GetPackageVersionInfo` target
    - Reduce use of `$(SharedFxVersion)` for the targeting pack

nits:
- Correct comments about old RTMVersions.csproj project
- Fix or remove a few other comments

* Do not pass package filenames on Helix command Lines
- remove parsing of these command-line arguments from `RuntestOptions`
  - instead craft the names using passed `$(SharedFxVersion)`
- restore `$(DotNetRuntimeSourceFeedKey)` on Helix command line
  - lost somewhere along the line
- correct argument count in runtests.sh
  - treated 11th argument as both Helix timeout and feed credential
  - count was messed up somewhere alone the line

nits:
- update C# syntax in `RuntestOptions` e.g. remove unused `public` setters
- sort and group properties and their assignments
2020-09-11 19:17:28 -07:00
Chris Ross b5515a8dac IIS: Identify if a request has a body (#25381) 2020-09-11 17:43:36 -07:00
Pranav K 004cd1a9d9
PR feedback for platform compatibility update (#25815)
* PR feedback for platform compatibility update

Follow up to https://github.com/dotnet/aspnetcore/pull/25421

* Add SupportedOSPlatform attributes to a few more DataProtection API
* Update the SDK to rc2
* Clean up warning suppression in CertificateManager
* React to nit feedbacks

Fixes https://github.com/dotnet/aspnetcore/issues/25781

* Apply suggestions from code review
2020-09-11 14:32:02 -07:00
Stephen Halter 3932156a95
Improve Http1ContentLengthMessageBody's reset logic (#25799) 2020-09-11 13:57:23 -07:00
Brennan 9eb9de6c8c
[Java] Catch errors from user callbacks (#25513)
* [Java] Catch errors from user callbacks

* test logger

* rebase

* fb
2020-09-11 11:44:00 -07:00
Chris Ross 4383118ef8
IIS: Identify if a request has a body (#25381) 2020-09-11 11:40:25 -07:00
Brennan 83e31342a1
[Kestrel] Deflake app abort test (#25484)
* [Kestrel] Deflake app abort test

* better

* fb
2020-09-11 10:53:45 -07:00
William Godbe f7a76173e4
Re-enable Helix tests for signalR java client (#25783)
* Re-enable Helix tests for signalR java client

* Change path to test results
2020-09-11 10:26:49 -07:00
William Godbe 77be06a894
Support primitive type/classes in HubConnection.on() (#25773)
* Support primitive type/classes in HubConnection.on()

* Small refactor

* Spacing
2020-09-11 10:11:29 -07:00
William Godbe 84962660a3
Strip duplicates from BuiltProjectOutputGroupOutput (#25785) 2020-09-11 10:11:10 -07:00
Brennan c32089a5e2
Add SignalR Client on WASM smoke test (#25526)
* Add SignalR Client on WASM smoke test

* Move test into BasicTestApp

Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
2020-09-11 09:23:08 -07:00
Brennan 2ab6436cdd
Set ShutdownTimeout in Kestrel tests (#25743) 2020-09-11 09:21:18 -07:00
Brennan a7d129cc97
Send CloseMessage in more cases (#25693)
* Send CloseMessage in more cases

* fb
2020-09-11 09:21:02 -07:00
Chris Ross 11b85eb7e2
Add Windows.10.Amd64.Server20H1.Open helix queue (#25627) 2020-09-10 19:36:42 -07:00
Sayed Ibrahim Hashimi 118d6b2986
Updating titles in project templates because in Visual Studio the (#25630)
templates will be showing the templates directly in the New Project
Dialog instead in the One ASP.NET dialog.

In this PR I have updated the English titles. For localized strings we
will need to get those from the localization team. I believe we are not
setup for that to be automated here.

I think we should merge the English strings because they are the most
used, and for other locales we will show the old localized names for
now. If it's difficult to get those localized, I can work with @phenning
to see if we can localize those files this time.
2020-09-10 18:46:32 -07:00
Brennan 970d0f5d00
[SignalR] Copy cookies from negotiate to WebSockets (#24572) 2020-09-10 18:22:14 -07:00
Stephen Halter 327d55d01c
Prevent ODE when response body isn't reset (#25779) 2020-09-10 18:14:08 -07:00
Pranav K 5aa4a7cd41
Avoid using PATH to find dotnet.exe in RazorSDK tasks (#25750)
This pattern is pretty identical to what we have in other SDKs. It allows
using the SDK when dotnet isn't in the path such as the https://github.com/dotnet/aspnetcore/issues/25746.

Fixes #14432
2020-09-10 16:30:55 -07:00
Pranav K 18d261b20c
Use T? for unconstrained nullable types (#25772) 2020-09-10 15:15:11 -07:00
Pranav K 36f8642f0b
Use T? for unconstrained nullable types (#25261)
* Use T? for unconstrained nullable types

* Apply suggestions from code review
2020-09-10 15:14:30 -07:00
Pranav K 690c717314
Update to latest SDK (#25421)
* React to platform compatibility analyzer warnings
* React to new warnings
* Add platform compatibility attributes
2020-09-10 15:12:17 -07:00
Zachary Becknell fa2a5076e4
Add option to specify hostname in BrowserRefreshServer (#25572)
* Add option to specify hostName for refresh server

* Update env variable name per suggestion

Co-authored-by: Pranav K <prkrishn@hotmail.com>

Co-authored-by: Pranav K <prkrishn@hotmail.com>
2020-09-10 15:10:47 -07:00
Ken Egozi cc0665cb6f
TypeReference usage clarification (#25719)
This change makes TypeReference usage a little bit easier

- Marking it abstract make it so that usages cannot "forget" subclassing (or omitting the { } part). Previously the error message would be confusing as the supertype would be Object.
- Removing the instanceof check and relying on exception since instantiating TypeReference without a type parameter (new TypeReference() ) *is* exceptional as it goes against the intention of this class altogether.
- Added some clarification to the javadoc regarding intended usage, and a link to prior art for further reading.
2020-09-10 15:02:21 -07:00
Kevin Pilch 3692e122ff
Add Public API baselines for Razor (#25637) 2020-09-10 13:27:09 -07:00
Pranav K 09160a779f
Use JsonSerializerDefaults instead of specifying individual options (#25747)
This lets MVC use the defaults as specified by System.Text.Json. Right now, these defaults are identical
to the two properties that were removed. However this allows MVC to pick up new S.T.J defaults in 6.0 including when
users attempt to use a 6.0 versioned package with 5.0
2020-09-10 11:54:00 -07:00
Kevin Pilch 848f42df8e
Add public API baselines for SiteExtensions, Testing, WebEncoders (#25654) 2020-09-10 11:45:01 -07:00
Kevin Pilch 158401f361
Add public API baselines to SignalR (#25653) 2020-09-10 11:44:04 -07:00
Juan Hoyos dda1d33f7b
Enable ARM64 installers build. (#25579)
Changes WiX toolset used to 3.14 to support ARM64
Generates targeting pack from the x86/x64 leg, as it gets produced using a zip that gets generated there.
The ARM64 leg now produces all the necessary msi's, exe, and wixlib needed for the installer to generate a bundle.
2020-09-10 10:59:37 -07:00
Javier Calvarro Nelson 31fcc8bd26
Update error page (#25706) 2020-09-10 10:20:19 -07:00
Javier Calvarro Nelson 0637599517
Update DfaMatcherBuilder to use the correct behavior (#25616) 2020-09-10 10:18:32 -07:00
Pranav K 2228c98b88
Use ICU sharding (#25521) 2020-09-10 10:17:02 -07:00
Kevin Pilch 6828192780
Add public API baselines for Servers (#25652) 2020-09-09 21:07:55 -07:00
Kevin Pilch 14a3862f5f
Add Public API baselines for Security (#25651) 2020-09-09 21:07:15 -07:00
John Luo 035221d731
Add cache for retrieved RBAC claims (#25698) 2020-09-09 14:24:48 -07:00
William Godbe 76fbd1a283
Strip duplicate files from SharedFx input to Nuget Pack (#25733) 2020-09-09 14:15:17 -07:00
Mackinnon Buck 8f461884c9
Update JSCallResultTypeHelper.cs (#25628)
* Update JSCallResultTypeHelper.cs and PublicAPI.Unshipped.txt

* CR feedback.

* Removed exception message
2020-09-09 13:33:47 -07:00
Mackinnon Buck 43ef580773
Fixed content type issue (#25702) 2020-09-09 13:30:13 -07:00
Stephen Halter b3f4a32d23
Increase SignalR Java client test timeouts to 30 seconds (#25639) 2020-09-09 11:26:51 -07:00
Steve Sanderson ecc2ba16b8
Accessibility fixes (#25678)
* Fix header tab ordering issues. Fixes 1163117

* Ensure text can be zoomed to 200% without switching to mobile layout. Fixes 1163184.

* Ensure "Log out" link can show focus state. Fixes 1162890

* Use screen reader-friendly link text. Fixes 1163642

* Update template test
2020-09-09 11:08:10 -07:00
Artak 0d548f302b
Enable PlatformCompatibilityAnalyzer for RCL projects (#25636) 2020-09-09 09:57:42 -07:00
Steve Sanderson c5bcd68853
Fix wasm caching on localhost and various E2E test issues (#25689)
* Fix caching of WASM resources on localhost

* Fix test server startup

* Add missing server variant of VirtualizationTest

* Make test namespaces consistent

* Fix VirtualizationTest cases

* Update BootResourceCachingTest
2020-09-09 09:54:45 -07:00
Pranav K 646925127b
Move ProtectedBrowserStorage to the shared fx (#25557)
* Move ProtectedBrowserStorage to the shared fx

* Fixups

* Fixup
2020-09-09 09:54:14 -07:00
Steve Sanderson 9f5276d17a
Update RCL template to use 5.0 features (#25613)
* Update JS interop to use auto-loaded ES6 module

* Test update

* Make it lazy for compatibility with prerendering

* Update comment

* Code style: go back to .AsTask - it's probably easier to read
2020-09-09 08:25:26 -07:00
dotnet-maestro[bot] 95763af89a
[release/5.0-rc2] Update dependencies from dotnet/arcade dotnet/runtime dotnet/efcore (#25555)
[release/5.0-rc2] Update dependencies from dotnet/arcade dotnet/runtime dotnet/efcore
- Updates:
  - System.ComponentModel.Annotations: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Diagnostics.DiagnosticSource: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Diagnostics.EventLog: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.DirectoryServices.Protocols: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Logging.Abstractions: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Logging.Configuration: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Logging.Console: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Logging.Debug: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Logging.EventLog: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Logging.EventSource: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Logging.TraceSource: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Options: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Options.ConfigurationExtensions: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Options.DataAnnotations: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Primitives: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Logging: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Internal.Transport: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Http: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Hosting.Abstractions: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Caching.Abstractions: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Caching.Memory: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Configuration: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Configuration.Abstractions: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Configuration.Binder: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Configuration.CommandLine: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Configuration.EnvironmentVariables: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Configuration.FileExtensions: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Configuration.Ini: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Configuration.UserSecrets: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Configuration.Xml: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.DependencyInjection: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.DependencyInjection.Abstractions: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.DependencyModel: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.FileProviders.Abstractions: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.FileProviders.Composite: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.FileProviders.Physical: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.FileSystemGlobbing: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.HostFactoryResolver.Sources: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Hosting: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Configuration.Json: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.NETCore.App.Runtime.win-x64: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.NETCore.BrowserDebugHost.Transport: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.NETCore.Platforms: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Win32.Registry: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Win32.SystemEvents: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.NETCore.App.Internal: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.NETCore.App.Ref: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Drawing.Common: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Threading.Channels: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Windows.Extensions: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Text.Json: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Text.Encodings.Web: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.ServiceProcess.ServiceController: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.IO.Pipelines: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Net.Http.Json: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Net.Http.WinHttpHandler: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Net.WebSockets.WebSocketProtocol: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Reflection.Metadata: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Runtime.CompilerServices.Unsafe: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Security.AccessControl: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Security.Cryptography.Cng: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Security.Cryptography.Pkcs: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Security.Cryptography.Xml: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Security.Permissions: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Security.Principal.Windows: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Resources.Extensions: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25

- Updates:
  - Microsoft.EntityFrameworkCore.Tools: from 5.0.0-rc.2.20452.4 to 5.0.0-rc.2.20458.4
  - Microsoft.EntityFrameworkCore.SqlServer: from 5.0.0-rc.2.20452.4 to 5.0.0-rc.2.20458.4
  - dotnet-ef: from 5.0.0-rc.2.20452.4 to 5.0.0-rc.2.20458.4
  - Microsoft.EntityFrameworkCore: from 5.0.0-rc.2.20452.4 to 5.0.0-rc.2.20458.4
  - Microsoft.EntityFrameworkCore.Design: from 5.0.0-rc.2.20452.4 to 5.0.0-rc.2.20458.4
  - Microsoft.EntityFrameworkCore.Relational: from 5.0.0-rc.2.20452.4 to 5.0.0-rc.2.20458.4
  - Microsoft.EntityFrameworkCore.Sqlite: from 5.0.0-rc.2.20452.4 to 5.0.0-rc.2.20458.4
  - Microsoft.EntityFrameworkCore.InMemory: from 5.0.0-rc.2.20452.4 to 5.0.0-rc.2.20458.4

- Updates:
  - Microsoft.DotNet.Build.Tasks.Installers: from 5.0.0-beta.20431.1 to 5.0.0-beta.20452.19
  - Microsoft.DotNet.Helix.Sdk: from 5.0.0-beta.20431.1 to 5.0.0-beta.20452.19
  - Microsoft.DotNet.Arcade.Sdk: from 5.0.0-beta.20431.1 to 5.0.0-beta.20452.19

 - System.IO.Pipelines Fix

(cherry picked from commit 520b9e23f027d7cca49d33f1dc6b2a0e57c893b3)

 - Skip reference check of System.IO.Pipelines ref/ assembly
- add Framework projects to solution
- add Framework.slnf and startvs.cmd in src/Framework

 - Merge branch 'release/5.0-rc2' into darc-release/5.0-rc2-d6b9c1c0-be36-4d12-b860-e7e54a75cb6d
2020-09-08 23:34:53 +00:00
Brennan 4718c11f4d
Add incremental build and project references to java projects (#25707)
* Add incremental build and project references to java projects

* fb

* fix version
2020-09-08 16:30:18 -07:00
John Luo 0a33267c1c
Simplify blazorserver template for individual local auth support (#25523) 2020-09-08 15:42:19 -07:00
Brennan 9cbf55b094
[Java] Fix close with LongPolling (#25582) 2020-09-08 10:54:09 -07:00
Doug Bunting 475fc569d9
[release/5.0-rc2] Add public API baselines for Components (#25660)
- part of #24347
- unable to do src/Components/Authorization due to contained `*.razor` file
- ignored src/Components/Analyzers and src/Components/WebAssembly/Sdk
2020-09-06 21:33:03 -07:00
Doug Bunting 2c1f1f6684
Remove extra public API baseline files (#25655)
- part of #24347
2020-09-06 16:37:29 -07:00
Doug Bunting ad5e173f5c
[release/5.0-rc2] Add public API baselines for HTML and HTTP (#25638)
- part of #24347
2020-09-06 14:26:02 -07:00
Brennan 2fb2055d1e
Quarantine BundlesScopedCssFiles_UpdatesBundleWhenContentsChange (#25656) 2020-09-06 11:52:39 -07:00
Kevin Pilch 956c24e2c8
Add PublicAPI baselines for Middleware (#25602) 2020-09-05 15:41:20 -07:00
John Luo c902645115
Add MigrationsEndPoint when DatabaseDeveloperPageExceptionFilter is used (#25554) 2020-09-04 15:46:14 -07:00
Mackinnon Buck 20af9b88bb
Update PublicAPI.Unshipped.txt (#25629)
- unbreak the build
2020-09-04 12:09:29 -07:00
Javier Calvarro Nelson 3d38d397ae
[Blazor] CSS isolation follow-ups (#25565)
This change includes several improvements to CSS isolation that we have gathered from validation and usage feedback.

We have switched from producing a single scoped CSS bundle file for the entire application with all the scoped css files from the current project, referenced projects and package projects to producing one bundle per referenced project/package and to include those bundles into an "application" bundle throught CSS @import statements.

We have cleaned up the bundle names to make them more unique by including the project name on them and we have also cleaned up the bundle extensions.

We have decided to put the individual bundles generated for the project scoped css assets into the static web assets base path of the project, so that when developers reference assets from their scoped css files (like using the CSS url function) the path they use matches what they have inside their library wwwroot folder.

We have decided to put the application bundle on the root path of the application provided that the developer has not overriden the default StaticWebAssetsBasePath.

This is so that the bundle location is consistent across templates, and can be found at ProjectName.styles.css independent of whether the app is a blazor webassembly app or a server side blazor app.

For cases where the default StaticWebAssetBasePath has been overriden, the value is respected and the bundle is placed at $(StaticWebAssetBasePath)/ProjectName.styles.css.

Packaged razor class libraries with scoped css files now package a "project" bundle instead of the individual files.
2020-09-04 10:54:44 -07:00
Mackinnon Buck bbc7fd8192
IJSUnmarshalledObjectReference for unmarshalled JS interop calls on JavaScript objects. (#25548)
* Added IJSUnmarshalledObjectReference

* Working support for IJSUnmarshalledObjectReference

* CR feedback

* Removed IVT and made JSObjectReference public

* Updated JSON converter.

* Update JSObjectReferenceJsonConverterTest.cs

* Removed whitespace 😓
2020-09-04 10:27:10 -07:00
Artak fe1a881b0e
Merge pull request #25520 from dotnet-maestro-bot/merge/release/5.0-to-release/5.0-rc2
[automated] Merge branch 'release/5.0' => 'release/5.0-rc2'
2020-09-04 09:01:50 -07:00
Kevin Pilch 844bcb557c
Add Public API Baselines for JSInterop, Localization, Logging.AzureAppServices (#25586) 2020-09-03 17:20:48 -07:00
Kevin Pilch c77b8f1b92
Add PublicAPI baselines for Identity (#25578)
Except Identity.UI, since it has Razor files.
2020-09-03 14:01:45 -07:00
Mackinnon Buck 8418ef66e3
Various virtualization improvements. Fixes #25535 (#25260)
* Use ItemSize if it's close to the calculated item size.

* Update WeatherForecastService.cs

* Improved item size calculation.

* Always use calculated item size

* Disable overflow anchoring on scroll containers (except the document itself)

* Update JS files following rebase

* Apply overflow anchor fix to document element too

* Add OverscanCount parameter

Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
2020-09-03 10:29:47 -07:00
Pranav K 12c016567c
Reject control characters in IsLocalUrl check (#25378)
Fixes https://github.com/dotnet/aspnetcore/issues/18109
2020-09-02 23:37:46 -07:00
Justin Kotalik d2c31edc14
Improving logs from hostfxr (#25541) 2020-09-02 15:54:41 -07:00
Mackinnon Buck 2a0b7dc43e
JSObjectReference API review follow-up (#25476)
* API review changes.

* Fixed JSObjectReferenceJsonConverter

* CR feedback

* Update JSObjectReferenceExtensions.cs
2020-09-02 15:09:26 -07:00
Stephen Halter 6ec1b48118
Quarantine UseHttpsWithAsyncCallbackDoeNotFallBackToDefaultCert (#25543) 2020-09-02 14:40:37 -07:00
Ben Adams 3254f71b95
Make IdentityServer.Configuration.KeyDefinition linker friendly (#25524) 2020-09-02 09:20:14 -07:00
Ben Adams ab3799f651
Make CertificateConfig linker friendly (#25515) 2020-09-02 09:19:13 -07:00
William Godbe 9036b0c11d
Merge branch 'release/5.0-rc2' into merge/release/5.0-to-release/5.0-rc2 2020-09-02 09:18:51 -07:00
William Godbe b44c628067
Separate MessagePackHubProtocol into its own package (#25253)
* Separate MessagePackHubProtocol into its own package

* Remove gitignore

* Maybe undo this later

* More factoring

* Get gradle test working

* Get gradle test working

* Get rid of version.java

* Separate build.gradle files for all

* Create separate javaproj's for everything

* Fix warnings

* Resolve conflicts

* Fixup gitignore

* Feedback, fix error

* Fix error

* Change package name

* Fix folder structure

* Skip helix tests, fix .gitignore

* Make TransferFormat private
2020-09-01 17:37:56 -07:00
Doug Bunting 5438f84ae5
Merge pull request #25500 from dotnet-maestro-bot/merge/release/5.0-to-release/5.0-rc2
[automated] Merge branch 'release/5.0' => 'release/5.0-rc2'
2020-09-01 16:00:06 -07:00
Justin Kotalik ee712265d5
Make startup timeout recycle worker process (#25321) 2020-09-01 15:30:28 -07:00
John Luo 6bdb4b95f9
Fix BlazorServer Identity templates (#25456)
Remove @using Microsoft.AspNetCore.Components.Web.Virtualization in blazorserver template.
2020-09-01 09:30:00 -07:00
Kévin Chalet 29042be4cc
Declare AddScheme's displayName parameter as nullable (#25480) 2020-09-01 09:23:07 -07:00
William Godbe b434b8e3f3
Add more assembly version testing for SharedFx/Targeting pack (#25474)
* Add more assembly version tests packs

* Add more tests

* Fix test, feedback
2020-09-01 09:12:13 -07:00
Kevin Pilch 95c526fcae
Api baselines (#25386)
* Enable Public API analyzer for some projects

* Analyzers
* Antiforgery
* Azure (except AzureAD.UI and AzureADB2C.UI due to issues with Razor compiler)
* Configuration.KeyPerFile
* DataProtection
* DefaultBuilder
* Features/JsonPatch
* FileProviders
* HealthChecks
* Hosting
2020-09-01 07:34:28 -07:00
John Luo 222dd67175
Fix Unhandled DBErrors in ComponentsWebAssembly and Spa templates (#25466)
* Add workaround for EF issue dotnet/efcore#22341
2020-09-01 07:26:33 -07:00
Doug Bunting 7579b300f7
Mark some projects as non-packable or non-shippable (#25468)
- used `$(IsTestAssetProject)` in src/Razor/test; slightly more correct
  - we don't have a special category for test infrastructure projects
2020-08-31 22:46:53 -07:00
Stephen Halter 04f23ecfc4
Add async ServerOptionsSelectionCallback UseHttps overload (#25390) 2020-08-31 17:13:19 -07:00
Justin Kotalik 071a539ae5
Avoid build race between x64 and x86 (#25465) 2020-08-31 15:21:21 -07:00
Matt Mitchell 6a3ce0d974
Add light/lit command packages (#25334)
* Add light/lit command packages
This adds light command package generation to aspnetcore.
After build of a wix project, generate a light package based off of the inputs that are sent to light.exe/lit.exe.
2020-08-31 14:19:34 -07:00
Brennan a73ae505a2
System.Security.Cryptography fails on WASM (#25285) 2020-08-31 13:53:55 -07:00
Doug Bunting 27582545ba
Correct the site extensions builds (#25406)
- handle differing SiteExtensions package versions
  - the arch-specific packages don't stabilize when final package does
- update 3.1 packages in bundle to 3.1.7 version
- remove useless empty folder from LoggingBranch (arch-specific) package
  - double slashes help nobody but add an empty-named level in the package

nit: fix a binary log filename
2020-08-31 12:26:04 -07:00
Mackinnon Buck cca4bef83b
Fix InputRadioGroupsWithNamesNestedInteractWithEditContext (#24859)
* Fixed stale element issues

* Reverted changes to blazor.server.js and blazor.webassembly.js
2020-08-31 11:56:17 -07:00
Doug Bunting 1f84e28882
Use `$(TargetFrameworkIdentifier)` and `$(TargetFrameworkVersion)` consistently (#25428)
- always use `$([MSBuild]::VersionXYZ(...))` for version checks
- use `$(NETCoreAppFrameworkIdentifier)` where it's available
- move `$(KnownAppHostPackOrFrameworkReferenceTfm)` setting to Directory.Build.props
  - use it to correct `@(KnownFrameworkReference)` updates
  - metadata of those items still uses `netcoreapp5.0`
  - see also https://github.com/dotnet/efcore/pull/22279#discussion_r478674176

nits:
- do not assume `$(TargetFrameworkVersion)` starts with a 'v'; valid w/o it
- add `$(_IsMicrosoftNETCoreApp20OrOlder)` property in OpenAPI targets file
  - evaluate the `Condition` once instead of three times
2020-08-31 11:36:19 -07:00
Pranav K e4b1950bc0
Set PrivateAssets on transport package (#25450)
The transport package does not ship and we do not want it to appear in WebAssembly.Server's nuspec.
2020-08-31 11:30:43 -07:00
Chris Ross 1cf67b3faf
Fix ClearsResponseBuffer_BeforeRequestIsReexecuted #24146 (#25294) 2020-08-31 10:20:05 -07:00
github-actions[bot] 2ea674021f
Sync shared code from runtime (#25435)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2020-08-31 10:19:44 -07:00
Safia Abdalla 50f739a4bc
Set supported platform on Shared project (#25376) 2020-08-31 10:17:33 -07:00
Safia Abdalla bb62621f37
Add guard checks to PageLoaderMatcherPolicy when loader returns asynchronously (#25370) 2020-08-31 10:16:36 -07:00
Mackinnon Buck c2f97933fe
InputFile follow-up (#25248)
* Changes from API review

* Feedback from security review

* Update IBrowserFile.cs

* Updated documentation.

* Moved InputFile to M.A.Components.Forms

* More changes

* Move ProtectedBrowserStorage to it's own package
* Mark Components.Web.Extensions as non-shipping until we can move it over
* Allow InputFile.OpenReadStreamAsync to specify an expected file size.

* Fix E2E tests

* CR: Throw if user supplies too many files.

* Another build fix

* CR: Zero files is not a scenario

* Update E2E tests

* Update JS binaries after rebase

* Update test

Co-authored-by: Pranav K <prkrishn@hotmail.com>
Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
2020-08-31 09:07:36 -07:00
David Fowler 5292fed790
Restore legacy behavior for certs without private keys (#25344)
* Restore legacy behavior for certs without private keys
- When trying to use an SSL certificate without a private key, SslStream would try to find another certificate in the cert store matching the thumbprint. Now that we're using the SslStreamCertificateContext, that behavor is no longer included so we need to restore it in Kestrel.

* Handle cert store failing to open
2020-08-29 16:14:00 -07:00
Chris Ross 9f0eefb4c1
Skip hanging IIS tests (#25379)
* Report IIS Express Startup failures

* Skip hanging IIS tests #25107
2020-08-29 16:09:39 -07:00
John Luo 44175edd79
Update Microsoft.AspNetCore.SpaServices.Extensions.csproj
Fixup the comment to more accurately describe what occured
2020-08-29 00:34:36 -07:00
Artak f891c2b15d
Merge pull request #25256 from dotnet/prkrishn/dotnet-watch
Allow dotnet watch to refresh on changes to .razor files in reference…
2020-08-28 20:23:59 -07:00
Jean-Marc Prieur 744e96b23d
Updating Web project templates to ms.id.web 0.3.0-preview (#25309)
* Updating Web project templates to ms.id.web 0.3.0-preview

* version bump
and quick fix to the Blasorwasm default values for
the Web api so that customers have a better experience

* Microsoft.Graph is brought in transitively by MS.ID.Web

Co-authored-by: John Luo <johluo@microsoft.com>
2020-08-28 19:56:37 -07:00
Justin Kotalik 4797582279
Call inner disable buffering feature (#25251)
* Call inner disable buffering feature

* Update StreamResponseBodyFeature.cs
2020-08-28 16:25:42 -07:00
Artak 5ba7c70a36
Merge pull request #25362 from dotnet/pranavkm-patch-2
Do not specify TaskCreationOptions \ TaskContinuationOptions in JSRuntime
2020-08-28 15:31:32 -07:00
Artak 0ebd5f040b
Merge pull request #25277 from dotnet/prkrishn/nullability-feedback
Address nullability feedback
2020-08-28 15:30:22 -07:00
Pranav K f733fe9967
Update src/Razor/Microsoft.NET.Sdk.Razor/src/build/netstandard2.0/Sdk.Razor.CurrentVersion.targets 2020-08-28 14:09:11 -07:00
John Luo 7438f7aabe Suppress baseline reference of Microsoft.AspNetCore.SpaServices
This was removed in release/5.0
2020-08-28 12:11:13 -07:00
Artak 4df35c7540
Merge pull request #25292 from dotnet/razor_source_generators
Pass generators to CSC during component discovery
2020-08-28 11:32:30 -07:00
Artak b51d2fe838
Merge pull request #25290 from dotnet/prkrishn/remove-spaservices
Remove NodeServices + SpaServices
2020-08-28 10:30:03 -07:00
Artak 3db5c9cbc5
Use MonoProxy package for debugging (#24721)
* Use MonoProxy package for debugging

* Initial working end-to-end

* Update package version and polish up dbging issues

* Throw exception if DebugProxy received no output
2020-08-28 10:29:34 -07:00
Safia Abdalla 3c3995f653
Add media type mappings for .blat files (#25284) 2020-08-28 10:29:24 -07:00
Pranav K aedd646f6f
Update JSRuntime.cs 2020-08-28 09:53:25 -07:00
Doug Bunting 31bd4d4b1d
[release/5.0] Correct baseline checks (#25227)
- mostly duplicates #25217
- update `BaselineGenerator` to produce baselines useful in 6.0 (too)
- update Baseline.Designer.props using new generator (matching 3.1.7 release)
- always suppress references expressed only in `*.nuspec` files
  - needed even in servicing builds
- restore warning and errors about removed references (new for 5.0)
  - adjust exclusions to handle `@(_ProjectReferenceByAssemblyName)` removal

nit: do not generate empty `<ItemGroup />` elements

* Correct `@(SuppressBaselineReference)` items
  - remove out-of-date `@(SuppressBaselineReference)` items
    - either 3.1.7 baselines we're using don't include reference or still using package
    - fix some comments and `Condition` attributes to make remainder easy to find
  - add missing `@(SuppressBaselineReference)` items
2020-08-28 09:53:20 -07:00
Pranav K 7686c0b4e7
Record type follow ups: (#25218)
* Record type follow ups:

* Throw an error if a record type property has validation metadata
* Disallow TryUpdateModel on a top-level record type
* Ignore previously specified model value when binding a record type
* Unskip record type tests
* Clean up record type detection

* Update src/Mvc/Mvc.Abstractions/src/Resources.resx

Co-authored-by: James Newton-King <james@newtonking.com>

* Fixup tests

* Update src/Mvc/Mvc.Abstractions/src/ModelBinding/ModelMetadata.cs

* Update src/Mvc/Mvc.Abstractions/src/ModelBinding/ModelMetadata.cs

* Update src/Mvc/Mvc.Abstractions/src/Resources.resx

Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>

* Update src/Mvc/Mvc.Core/src/Resources.resx

Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: James Newton-King <james@newtonking.com>
Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
2020-08-28 09:42:11 -07:00
Kevin Pilch 748b368d54
Handle auth schemes in cookie names (#25279)
* Handle auth schemes in cookie names #25266

* With unicode
2020-08-28 09:00:36 -07:00
Safia Abdalla 97280fe5f6
Revert identity package workaround and bump versions (#24819)
* Revert "Add workaround for deprecated overload in authentication scenarios (#24600)"

This reverts commit 7eb58e045d.

* Update identity package versions
2020-08-28 09:00:09 -07:00
Steve Sanderson d793f473c4
Support pseudoelements in CSS scoping (#25270)
* Support pseudoelements in CSS scoping. Fixes #25268

* CR: More test cases

* Another pseudoelement case

* Case insensitivity for single-colon pseudoelements

Not that anybody should ever want to do this

* Avoid an allocation
2020-08-28 08:37:37 -07:00
Steve Sanderson ebaaa0f01d
Fix minimized attributes when using 5.0 SDK with 3.x target (#25307)
* Write minimized attribute values explicitly for older language version

* Add tests

* Add baselines for new tests
2020-08-28 08:37:30 -07:00
Safia Abdalla 6f780bb9ea Throw exception if DebugProxy received no output 2020-08-28 08:25:49 -07:00
Safia Abdalla a3ed9add5d Update package version and polish up dbging issues 2020-08-28 08:25:49 -07:00
Safia Abdalla 302d79a347 Initial working end-to-end 2020-08-28 08:25:18 -07:00
Safia Abdalla 691910c67d Use MonoProxy package for debugging 2020-08-28 08:23:30 -07:00
William Godbe ce058f639c
Add net461 TFM to netstandard2.0 projects (#25094)
* Add net461 TFM to netstandard2.0 projects

* Fix a couple of errors

* Fix some errors

* Get rid of Sockets reference

* Respond to feedback

* net461 -> property

* Fixup clientSample

* Remove net461 from analyzers/razor

* Remove net461 from test projects

* Feedback

* Add net461 test configs

* Remove some incompatible test configs

* Fix test
2020-08-27 16:05:40 -07:00
Chris Sienkiewicz aa51b8c1d1 Remove unsupported SkipAnalyzers param 2020-08-27 15:57:56 -07:00
Chris Sienkiewicz 866df807a8 Disable compiler warnings during component discovery phase 2020-08-27 15:57:33 -07:00
William Godbe a54c5baf7a
Add TypeReference class to signalr java client (#25286)
* Add TypeReference class to signalr java client

* Fix syntax

* Add comments

* Update src/SignalR/clients/java/signalr/src/main/java/com/microsoft/signalr/TypeReference.java

Co-authored-by: Brennan <brecon@microsoft.com>

* Feedback

Co-authored-by: Brennan <brecon@microsoft.com>
2020-08-27 15:56:51 -07:00
John Luo 7b8fe53234
Disable failing/hanging tests due to Chrome/Selenium issue (#25323) 2020-08-27 13:16:01 -07:00
Chris Sienkiewicz d9590840d9 Pass generators to CSC during component discovery 2020-08-26 18:08:24 -07:00
Pranav K 87a51a358a
Merge branch 'release/5.0' into prkrishn/nullability-feedback 2020-08-26 16:38:48 -07:00
Brennan f2b72b0511
Fix SignalR typescript tests with Chrome SameSite reaction (#25283)
* Fix Typescript tests
* fixup
2020-08-26 14:23:01 -07:00
Pranav K 5ed38b7eeb
Remove NodeServices + SpaServices
Follow up to https://github.com/dotnet/aspnetcore/pull/24912.
Not shipping NodeServices isn't enough since it's referenced by SpaServices. This PR removes the two packages
that were announced to be removed in 5.0
2020-08-26 14:19:07 -07:00
Pranav K c4dde35e37
Remove test 2020-08-26 13:48:19 -07:00
Mackinnon Buck 2916f4b09b
Fixed server interop reliability tests (#25244) 2020-08-26 12:56:56 -07:00
Safia Abdalla e2dd2969b5
Set SameSiteMode for cookies in authentication tests (#25281) 2020-08-26 12:22:34 -07:00
Chris R f33937f04d With unicode 2020-08-26 12:04:14 -07:00
Chris R 4636950bfa Handle auth schemes in cookie names #25266 2020-08-26 11:32:05 -07:00
Pranav K 00bbb78d3c
Address nullability feedback
Fixes https://github.com/dotnet/aspnetcore/issues/25275
2020-08-26 09:55:27 -07:00
Pranav K 28e18c3058
Allow dotnet watch to refresh on changes to .razor files in referenced projects
dotnet-watch expects full paths to files to watch in all added items. For files in the current project, this
happens to work. However this does not work very well for files in referenced projects. Using the FullPath metadata
does not work during global evaluation, but we're able to do this in a target.

This change adds extensibility to the dotnet-watch tool that allows calling a target as part of "watch" evaluation.

Fixes https://github.com/dotnet/aspnetcore/issues/22219
2020-08-25 16:03:32 -07:00
John Luo 098be5f5ee
Use LDAP support from DirectoryServices.Protocols for RBAC claim resolution on Linux for Negotiate (#25075) 2020-08-25 13:21:46 -07:00
Doug Bunting c2f0331805
Include project file in F# Worker Service template (#25180)
- add test of this project template
2020-08-25 10:47:37 -07:00
Pranav K b0530a68c0
Do not include the shared framework in the packages (#24816)
* Do not include the shared framework in the packages

DevServer and dotnet-watch include binaries from the ASP.NET Core shared framework
as part of the package. This change compiles these projects against the most recently built
version of the shared framework which ensures build and publish work as normals. Individual
projects from the runtime can be referenced to pick up new runtime features when necessary

* More hacks!

* Ensure shared runtime is built before running tests

* Delete dotnet-watch.nuspec
2020-08-25 10:03:58 -07:00
Javier Calvarro Nelson 402dc41d33
[Blazor] Render Blazor Webassembly components from MVC (#25203)
* Server pieces

* Changes for prerendering

* Discover client components

* tmp

* Cleanup

* Cleanups

* Undo changes

* Remove unwanted changes

* Move interop class to its own file

* Cleanup unwanted changes

* Add test rendering multiple client-side components

* Unit tests and E2E tests

* Cleanups

* Addressed feedback

* Rename Client to WebAssembly in RenderMode

* Update generated js files

* Cleaned up JS and addressed feedback

* Client->WebAssembly and other feedback

* Unify component discovery code and use webassembly instead of 'client'

* Update js files

* Fix tests
2020-08-25 09:30:24 -07:00
Pranav K 78a587b02e
Guard against client disconnect exceptions that appear when reading body (#25146)
* Guard against client disconnect exceptions that appear when performing ReadFormAsync

Reading the request body may throw an exception. This change adds some extra guards
for this and presents this as a 4xx response rather than a 5xx response.

* Add some tests

* Fixup test
2020-08-25 09:29:50 -07:00
Steve Sanderson a9b596e091
Prevent @import in scoped CSS (#25196)
* Reject @import rules in scoped CSS files

* CR feedback: Use SourceText

* CR feedback: Another test case

* Use same file reading mechanism as "generate" command
2020-08-25 09:28:14 -07:00
Steve Sanderson 64c47b733f
Support custom validation class names (#24835)
* Store arbitrary properties on EditContext

* Define FieldCssClassProvider as a mechanism for customizing field CSS classes

* Add E2E test
2020-08-25 09:27:43 -07:00
Justin Kotalik 6333040b5a
Fix MaxRequestBodySize in IIS (#25096)
* Fix MaxRequestBodySize

* Apply suggestions from code review

Co-authored-by: Chris Ross <Tratcher@Outlook.com>

* Update test

* Keep IIS limit default and update API comment

* Update tests

Co-authored-by: Chris Ross <Tratcher@Outlook.com>
2020-08-25 09:12:58 -07:00
Chris Ross e409c97612
Allow suppressing the use of environment variables (#25136)
* Allow suppressing the use of environment variables #20328

* Formatting

* Update src/Hosting/Hosting/src/WebHostBuilderOptions.cs

Co-authored-by: Kahbazi <akahbazi@gmail.com>

Co-authored-by: Kahbazi <akahbazi@gmail.com>
2020-08-24 23:28:17 -07:00
Mackinnon Buck 8a2f29bb53
JSObjectReference (#25028) 2020-08-24 21:02:19 -07:00
Pranav K 29cbf6e106
Make PropertySetter a concrete type (#25054)
* Make PropertySetter a concrete type

* Use the pattern from PropertyHelpers to set property values
* Tweaks to Blazor WebAssembly tests to allow running tests locally

* Update src/Components/Components/src/Reflection/IPropertySetter.cs
2020-08-25 01:54:28 +00:00
Brennan db77380c84
Java client connection state part 1 (#24166) 2020-08-24 16:45:33 -07:00
ar0311 f2c3c11a2d
Minor typos (#25140) 2020-08-24 15:51:09 -07:00
Steve Sanderson faf1d80af1
Follow-ups from PR 23385 (#24834)
* Make preservewhitespace use FileScopedSinglyOccurring

* Design-time experience for boolean directive tokens

* Update baselines
2020-08-24 14:02:21 +01:00
Chris Ross 11bae8a112
Identifying if a request has a body #24175 (#24984) 2020-08-24 06:38:40 +00:00
Chris Ross e5ab127f74
Update OAuth providers #4684 (#25112) 2020-08-23 17:04:43 -07:00
Pranav K 85835c7134
Default new runtime feature switches (#25108)
Porting #23932 to WebAssemblySDK.

* Default new runtime feature switches

These new feature switches have been added to the runtime to make applications smaller. Setting reasonable defaults to Blazor wasm projects.

Fixes https://github.com/dotnet/aspnetcore/issues/25099

If there is an ask mode template to fill out, let me know and I can do it.
2020-08-22 14:35:13 +00:00
Sourabh Shirhatti 826bc84183
Add wireshark logging. Replaces #23088 (#25139)
* Add wireshark style logging in Kestrel

* More Append!

* Update third party notices

Co-authored-by: Kahbazi <A.Kahbazi@gmail.com>
2020-08-22 03:16:54 +00:00
Pranav K 134850b4a2
Update rzc to ne5.0 (#25111) 2020-08-22 02:44:08 +00:00
Pranav K 0960a7a0c5
Configure OpenAPI as part of webapi project template creation (#25110)
* Configure OpenAPI as part of webapi project template creation
Fixes https://github.com/dotnet/aspnetcore/issues/25080

* Update to default to WebAPI
2020-08-21 23:44:11 +00:00
Pranav K 50815ed598
JSInterop nullability PR feedback (#25114) 2020-08-21 22:24:32 +00:00
Safia Abdalla ecf2a23d3d
Update to @azure/msal-browser@2.0.0 (#24827)
* Update to @azure/msal-browser@2.0.0
* Retain promise during initialization
* Set knownAuthority hostname from authority URL
* Add KnownAuthorities config option and fix silent sign-in
* Set knownAuthorities default to empty list
2020-08-21 11:15:41 -07:00
Pranav K 3e8c5c48f0
Add support for views + SingleFileExe (#24925)
* Add support for views + SingleFileExe
2020-08-20 19:46:58 -07:00
Mackinnon Buck 0b1042c54e
InputFile Component (#24640) 2020-08-20 17:52:41 -07:00
Eric Erhardt a700662dec
Quote the ToolAssembly path in BrotliCompress task. (#25101)
Fix #25098
2020-08-20 23:36:09 +00:00
Brennan 04a704c929
[Java] Observe accessTokenProvider on error (#24344) 2020-08-20 16:27:20 -07:00
Pranav K 6a9241b920
Skip test for now 2020-08-20 14:59:39 -07:00
Juan Barahona 601fc20ece
Add enhancement to default behavior of client reconnection (#24992)
These changes are to improve the default reconnection behavior of the client

- [x] Match the reconnection time with server side
- [x] Add indicator to know at which reconnection attempt we currently are
- [x] [Additional] Add a loader symbol
- [x] Add client side test

Addresses #18745
2020-08-20 14:12:04 -07:00
Brennan c181218a4e
Run 1 browser at a time in SignalR javascript functional tests (#25083) 2020-08-20 13:16:23 -07:00
James Newton-King 920d93590d
Remove HTTP/2 headers from request primary headers (#24900) 2020-08-21 07:39:40 +12:00
William Godbe 8522ba8e55
Add MessagePack support for Java SignalR Client (#23532)
* Implement ParseMessages for java messagePack client

* Fix some spacing & syntax

* Implement write

* Tab -> Spaces

* MessagePacker -> MessageBufferPacker

* Tabs -> Spaces

* Tabs -> Spaces

* InvocationMessage may not include streamIDs

* Only 1 ctor per message type

* Fixup HubConnection.java

* Change return type of parseMessages to List

* Fix HubConnection

* Check for primitive value before returning

* Implement length header prefix

* Minor fixes

* Use ByteBuffer to read length header

* Add case for Char

* Close unpacker

* Typo

* Override onMessage w/ ByteString

* Change OKHttpWebSocketWrapper

* Account for nil InvocationId

* Change interface & MessagePack impl

* Update JsonHubProtocol

* Use ByteBuffer

* Fixup HubConnection

* Fixup more stuff

* Convert more stuff to ByteBuffer

* Account for ReadOnly

* Spacing

* No need to reset ByteBuffer when setting position

* Add Protocol to HubConnection ctor

* Set default, make stuff public

* Fixup tests

* More test cleanup

* Spacing

* only grab remaining buffer bytes in json

* Last test fixes

* Get rid of some unused imports

* First round of msgpack tests

* Flip condition

* Respond to feedback

* Spacing

* More tests

* Add test for primitives

* Add more tests, start using msgpack-jackson

* Fix build.gradle

* Remove debug prints

* Start using Type instead of Class

* Add overloads for Type, make messagePack readValue() more efficient

* Apply feedback, add some tests

* Add some tests, fix some tests

* Fix tests for real

* Add a whole buncha tests

* Add TestUtils change that I didn't commit yesterday

* Respond to some feedback

* Add a couple Json tests

* Apply more feedback

* Move readonly fix to msgpack

* Minor optimization

* Fixup some javadocs

* Respond to feedback

* Remove TypeReference, make Protocols private again

* Feedback
2020-08-20 12:12:41 -07:00
Pranav K 4f64c65325
Add a regression test for web.config transform (#25056)
This was resolved as part of moving to the WebAssembly SDK.
A test that would have helped us catch this sooner. This change addresses the test gap.

Resolves https://github.com/dotnet/aspnetcore/issues/24568
2020-08-20 10:14:53 -07:00
Javier Calvarro Nelson 3c34c3ab0d
[Https] Various improvements to the dev-certs tool (#25037)
* Add support for the trust option on Linux on the command-line tool and print a message when it's used pointing to docs.
* Bump the certificate version to 2 to ensure that the certificate gets updated for 5.0 on Mac OS.
* Ensure we always select the certificate with the highest available version to ensure that when we change the certificate in the future older runtimes pick up the new certificate.
* Support exporting the certificate without key on PEM format.
2020-08-20 09:55:56 -07:00
James Newton-King 818279f1f5
Add HealthChecks to solution and enable nullable in tests (#25059) 2020-08-20 15:04:44 +00:00
John Luo 4c381e83d2
Throw original exception if exception handler is not found (#25062)
* Throw original exception if exception handler is not found
2020-08-20 02:45:07 -07:00
Safia Abdalla 8fc1419186
Make OnNavigateAsync EventCallback and cancel previous navigation (#25011)
* Make OnNavigateAsync EventCallback and cancel previous navigation

* Add more tests
2020-08-19 18:25:24 -07:00