Commit Graph

20835 Commits

Author SHA1 Message Date
dotnet-maestro[bot] aa50176707
[release/5.0] Update dependencies from dotnet/arcade (#26817)
[release/5.0] Update dependencies from dotnet/arcade


 - `NETCOREAPP5_0` -> `NET5_0`

 - Add PublishIISAssets To Fix Test
2020-10-14 04:35:26 +00:00
Javier Calvarro Nelson 901bf9ba43
[Blazor] Missing IAsyncDisposable implementation on renderer (#26848)
* Implement async disposable on the renderer

* Minor cleanups
2020-10-13 13:50:54 -07:00
Phil Henning 905777ca5b
Update localized strings.json (#26853)
* Update localized strings.json

* Add missing CSharp worker service update
2020-10-13 13:35:21 -07:00
Pranav K b3aa220af6
Quarantine flaky test (#26627) 2020-10-12 15:02:50 -07:00
Doug Bunting 8399c9f3f9
!!! Correct condition controlling `public` API analysis !!! (#26797)
* !!! Correct condition controlling `public` API analysis !!!
-  #26785 demonstrated analyzers were inoperable

* Remove unused `public` API files

* Update `public` API files
- three Components files were missing `#nullable enable`
- `nullable` annotations missing or out-of-date elsewhere

* Ignore `public` API files completely during source build
- do not warn about unused files

* Update more `public` API files
2020-10-12 11:07:18 -07:00
Stephen Halter ff6d1986ac
Add docs for Session, Diagnostics.EntityFrameworkCore, MiddlewareAnalysis and HeaderPropagation (#26720) 2020-10-09 20:38:45 -07:00
William Godbe bc3dc72700
Fix path data in FrameworkList.xml (#26622)
* Fix path data in FrameworkList.xml

* Move FrameworkList.xml to SharedFxRoot

* Fix targeting pack xml test

* Add test

* Add another test

* Extract .xml files to Helix as well

* Add another test

* Update TestRunner.cs

* Remove slash
2020-10-09 11:06:15 -07:00
Stephen Halter 053052d405
Remove KestrelEventSource events with broken ActivityId tracking (#26684)
* Remove KestrelEventSource events with broken ActivityId tracking

* Skip test requiring ALPN on macOS
2020-10-08 11:47:48 -07:00
Safia Abdalla 84e9f56bca
Resolve issue with readLazyAssembly returning stale value (#26642)
* Resolve issue with readLazyAssembly returning stale value

* Address feedback from peer review

* Update test to exercise loaded package
2020-10-07 22:57:13 -07:00
William Godbe 8118a25e7f
Add API ref docs for HTTPSys (#26649)
* Add API ref docs for HTTPSys

* Spacing

* Feedback
2020-10-07 22:28:49 -07:00
Brennan 5b6362f29a
Enable test logging for ProjectTemplate tests (#26507)
* Enable test logging for ProjectTemplate tests

* Add logging to templates

* some updates

* nullref
2020-10-07 14:37:33 -07:00
John Luo 8555002772
Add an option to allow 404 responses from ExceptionHandlers (#26567) 2020-10-06 10:23:58 -07:00
William Godbe d5b5f08a4f
Cast ByteBuffer to Buffer before calling position(int) (#26614)
* Cast ByteBuffer to Buffer before calling position(int)

* Add comments
2020-10-06 10:17:57 -07:00
Pranav K 8b741bd9c6
Add docs for Negotiate, OAuth, OpenIdConnect (#26610)
* Add docs for Negotiate, OAuth, OpenIdConnect

Contributes to #26397
2020-10-06 08:41:47 -07:00
Sourabh Shirhatti fda7d1d660
Preserve client order of activity baggage items (#26302) (#26395)
Co-authored-by: Andrey Tretyak <andreyt@microsoft.com>
2020-10-05 14:29:39 -07:00
Stephen Halter 96c082f285
Fix WebSockets Negotiate Auth in Kestrel (#26480)
* Don't close connections after upgrade requests without a 101 response

* Add test

* Add DefautCredentials_WebSocket_Success
2020-10-02 14:47:20 -07:00
John Luo 8eb9603a9c
Api docs for Diagnostics middlewares (#26525)
* Api docs for Diagnostics middlewares

* Update ExceptionHandlerFeature.cs

* Update StatusCodePagesMiddleware.cs

* Update ExceptionHandlerMiddleware.cs

* Apply suggestions from code review

Co-authored-by: Pranav K <prkrishn@hotmail.com>

Co-authored-by: Pranav K <prkrishn@hotmail.com>
2020-10-02 20:54:37 +00:00
John Luo ce2e3bc723
Api docs for HttpOverrides (#26530)
* Api docs for HttpOverrides

* Update ForwardedHeadersExtensions.cs

* Update ForwardedHeadersOptions.cs

* Feedback

* Add more details

Co-authored-by: Pranav K <prkrishn@hotmail.com>
2020-10-02 20:42:18 +00:00
Hao Kung 0a52bb721c
API docs for Components (#26505)
* Turn on doc warnings

* Api ref stuff

* Add api docs

* Api docs

* Missing docs

* Add docs

* Update src/Components/WebAssembly/WebAssembly.Authentication/src/Services/ExpiredTokenException.cs

Co-authored-by: Pranav K <prkrishn@hotmail.com>

Co-authored-by: Pranav K <prkrishn@hotmail.com>
2020-10-02 13:22:14 -07:00
Pranav K e755f6017c
Add docs for Auth, Auth.Cookies, Auth.Certificate (#26503)
* Add docs for Auth, Auth.Cookies, Auth.Certificate

Contributes to https://github.com/dotnet/aspnetcore/issues/26397

* Also add JWT

* Apply suggestions from code review

Co-authored-by: Hao Kung <HaoK@users.noreply.github.com>
Co-authored-by: Chris Ross <Tratcher@Outlook.com>

* Update src/Security/Authentication/Core/src/TicketSerializer.cs

* Update src/Security/Authentication/Core/src/TicketSerializer.cs

* Update src/Security/Authentication/Core/src/TicketSerializer.cs

* Apply suggestions from code review

Co-authored-by: Hao Kung <HaoK@users.noreply.github.com>
Co-authored-by: Chris Ross <Tratcher@Outlook.com>
2020-10-02 13:12:16 -07:00
John Luo acf1dc45c0
Api docs for ResponseCaching (#26531)
* Api docs for ResponseCaching

* Enable warnings for HostFiltering, HttpsPolicy and StaticFiles

* Update src/Middleware/ResponseCaching/src/ResponseCachingFeature.cs

Co-authored-by: Pranav K <prkrishn@hotmail.com>

* Add more details

Co-authored-by: Pranav K <prkrishn@hotmail.com>
2020-10-02 18:58:34 +00:00
Brennan 659532b16c
API docs for SignalR (#26445)
* API docs for SignalR

* Apply suggestions from code review

Co-authored-by: Stephen Halter <halter73@gmail.com>
Co-authored-by: Pranav K <prkrishn@hotmail.com>

Co-authored-by: Stephen Halter <halter73@gmail.com>
Co-authored-by: Pranav K <prkrishn@hotmail.com>
2020-10-02 10:14:32 -07:00
Safia Abdalla cd94cd63b7
Add documentation for Routing surface area (#26513)
* Add documentation for Routing surface area

* Apply suggestions from code review

Co-authored-by: James Newton-King <james@newtonking.com>

* Fix up some doc strings

Co-authored-by: James Newton-King <james@newtonking.com>
2020-10-02 10:10:56 -07:00
Pranav K 63baa06482
Use assertion library more consistently (#26519)
Using Browser.Exists is equivalent to Browser.FindElement except it provides better logs
and diagnostics when the assertion fails. The additional waits will also rule out
failures due to the browser taking time to update possibly improving stability.

I looked at the implementation of WebDriverWait to verify that using it will not
introduce additional delays to our tests.
2020-10-02 09:44:02 -07:00
Hao Kung 854b4aad4d
Remove photo from showprofile (#26253) 2020-10-02 09:21:29 -07:00
Hao Kung 5e2259f4bb
Add MVC.Core api docs (#26469)
* Add docs

* Add api docs

* Add xml doc

* Reenable warnings on identity projects

* Razor pages docs

* Add doc

* Missed files

* Add docs

* Apply suggestions from code review

Co-authored-by: Safia Abdalla <safia@microsoft.com>

* Apply suggestions from code review

Co-authored-by: Safia Abdalla <safia@microsoft.com>

* PR feedback

* Update src/Mvc/Mvc.Core/src/ConsumesAttribute.cs

Co-authored-by: Pranav K <prkrishn@hotmail.com>

* Update src/Mvc/Mvc.Core/src/ModelBinding/Validation/ValidationVisitor.cs

Co-authored-by: Pranav K <prkrishn@hotmail.com>

* Update src/Mvc/Mvc.Core/src/Routing/UrlHelperBase.cs

Co-authored-by: Pranav K <prkrishn@hotmail.com>

* Update src/Mvc/Mvc.Core/src/ModelBinding/Validation/ValidationVisitor.cs

Co-authored-by: Pranav K <prkrishn@hotmail.com>

* Update src/Mvc/Mvc.Core/src/Infrastructure/FileResultExecutorBase.cs

Co-authored-by: Pranav K <prkrishn@hotmail.com>

* Update src/Mvc/Mvc.RazorPages/src/DependencyInjection/MvcRazorPagesMvcCoreBuilderExtensions.cs

Co-authored-by: Pranav K <prkrishn@hotmail.com>

* Update src/Mvc/Mvc.Core/src/Routing/UrlHelperBase.cs

Co-authored-by: Pranav K <prkrishn@hotmail.com>

* Update src/Mvc/Mvc.RazorPages/src/DependencyInjection/MvcRazorPagesMvcCoreBuilderExtensions.cs

Co-authored-by: Pranav K <prkrishn@hotmail.com>

* Update src/Mvc/Mvc.Core/src/Routing/UrlHelperBase.cs

Co-authored-by: Pranav K <prkrishn@hotmail.com>

* Update ValidationVisitor.cs

Co-authored-by: Safia Abdalla <safia@microsoft.com>
Co-authored-by: Pranav K <prkrishn@hotmail.com>
2020-10-01 16:02:15 -07:00
William Godbe c3f89a91ab
Generate non-stable version for installer (#26064)
* Generate non-stable version for installer

* Fix versions

* Add upgrade codes for 3.1.0-3.1.8

* Fixup

* Fixup

* Update src/Installers/Windows/SharedFrameworkBundle/Bundle.wxs

Co-authored-by: Massimiliano Donini <massimiliano.donini@gmail.com>

* Add codes for 3.1.9

Co-authored-by: Massimiliano Donini <massimiliano.donini@gmail.com>
2020-10-01 09:51:30 -07:00
Brennan 7c3a072dfd
API docs for WebSockets (#26470) 2020-09-30 20:10:49 -07:00
Safia Abdalla e2b1b20633
Add doc strings for public APIs in Http.Abstractions and Routing.Abstractions (#26468)
* Add doc strings to Http.Abstractions and Routing.Abstractions

* Address feedback from peer review

* Update src/Http/Http.Abstractions/src/ConnectionInfo.cs

Co-authored-by: James Newton-King <james@newtonking.com>

Co-authored-by: James Newton-King <james@newtonking.com>
2020-09-30 13:50:31 -07:00
Pranav K a218c3bea6
Add docs to CookiePolicy (#26446)
* Add docs to CookiePolicy

Contributes to https://github.com/dotnet/aspnetcore/issues/26397

* Apply suggestions from code review
2020-09-30 13:45:18 -07:00
Safia Abdalla 66584a0f30
Add doc strings for public APIs in src/Hosting (#26443)
* Add doc strings for public APIs in src/Hosting

* Apply suggestions from code review

Co-authored-by: Chris Ross <Tratcher@Outlook.com>
Co-authored-by: Pranav K <prkrishn@hotmail.com>
Co-authored-by: James Newton-King <james@newtonking.com>

* Address feedback from peer review

Co-authored-by: Chris Ross <Tratcher@Outlook.com>
Co-authored-by: Pranav K <prkrishn@hotmail.com>
Co-authored-by: James Newton-King <james@newtonking.com>
2020-09-30 13:42:05 -07:00
Stephen Halter b740b6a23b
Keep Http2Connection's ExecutionContext in middleware (#26304)
* Add Http2EndToEndTests

* Finish MiddlewareIsRunWithConnectionLoggingScopeForHttp2Requests

* Keep Http2Connection's ExecutionContext in middleware

* Restore EC before awaiting next request

* Update src/Servers/Kestrel/Core/src/Internal/Http2/Http2Connection.cs

Co-authored-by: James Newton-King <james@newtonking.com>

* Move InitialExecutionContext to HttpConnectionContext

Co-authored-by: James Newton-King <james@newtonking.com>
2020-09-30 13:13:40 -07:00
Javier Calvarro Nelson 720f88231a
Fix policheck issues (#26433) 2020-09-30 11:55:09 -07:00
Pranav K e24064c3f6
Add docs for Authentication.Abstractions (#26438)
* Add docs for Authentication.Abstractions

Contributes to https://github.com/dotnet/aspnetcore/issues/26397

* Turn on docs warning for Authentication.Core

* Update src/Http/Authentication.Abstractions/src/AuthenticationProperties.cs

* Update src/Http/Authentication.Abstractions/src/AuthenticationProperties.cs
2020-09-30 10:52:25 -07:00
Justin Kotalik 4cb7f94fb1
Rewrite api docs (#26440) 2020-09-30 10:51:39 -07:00
Justin Kotalik 75e707bc38
API docs for IIS (#26387) 2020-09-29 14:12:28 -07:00
Steve Sanderson 67ac1675c4
Make Virtualize work in cultures that use alternate number formatting (#26432) 2020-09-29 13:17:23 -07:00
John Luo e62bd65421
Lift OIDC and JwtBearer dependencies in templates (#26390)
Reimplementing the changes originally included in https://github.com/dotnet/aspnetcore/pull/24600

Co-authored-by: Safia Abdalla <safia@microsoft.com>
2020-09-29 11:11:56 -07:00
Stephen Halter ccc59b91c4
Revert breaking KestrelServer ctor change (#26367) 2020-09-29 11:06:32 -07:00
James Newton-King 792df8a4c2
Add API docs to healthchecks and CORS (#26416)
* Add API docs to healthchecks and CORS

* Clean up

* Missing docs
2020-09-29 10:36:25 -07:00
Pranav K 0e5d7ef1d4
Attempt to read the logs from the browser (#26289)
* Attempt to read the logs from the browser

Seleniunm currently does not return log messages (See https://github.com/SeleniumHQ/selenium/issues/8229).
This making figuring out blazor WASM test failures a lot harder.

This change adds some JS to the test apps to read the console output.

* WIP
2020-09-28 17:07:22 -07:00
Pranav K de59a61f9a
Update GenericHostBuilderExtensions.cs (#26386) 2020-09-28 13:52:04 -07:00
Pranav K 6c37a763d1
Remove Microsoft.Components.Web.Extensions (#26256) (#26298)
The package was marked as non-shipping but we continued to build and test it. This change
removes it. A copy of this code exists in asplabs so all is not lost.
2020-09-25 12:14:56 -07:00
Doug Bunting eed71b9083
Support override of PackageOverrides.txt content in servicing (#26308)
* Support override of PackageOverrides.txt content in servicing
- doing now ensures we don't forget if we need to service targeting packs
- not needed in release/3.1 because that branch still pins packages at `X.Y.0` in targeting packs
  - did not do bfc1ec6792 / #25851 work in 3.1 because dotnet/runtime ref/ assemblies change there
- revert no-longer-necessary parts of 6418c8f78a / #25986
  - `$(MicrosoftNETCoreAppRuntimeVersion)` is now correct whenever `GeneratePackageOverrides` runs

nits:
- rename `GeneratePackageConflictManifest` target to `GeneratePackageOverrides`
- rename `$(PackageConflictManifestFileName)` to `$(PackageOverridesFileName)`
2020-09-25 10:54:54 -07:00
Safia Abdalla 2e7b294c6c
Revert "Disconnect circuit on 'beforeunload' event" (#26297)
* Add tests for failing disconnect scenarios

* Remove beforeunload call and add public API

* Add additional test case

* Update src/Components/test/testassets/BasicTestApp/GracefulTermination.razor

Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>

Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
2020-09-25 10:11:26 -07:00
Doug Bunting 32e3353e69
Quarantine recent test failures (#26295)
- see #26291 and #26294
2020-09-24 16:29:31 -07:00
Steve Sanderson f63e90e106
Omit omissible frames when updating rendertree to match bind event. Fixes #24014 (#26273) 2020-09-24 13:24:06 -07:00
Safia Abdalla b925b2886a
Pass all scopes in token request and update IndividualLocalAuth template (#26232)
* Pass all scopes in token request and update IndividualLocalAuth template

* Fix build and address feedback from peer review
2020-09-23 20:42:44 -07:00
dotnet-maestro[bot] 1564ca328c
[release/5.0-rc2] Update dependencies from dotnet/runtime dotnet/efcore (#26209)
[release/5.0-rc2] Update dependencies from dotnet/runtime dotnet/efcore


 - Use non-obsolete `GetColumnName(...)` overload
- react to EF breaking change

 - Add missing `using`
2020-09-23 23:25:06 +00:00
Pranav K de1bf0abe4
Detect culture change in .NET (#26192)
* Detect culture change in .NET

With ICU sharding enabled, blazor wasm attempts to detect if the application culture was changed by the
application code as part of Program.MainAsync and tell them they need to opt out of sharding.

Prior to this change, Blazor compared the .NET culture string with a JS representation for language. With iOS 14,
the two culture strings differ in casing which prevents the use of any Blazor WASM app the latest version installed.

As part of this change, the comparison is performed entirely in .NET which avoids relying on the JS representation.

* Fixups
2020-09-23 09:00:38 -07:00
Pranav K da3f97b0ad
Fix client validation for record types (#26159)
* Fix client validation for record types

Server validation for record types uses metadata from parameters
when validating record type properties. However client validation
does not use the parameter to harvest client validation attributes.

In the absence of this change, validation on parameters would require server
round trips which is unexcepted and not at parity with validation applied
to properties on regular classes or record types.

Validation experience with record types is subpar and requires server
round trips.

No. This feature is new to 5.0.

Low. The change is isolated to record types and does not affect other code paths. We have
unit and functional test coverage to verify this change.

* Correctly dispose app after use
2020-09-22 22:02:49 -07:00
William Godbe c34d1dceac
Include all .xml files in targeting pack (#26147)
* Include all .xml files in targeting pack

* Better syntax

* Remove distinct
2020-09-22 12:54:28 -07:00
Steve Sanderson 7140f7cae7
Virtualize component: method to trigger data refresh (#26177)
* E2E test cases for Virtualize data refresh

* Expose public RefreshDataAsync API

* Optimize: don't instantiate CancellationTokenSource when it won't be used

* For in-memory data, refresh automatically on each render cycle

* Fix typo
2020-09-22 11:52:16 -07:00
Safia Abdalla 93f73c7764
Add support for debugging lazy-loaded assemblies (#25943)
* Add support for debugging lazy-loaded assemblies

* Address feedback from peer review

* Increase wait for output on tests
2020-09-22 08:23:39 -07:00
Sayed Ibrahim Hashimi d97ef5ccd4
Updated icons for projects that appear in VS with icons that have the (#25974)
* Updated icons for projects that appear in VS with icons that have the
language adornment.
This PR should fix #25973.

* updating icons for asp.net core templates in vs
2020-09-21 13:04:31 -07:00
Justin Kotalik 02d81add81
Increase Http2Timeout (#26075) 2020-09-21 10:55:08 -07:00
Hao Kung 6bfffda734
Remove ComponentsWebAssembly shared layout (#26078) 2020-09-19 11:12:38 -07:00
Pranav K bf91253cd3
Increase more SignalR Java client test timeouts (#26036)
Co-authored-by: Stephen Halter <halter73@gmail.com>
2020-09-18 17:00:43 -07:00
Pranav K 140f177d9e
Converge implementations of AwaitableProcess and ProcessEx (#26069)
* Converge implementations of AwaitableProcess and ProcessEx

* dotnet-watch tests are running in to the same issue as GRPC tests (https://github.com/dotnet/aspnetcore/pull/20341/files).
This change carries over some of the patterns from the other type to remedy this issue.

* Revive dotnet-watch tests on OSX

* Remove build artifacts that were accidentally commited to source.
2020-09-18 16:32:06 -07:00
Pranav K 611ee61e0e
Quarantine tests (#26062) 2020-09-18 13:08:30 -07:00
dotnet-maestro[bot] 7e0e801bb4
[release/5.0-rc2] Update dependencies from dotnet/arcade dotnet/efcore (#26058)
[release/5.0-rc2] Update dependencies from dotnet/arcade dotnet/efcore


 - Update installers task location
2020-09-18 19:58:16 +00:00
Matt Mitchell b1b3d5474f
Enable PostBuildSign flag and include signing information in the manifest (#26033)
This change is prep for post build signing. When PostBuildSign=true, signing is not performed during the build. Instead, pass the top-level artifacts that are signable to PushToAzureDevOpsArtifacts (via Publish.proj).
Also fix up ArtifactsDir. As far as I can tell, it's been fixed up in Arcade to always include the trailing \, and Publish.proj should no longer be messed up.
2020-09-18 11:07:42 -07:00
Doug Bunting b592cf6610
Place ref/ layout where SDK can find it (#25987)
- correct Helix test failures with stable versions, where SDK's packs aren't enough

E.g. from https://dev.azure.com/dnceng/internal/_build/results?buildId=813814
``` text
...\.dotnet\sdk\5.0.100-rc.1.20379.10\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(318,5): error MSB4018: The "ResolveTargetingPackAssets" task failed unexpectedly. [...\src\ProjectTemplates\test\bin\Release\net5.0\TestTemplates\AspNet.m0yq3xrporu\AspNet.m0yq3xrporu.csproj]
...\.dotnet\sdk\5.0.100-rc.1.20379.10\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(318,5): error MSB4018: System.IO.DirectoryNotFoundException: Could not find a part of the path '...\.dotnet\packs\Microsoft.AspNetCore.App.Ref\5.0.0\data\FrameworkList.xml'. [...\src\ProjectTemplates\test\bin\Release\net5.0\TestTemplates\AspNet.m0yq3xrporu\AspNet.m0yq3xrporu.csproj]
```
2020-09-17 21:03:07 -07:00
Doug Bunting 6418c8f78a
Pin PackageOverrides.txt Extensions versions at Major.Minor.0 in servicing (#25986)
- set the package version of Extensions assemblies using NETCore.App version
  - ignore Microsoft.Extensions.Internal.Transport package version
    - transport package has a non-stable version and isn't shipped
    - just got lucky this worked before versions stabilize
- update test expectations when checking PackageOverrides.txt
  - use NuGet.Versioning to make this easier
2020-09-17 21:02:46 -07:00
Brennan 3ee23fb771
Refactor transient state in Java client (#24219)
* Refactor transient state in Java client

* some fb

* fix nullref

* fixup rebase

* fb

* apply some fb

* fix flaky

* lock

* check previous state
2020-09-17 17:59:27 -07:00
Brennan 899deacb22
Fix SignalR+WebSockets on WASM (#25922)
* Fix SignalR+WebSockets on WASM

* fb

* move stuff

* select
2020-09-17 11:30:31 -07:00
Pranav K 2921f5514a
dotnet-watch: continue printing output to console after the app is ready (#25984)
dotnet-watch redirects standard out to detect when the app is launched and
prints these redirected messages to the console. Unfortunately once the app
is launched, redirected messages are no longer printed. This wasn't caught earlier
since ASP.NET Core is very quiet by default.

ASP.NET Core apps launched via dotnet watch do not print output to the console.

Yes. This was introduced as part of changes to dotnet-watch to launch a browser in 5.0-preview8.

Low.
2020-09-16 18:53:59 -07:00
Steve Sanderson 8c23b53bef
Make timezone and ICU data available offline for PWA (#25954) 2020-09-16 16:49:09 -07:00
dotnet-maestro[bot] 9675fdb455
[release/5.0-rc2] Update dependencies from dotnet/arcade (#25963)
[release/5.0-rc2] Update dependencies from dotnet/arcade


 - Update create light/light command package drop task

 - Create output directory
2020-09-16 22:08:01 +00:00
Brennan ce76ae75f6
Fix Java packaging (#25838)
* Fix Java packaging

* fix flaky test
2020-09-15 10:20:43 -07:00
John Luo d14e273015
[5.0.0-rc2] Backport Fix chrome/selenium tests (#25330) (#25840)
* Fix chrome/selenium tests (#25330)

* Revert "Disable failing/hanging tests due to Chrome/Selenium issue (#25323)"

This reverts commit 332f1504128a63431cb67830703922cdeefee525.

* Update Selenium to latest

* Update API

* Try specifying a version

* Update Selenium to 4.0.0-beta5

* Disable browser log tests

* Fix components e2e tests and disable blazor standalone template test

* Disable tests using browser log

* Disable template test

* Avoid using .NET formatted strings in tests

* Annotate BasicTestApp suggesting that it needs the all globalization data

* Culture specific formatting relies on the ICU data carried by the OS. This
causes issues in our tests if WebAssembly carries a different set than the OS. Instead
updating these tests to use hardcoded strings.

* Additionally fixing an issue where some projects in the solution were using tasks from
the .dotnet SDK rather than the local copy of the SDK. This was causing issues building locally.

Co-authored-by: Pranav K <prkrishn@hotmail.com>
2020-09-14 18:43:42 -07:00
Kevin Pilch e3a52ee3de
Merge pull request #25881 from dotnet-maestro-bot/merge/release/5.0-to-release/5.0-rc2
[automated] Merge branch 'release/5.0' => 'release/5.0-rc2'
2020-09-14 15:24:14 -07:00
Pranav K a6f667bbb3
Add SkipAnalyzers=true to component declaration compilation (#25736)
* Update to latest SDK

* React to platform compatibility analyzer warnings
* React to new warnings
* Add platform compatibility attributes

* Add SkipAnalyzers=true to component declaration compilation
Fixes https://github.com/dotnet/aspnetcore/issues/25365

* Update eng/Version.Details.xml

* Update Versions.props

* Update Version.Details.xml

* Update Versions.props

* Update Version.Details.xml
2020-09-14 12:41:37 -07:00
Martin Costello a0ede85a61
Fix MSB4109 (#25880)
Fix MSB4109 error when the Microsoft.Extensions.ApiDescription.Server NuGet package is installed.
2020-09-14 12:07:15 -07:00
Doug Bunting 6c29f44a0b
Reduce references to Microsoft.AspNetCore.App.Runtime.csproj (#25836)
- dotnet-watch builds against runtime in the SDK
- other projects build after runtime project due to Ref.csproj reference
  - but, when the targeting packs aren't building, there's no reason to use Ref.csproj
- followup on 76fbd1a283 and 84962660a3, reducing parallelism in build
2020-09-14 11:34:07 -07:00
Steve Sanderson ccbc46c076
Fix RCL template to have correct filename for scoped CSS (#25870) 2020-09-14 09:13:49 -07:00
John Luo 472e8297a7
Update identity web templates (#25834)
* Update identity web templates

* Do not generate scopeRequiredByApi if not needed
2020-09-14 07:58:03 -07:00
Doug Bunting e3b632894d
Fix Helix testing issues with stable versions and local builds (#25865)
- include all shipping packages in Helix payloads that need runtime
  - remove hard-coded `-ci` that broke Helix tests with stable versions or local builds
  - for local builds, do not assume `$(Configuration)` is Release
- support `$(HelixTargetQueues)` property used in RunHelix.ps1
  - lost somewhere along the lines; script ran full matrix

nits:
- clean up redundant addition of runtime and ref/ packages
  - `@(HelixContent)` additions in `_CreateHelixWorkItem` target are ignored
- mention '+' separation of `-HelixQueues` argument to RunHelix.ps1
- allow `$(IsUnitTestProject)` override in case we need it in the future
2020-09-13 21:45:23 -07:00
Pranav K ab5dfe5374
Allow dotnet-watch to look for changes to .razor.css files (#25792)
Fixes https://github.com/dotnet/aspnetcore/issues/25483
2020-09-13 14:46:47 -07:00
Doug Bunting b760d35b54
Support override of PlatformManifest.txt content in servicing (#25849)
- copied from release/3.1; not sure why this wasn't merged forward
- doing now ensures we don't forget if we need to service targeting packs
2020-09-13 11:40:09 -07:00
Pranav K 99496b41a0
Nullability feedback for public types in Components (#25821)
* EventCallback.InvokeAsync can pass a null value
* Remove unused BindFormatterWithFormat
2020-09-13 10:01:21 -07:00
Javier Calvarro Nelson b1e1aabc9d [Mvc] Fix global state in controller and action endpoint data sources.
* Create data sources "per router" instance.
* Make a global shared order sequence "per router" for conventional and
  controller and page routes.
* Create DynamicControllerEndpointSelector and DynamicPageEndpointSelector
  instances per data source.
2020-09-12 10:03:32 -07:00
Javier Calvarro Nelson a17842a2e4 [Mvc] Add support for order in dynamic controller routes (#25073)
* Order defaults to 1 same as conventional routes
* An incremental order is applied to dynamic routes as they are defined.
2020-09-12 10:03:32 -07:00
James Newton-King 340ee72715
Update gRPC version in template to 2.32.0-pre1 (#25587)
* Update gRPC version in template to 2.32.0-pre1

* Log server timeout detail

* Only run interop tests on windows queues

Co-authored-by: John Luo <johluo@microsoft.com>
2020-09-11 20:23:16 -07:00
Doug Bunting 326507bb01
Correct `$(SharedFxVersion)` and `$(TargetingPackVersion)` values (#25790)
* Correct `$(SharedFxVersion)` and `$(TargetingPackVersion)` values
- Ensure `$(SharedFxVersion)` doesn't change in `$(NoSemVer20)` projects
- Ignore current project's `$(VersionSuffix)` in `$(TargetingPackVersion)`
    - Never assume `$(AspNetCoreBaselineVersion)` matches released targeting pack
- Stabilize both versions correctly
- Use these properties more widely
    - Remove other mechanisms to get the same values
    - Reduce use of the `_GetPackageVersionInfo` target
    - Reduce use of `$(SharedFxVersion)` for the targeting pack

nits:
- Correct comments about old RTMVersions.csproj project
- Fix or remove a few other comments

* Do not pass package filenames on Helix command Lines
- remove parsing of these command-line arguments from `RuntestOptions`
  - instead craft the names using passed `$(SharedFxVersion)`
- restore `$(DotNetRuntimeSourceFeedKey)` on Helix command line
  - lost somewhere along the line
- correct argument count in runtests.sh
  - treated 11th argument as both Helix timeout and feed credential
  - count was messed up somewhere alone the line

nits:
- update C# syntax in `RuntestOptions` e.g. remove unused `public` setters
- sort and group properties and their assignments
2020-09-11 19:17:28 -07:00
Chris Ross b5515a8dac IIS: Identify if a request has a body (#25381) 2020-09-11 17:43:36 -07:00
Pranav K 004cd1a9d9
PR feedback for platform compatibility update (#25815)
* PR feedback for platform compatibility update

Follow up to https://github.com/dotnet/aspnetcore/pull/25421

* Add SupportedOSPlatform attributes to a few more DataProtection API
* Update the SDK to rc2
* Clean up warning suppression in CertificateManager
* React to nit feedbacks

Fixes https://github.com/dotnet/aspnetcore/issues/25781

* Apply suggestions from code review
2020-09-11 14:32:02 -07:00
Stephen Halter 3932156a95
Improve Http1ContentLengthMessageBody's reset logic (#25799) 2020-09-11 13:57:23 -07:00
Brennan 9eb9de6c8c
[Java] Catch errors from user callbacks (#25513)
* [Java] Catch errors from user callbacks

* test logger

* rebase

* fb
2020-09-11 11:44:00 -07:00
Chris Ross 4383118ef8
IIS: Identify if a request has a body (#25381) 2020-09-11 11:40:25 -07:00
Brennan 83e31342a1
[Kestrel] Deflake app abort test (#25484)
* [Kestrel] Deflake app abort test

* better

* fb
2020-09-11 10:53:45 -07:00
William Godbe f7a76173e4
Re-enable Helix tests for signalR java client (#25783)
* Re-enable Helix tests for signalR java client

* Change path to test results
2020-09-11 10:26:49 -07:00
William Godbe 77be06a894
Support primitive type/classes in HubConnection.on() (#25773)
* Support primitive type/classes in HubConnection.on()

* Small refactor

* Spacing
2020-09-11 10:11:29 -07:00
William Godbe 84962660a3
Strip duplicates from BuiltProjectOutputGroupOutput (#25785) 2020-09-11 10:11:10 -07:00
Brennan c32089a5e2
Add SignalR Client on WASM smoke test (#25526)
* Add SignalR Client on WASM smoke test

* Move test into BasicTestApp

Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
2020-09-11 09:23:08 -07:00
Brennan 2ab6436cdd
Set ShutdownTimeout in Kestrel tests (#25743) 2020-09-11 09:21:18 -07:00
Brennan a7d129cc97
Send CloseMessage in more cases (#25693)
* Send CloseMessage in more cases

* fb
2020-09-11 09:21:02 -07:00
Chris Ross 11b85eb7e2
Add Windows.10.Amd64.Server20H1.Open helix queue (#25627) 2020-09-10 19:36:42 -07:00
Sayed Ibrahim Hashimi 118d6b2986
Updating titles in project templates because in Visual Studio the (#25630)
templates will be showing the templates directly in the New Project
Dialog instead in the One ASP.NET dialog.

In this PR I have updated the English titles. For localized strings we
will need to get those from the localization team. I believe we are not
setup for that to be automated here.

I think we should merge the English strings because they are the most
used, and for other locales we will show the old localized names for
now. If it's difficult to get those localized, I can work with @phenning
to see if we can localize those files this time.
2020-09-10 18:46:32 -07:00
Brennan 970d0f5d00
[SignalR] Copy cookies from negotiate to WebSockets (#24572) 2020-09-10 18:22:14 -07:00
Stephen Halter 327d55d01c
Prevent ODE when response body isn't reset (#25779) 2020-09-10 18:14:08 -07:00
Pranav K 5aa4a7cd41
Avoid using PATH to find dotnet.exe in RazorSDK tasks (#25750)
This pattern is pretty identical to what we have in other SDKs. It allows
using the SDK when dotnet isn't in the path such as the https://github.com/dotnet/aspnetcore/issues/25746.

Fixes #14432
2020-09-10 16:30:55 -07:00
Pranav K 18d261b20c
Use T? for unconstrained nullable types (#25772) 2020-09-10 15:15:11 -07:00
Pranav K 36f8642f0b
Use T? for unconstrained nullable types (#25261)
* Use T? for unconstrained nullable types

* Apply suggestions from code review
2020-09-10 15:14:30 -07:00
Pranav K 690c717314
Update to latest SDK (#25421)
* React to platform compatibility analyzer warnings
* React to new warnings
* Add platform compatibility attributes
2020-09-10 15:12:17 -07:00
Zachary Becknell fa2a5076e4
Add option to specify hostname in BrowserRefreshServer (#25572)
* Add option to specify hostName for refresh server

* Update env variable name per suggestion

Co-authored-by: Pranav K <prkrishn@hotmail.com>

Co-authored-by: Pranav K <prkrishn@hotmail.com>
2020-09-10 15:10:47 -07:00
Ken Egozi cc0665cb6f
TypeReference usage clarification (#25719)
This change makes TypeReference usage a little bit easier

- Marking it abstract make it so that usages cannot "forget" subclassing (or omitting the { } part). Previously the error message would be confusing as the supertype would be Object.
- Removing the instanceof check and relying on exception since instantiating TypeReference without a type parameter (new TypeReference() ) *is* exceptional as it goes against the intention of this class altogether.
- Added some clarification to the javadoc regarding intended usage, and a link to prior art for further reading.
2020-09-10 15:02:21 -07:00
Kevin Pilch 3692e122ff
Add Public API baselines for Razor (#25637) 2020-09-10 13:27:09 -07:00
Pranav K 09160a779f
Use JsonSerializerDefaults instead of specifying individual options (#25747)
This lets MVC use the defaults as specified by System.Text.Json. Right now, these defaults are identical
to the two properties that were removed. However this allows MVC to pick up new S.T.J defaults in 6.0 including when
users attempt to use a 6.0 versioned package with 5.0
2020-09-10 11:54:00 -07:00
Kevin Pilch 848f42df8e
Add public API baselines for SiteExtensions, Testing, WebEncoders (#25654) 2020-09-10 11:45:01 -07:00
Kevin Pilch 158401f361
Add public API baselines to SignalR (#25653) 2020-09-10 11:44:04 -07:00
Juan Hoyos dda1d33f7b
Enable ARM64 installers build. (#25579)
Changes WiX toolset used to 3.14 to support ARM64
Generates targeting pack from the x86/x64 leg, as it gets produced using a zip that gets generated there.
The ARM64 leg now produces all the necessary msi's, exe, and wixlib needed for the installer to generate a bundle.
2020-09-10 10:59:37 -07:00
Javier Calvarro Nelson 31fcc8bd26
Update error page (#25706) 2020-09-10 10:20:19 -07:00
Javier Calvarro Nelson 0637599517
Update DfaMatcherBuilder to use the correct behavior (#25616) 2020-09-10 10:18:32 -07:00
Pranav K 2228c98b88
Use ICU sharding (#25521) 2020-09-10 10:17:02 -07:00
Kevin Pilch 6828192780
Add public API baselines for Servers (#25652) 2020-09-09 21:07:55 -07:00
Kevin Pilch 14a3862f5f
Add Public API baselines for Security (#25651) 2020-09-09 21:07:15 -07:00
John Luo 035221d731
Add cache for retrieved RBAC claims (#25698) 2020-09-09 14:24:48 -07:00
William Godbe 76fbd1a283
Strip duplicate files from SharedFx input to Nuget Pack (#25733) 2020-09-09 14:15:17 -07:00
Mackinnon Buck 8f461884c9
Update JSCallResultTypeHelper.cs (#25628)
* Update JSCallResultTypeHelper.cs and PublicAPI.Unshipped.txt

* CR feedback.

* Removed exception message
2020-09-09 13:33:47 -07:00
Mackinnon Buck 43ef580773
Fixed content type issue (#25702) 2020-09-09 13:30:13 -07:00
Stephen Halter b3f4a32d23
Increase SignalR Java client test timeouts to 30 seconds (#25639) 2020-09-09 11:26:51 -07:00
Steve Sanderson ecc2ba16b8
Accessibility fixes (#25678)
* Fix header tab ordering issues. Fixes 1163117

* Ensure text can be zoomed to 200% without switching to mobile layout. Fixes 1163184.

* Ensure "Log out" link can show focus state. Fixes 1162890

* Use screen reader-friendly link text. Fixes 1163642

* Update template test
2020-09-09 11:08:10 -07:00
Artak 0d548f302b
Enable PlatformCompatibilityAnalyzer for RCL projects (#25636) 2020-09-09 09:57:42 -07:00
Steve Sanderson c5bcd68853
Fix wasm caching on localhost and various E2E test issues (#25689)
* Fix caching of WASM resources on localhost

* Fix test server startup

* Add missing server variant of VirtualizationTest

* Make test namespaces consistent

* Fix VirtualizationTest cases

* Update BootResourceCachingTest
2020-09-09 09:54:45 -07:00
Pranav K 646925127b
Move ProtectedBrowserStorage to the shared fx (#25557)
* Move ProtectedBrowserStorage to the shared fx

* Fixups

* Fixup
2020-09-09 09:54:14 -07:00
Steve Sanderson 9f5276d17a
Update RCL template to use 5.0 features (#25613)
* Update JS interop to use auto-loaded ES6 module

* Test update

* Make it lazy for compatibility with prerendering

* Update comment

* Code style: go back to .AsTask - it's probably easier to read
2020-09-09 08:25:26 -07:00
dotnet-maestro[bot] 95763af89a
[release/5.0-rc2] Update dependencies from dotnet/arcade dotnet/runtime dotnet/efcore (#25555)
[release/5.0-rc2] Update dependencies from dotnet/arcade dotnet/runtime dotnet/efcore
- Updates:
  - System.ComponentModel.Annotations: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Diagnostics.DiagnosticSource: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Diagnostics.EventLog: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.DirectoryServices.Protocols: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Logging.Abstractions: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Logging.Configuration: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Logging.Console: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Logging.Debug: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Logging.EventLog: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Logging.EventSource: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Logging.TraceSource: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Options: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Options.ConfigurationExtensions: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Options.DataAnnotations: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Primitives: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Logging: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Internal.Transport: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Http: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Hosting.Abstractions: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Caching.Abstractions: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Caching.Memory: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Configuration: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Configuration.Abstractions: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Configuration.Binder: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Configuration.CommandLine: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Configuration.EnvironmentVariables: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Configuration.FileExtensions: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Configuration.Ini: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Configuration.UserSecrets: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Configuration.Xml: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.DependencyInjection: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.DependencyInjection.Abstractions: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.DependencyModel: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.FileProviders.Abstractions: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.FileProviders.Composite: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.FileProviders.Physical: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.FileSystemGlobbing: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.HostFactoryResolver.Sources: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Hosting: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Extensions.Configuration.Json: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.NETCore.App.Runtime.win-x64: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.NETCore.BrowserDebugHost.Transport: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.NETCore.Platforms: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Win32.Registry: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.Win32.SystemEvents: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.NETCore.App.Internal: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - Microsoft.NETCore.App.Ref: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Drawing.Common: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Threading.Channels: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Windows.Extensions: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Text.Json: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Text.Encodings.Web: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.ServiceProcess.ServiceController: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.IO.Pipelines: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Net.Http.Json: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Net.Http.WinHttpHandler: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Net.WebSockets.WebSocketProtocol: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Reflection.Metadata: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Runtime.CompilerServices.Unsafe: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Security.AccessControl: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Security.Cryptography.Cng: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Security.Cryptography.Pkcs: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Security.Cryptography.Xml: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Security.Permissions: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Security.Principal.Windows: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25
  - System.Resources.Extensions: from 5.0.0-rc.2.20452.8 to 5.0.0-rc.2.20454.25

- Updates:
  - Microsoft.EntityFrameworkCore.Tools: from 5.0.0-rc.2.20452.4 to 5.0.0-rc.2.20458.4
  - Microsoft.EntityFrameworkCore.SqlServer: from 5.0.0-rc.2.20452.4 to 5.0.0-rc.2.20458.4
  - dotnet-ef: from 5.0.0-rc.2.20452.4 to 5.0.0-rc.2.20458.4
  - Microsoft.EntityFrameworkCore: from 5.0.0-rc.2.20452.4 to 5.0.0-rc.2.20458.4
  - Microsoft.EntityFrameworkCore.Design: from 5.0.0-rc.2.20452.4 to 5.0.0-rc.2.20458.4
  - Microsoft.EntityFrameworkCore.Relational: from 5.0.0-rc.2.20452.4 to 5.0.0-rc.2.20458.4
  - Microsoft.EntityFrameworkCore.Sqlite: from 5.0.0-rc.2.20452.4 to 5.0.0-rc.2.20458.4
  - Microsoft.EntityFrameworkCore.InMemory: from 5.0.0-rc.2.20452.4 to 5.0.0-rc.2.20458.4

- Updates:
  - Microsoft.DotNet.Build.Tasks.Installers: from 5.0.0-beta.20431.1 to 5.0.0-beta.20452.19
  - Microsoft.DotNet.Helix.Sdk: from 5.0.0-beta.20431.1 to 5.0.0-beta.20452.19
  - Microsoft.DotNet.Arcade.Sdk: from 5.0.0-beta.20431.1 to 5.0.0-beta.20452.19

 - System.IO.Pipelines Fix

(cherry picked from commit 520b9e23f027d7cca49d33f1dc6b2a0e57c893b3)

 - Skip reference check of System.IO.Pipelines ref/ assembly
- add Framework projects to solution
- add Framework.slnf and startvs.cmd in src/Framework

 - Merge branch 'release/5.0-rc2' into darc-release/5.0-rc2-d6b9c1c0-be36-4d12-b860-e7e54a75cb6d
2020-09-08 23:34:53 +00:00
Brennan 4718c11f4d
Add incremental build and project references to java projects (#25707)
* Add incremental build and project references to java projects

* fb

* fix version
2020-09-08 16:30:18 -07:00
John Luo 0a33267c1c
Simplify blazorserver template for individual local auth support (#25523) 2020-09-08 15:42:19 -07:00
Brennan 9cbf55b094
[Java] Fix close with LongPolling (#25582) 2020-09-08 10:54:09 -07:00
Doug Bunting 475fc569d9
[release/5.0-rc2] Add public API baselines for Components (#25660)
- part of #24347
- unable to do src/Components/Authorization due to contained `*.razor` file
- ignored src/Components/Analyzers and src/Components/WebAssembly/Sdk
2020-09-06 21:33:03 -07:00
Doug Bunting 2c1f1f6684
Remove extra public API baseline files (#25655)
- part of #24347
2020-09-06 16:37:29 -07:00
Doug Bunting ad5e173f5c
[release/5.0-rc2] Add public API baselines for HTML and HTTP (#25638)
- part of #24347
2020-09-06 14:26:02 -07:00
Brennan 2fb2055d1e
Quarantine BundlesScopedCssFiles_UpdatesBundleWhenContentsChange (#25656) 2020-09-06 11:52:39 -07:00
Kevin Pilch 956c24e2c8
Add PublicAPI baselines for Middleware (#25602) 2020-09-05 15:41:20 -07:00
John Luo c902645115
Add MigrationsEndPoint when DatabaseDeveloperPageExceptionFilter is used (#25554) 2020-09-04 15:46:14 -07:00
Mackinnon Buck 20af9b88bb
Update PublicAPI.Unshipped.txt (#25629)
- unbreak the build
2020-09-04 12:09:29 -07:00
Javier Calvarro Nelson 3d38d397ae
[Blazor] CSS isolation follow-ups (#25565)
This change includes several improvements to CSS isolation that we have gathered from validation and usage feedback.

We have switched from producing a single scoped CSS bundle file for the entire application with all the scoped css files from the current project, referenced projects and package projects to producing one bundle per referenced project/package and to include those bundles into an "application" bundle throught CSS @import statements.

We have cleaned up the bundle names to make them more unique by including the project name on them and we have also cleaned up the bundle extensions.

We have decided to put the individual bundles generated for the project scoped css assets into the static web assets base path of the project, so that when developers reference assets from their scoped css files (like using the CSS url function) the path they use matches what they have inside their library wwwroot folder.

We have decided to put the application bundle on the root path of the application provided that the developer has not overriden the default StaticWebAssetsBasePath.

This is so that the bundle location is consistent across templates, and can be found at ProjectName.styles.css independent of whether the app is a blazor webassembly app or a server side blazor app.

For cases where the default StaticWebAssetBasePath has been overriden, the value is respected and the bundle is placed at $(StaticWebAssetBasePath)/ProjectName.styles.css.

Packaged razor class libraries with scoped css files now package a "project" bundle instead of the individual files.
2020-09-04 10:54:44 -07:00
Mackinnon Buck bbc7fd8192
IJSUnmarshalledObjectReference for unmarshalled JS interop calls on JavaScript objects. (#25548)
* Added IJSUnmarshalledObjectReference

* Working support for IJSUnmarshalledObjectReference

* CR feedback

* Removed IVT and made JSObjectReference public

* Updated JSON converter.

* Update JSObjectReferenceJsonConverterTest.cs

* Removed whitespace 😓
2020-09-04 10:27:10 -07:00
Artak fe1a881b0e
Merge pull request #25520 from dotnet-maestro-bot/merge/release/5.0-to-release/5.0-rc2
[automated] Merge branch 'release/5.0' => 'release/5.0-rc2'
2020-09-04 09:01:50 -07:00
Kevin Pilch 844bcb557c
Add Public API Baselines for JSInterop, Localization, Logging.AzureAppServices (#25586) 2020-09-03 17:20:48 -07:00
Kevin Pilch c77b8f1b92
Add PublicAPI baselines for Identity (#25578)
Except Identity.UI, since it has Razor files.
2020-09-03 14:01:45 -07:00
Mackinnon Buck 8418ef66e3
Various virtualization improvements. Fixes #25535 (#25260)
* Use ItemSize if it's close to the calculated item size.

* Update WeatherForecastService.cs

* Improved item size calculation.

* Always use calculated item size

* Disable overflow anchoring on scroll containers (except the document itself)

* Update JS files following rebase

* Apply overflow anchor fix to document element too

* Add OverscanCount parameter

Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
2020-09-03 10:29:47 -07:00
Pranav K 12c016567c
Reject control characters in IsLocalUrl check (#25378)
Fixes https://github.com/dotnet/aspnetcore/issues/18109
2020-09-02 23:37:46 -07:00
Justin Kotalik d2c31edc14
Improving logs from hostfxr (#25541) 2020-09-02 15:54:41 -07:00
Mackinnon Buck 2a0b7dc43e
JSObjectReference API review follow-up (#25476)
* API review changes.

* Fixed JSObjectReferenceJsonConverter

* CR feedback

* Update JSObjectReferenceExtensions.cs
2020-09-02 15:09:26 -07:00
Stephen Halter 6ec1b48118
Quarantine UseHttpsWithAsyncCallbackDoeNotFallBackToDefaultCert (#25543) 2020-09-02 14:40:37 -07:00
Ben Adams 3254f71b95
Make IdentityServer.Configuration.KeyDefinition linker friendly (#25524) 2020-09-02 09:20:14 -07:00
Ben Adams ab3799f651
Make CertificateConfig linker friendly (#25515) 2020-09-02 09:19:13 -07:00