Commit Graph

44119 Commits

Author SHA1 Message Date
msftbot[bot] 4752d95a76
Merge pull request #24596 from dotnet-maestro-bot/merge/release/5.0-preview8-to-master
[automated] Merge branch 'release/5.0-preview8' => 'master'
2020-08-05 22:01:31 +00:00
Kahbazi b2c7d514c9
[Kestrel] Move to GenericHost (#24279)
* [Kestrel] Move to GenericHost

* Change TransportSelector

* Add an empty app for TestServer

* Add an empty app for TestServer

* Set app

* Stop host

* Stop the TestSserver

* Stop more hosts!

* Stop host in dispose

* implement IAsyncDisposable for TestServer

* configure await

* catch OperationCanceledException

* Apply suggestions from code review

Co-authored-by: Brennan <brecon@microsoft.com>
2020-08-05 21:48:53 +00:00
JC Aguilera 25948ab962
Merge pull request #24585 from jcagme/pathChange
Update path after dupe fix
2020-08-05 14:38:39 -07:00
Pranav K b8b438d945
Add additional constructor to HealthReport (#24597)
Co-authored-by: Serg046 <serg046@outlook.com>
2020-08-05 21:21:55 +00:00
Justin Kotalik e75a5c166a Merge branch 'release/5.0-preview8' into master 2020-08-05 13:47:27 -07:00
witskeeper 2831aaa08a
fix : failureStatus (#21175)
* fix : failureStatus

use HealthCheckRegistration.FailureStatus when CheckHealthAsync failure

Fixes https://github.com/dotnet/aspnetcore/issues/22503
2020-08-05 13:00:08 -07:00
Pranav K b654051748
Remove Blazor internal profiling infrastructure (#24468) (#24589)
* Put back InternalCalls

* Removing .NET profiling calls

* Remove JS side profiling

Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
2020-08-05 12:45:42 -07:00
juanam a0056635aa Update path after dupe fix 2020-08-05 10:26:39 -07:00
Ryan Brandenburg 50fb513fda
Remove ActivityLog.xml from Razor issue template (#24573)
pre-requisite checklist
2020-08-05 09:34:40 -07:00
WuYafeng 748798889b
Fix:ControllerLinkGeneratorExtensions.GetAmbientValues throws NullReferenceException (#24576)
- related issue #24412
- add null check on GetAmbientValues(HttpContext)
2020-08-05 09:33:31 -07:00
Steve Sanderson f05827484e
Speed up multiple attributes overwrite detection. Fixes #24467 (#24561) 2020-08-05 16:39:36 +01:00
Steve Sanderson d99644ef9c
Move reconnection delay mechanism into framework code (#24566) 2020-08-05 16:00:54 +01:00
Pranav K bb9653532a
Add nullable annotations to M.A.Hosting and DefaultBuilder (#24571)
* Turn on nullability annotations for public types in M.A.Hosting
* Turn on nullability annotations for Microsoft.AspNetCore and
  Microsoft.AspNetCore.Server.Abstractions

Contributes to https://github.com/dotnet/aspnetcore/issues/5680
2020-08-05 01:07:11 +00:00
msftbot[bot] e2d2aaa753
Merge pull request #24549 from dotnet-maestro-bot/merge/release/5.0-preview8-to-master
[automated] Merge branch 'release/5.0-preview8' => 'master'
2020-08-05 00:51:20 +00:00
Pranav K 84b30133a7
Merge branch 'master' into merge/release/5.0-preview8-to-master 2020-08-04 16:21:58 -07:00
Tanay Parikh 29ceed2b2a
Razor TagHelperDescriptor Hashing (#24551)
* Razor TagHelperDescriptor Hashing and Caching

1/2 PRs for https://github.com/dotnet/aspnetcore/issues/23170

The other PR will be in aspnetcore-tooling to utilize these changes.

https://github.com/dotnet/aspnetcore-tooling/pull/2307
2020-08-04 13:06:42 -07:00
David Fowler cfd20ad2d7
Fix some linker warnings, report others (#24553)
* Fix some linker warnings, report others
- Added RequiresUnreferencedCode to UseStartup that takes a string
- Added some suppressions
- Fixed ConfigureContainer calls
- Fixed HostingStartupAttribute
2020-08-04 12:40:42 -07:00
Doug Bunting e13368391b
Keep `@(Reference)` metadata when creating `@(ProjectReference)` items (#21567)
- #20818, fix e.g. references to Microsoft.Web.Xdt.Extensions in our packages
- make `@(Reference)` items much more broadly applicable
- emit an error when `@(ProjectReference)` is used instead of `@(Reference)`
    - then get rid of the errors (!!)
- rename a couple of projects to match their assembly names
    - then regenerate the `@(ProjectReferenceProvider)` items
- switch intersection approach from Exclude / Exclude to Copy / Update / Copy

Projects of particular interest:
- src/DefaultBuilder/src/Microsoft.AspNetCore.csproj
    - honouring metadata left e.g. Microsoft.AspNetCore.Components.WebAssembly.DevServer package unchanged
    - removed redundant metadata after that confirmation
- src/Razor/tools/Microsoft.AspNetCore.Razor.Internal.Transport/
    - content of this package unchanged but metadata avoids extra work
    - add a comment about the extra work
- src/SiteExtensions/LoggingAggregate/src/Microsoft.AspNetCore.AzureAppServices.SiteExtension/
    - success! removes Microsoft.Web.Xdt.Extensions dependency from the package
- src/SiteExtensions/Runtime/Microsoft.AspNetCore.Runtime.SiteExtension.pkgproj
    - add a `Condition` to avoid an ordering issue I hit here
- src/Tools/Extensions.ApiDescription.Server/src/
    - avoid errors the new build ordering and timing caused

Separately, up the timeout in the `<DownloadFile />` task
- hit repeated timeouts downloading dotnet-runtime-5.0.0-rc.1.20370.4-win-x64.zip

nits:
- remove dupe `@(Reference)` item in Microsoft.AspNetCore.Components.WebAssembly.DevServer.csproj
- remove useless `%(ProjectReference.IsImplicitlyDefined)` metadata as well as its misspellings
- remove extra spaces from ProjectReferences.props
- clean up a few comments in ResolveReferences.targets

* !fixup! Correct other references to renamed projects
2020-08-04 10:05:55 -07:00
SQL-MisterMagoo 1be16fb4c9
Add delay before showing Reconnection UI (#24137)
* Add CSS delay before showing Reconnection UI

* rebuild yet again to try and get past the conflict
2020-08-04 04:14:46 +00:00
Mackinnon Buck 4ef5e10e6d
Virtualization support (#24179) 2020-08-03 17:02:12 -07:00
Pranav K fcabe6f0fd
Turn off full GC (#24545)
Using the full gc sometimes leads to an infinite recursion resulting
in a browser freeze. This was noted as part of running Blazor's benchmarks.
This is being addressed in rc1, in the meanwhile this reverts the behavior to 3.2 defaults.

Browser freezes when using a Blazor WASM application.

Yes. Full GC on is new to WASM on .NET Core

Low. Off by default is the behavior we had in 3.2.
2020-08-03 15:43:34 -07:00
David Fowler 3f15d26851
Obsolete the ResponseCookiesFeature constructor (#24546) 2020-08-03 14:47:20 -07:00
David Fowler 1f5149a663
Implement CopyToAsync in the FileBufferingReadStream (#24499)
* Implement CopyToAsync in the FileBufferingReadStream
- overrride Span and Memory overloads and implement array overloads in terms of those overloads.
- Implemented CopyToAsync (but not CopyTo)
- Added tests

Fixes #24032
2020-08-03 14:14:42 -07:00
Daniel Roth e31998c94b
Update Blazor Server survey link for .NET 5 (#24507) 2020-08-03 13:46:09 -07:00
Steve Sanderson 1885af9634
Add console runner for measuring Blazor perf on desktop interpreter (#24469) 2020-08-03 21:42:44 +01:00
Safia Abdalla 0335ac60a6
Check completed task in circuit termination tests (#24450)
* Check completed task in circuit termination tests
* Remove extraneous whitespace
* Update CircuitGracefulTerminationTests.cs
2020-08-03 13:40:29 -07:00
Steve Sanderson 7e11c3c264
Cache parameter writer lookups (#24536) 2020-08-03 21:01:16 +01:00
Steve Sanderson 38e166fd59
Optimize render tree building via RenderTreeFrameArrayBuilder (#24484) 2020-08-03 18:42:31 +01:00
Cédric Luthi 749450ac7b
[HTTPS] Fix the CertificateManagerEventSource event ids (#24519) 2020-08-03 07:30:52 -07:00
David Fowler 404d817677
Dipping toes into linker friendliness (#24458)
- Annotated UseMiddleware and UseStartup to preserve constructors and public methods.
- Annotated UseHub and MapHub preserve constructors and public methods.
- Added a test to verify UseStartup and UseMiddleware works
- The linker.xml preserves constructors all of the types that are registered in DI. This should be removed once we get the linker friendly DI changes.
2020-08-03 06:54:03 -07:00
msftbot[bot] dd25b5f91a
Merge pull request #24522 from dotnet-maestro-bot/merge/release/5.0-preview8-to-master
[automated] Merge branch 'release/5.0-preview8' => 'master'
2020-08-03 05:30:10 +00:00
Doug Bunting a78cd6239f
Increase main Helix job timeout (#24493)
- now matches timeout in quarantined-pr.yml which uses the same queues
- internal PRs may otherwise time out
2020-08-02 18:00:45 -07:00
Doug Bunting b534f92589
Remove unused HTML files (#24488)
- just a bit confusing to leave these around
- the files haven't been used since @pakrym removed the resources in 56c064bd53
2020-08-02 11:46:10 -07:00
Daniel Roth 4bb01a5a43
Update Blazor WebAssembly in-product survey link for .NET 5. (#24508) 2020-08-02 09:59:30 -07:00
Hao Kung 130ec438fd
Improve crash/hang support in helix (#24489) 2020-08-01 10:38:26 -07:00
Safia Abdalla 723e32a47d
Update documentation on darc (#24487)
* Update documentation on darc

* Apply suggestions from code review

Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>

* Update code blocks in referenced assemblies

Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
2020-07-31 21:49:56 +00:00
Steve Sanderson 6f7a3dfd4e
Remove Blazor internal profiling infrastructure (#24468)
* Put back InternalCalls

* Removing .NET profiling calls

* Remove JS side profiling
2020-07-31 22:04:48 +01:00
dotnet-maestro[bot] a64f3fda00
Update dependencies from https://github.com/dotnet/arcade build 20200724.1 (#24482)
Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.Arcade.Sdk
 From Version 5.0.0-beta.20364.3 -> To Version 5.0.0-beta.20374.1
- downgrade of the Arcade SDK should be fine

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
2020-07-31 14:04:05 -07:00
Pranav K f495fcb151
Avoid doing unncecessary work when generating component declaration files. (#24445)
The output of the declaration file for Razor components are unaffected by all inputs other than the input .razor file.
Consequently we can avoid regenerating these files if the output is newer than the input. This is the same heuristic we apply to Blazor WebAsssembly's
compression artifacts.

This PR combines these two improvements for a ~90ms (10%) improvement in the inner loop.

```
       17 ms  GenerateBlazorWebAssemblyBootJson          1 calls
       22 ms  Copy                                       8 calls
       39 ms  ProcessFrameworkReferences                 1 calls
       40 ms  RazorTagHelper                             1 calls
       51 ms  ResolveAssemblyReference                   1 calls
       70 ms  GetFileHash                                1 calls
       80 ms  RazorGenerate                              2 calls
      111 ms  Csc                                        2 calls

      Time Elapsed 00:00:00.95
```

```
       17 ms  GenerateBlazorWebAssemblyBootJson          1 calls
       21 ms  Copy                                       8 calls
       37 ms  ProcessFrameworkReferences                 1 calls
       51 ms  ResolveAssemblyReference                   1 calls
       70 ms  Csc                                        1 calls
       72 ms  GetFileHash                                1 calls
       79 ms  RazorGenerate                              2 calls

Time Elapsed 00:00:00.86
```

In after: Csc calls reduced to one, RazorTagHelper call removed.
2020-07-31 20:40:52 +00:00
Hao Kung e6b9a3d295
Remove debian 8 from helix runs (#24454)
* Add display environment

* Print out env variables as part of helix runs

* Update TestRunner.cs

* Remove Debian 8 from helix matrix

* Remove Debian 8 skip

* Remove debian 8 skip

* Remove debian 8

* Remove debian 8 skip

* Remove Debian 8 skip

* Remove debian 8

* Update Program.cs

* Update TestRunner.cs

* Update TestRunner.cs
2020-07-31 20:35:54 +00:00
Safia Abdalla c0c0a26000
Wait for component to mount before checking for output (#24451)
* Wait for component to mount before checking for output
* Use Exists to check for element with timeout
* Update ComponentRenderingTest.cs
2020-07-31 12:44:27 -07:00
dotnet-maestro[bot] b2fe5dd4b1
Update dependencies from https://github.com/dotnet/roslyn build 20200729.3 (#24456)
Microsoft.Net.Compilers.Toolset
 From Version 3.8.0-1.20367.11 -> To Version 3.8.0-2.20379.3

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
2020-07-31 10:32:31 -07:00
Brennan 4290bcc782
Pass serialization exceptions to Hub disconnect (#24408) 2020-07-31 10:13:28 -07:00
Steve Sanderson f28ef7c3e8
Use ordinal comparison when detecting event handler attributes. Fixes #24465 (#24471) 2020-07-31 17:54:35 +01:00
Pranav K 3e1e69ecce
Add nullable annotations to Authenticator.Core & Authentication.Cookies (#24307)
Contributes to https://github.com/dotnet/aspnetcore/issues/5680
2020-07-30 17:09:14 -07:00
Kahbazi 799014cfe7
Throw BadHttpRequestException in HttpSys (#24213) 2020-07-30 16:29:38 -07:00
Kahbazi d0cca519b4
Set ContentLength for TestHost (#24107) 2020-07-30 16:10:58 -07:00
Miha Zupan e3501ddd4a
H/QPackEncoder overloads accepting Encoding (#24448) 2020-07-30 20:11:58 +00:00
marlongerson b9e663bffb
[Identity] Updated RenderSection to use async method. (#24121) 2020-07-30 13:03:11 -07:00
Safia Abdalla e0ef3d2246
Merge pull request #24387 from dotnet-maestro-bot/merge/release/5.0-preview8-to-master
[automated] Merge branch 'release/5.0-preview8' => 'master'
2020-07-30 12:16:52 -07:00