There are two places in 2.1 where SendFileAsync falls back to a copy loop. These loops should short circuit when the client disconnects, or else the server will sit there and burn resources reading the whole file from disk.
Fix: If you passed in your own active CT we'll use it. Otherwise we'll use the RequestAborted token.
* Attempt to auto-publish vs.redist packages to orchestrated feed
* Use non-stable packageVersion for vs.redist
* Fix typo
* Update build/Publish.targets
- should trigger a build that's more likely to succeed
* Print what we're trying to publish
* More debug prints
* Set RedistPackageId in publishing.targets
* Reference variable correctly
* Remove unnecessary messages
* Respond to feedback
Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
* [Https] Detects and fixes HTTPS certificates where the key is not guaranteed to be accessible across security partitions
* Fix dotnet dev-certs https --check
* Update logic for detecting missing certs
* Fix security command
* Update warning logic
* Check that the key is accessible in Kestrel
* Add correct link to docs
* Update src/Tools/dotnet-dev-certs/src/Program.cs
Co-Authored-By: Daniel Roth <daroth@microsoft.com>
* Update src/Tools/dotnet-dev-certs/src/Program.cs
Co-Authored-By: Daniel Roth <daroth@microsoft.com>
* Add test for 2.1
* Update src/Tools/dotnet-dev-certs/src/Program.cs
Co-Authored-By: Chris Ross <Tratcher@Outlook.com>
* Address feedback
* Fix non-interctive path
* Fix tests
* Remove a couple of test from an unshipped product
* Check only for certificates considered valid
* Switch the exception being caught, remove invalid test
Co-authored-by: Daniel Roth <daroth@microsoft.com>
Co-authored-by: Chris Ross <Tratcher@Outlook.com>
Fixed the `PipeWriterStream` to properly detect a canceled write and throw an `OperationCanceledException` in those cases. And making sure `Complete` is called in a safe manner by ensuring it is in a lock so writes can't be in-progress.
* also improve PreparingPatchUpdates.md
- document changes to dependencies.props
- reflect changes in how Templating is handled
- e.g. use EF Core examples
- nit: adjust indentation to avoid markdown warnings
Doug Bunting
dotnet-bot
Michael Stuckey
Chris Ross (ASP.NET)
John Luo
Brady Gaster
Justin Kotalik
William Godbe
Pranav Krishnamoorthy
Matt Mitchell
Chris Ross
Javier Calvarro Nelson
Brennan
Andrew Stanton-Nurse
Steve Sanderson
Mikael Mengistu
Justin Kotalik
Ryan Brandenburg