huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
2,110 Commits 1 Branch 0 Tags 251 MiB
Commit Graph

2110 Commits

Author SHA1 Message Date
Pranav K 18c80d156c Replace NotNullAttribute with thrown exceptions 2015-09-26 23:48:43 -07:00
Doug Bunting eff10cdd66 Move `ModelStateDictionaryExtensions` into `Microsoft.AspNet.Mvc.ModelBinding` namespace 
- missed the inconsistency when reviewing
- kept class in ViewFeatures assembly because it depends on `ExpressionHelper`

nit: wrap some long lines
 2015-09-26 18:15:04 -07:00
Muchiachio b28debf442 Generic ModelStateDictionary add and remove extensions 
- Added generic add model error and remove extensions for
ModelStateDictionary, to avoid using hard coded strings then specifying
model state dictionary keys.
- Added generic removal all  extension for ModelStateDictionary, to
support removing all the model state keys for given expression.

aspnet/Mvc#3164
 2015-09-26 18:14:58 -07:00
Pranav K 6a0a24481a Asynchronously flush the HttpResponseStreamWriter after a view has been rendered. 
This solves a perf issue for views which produce content that is smaller
than the buffer size of HttpResponseStreamWriter. In this case, the writer
ends up synchronously writing to the Response as part of Dispose which
affects perf.
 2015-09-25 21:07:15 -07:00
Ryan Nowak 8a502dbe5d Rewrite of validation 2015-09-25 16:56:42 -07:00
Kirthi Krishnamraju 0889b18f95 Add localizers to validation attributes 2015-09-25 16:13:21 -07:00
Nero Sule 49acfd562e Adds common interfaces around Models (Implements #3158) 2015-09-25 11:10:59 -07:00
Ajay Bhargav Baaskaran 9c81b95d1b Renamed Controller.Context to Controller.HttpContext 
- #3165
 2015-09-25 11:01:30 -07:00
Ryan Nowak 5a80435534 API Review - Move ModelBindingHelper 2015-09-25 09:59:56 -07:00
Kirthi Krishnamraju ed509f65a2 fix #2747: Fix Mvc localization test once dnx support reading resources 2015-09-24 12:53:20 -07:00
Pranav K 1833e06984 TModel substitution in Razor pages has broken intellisense 
Fixes #3185
 2015-09-23 17:47:52 -07:00
Pranav K ff4100e292 Generate an expression to create line mappings for ModelChunk directives 2015-09-23 16:14:29 -07:00
Pranav K 89f58aa49f Allow @model specified in a page work with @inherits directive in 
_ViewImports

Fixes #3144
 2015-09-23 12:10:10 -07:00
Ryan Nowak 80add92de8 React to removal of TagHelperContent.ToString() 
Avoid calling ToString on a TagHelperContent.

Also react to new properties on TagHelperCodeGenerationContext
 2015-09-23 11:09:27 -07:00
Doug Bunting d8d0a1ab89 Rename `ModelMetadata.IsCollectionType` and add "real" `ModelMetadata.IsCollectionType` 
- #3022
- existing `IsCollectionType` -> `IsEnumerableType`
- use new `IsCollectionType` in a few places
 2015-09-22 19:05:40 -07:00
Pranav K 1574637a6a Reacting to Microsoft.AspNet.Cors version change 2015-09-22 11:26:04 -07:00
Pranav K 9eb2c5b810 Reacting to IExpirationTrigger -> IChangeToken rename 2015-09-22 08:14:34 -07:00
Ryan Nowak b544aabfdb Fix #3111 - Don't trounce content-type in VCR 
This change makes ViewComponentResult respect an existing Content-Type
setting on the HttpResponse. Code is very similar to the code in
ViewExector, and includes the same quirks.
 2015-09-21 23:20:20 -07:00
Ryan Nowak a318c4599a API Review - Split up .Actions 
Abstractions - Core MVC extensibility

Controllers - MVC implementations of .Abstractions and supporting
contracts

Infrastructure - General purpose support APIs. Metadata APIs that don't
fit clearly with a feature or with .Abstraction
 2015-09-21 21:54:02 -07:00
Pranav K 00b6e71e31 Changes per NotNull PR comments 2015-09-21 17:22:27 -07:00
Pranav K 498d209949 Remove chaining from HashCodeCombiner. 
Reacting to https://github.com/aspnet/Common/issues/40
 2015-09-21 17:11:08 -07:00
Ajay Bhargav Baaskaran 8f3a322cf9 Enabling NuGetPackageVerifier 2015-09-21 15:24:57 -07:00
Pranav K f045c6792b Allow _ViewImports to remove default inherited tag helpers. 
Additionally simplifying the contract for
ChunkInheritaceUtility\IChunkMerger so we don't have to understand the
order in which CodeTrees appear.
 2015-09-21 14:53:24 -07:00
Ryan Nowak b95dcd5f1c Fix #3102 - Add an AddMvcOptions to builders 
This makes it easier/possible for any third party code that extends
IMvcBuilder to set options.
 2015-09-21 12:54:59 -07:00
N. Taylor Mullen 162e0b960d Remove travis OSX work around for surpassing max file limit 2015-09-21 12:53:11 -07:00
Ryan Nowak f4c5e31ec1 Remove JsonPatch from MVC 
JsonPatch is moving to https://github.com/aspnet/JsonPatch
 2015-09-21 11:14:40 -07:00
Pranav K 66a04c2fd6 Replacing NotNullAttribute with thrown exceptions 2015-09-21 10:26:14 -07:00
Ryan Nowak 00c436b0e1 [Perf] Remove use of [FromServices] on Controller 
[FromServices] requires modelbinding to run for each of these four
properties, which allocates a lot, and ultimately just ends up calling
GetRequiredService in the end.

Also, retrieving these services is now lazy, which should be very
beneficial as few of them aren't used often.
 2015-09-21 08:53:12 -07:00
Ryan Nowak 9badd9386e API-Review Strongly-typed collections for a few options types. 
We don't want these extensions methods defined in a wierd namespace, it's
straightforward and future-proof to just make these strongly-typed
collections.
 2015-09-20 22:11:22 -07:00
Doug Bunting 895258d550 Work around aspnet/External#33, aspnet/External#41, aspnet/External#42, and aspnet/External#43 
- do not run tests that hit known issues with Core CLR on Linux
 2015-09-20 21:42:12 -07:00
Doug Bunting c67ea208b2 [quick fix] Remove `version` property from `project.json` for LoggingWebSite 
- avoid warning when building Microsoft.AspNet.Mvc.FunctionalTests project
- now consistent w/ other web sites in this repo
  - all but MvcMinimalSample.Web and that isn't used in functional tests
 2015-09-20 21:38:08 -07:00
Ryan Nowak 10ec9144ca Remove extra registration of TelemetrySource 
This is now provided by hosting.
 2015-09-20 21:16:01 -07:00
Ryan Nowak 4d55a6e62d API review - remove DefaultOrder 
No change in behavior intended, removing this from our public API.
 2015-09-20 21:11:57 -07:00
Ryan Nowak ccb5ead450 Api-Review - put uri complexity in CreatedResult 2015-09-20 19:44:32 -07:00
Doug Bunting 42017faa21 Add `InputFormatterResult` and `InputFormatterContext.ModelName` 
- #2722
- make communication of errors from formatters to `BodyModelBinder` explicit
  - `JsonInputFormatter` now adds errors to `ModelStateDictionary` with correct key
- change `InputFormatter.SelectCharacterEncoding()` to add an error and return `null` when it fails
  - one less `Exception` case and removes some duplicate code

nits:
- improve some doc comments (more `<inheritdoc/>`, `<paramref/>` and `<see/>`)
- add another two `BodyValidationIntegrationTests` tests
 2015-09-19 21:36:38 -07:00
Doug Bunting 0476d53f1d [quick fix] Allow `TestCommon` project to build successfully 
- otherwise may fail in VS or when using `BuildV2` from the command line
 2015-09-18 16:45:01 -07:00
Ajay Bhargav Baaskaran 90777c903d Running xml-docs-test before test target 2015-09-18 12:28:29 -07:00
Doug Bunting 0fb09908d3 [Build break] Correct doc comment references to match current namespaces 
- local command line builds fail consistently during `xml-docs-test`
- bit buried on the CI machine but repo is not testing successfully there
 2015-09-17 23:12:26 -07:00
N. Taylor Mullen f81707d5fe Update nuget.exe and corresponding feeds to v3. 2015-09-17 18:34:03 -07:00
Kiran Challa b7382dc6c3 Fix Razor test compilation failure 2015-09-17 16:47:07 -07:00
Pranav K 4874677807 Fixing CI build failure 2015-09-17 16:10:36 -07:00
Kiran Challa f3e537ddcb Reacting to TestHost changes 2015-09-17 16:08:23 -07:00
Pranav K 7b433820b1 Changes per PR comments 
Reformatting parameter identation
 2015-09-17 15:42:58 -07:00
Pranav K a68d9e4cb1 Replace NotNullAttribute with thrown exceptions 2015-09-17 11:56:44 -07:00
Ryan Nowak ef730790d4 Fix tests broken by renames 2015-09-17 07:40:15 -07:00
Ryan Nowak 538cd9c191 Move less-commonly used types out of .Rendering 2015-09-16 23:52:29 -07:00
Ryan Nowak 046cb976b3 Move ActionResult classes back to main namespace 2015-09-16 21:42:31 -07:00
Pranav K 1c4614c219 Avoid allocating strings in DefaultViewLocationCache 
Fixes #3135
 2015-09-16 17:28:40 -07:00
Pranav K 00075520b4 Razor CompilerCache allocates too much in NormalizePath 
Fixes #3035
 2015-09-16 16:55:51 -07:00
Ryan Nowak 9a15b54d30 Flow IHtmlContent through to the razor buffer 2015-09-16 16:17:40 -07:00