Commit Graph

1604 Commits

Author SHA1 Message Date
Ryan Nowak f77493dffe Part 1 of #1712 - Remove reflection in MutableObjectModelBinder
This change introduces a new property to ModelMetadata called
IsBindingRequired, which specifies whether or not a model value must be
present on the wire during model binding.

[DataMember(IsRequired = true)] is currently the only thing that will set
this property.

Updated tests and documentation for clarity on the difference in meaning
between MM.IsRequired and MM.IsBindingRequired. Moved setting for
IsRequired to ValidationMetadata which is a better fit.

Also added functional tests for [BindingBehavior] and [DataMember] in
model binding because they were totally missing.
2015-04-16 12:07:33 -07:00
Kiran Challa c3f10f4a0f Logging for content-negotiation 2015-04-16 12:02:55 -07:00
Kiran Challa 7576116969 Removed test code related to logging and instead used Testing repo's logging helpers. 2015-04-16 11:19:24 -07:00
Kiran Challa 65bd8c448a Removed Logging related ILogValues types and cleaned up tests. 2015-04-16 11:19:20 -07:00
Kiran Challa 20daab2fb5 Removed direct dependency on Framework.Logging and instead used Framework.Logging.Interfaces.
Fixed breaking code which additionally cleans up start-up logging which we wanted to do.
2015-04-16 11:19:17 -07:00
Henk Mollema 9eb87d4676 Removed htmlAttributes null check in GenerateForm
The null check caused the form not to use the default url generation
behavior when html attributes were specified.
2015-04-16 16:29:27 +02:00
Harsh Gupta 7f68a47fde Fixing doc comments for c67236141b 2015-04-15 14:46:29 -07:00
Harsh Gupta c67236141b Fixes 2304:
The fix splits client validation and model validation into two separate hierarchies.
Introduced ClientModelValidatorProvider in MvcOptions, which can be iterated to produce IClientModelValidators.
As a result of this, HtmlGenerator code can be free of ActionBindingContext and directly consumes options.
This also means that we do not modify the client validations during resource filters.
2015-04-15 14:30:46 -07:00
N. Taylor Mullen eaa58bc913 Change inject directive to format correctly after newline during design time.
- Also modified existing tests to account for aspnet/Razor#332 which fixed models formatting after newline.
- Updated tests for inject to understand new formatting parsing.

aspnet/Razor#332
2015-04-15 12:18:45 -07:00
Ajay Bhargav Baaskaran 4951235eef [Fixes #2337] Added support for file types in input taghelper and
htmlhelper
2015-04-15 11:58:40 -07:00
Ajay Bhargav Baaskaran a9f2c937df React to Cookie changes 2015-04-15 11:50:11 -07:00
Hao Kung bee20973c7 React to http challenge changes 2015-04-15 11:39:12 -07:00
Youngjune Hong 9daf6b48a1 Update ModelBinderAttribute not throw exceptions from BinderType property setter 2015-04-14 17:31:50 -07:00
Youngjune Hong 852d6402eb Remove an unecessary test from DefaultAssemblyProviderTests 2015-04-14 16:00:10 -07:00
N. Taylor Mullen 2c4c35e126 Add rendering logic for PreElement and PostElement on TagHelperOutput.
- Added unit tests to validate that the properties were rendered correctly.
- Modified functional tests to utilize PreElement and PostElement.

aspnet/Razor#341
2015-04-14 12:01:20 -07:00
Ryan Nowak d0e5118741 Delay Attribute Route initialization to the first request 2015-04-13 16:16:27 -07:00
Kiran Challa 24b930fa7c Clean up logging.
- Removing scopes as we want to limit the number of scopes being created.
- Added new log statements using the new log format string.
2015-04-13 15:59:38 -07:00
sornaks 7ea467f73d Adding functional test for CacheTagHelper's enabled property. 2015-04-09 13:21:47 -07:00
Doug Bunting 8965ac96c0 Add more functional tests of cache profiles 2015-04-08 22:37:45 -07:00
Harsh Gupta 58a5ad2279 Adding Outputformatter in resource filters. 2015-04-08 16:46:46 -07:00
Ajay Bhargav Baaskaran f60896bd90 [Fixes #2259] Use fast property setter in MutableObjectModelBinder 2015-04-08 16:44:30 -07:00
Victor Hurdugaci 5164d647c5 React to resource renames 2015-04-08 15:27:51 -07:00
sornaks 645b82d194 Fixing the build break. 2015-04-08 14:30:19 -07:00
sornaks b08a2154c1 #2142: Introducing enabled attribute for CacheTagHelper. 2015-04-08 13:27:03 -07:00
Pranav K 43e24b2aad Removing IInputFormatterSelector
Follow up work item to #2269
2015-04-08 07:35:48 -07:00
Pranav K f280353a56 Merge branch 'release' into dev 2015-04-08 07:18:56 -07:00
Pranav K 8c8992fa9c Reacting to ICompilationMessage line indexes changing to be 1-based. 2015-04-07 21:38:46 -07:00
Doug Bunting cef32d4098 React to aspnet/razor#320 fix
- Razor PR aspnet/Razor#350
2015-04-07 17:50:58 -07:00
Doug Bunting 73e8fc10e4 Automatically use `type="number"` for expressions of more types
- #2261
- include `short`, `ushort`, `float`, `double`

- correct typo in `<input/>` tag helper; ignored calculated format
 - only one test for `<input/>`'s calculated format 😦
- fill some `Editor*()` and `<input/>` tag helper test gaps

nit: clean up some trailing whitespace
2015-04-07 17:19:08 -07:00
N. Taylor Mullen 03dabb5950 Update .travis.yml and appveyor.yml to build quietly. 2015-04-07 16:16:05 -07:00
N. Taylor Mullen df13245be3 Merge branch 'release' into dev 2015-04-07 14:47:21 -07:00
N. Taylor Mullen a8d5bb934d Add serviceable attribute to projects.
aspnet/DNX#1600
2015-04-07 14:47:02 -07:00
Pranav K f9d53e341c * Simplify MvcOptions
* Remove facades for accessing Options<T> and pass options to the invoker

Fixes #2266
Fixes #2269
2015-04-07 14:45:53 -07:00
Doug Bunting 689f5bfa79 Use `XmlAssert` to avoid functional test failures
- #2311

nit: rewrap lines for consistency and to remove orphans
2015-04-07 11:46:38 -07:00
Doug Bunting 94721f09a9 Remove duplicate tests
- duplication in data sets confuses xUnit
2015-04-07 11:00:45 -07:00
sornaks 7e2420b93c Reacting to AppendFormat changes in Razor. 2015-04-07 08:40:05 -07:00
Harsh Gupta 0c0fa10ed0 Fixes 2307. MutableObjectBinder now relies on ModelMetadata to decide if a type is a complex type.
This avoids reflection at multiple places and allows caching.
2015-04-06 13:17:39 -07:00
Kiran Challa 9330789fe3 Reacting to ILogger api changes 2015-04-04 02:52:43 -07:00
Wei Wang 5c29efc49c Fix AppVeyor git line ending config 2015-04-03 17:18:08 -07:00
Doug Bunting f3ec6f33ae Merge remote-tracking branch 'origin/release' into dev 2015-04-03 12:08:11 -07:00
Doug Bunting 7916cb9c68 Add a few more `<Service/>` items 2015-04-02 22:55:21 -07:00
N. Taylor Mullen 88dc5f73ac Update project.json, code=>compile. Also remove **/*.cs and **/*.vs from compile section. These are now defaulted to on. 2015-04-02 16:17:54 -07:00
Doug Bunting 393aa54545 Update .xproj files for Microsoft.Web.AspNet.* -> Microsoft.DNX.* rename 2015-04-02 13:49:27 -07:00
Pranav K 6058ad084e Reacting to diagnostics error page changes 2015-04-02 12:42:17 -07:00
Troy Dai 833cb1e820 Update global.json, sources=>projects 2015-04-02 09:20:21 -07:00
N. Taylor Mullen 7aa73bb294 Turn off sudo for .travis.yml. 2015-04-01 17:06:59 -07:00
Pranav K f6ad0a32f0 Tables aren't cool anymore 2015-04-01 16:18:33 -07:00
Pranav K 72f34c5a55 Adding AppVeyor and Travis build status to README 2015-04-01 16:10:46 -07:00
N. Taylor Mullen 2de7c173ab Add travis and appveyor CI support. 2015-04-01 15:53:39 -07:00
Pranav K a4f3b86865 Prevent RazorErrorExtensions.ToDiagnostics from throwing when it
encounters SourceLocation.Undefined \ negative error lengths
2015-04-01 13:51:29 -07:00