29647fda33
[ Fixes #5801 ] Move call to validate constructor in ComplexTypeModelBinder into CreateModel
2017-02-15 12:33:01 -08:00
38e1e7d14e
React to aspnet/Razor#996
2017-02-14 15:11:39 -08:00
eb820106e2
Generate the class name from relative path
2017-02-14 09:41:05 -08:00
44048331e9
Make `ViewComponent.View()` overloads respect explicitly passed in model even when `null`
2017-02-13 17:08:48 -08:00
35edc299d7
Fix test failures
...
Fixes #5794
2017-02-13 12:03:10 -08:00
2cdd84f437
Remove pranav's hack
...
This is part 1 of the right fix for the directive getting removed. This
pass has the wrong order, an it should be running sooner before the
directive is processed by the default processor.
2017-02-13 09:23:58 -08:00
af5648c1f7
Merge branch 'rel/1.1.2' into dev
2017-02-13 08:34:18 -08:00
531c11df2a
Fix 5594 - ExceptionHandled + Result is broken
...
This change ensures that setting ExceptionContext.Result will always
execute if set. The problem with 1.1.0 is that when we had a real short
circuit the wrong set of conditions were checked. I suspect that when you
set ExceptionFilter.Result and didn't short circuit that result filters
were also running (which is a bug).
Added a few tests that verify that the result doesn't trigger result
filters.
I did some general cleanup on this code path to make the state transitions
more clear.
No exception was thrown -> BeginResult
Exception was handled -> ExceptionHandled
Exception was not handled -> gets rethrown
2017-02-13 07:58:32 -08:00
4bddb5ff1b
Small follow up to 8ee3d45
...
- rename `containsIndexers` to `doNotCache` in `ExpressionHelper`
2017-02-10 16:46:55 -08:00
fc40985412
Merge branch 'rel/1.1.2' into dev
2017-02-10 14:55:32 -08:00
8ee3d45ef1
Do not cache expressions containing method calls
...
- #5655
- also make `ExpressionTextCache` more robust for defence-in-depth
nits:
- two `null` expression nodes are equal
- declare data properties as `TheoryData<T>`
2017-02-10 14:50:09 -08:00
1652bf554f
Workaround APICheck errors
2017-02-10 12:46:15 -08:00
842d661ac2
[ Fixes #5698 ] Regression in 1.1 model binding for model types without default constructor
...
- Also reverts "Check for default constructor in ComplexTypeModelBinderProvider" commit d09e921c4a
2017-02-10 11:10:02 -08:00
bc3a741eee
Use DocumentClassifierPassBase
...
Workaround issue with the model directive disappearing
2017-02-09 20:30:31 -08:00
8b03e9ef73
Make PageStart work
...
Move more API to RazorPageBase
2017-02-09 18:23:01 -08:00
bd9e431873
Order IgnoreAntiforgeryTokenAttribute and add test ( #5765 )
2017-02-08 09:37:43 -08:00
f474d8bc52
React to optional Razor directive token feature
2017-02-07 21:58:31 -08:00
9264f3aa2d
Add TryUpdateModelAsync to pages
2017-02-07 21:16:40 -08:00
314aa366e1
Add TempData property support for Pages
2017-02-07 15:27:02 -08:00
690ef186a3
Add PageActionDescriptorChangeProvider to allow reloading on page changes
2017-02-07 12:53:44 -08:00
2ff80ffb49
Porting DefaultPageHandlerMethodSelector and ExecutorFactory
2017-02-07 12:44:27 -08:00
624909763b
Make _PageImports work
...
Add support for generating the Model property
2017-02-07 11:13:15 -08:00
9f3dfd9819
Make RazorPages work E2E
2017-02-06 19:05:31 -08:00
c349929cc1
Port old Razor tests to new Razor
2017-02-03 17:09:18 -08:00
8d5abd433f
Add support for PageStarts
2017-02-03 15:57:00 -08:00
c95c2a5a6d
[ Fixes #5686 ] Extend `ModelMetadata` to reduce ugliness
2017-02-03 11:37:28 -08:00
dc0be8d747
SaveTempDataFilter handle write to body
...
(cherry picked from commit 03cdd15e5c
2017-02-03 10:41:36 -08:00
cf70ed663b
Merge tag 'rel/1.1.1' into dev
2017-02-03 10:31:17 -08:00
1777f7babd
Enabling Razor Instrumentation
2017-02-01 15:29:09 -08:00
4c62eb89af
Unit tests for VCTH and model directive
2017-01-31 13:14:20 -08:00
705369ee51
Add unit tests for ModelExpressionPass
...
Add unit tests for @inject
2017-01-30 19:08:39 -08:00
b79f8384b0
Make some methods public for ViewCompilation.
2017-01-30 13:46:27 -08:00
84d2e027f5
Use new Razor in MVC
2017-01-30 10:55:49 -08:00
7449ffad74
Add include and exclude attributes to EnvironmentTagHelper
...
Addresses #5671
2017-01-27 14:46:53 -08:00
d44c9aee1e
Added printing of route values when a route is not matched
2017-01-27 11:31:05 -08:00
17dc23a024
[ Fixes #5637 ] Make CookieName of CookieTempDataProvider configurable
2017-01-27 11:01:26 -08:00
03cdd15e5c
SaveTempDataFilter handle write to body
2017-01-27 10:54:00 -08:00
3e214e2399
Introducing IPageModelActivatorProvider
...
Fixes #5480
2017-01-26 11:31:14 -08:00
9b1271ba19
Remove obsolete DefaultHtmlGenerator ctor ( #5711 )
2017-01-25 16:25:12 -08:00
42ae78a360
[ Fixes #5012 ] ProducesAttribute should not inherit from ResultFilterAttribute
2017-01-25 14:00:35 -08:00
8ac6b6699f
[ Fixes #4945 ] Simple string returned by controller action is not a valid JSON!
2017-01-25 13:29:18 -08:00
5885feb7c0
Fixes a parsing bug with the AcceptHeaderParser
...
When we find an invalid character at the end of a media type value we
should advance and skip over it.
2017-01-23 13:12:40 -08:00
305748a800
Move classes out of .Internal
2017-01-19 11:11:28 -08:00
6396e14504
Add null-check back to MediaType
2017-01-18 16:56:08 -08:00
6f7fc4fb34
Remove obsolete ViewEngine ( #5699 )
2017-01-18 16:29:20 -08:00
24efd4268b
Pin the version of RazorTooling packages to 1.1.0-preview4-final
2017-01-17 11:55:15 -08:00
e749a80b30
Check for empty location in ViewsFeatureProvider
...
Fixes #5675
2017-01-17 11:07:48 -08:00
ce53675b87
Add `[ValidateNever]` and `IPropertyValidationFilter`
...
- #5642
- lazy-load `ValidationEntry.Model`
- avoids `Exception`s when moving to a property that will not be validated
nits:
- remove duplicate code in `ValidationVisitor`
- clarify "all properties of" doc comments
- also add missing `<param>` doc in `ViewDataInfo`
2017-01-15 21:40:29 -08:00
07c22f2b29
Mutate API description parameter type from JsonPatchDocument to Operation[]
...
Addresses #5464
2017-01-13 16:39:08 -08:00
f95d49c870
Change datetime to datetime-local
...
Addresses #4871
2017-01-13 15:40:30 -08:00
93774a0234
Mitigate MediaType overflow
2017-01-13 12:51:19 -08:00
a7abdeabcd
Introducing PageActionInvoker
2017-01-13 11:49:02 -08:00
13b32adeae
Move InvokeAsync to ResourceInvoker
2017-01-11 11:13:05 -08:00
6b0282fa84
Commonize code from ControllerActionInvokerCache and PageFilterFactoryProvider
2017-01-11 10:53:23 -08:00
9cc20ff114
Edited docs, removed unnecessary usings for ApiDescription ( #5634 )
...
Addresses #5625
2017-01-04 17:44:47 -08:00
473337ea33
CompositeChangeToken moved to aspnet/Common Microsoft.Extensions.Primitives
...
Addresses Common Issue aspnet/Common#163
2017-01-04 17:32:20 -08:00
de0f277892
Fix attribute routing error message related to replace tokens
2017-01-04 15:43:57 -08:00
5070526f43
replaced hardcoded message with Resources.ArgumentCannotBeNullOrEmpty
2017-01-04 10:47:21 -08:00
78492b39d8
Introduce a base type for executing auth and resource filters.
2017-01-03 11:14:15 -08:00
2b8233932a
Add IPageFactory and IPageActivator
2016-12-29 15:11:29 -08:00
9146fce4ec
Add extension method for IParameterModelConvention. ( #5640 )
2016-12-27 16:49:12 -08:00
2b50ec99df
Updating to 4.4 CoreFx packages
2016-12-21 16:47:14 -08:00
b2340d327e
Order IgnoreAntiforgeryTokenAttribute and add test
2016-12-12 14:55:36 -08:00
cfa9631ce8
Resolve path traversals in RazorViewEngine
...
This change moves the onus of path resolution from individual IFileProvider instances to RazorViewEngine.
Fixes #5574
Fixes https://github.com/aspnet/MvcPrecompilation/issues/33
2016-12-08 11:20:06 -08:00
de1b763d96
Update IControllerModelConvention.cs
2016-12-07 11:11:57 -08:00
b2f0438562
Fixing comment typo
2016-12-07 11:10:54 -08:00
6fbe514626
Fixing comment typos
2016-12-07 11:07:31 -08:00
1dd1d49321
Redirects with fragment ( #5519 )
...
- Added implementation of overloads where you can specify the fragment to redirect to.
- Added unit tests
- Added XML comments, including missing documentation of existing members
2016-12-06 10:32:01 -08:00
7178464ed2
Munch on less memory when handling property metadata
...
- #5499
- switch `foreach` to `for` and use less Linq when accessing `modelMetadata.Properties`
- change backing field for `ModelExplorer.Properties` from a list to an array
2016-12-05 20:47:45 -08:00
48546dbb28
Add more to `MvcCoreServiceCollectionExtensionsTest`
...
- 2nd half of #5554
- follow-on to #5540 PR
2016-12-05 20:05:24 -08:00
f32d0f2505
Update MvcCoreServiceCollectionExtensions.cs
2016-12-05 20:01:30 -08:00
8f8bf5af34
Seperate view and model for enum display
2016-11-30 11:13:38 -08:00
52ee9afc31
Adding PageActionDescriptorProvider
...
Fixes #5353
2016-11-23 16:53:06 -08:00
74c9194aee
Pinning versions for 1.1.0 release
2016-11-18 12:12:52 -08:00
2bacb6003f
Fix typo in XML doc
2016-11-18 10:56:46 -08:00
975dc212b7
Fix package versions
2016-11-17 10:19:48 -08:00
c5a5ba1fee
Add support for updateable ActionDescriptorCollection
...
Fixes #5350
2016-11-17 10:08:38 -08:00
29cd24f66b
Add Microsoft.AspNetCore.Mvc.RazorPages projects
2016-11-17 10:08:38 -08:00
5deda80e5a
Downgrade Microsoft.Extensions.DependencyModel to 1.1.0
2016-11-09 18:16:49 -08:00
b82969a557
Updating versions to 1.2.0-*
2016-11-09 14:18:46 -08:00
7c05d62a6e
Use request PathBase value to set cookie path only if it has a non-null & non-empty value
2016-11-09 04:43:08 -08:00
6d4361218e
Add builder extensions to simplify use of `CookieTempDataProvider`
...
- #5515
2016-11-08 15:32:09 -08:00
576c0e6a65
Throw an exception if configurationType to CreateConfigureDelegate is abstract/has no parameterless ctor
...
Addresses #5431
2016-11-08 14:16:03 -08:00
07a2f1de06
Fixes CookieTempDataProvider to set the secure attribute of a cookie only if a request is secure
2016-11-08 13:30:28 -08:00
a3c06b00cc
Fixes CookieTempDataProvider to handle empty request PathBase while setting cookie options
2016-11-08 13:30:27 -08:00
24d5dfb552
Dynamic assembly checks to prevent NotSupprotedExceptions from System.Reflection.Emit
...
Fixes #5487
2016-11-07 12:49:49 -08:00
9caa688a30
Modified exception message for duplicate keys exception in CandidateResolver
...
Addresses #5289
2016-11-07 11:16:11 -08:00
304000095a
Added logging for precompiled views in RazorViewEngine
...
Addresses #5462
2016-11-07 10:46:54 -08:00
bfe50ddd8c
Created public API baselines
2016-11-04 23:53:26 -07:00
abd80b5f07
Remove unused source package references.
2016-11-04 15:58:20 -07:00
0cee00aae1
[ Fixes #5352 ] When replacing Controller.Dispose with an explicit implementation the base Dispose is an action
2016-11-04 09:34:30 -07:00
7985121bab
[ Fixes #5207 ] Support IsIndexer for ViewComponent tag helpers
2016-11-03 16:50:22 -07:00
63d7d35bd2
Filter out generic invoke methods in ViewComponents
2016-11-03 15:15:44 -07:00
f04286562e
Treat `ContentType==null` and `MediaType.GetEncoding(ContentType)==null` differently
...
- now, if client sends e.g. `Content-type: text/json;charset=[invalid]`, service will respond with HTTP/415
- if client sends `Content-type: text/json`, service will still try UTF-8 (or updated default encoding)
- intentional (and slight) behaviour change from 1ac7315
2016-11-03 10:51:39 -07:00
116c927e61
Revert "Do not call `Encoding.GetEncoding()` with a string from the request"
...
- #5351 should be Won't Fix
This reverts commit 1ac731519a
2016-11-03 10:51:39 -07:00
01b237dda9
Antiforgery goes at the end of filters
2016-11-02 16:50:27 -07:00
c28ad48e98
[ Fixes #5216 ] Make generic parameters work with ViewComponent tag helpers
2016-11-02 15:55:23 -07:00
ea701f2cd6
Added UserClaimsPrincipal to ViewComponent
...
Addresses #4964
2016-11-02 10:30:22 -07:00
32710bbfbe
[ #5430 ] CookieTempDataProvider chunking broken
2016-11-01 16:13:27 -07:00
5d5b282dbd
Moved CaseSensitiveTagHelperAttributeComparer to Razor.TagHelpers.Testing.Sources
...
Addresses #5323
2016-11-01 14:51:37 -07:00
Kiran Challa
Ajay Bhargav Baaskaran
Pranav K
Ryan Nowak
Doug Bunting
Ryan Brandenburg
Jass Bagga
Joonas Westlin
hiiru
Steve Smith
Joonas Westlin
Daniel Roth
Julian Dominguez
Marcus Schweda
jacalvar
N. Taylor Mullen