Commit Graph

42564 Commits

Author SHA1 Message Date
Rick Anderson 28f9816d46 Remove please from QR code (#11971) 2019-07-10 08:59:34 -07:00
WuYafeng d061d0d95b Resolve #11727 (#11957)
* Resolve #11727

- Add a BuildServiceProviderValidator for checking startup method 'ConfigureServices(IServiceCollection,..)'

* Fix file name and class name not match

* Resolve conversation:
- helpLink point to 'aka.ms'
- Update DiagnosticDescriptor title
- Update DiagnosticDescriptor messageFormat
2019-07-10 08:46:32 -07:00
Pranav K d0a69f9860 Json Options (dotnet/extensions#1993)
\n\nCommit migrated from 912ab18694
2019-07-10 07:54:15 -07:00
Steve Sanderson 3c42f4436f Bring back required export jsCallDispatcher.findJSFunction (dotnet/extensions#2002)
\n\nCommit migrated from 5350efd2f4
2019-07-10 12:12:11 +01:00
Doug Bunting 716bc8dce9
Merge branch 'release/2.1' => 'release/2.2' (#12009) 2019-07-09 19:09:40 -07:00
Ryan Nowak 99e99c167a Add some tests for invalid data 2019-07-09 16:57:57 -07:00
Ryan Nowak 138a24c79c Add globalization support for forms
Updates our form controls to behave correctly when used
in non-en-US cultures.

Adds E2E tests for the same
2019-07-09 16:57:57 -07:00
Ryan Nowak 80f71bcd1f Support more cases for date parsing
We didn't have support for DateTimeOffset, nor support for parsing
formats with nullable DateTime.

Added E2E tests for bind + DateTime/DateTimeOffset.

Added E2E tests for 'manual bind' with number and date field. These
can't use `@bind` without a compiler update. This PR will add the
runtime support we need, so we can update the compiler.
2019-07-09 16:57:57 -07:00
Ryan Nowak 1e6739f108 Add globalization tests
Adds tests for current culture bind with text fields

This already functions correctly without new features or modifications.
2019-07-09 16:57:57 -07:00
Ryan Nowak 6d1ef39dcc Add server-side localization test. 2019-07-09 16:57:57 -07:00
N. Taylor Mullen 8c67a6ebc6 Add Components analyzer flag to ensure no analyzer duplicates.
- Chose the name `DisableImplicitComponentAnalyzers` (DICA) to not conflict with `DisableImplicitAspNetCoreAnalyzers` (DIAA). The goal with this flag is that in the SDK we can read its value and do one of the following:

| DICA    | DIAA    | Action                                                                                                     |
|---------|---------|------------------------------------------------------------------------------------------------------------|
| `true`  | `true`  | No component analyzers added from SDK, remove the component analyzers that were added from the package ref |
| `true`  | `false` | No component analyzers added from SDK                                                                      |
| `false` | `true`  | No component analyzers added from SDK                                                                      |
| `false` | `false` | Component analyzers added in SDK                                                                           |

#8825
2019-07-09 16:17:36 -07:00
Doug Bunting c07d39d746
Update dependencies from 5 repositories (#11939)
* Update dependencies from build '20190706.1' of 'https://github.com/dotnet/arcade'
  - 'Microsoft.DotNet.Arcade.Sdk': '1.0.0-beta.19351.4' => '1.0.0-beta.19356.1'
  - 'Microsoft.DotNet.GenAPI': '1.0.0-beta.19351.4' => '1.0.0-beta.19356.1'
  - 'Microsoft.DotNet.Helix.Sdk': '2.0.0-beta.19351.4' => '2.0.0-beta.19356.1'

* Update dependencies from build '20190706.2' of 'https://github.com/dotnet/roslyn'
  - 'Microsoft.Net.Compilers.Toolset': '3.3.0-beta1-19351-01' => '3.3.0-beta2-19356-02'

* Update dependencies from build '20190706.5' of aspnet/AspNetCore-Tooling
  - 'Microsoft.AspNetCore.Mvc.Razor.Extensions': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19356.5'
  - 'Microsoft.AspNetCore.Razor.Language': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19356.5'
  - 'Microsoft.CodeAnalysis.Razor': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19356.5'
  - 'Microsoft.NET.Sdk.Razor': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19356.5'

* Update dependencies from build '20190705.1' of 'https://github.com/aspnet/Blazor'
  - 'Microsoft.AspNetCore.Blazor.Mono': '0.10.0-preview8.19351.2' => '0.10.0-preview8.19355.1'

* Update dependencies from from build '20190704.5' of 'https://github.com/aspnet/EntityFrameworkCore'
  - 'Microsoft.EntityFrameworkCore.Tools': '3.0.0-preview8.19353.14' => '3.0.0-preview8.19354.5'
  - 'Microsoft.EntityFrameworkCore.SqlServer': '3.0.0-preview8.19353.14' => '3.0.0-preview8.19354.5'
  - 'dotnet-ef': '3.0.0-preview8.19353.14' => '3.0.0-preview8.19354.5'
  - 'Microsoft.EntityFrameworkCore': '3.0.0-preview8.19353.14' => '3.0.0-preview8.19354.5'
  - 'Microsoft.EntityFrameworkCore.InMemory': '3.0.0-preview8.19353.14' => '3.0.0-preview8.19354.5'
  - 'Microsoft.EntityFrameworkCore.Relational': '3.0.0-preview8.19353.14' => '3.0.0-preview8.19354.5'
  - 'Microsoft.EntityFrameworkCore.Sqlite': '3.0.0-preview8.19353.14' => '3.0.0-preview8.19354.5'

Coherency updates...
  - 'Microsoft.AspNetCore.Analyzer.Testing': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.AspNetCore.BenchmarkRunner.Sources': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.ActivatorUtilities.Sources': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Caching.Abstractions': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Caching.Memory': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Caching.SqlServer': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Caching.StackExchangeRedis': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.CommandLineUtils.Sources': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Configuration.Abstractions': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Configuration.AzureKeyVault': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Configuration.Binder': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Configuration.CommandLine': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Configuration.EnvironmentVariables': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Configuration.FileExtensions': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Configuration.Ini': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Configuration.Json': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Configuration.KeyPerFile': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Configuration.UserSecrets': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Configuration.Xml': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Configuration': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.DependencyInjection.Abstractions': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.DependencyInjection': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.DiagnosticAdapter': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Diagnostics.HealthChecks': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.FileProviders.Abstractions': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.FileProviders.Composite': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.FileProviders.Embedded': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.FileProviders.Physical': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.FileSystemGlobbing': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.HashCodeCombiner.Sources': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Hosting.Abstractions': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Hosting': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.HostFactoryResolver.Sources': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Http': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Localization.Abstractions': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Localization': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Logging.Abstractions': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Logging.AzureAppServices': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Logging.Configuration': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Logging.Console': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Logging.Debug': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Logging.EventSource': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Logging.EventLog': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Logging.TraceSource': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Logging.Testing': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.ObjectPool': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Options.ConfigurationExtensions': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Options.DataAnnotations': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Options': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.ParameterDefaultValue.Sources': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.Primitives': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.TypeNameHelper.Sources': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.ValueStopwatch.Sources': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Extensions.WebEncoders': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Internal.Extensions.Refs': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.JSInterop': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Mono.WebAssembly.Interop': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Internal.AspNetCore.Analyzers': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'
  - 'Microsoft.AspNetCore.Testing': '3.0.0-preview8.19353.10' => '3.0.0-preview8.19354.4'

  - 'Microsoft.Extensions.DependencyModel': '3.0.0-preview8-27903-07' => '3.0.0-preview8-27904-06'
  - 'Microsoft.NETCore.App.Ref': '3.0.0-preview8-27903-07' => '3.0.0-preview8-27904-06'
  - 'Microsoft.NETCore.App.Runtime.win-x64': '3.0.0-preview8-27903-07' => '3.0.0-preview8-27904-06'
  - 'NETStandard.Library.Ref': '2.1.0-preview8-27903-07' => '2.1.0-preview8-27904-06'

  - 'Microsoft.Bcl.AsyncInterfaces': '1.0.0-preview8.19353.3' => '1.0.0-preview8.19354.4'
  - 'Microsoft.CSharp': '4.6.0-preview8.19353.3' => '4.6.0-preview8.19354.4'
  - 'Microsoft.NETCore.Platforms': '3.0.0-preview8.19353.3' => '3.0.0-preview8.19354.4'
  - 'Microsoft.Win32.Registry': '4.6.0-preview8.19353.3' => '4.6.0-preview8.19354.4'
  - 'System.ComponentModel.Annotations': '4.6.0-preview8.19353.3' => '4.6.0-preview8.19354.4'
  - 'System.Diagnostics.EventLog': '4.6.0-preview8.19353.3' => '4.6.0-preview8.19354.4'
  - 'System.IO.Pipelines': '4.6.0-preview8.19353.3' => '4.6.0-preview8.19354.4'
  - 'System.Net.Http.WinHttpHandler': '4.6.0-preview8.19353.3' => '4.6.0-preview8.19354.4'
  - 'System.Net.WebSockets.WebSocketProtocol': '4.6.0-preview8.19353.3' => '4.6.0-preview8.19354.4'
  - 'System.Reflection.Metadata': '1.7.0-preview8.19353.3' => '1.7.0-preview8.19354.4'
  - 'System.Runtime.CompilerServices.Unsafe': '4.6.0-preview8.19353.3' => '4.6.0-preview8.19354.4'
  - 'System.Security.Cryptography.Cng': '4.6.0-preview8.19353.3' => '4.6.0-preview8.19354.4'
  - 'System.Security.Cryptography.Pkcs': '4.6.0-preview8.19353.3' => '4.6.0-preview8.19354.4'
  - 'System.Security.Cryptography.Xml': '4.6.0-preview8.19353.3' => '4.6.0-preview8.19354.4'
  - 'System.Security.Permissions': '4.6.0-preview8.19353.3' => '4.6.0-preview8.19354.4'
  - 'System.Security.Principal.Windows': '4.6.0-preview8.19353.3' => '4.6.0-preview8.19354.4'
  - 'System.ServiceProcess.ServiceController': '4.6.0-preview8.19353.3' => '4.6.0-preview8.19354.4'
  - 'System.Text.Encodings.Web': '4.6.0-preview8.19353.3' => '4.6.0-preview8.19354.4'
  - 'System.Text.Json': '4.6.0-preview8.19353.3' => '4.6.0-preview8.19354.4'
  - 'System.Threading.Channels': '4.6.0-preview8.19353.3' => '4.6.0-preview8.19354.4'

* React to new transitive dependencies
- see dotnet/corefx#38908

nit: remove duplicate URL for the dotnet-core blob feed

* Remove `.Layouts` namespace from Blazor (thanks @rynowak)

* fix one more straggler (thanks @rynowak)
2019-07-09 15:19:03 -07:00
John Luo 146a483852 Revert unnecessary change from merge 2019-07-09 15:11:04 -07:00
Hao Kung d48ad7a971
DataProtection: Refresh key rings for a short window (#11987) 2019-07-09 13:42:20 -07:00
Isaac Levin 395be9d851 reference minified js in templates 2019-07-09 14:43:32 -04:00
Doug Bunting ae5b18d459
Merge branch 'release/2.1' into release/2.2 2019-07-09 11:28:17 -07:00
Justin Kotalik 3fd32ac7e1
Make native builds work when launching the IIS repo from VS and speed up local builds (#11805) 2019-07-09 08:21:10 -07:00
Justin Kotalik 401a90633b
Await dispose for inner stream before disposing SslStream. (#11819) 2019-07-09 08:20:10 -07:00
Steve Sanderson 86b55046c9 In JSInterop calls, use expected value for 'this'. Fixes dotnet/extensions#1477 (dotnet/extensions#1990)
\n\nCommit migrated from a664ecb5b3
2019-07-09 12:40:20 +01:00
Ryan Nowak 59d636f6bd
Make some MVC routing types public again (#11969)
* Make some types public again

We've heard some demand to make these types public again after trying
them as internal.

API Versioning calls the action selector and handles
AmbiguousActionException to give more specific responses.

API Versioning (and others) look for HttpMethodActionConstraint to
determine the supported HTTP methods of an IRouter-based action method.

* fix the build
2019-07-08 20:59:56 -07:00
Ryan Nowak 69785904cf
Blazor API review changes: CompilerServices (#11911)
* Blazor API review changes: CompilerServices

Fixes: #11907

These are the changes from the compiler-related API review that are safe
to make (these methods are not used).

I'll follow up with `BindMethods.GetValue` separately because that's
used by the compiler.
2019-07-08 20:01:40 -07:00
Ryan Brandenburg 6ef6930b1b PR feedback 2019-07-08 14:37:20 -07:00
Ryan Brandenburg 97a039f154 PR feedback
\n\nCommit migrated from d656c4f7e2
2019-07-08 14:37:20 -07:00
Ryan Brandenburg 0ef640d043 More doc comments 2019-07-08 14:37:20 -07:00
Ryan Brandenburg f8b525f02d PR feedback
\n\nCommit migrated from 2e1cfcd1f9
2019-07-08 14:37:20 -07:00
Ryan Brandenburg 8bce347b3b Add some missing doc comments 2019-07-08 14:37:20 -07:00
Ryan Brandenburg 25cad453f4 More doc comment additions
\n\nCommit migrated from 551e7c269a
2019-07-08 14:37:20 -07:00
Ryan Brandenburg 109d388e5e More doc comments
\n\nCommit migrated from d3cad4c787
2019-07-08 14:37:20 -07:00
Ryan Brandenburg bd0623bf72 Fix generic <see references
\n\nCommit migrated from 72d4e3ad79
2019-07-08 14:37:20 -07:00
Ryan Brandenburg a61d9b6921 Add some missing doc comments
\n\nCommit migrated from 238b272238
2019-07-08 14:37:20 -07:00
N. Taylor Mullen b647a223f7 Add analyzer to expect public properties for component parameters.
- If we find a parameter that is non-public we will create a warning for that situation and notify the user.
- Updated the naming of existing properties and classes that referred to public/private required properties to be specific to those properties setters (that's what they verified before these changes).
- Updated test expectations and names.
- Changed the code fix provider to no longer worry about the property setters and instead inspect the properties declared accessibility. Did not re-add the property setter code fix provider because these code fix providers do nothing in practice (Razor light bulbs aren't enabled in the editor).
- Added new tests.

#8825
2019-07-08 13:56:16 -07:00
John Luo e31813b9cd
Add support for source-build (#11717) 2019-07-08 11:02:30 -07:00
Ryan Brandenburg 57a344d90e
Merge pull request #11553 from isaac2004/10935-work
Remove Razor Pages specific things from the MVC (Model-View-Controller) template #10935
2019-07-08 10:56:08 -07:00
Artak 9f9e28719a
Updated npm dependencies (#11967) 2019-07-08 10:54:38 -07:00
Pranav K 4c67855ccf
Correct the log message for IAsyncEnumerable (#11607) 2019-07-08 09:13:35 -07:00
Alessio Franceschelli adc0043c2a Mvc.Core logging for controller and page factories (#11526)
* Mvc.Core logging for controller and page factories

* Fixed name in loosely related test

* Renamed model to page model

* Extensions tests

* Controller Tests

* Page tests
2019-07-08 07:43:08 -07:00
Steve Sanderson 6534bcff32
Expand Blazor logging (#11919) 2019-07-08 13:50:19 +01:00
Doug Bunting 0049c5899c Stop shipping a runtime.dev.json file
- #10958
- publish _both_ `dotnet-getdocument` and `GetDocumentInsider` before packing
- simplify how Microsoft.Extensions.ApiDescription.Server gets published files for the tools

nit: correct information in a comment
2019-07-05 21:44:56 -07:00
Ryan Nowak 69a7037480 Revert "Remove some dead code in Blazor hosting"
This reverts commit d8b1af39f0.

This wasn't dead-code after all. Removing this code breaks the
Components functional tests (at least running locally).
2019-07-05 20:18:54 -07:00
dotnet-maestro[bot] 38e18ff183 [master] Update dependencies from AspNetCore-Tooling (#11878)
* Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190703.10
- Microsoft.NET.Sdk.Razor - 3.0.0-preview8.19353.10
- Microsoft.CodeAnalysis.Razor - 3.0.0-preview8.19353.10
- Microsoft.AspNetCore.Razor.Language - 3.0.0-preview8.19353.10
- Microsoft.AspNetCore.Mvc.Razor.Extensions - 3.0.0-preview8.19353.10
2019-07-05 12:21:38 -07:00
dotnet-maestro[bot] 3146b77890 [master] Update dependencies from dotnet/arcade (#11744)
* Update dependencies from https://github.com/dotnet/arcade build 20190701.4
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19351.4
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19351.4
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19351.4
2019-07-05 12:18:14 -07:00
Doug Bunting 025476f31e
Merge branch 'release/3.0-preview7' => 'master' (#11784) 2019-07-05 09:59:53 -07:00
John Luo 99ee868090
Resolve Guid inputs correctly (#11865) 2019-07-05 09:46:26 -07:00
Doug Bunting 93b1043dff
Avoid TypeScript warnings 2019-07-05 08:19:52 -07:00
Steve Sanderson 6f6d099113
Make ArrayBuilder<T>.ToSegment() safe even when reusing underlying arrays (#11903) 2019-07-05 16:01:53 +01:00
Javier Calvarro Nelson 7d545d40aa
Javiercn/js interop improvements part 1 (#11809)
* Adds exception sanitization to RemoteJSRuntime
* Adds default async timeouts of 1 minute for JS async calls to server-side blazor
2019-07-05 16:28:41 +02:00
Steve Sanderson b31cd35f92 Ensure DI scope is disposed if prerendering fails 2019-07-05 09:41:04 +01:00
Steve Sanderson ee1cbda155 Ensure CircuitHost disposes DI scope even if other disposals throw 2019-07-05 09:41:04 +01:00
Javier Calvarro Nelson 919734cbb2 Invoking a method with an invalid dotnetobjectref bubbles up through the wrong path (dotnet/extensions#1940)
* Handle non existing dotnet object references and returns the error through JSInterop instead of bubbling it up to the caller.
* Every other error in JSInterop is returned that way.
* It makes sure that the error gets to the client and is sanitized appropriately if necessary.\n\nCommit migrated from a30f2cbb27
2019-07-05 10:16:39 +02:00
Ryan Nowak 002cb51d72
Cleanup of components based on CaptureUnmatchedAttributes (#11580)
Part of #10713

This change addresses the cleanup of the form components by removing the
Id and Class parameters as explicit parameters. These components will
now propagate the id and class attributes to the created HTML element
without the need for explicit parameters.

Note that we preserve the combining behaviour of class with FieldClass.

* Update NavLink to use new features

Simplifies the design of NavLink to use our new features for capturing
unmatched attributes. I can't run the functional tests locally so I hope
this works....
2019-07-04 22:37:23 -07:00