751a0e2e7e
Better checks for connection reset in RequestTests.ConnectionReset* tests ( #1517 )
2017-03-21 19:35:41 -07:00
72587baac3
Check that MaxRequestBufferSize is greater than or equal to MaxRequestHeadersTotalSize ( #1491 ).
2017-03-21 19:25:56 -07:00
6c131ea240
Verify scopeids are connectable using Socket before testing Kestrel ( #1536 )
2017-03-21 18:31:29 -07:00
32d6b42964
Respond to corefxlab rename (build break) ( #1529 )
2017-03-21 08:43:49 -07:00
cf576559b6
Fix write after close ( #1526 )
...
- Change Alloc to be a Write with a callback that exposes the WritableBuffer.
This allows the ISocketOutput to implementation to not call the callback if
the underlying socket is dead.
- Added a new functional test
2017-03-20 23:58:26 -07:00
3b40ba52ca
Check if request is aborted before verifying response bytes written ( #1498 ).
2017-03-20 16:02:25 -07:00
8923b0da70
Use correct config for response buffer limit ( #1516 )
2017-03-20 15:43:55 -07:00
2ed456fd68
Faster Write implementation using cpblk ( #1511 )
...
* Faster Write implementation
- Use Unsafe.CopyBlockUnaligned to copy bytes to the
WritableBuffer. This is temporary until we get newer
corefx bits with a better span.CopyTo implementation.
- Remove WritableBufferExtensions from Performance project
- Split method into WriteFast and WriteMultiBuffer
- Cache the span for the common case where
the buffer is non empty.
- Use ref locals instead of pinning pointers in fast path
2017-03-19 12:44:01 -07:00
1094cc0670
Use StreamSocketOutput for writing benchmarks ( #1507 )
...
- Use StreamSocketOutput with a null stream to get a
better picture of what actual performance looks like
2017-03-18 13:20:07 -07:00
5b814a55ac
Speed up WritableBuffer.WriteXxx ( #1504 )
...
* Speed up WritableBuffer.WriteAscii
* Add Benchmarks
* Non-standard header vals are still ascii
* Speedup WriteNumeric
* Don't advance for write
* Remove cruft
2017-03-18 12:25:10 -07:00
07cbf7faa9
Use pipelines for SocketOutput
...
- Changed socket output to be based on pipelines
- Changed connection filter glue to be based on pipelines
- Codegen that used `MemoryPoolIterator` for output now uses `WritableBuffer`
- Made `UvWriteReq` async/await friendly with `LibuvAwaitable<T>`
- Deleted MemoryPool and friends
2017-03-18 00:26:00 -07:00
2ef3804578
Span-based RemoveDotSegments ( #1448 )
2017-03-17 14:42:13 -07:00
9a4a810aa8
Fix race conditions in test event listener
2017-03-15 10:26:09 -07:00
632780dd16
Remove splitting of path and path base ( #1050 ).
2017-03-15 09:57:33 -07:00
d4c0d4b81e
Adds an EventSource named 'Microsoft-AspNetCore-Server-Kestrel' with the following event and properties:
...
ConnectionStart:
- connectionId
- scheme
- localEndPoint
- remoteEndPoint
ConnectionStop:
- connectionId
2017-03-14 16:59:11 -07:00
5073d4fdaf
Re-add .NET Framework to tests and other cleanup ( #1494 )
2017-03-14 11:02:49 -07:00
b94912bcb1
InitializeHeaders only at start of parsing/Fix remaining ( #1488 )
...
* Don't reinitialize header collection each loop
* Correct remaining tracking value
* Add tests
2017-03-13 15:32:28 -07:00
5644310811
Clean up benchmarks ( #1487 )
...
- Benchmarks are suffixed with *Benchmarks
- Removed Custom RpsColumn.cs and used Ops/Second column
- Removed params from RequestParsingBenchmark
2017-03-12 22:52:24 -07:00
49f09d5a25
Log rejected request targets.
2017-03-12 18:37:08 -07:00
f479720d5a
Remove our custom bootstrapper and use the BenchmarkSwitcher ( #1480 )
2017-03-11 18:19:13 -08:00
3c8ee39f1d
Fxi writing perf test ( #1478 )
2017-03-10 12:04:28 -08:00
49b328d4c2
Handle absolute, asterisk, and authority-form request targets
...
Improves compliance with RFC 7230 on the expected handling of requests
that have URI or asterisk in the request target.
This means rejecting asterisk requests that are not OPTIONS and rejecting
authority-form requests taht are not CONNECT.
This also means the server will handle the path and query on targets
with absolute URIs as request-targets.
2017-03-09 16:54:12 -08:00
941d396942
Speed up ParseRequestLine ( #1463 )
2017-03-08 19:27:56 -08:00
63e3c9428a
You can't have two benchmarks as the baseline.
2017-03-08 17:28:13 -08:00
3a1f3d14f9
Add absolute-uri benchmark and change plaintext, live aspnet, and unicode benchmarks to use origin-form
2017-03-08 17:21:21 -08:00
bb973decb8
Unify header rejection messages.
...
- Log bad headers with escaped non-vchar characters
2017-03-08 15:27:44 -08:00
e25eb418bb
Change non-printable char representation in log messages from <0xXX> to \xXX.
2017-03-08 10:05:53 -08:00
13519b6079
Fix CopyTo implementation in benchmark. ( #1462 )
...
* wip
* ooops
2017-03-07 17:39:56 -08:00
5743d740b4
Convert HTTP parsing FrameTests to IHttpParser tests ( #1416 ).
...
- Also fix an issue in KestrelHttpParser where "Header: \r\n" is
parsed with a value of " " instead of "".
2017-03-07 15:51:11 -08:00
e2f8c226ef
Simplify TakeSingleHeader and Vectorize ( #1457 )
...
* Sanitize unsafe code
* Vectorize
* Extract Contains and add more tests
2017-03-07 13:30:57 -08:00
1294c00618
Cleanup unused code ( #1458 )
2017-03-07 11:52:45 -08:00
02a4342908
Made changes to TakeSingleHeader ( #1453 )
...
* Made changes to TakeSingleHeader
- Remove state machine and just parse in place
- Inline OnHeader into TakeSingleHeader
- Use IndexOfVectorized instead of custom indexof
- Normalize header whitespace error
- Combine IndexOf and IndexOfAny into a single IndexOfNameEnd call
2017-03-07 08:58:55 -08:00
06134bc6e0
Add IPv6 loopback address by default #1434
2017-03-06 18:02:28 -08:00
11c7eb5665
Verify all request rejections are logged ( #1295 ).
2017-03-06 12:05:38 -08:00
7d94abd606
Enable default server address test
2017-03-06 10:26:32 -08:00
0404bcc58c
Add more microbenchmarks.
2017-03-06 10:14:22 -08:00
537b06f025
Interleave multispan and single span code path ( #1442 )
...
- Attempt at making the reader better for multispan parsing
- Try tighter inner loop
- Fix boundary case and clean code up
- Update the cursor once instead of after every header
- Fix errors with not updating consumed state on incomplete header payload
- Filled a test hole, removed a condition that should never happen
- Avoid struct copies every iteration when parsing headers
2017-03-06 09:06:28 -08:00
0ce111d9f1
Fix write size in benchmark ( #1449 )
2017-03-06 03:31:45 -08:00
83edc38e72
Use TechEmpower request as baseline for request parsing benchmarks.
2017-03-03 15:55:07 -08:00
de2c3d3608
Merge branch 'KrzysztofCwalina/NewBenchmark' into dev
2017-03-03 15:28:34 -08:00
ac60f13312
Modify RequestProcessingAsync to call single parse method ( #1427 )
...
* Modify RequestProcessingAsync to call single parse method
* Fix bad request logging
2017-03-03 14:43:32 -08:00
7cc5c537a4
Added a new benchmark
2017-03-03 13:13:11 -08:00
1d685e195e
Parser cleanup and remove line continuation header error ( #1431 )
...
- Cleaned up some parsing logic (removed locals etc)
- Removing line continuation errors cleaned up code duplication
a little bit
2017-03-03 10:04:44 -08:00
4533383612
React to hosting change
...
- Kestrel binds to ipv4 by default
Fixes #1432
2017-03-02 23:09:13 -08:00
4d7c6ff69f
use rtm appveyor
2017-03-02 21:44:36 -08:00
1e0f2b3951
Fix systemd activation tests ( #1429 )
2017-03-02 17:26:41 -08:00
8929b40527
Single span optimizations ( #1421 )
...
- Added a fast path for single span in the start line parsing
- Added a fast path for single span header parsing
- Changed the out header loop to be pointer based (instead of slicing)
2017-03-02 12:17:39 -08:00
40ee51846c
Add allocations column ( #1422 )
2017-03-02 06:56:05 -08:00
cb6059c143
Make the IHttpParser per frame and add a reset ( #1415 )
...
* Make the IHttpParser per frame and add a reset
- Made the IHttpParser a per frame object so state can be stored
across method calls and parses.
- Added HttpParserFactory to ServiceContext
2017-03-01 13:12:03 -08:00
d3694f085a
Add IHttpParser interface ( #1414 )
2017-03-01 11:55:36 -08:00
c56de066d3
Optimized parsing GET verb and version ( #1399 )
...
* Optimized parsing GET verb
* optimized http version parsing
* Added microbenchmarks for GetKnownMethod and GetKnownVersion
2017-02-28 17:02:52 -08:00
6ad9f3e8b0
Reacting to HeaderUtitilities renames
2017-02-28 14:50:02 -08:00
568aaff9c4
Improve HTTP parsing tests ( #1393 ).
...
- Add several more test cases
- Share data between functional and unit tests
2017-02-28 14:23:27 -08:00
fde0f6b2fc
Add an option to Kestrel to disable threadpool dispatching
2017-02-28 10:14:58 -08:00
a95743c5f6
Add functional test to verify generated code is up to date ( #1369 ).
2017-02-27 14:19:56 -08:00
c6705d8693
Convert TakeStartLine and TakeMessageHeaders to be state machines ( #1401 )
...
- Less passes over the buffer
- Single pass to find all start line delimiters instead
of calling IndexOf multiple times.
- Made TakeStartLine and TakeMessageHeaders a state machine
- Only check length against remaining bytes once
- Change variable names to match TakeStartLine
- Use ReadableBuffer.First.Span instead of ToSpan()
- Added test for missing path with a querystring
2017-02-27 11:55:30 -08:00
5692f51bf7
Revert "Revert "Use Spans to parse the start line and headers ( #1394 )""
...
This reverts commit 19c3107deb
2017-02-24 10:22:05 -08:00
19c3107deb
Revert "Use Spans to parse the start line and headers ( #1394 )"
...
This reverts commit 8140b8cdfe
2017-02-24 10:03:32 -08:00
4544f881a2
Revert "Skipping failing tests to unblock CI"
...
This reverts commit 0860981ada
2017-02-24 09:48:44 -08:00
0860981ada
Skipping failing tests to unblock CI
2017-02-24 09:31:43 -08:00
8140b8cdfe
Use Spans to parse the start line and headers ( #1394 )
...
* Use Spans to parse the start line and headers
- Use `Span<byte>` to parse the start line and headers
2017-02-23 23:02:29 -08:00
990e2a8dc4
Use pass through connection adapter instead of ssl for max buffer size tests ( #1391 )
2017-02-23 08:04:43 -08:00
ba549502e1
Use the IThreadPool as the ReaderScheduler ( #1372 )
...
- This is what socket input did, also using
ThreadPool.QueueUserWorkItem is better than Task.Run for this
scenario and avoids a bunch of overhead.
2017-02-21 21:09:23 -08:00
80b9673693
Temporary add delay to connection test to make it pass ( #1384 )
2017-02-21 16:04:32 -08:00
0dca3a266f
Remove custom BenchmarkDotNet toolchain.
2017-02-21 12:05:16 -08:00
4fd71e3a6b
Fix 'No data found for...' errors in CI test runs.
2017-02-21 11:50:20 -08:00
d3a6915732
Remove dotnet-core and dotnet-corefxlab feeds
...
Let VS do it's thing with test projects
2017-02-20 10:24:41 -08:00
824ef2c937
Input Pipeline migration ( #1277 )
2017-02-17 15:38:13 -08:00
bfe1f06938
Fix AddressRegistrationTests.RegisterAddresses_IPv6ScopeId_Success ( #1363 ).
2017-02-17 10:35:00 -08:00
932b6ed53a
Cleanup MSBuild conversion
...
Remove runtimeconfig.template.json
Remove ToolsVersion attribute
Use repo.targets instead of makefile.shade
Rename code gen app to shorter name
Use GetOSPlatform task
Upgrade tests to .NET Framework 4.5.2
Cleanup solution configurations. Set the class libraries to AnyCPU even when on the x86 or x64 solution config.
2017-02-16 09:44:58 -08:00
708630fd23
Downgrade to stable packages
2017-02-15 14:22:38 -08:00
be9f83b308
Bump test projects up to .NET 4.5.2
...
- aspnet/Testing#248
- xUnit no longer supports .NET 4.5.1
- build tests for desktop .NET only on Windows
2017-02-14 09:21:44 -08:00
5124adf450
Better report Kestrel crashing errors
2017-02-07 00:26:00 -08:00
8cbe54a182
Remove usage of conditional multi-targeting
...
This causes Visual Studio to crash. See
dotnet/roslyn-project-system#1431
2017-02-01 12:12:43 -08:00
1a2c438899
Upgrade to RC.3
2017-01-31 16:23:23 -08:00
ecca980c91
Implement IHeaderDictionary.ContentLength
2017-01-24 14:55:48 -08:00
2895447cbe
Merge branch 'benaadams/flush' into dev
2017-01-23 09:36:29 -08:00
10fe5e6fa2
Fix performance tests
2017-01-20 14:55:21 -08:00
f32058c5c3
Warn instead of throw when ignoring IServerAddressesFeature
...
- Throwing could be too much when IServerAddressesFeature URLs come from VS
- Listen on 127.0.0.1:5000 by default
https://github.com/aspnet/Hosting/issues/917
2017-01-19 11:36:19 -08:00
20e02e8fd6
Don't overwhelm server with data in KeepAliveTimeoutTests.ConnectionNotTimedOutWhileRequestBeingSent().
2017-01-19 11:03:43 -08:00
89a63d190e
Don't close connection when Content-Length set but no bytes written.
2017-01-12 12:38:15 -08:00
e26f91a392
Call OnStarting before verifying response length ( #1289 ).
2017-01-10 14:24:44 -08:00
cf77813c82
Re-enable HTTPS tests ( #1273 ).
2017-01-10 13:48:46 -08:00
57b368566d
Use StatusCode instead of three digit numbers for status codes
2017-01-09 10:09:54 -08:00
6d7ddc45ef
Fix deadlock in SocketOutput ( #1278 ).
2017-01-06 20:33:35 -08:00
2351c1b558
Create a direct way to configure Kestrel endpoints
...
- Replace endpoint configuration via .UseUrls() or --server.urls with Listen*
methods on KestrelSerrverOptions.
- Replace IConnectionFilter with IConnectionAdapter which no longer exposes
ServerAddress via a context.
- Simplify libuv Listener classes
- Support systemd socket activation
- Add docker-based test for systemd socket activation to be run on Travis
2017-01-06 17:37:58 -08:00
c72605f43a
Fix NuGet downgrade warning
...
Works around warning where a P2P reference is explicitly listed in the project. For e.g.
warn : SampleApp (>= 1.1.0) -> Microsoft.AspNetCore.Server.Kestrel.Https (>= 1.2.0) -> Microsoft.AspNetCore.Server.Kestrel
warn : SampleApp (>= 1.1.0) -> Microsoft.AspNetCore.Server.Kestrel (>= 1.2.0)
2016-12-28 09:44:21 -08:00
81a8ba0347
Skip tests commentd out in 973b705.
2016-12-23 17:38:54 -08:00
973b705cdb
Disable tests that hang on SslStream.WriteAsync after update to CoreFx 4.4.
2016-12-22 18:37:14 -08:00
4c0413c804
Implement Stream Flush+FlushAsync fully
...
Streams should pass through the flush and not assume the underlying
Stream's Flush behaviour
2016-12-22 13:40:40 +00:00
5b8f7c2b2b
Updating to 4.4 CoreFx packages
2016-12-21 22:22:13 -08:00
461caa85f4
Test RequestHeadersTimeout in KestrelServerLimitsTests.RequestHeadersTimeoutValid ( #1268 ).
2016-12-21 13:22:20 -08:00
b41c4078bd
Abort connections not closed during shutdown ( #1112 ).
2016-12-20 14:44:34 -08:00
4485bfec39
Fix test races caused by cedbe76.
2016-12-13 13:57:26 -08:00
cedbe76f52
Abort request on client FIN ( #1139 ).
2016-12-13 12:03:33 -08:00
51ecbd7949
Add benchmarks for Frame writes.
2016-12-13 11:33:56 -08:00
defcbdb907
Revert "Add MaxRequestBodySize limit ( #478 )."
...
This reverts commit e53a87be9c
2016-12-09 16:30:12 -08:00
e53a87be9c
Add MaxRequestBodySize limit ( #478 ).
2016-12-05 17:06:57 -08:00
02b84d7ae1
Make ListenerPrimaryTests more reliable
...
- The Task from ListenerSecondary.StartAsync() may complete before the
PrimaryListener adds the pipe connection to its dispatch pipe list.
2016-11-28 14:37:25 -08:00
fd7232616a
Pin global.json SDK to 1.0.0-preview2-1-003177.
2016-11-23 15:59:21 -08:00
Cesar Blum Silveira
Stephen Halter
Ben Adams
David Fowler
Cesar Blum Silveira
Pavel Krymets
Nate McMaster
Nate McMaster
John Luo
Krzysztof Cwalina
Pranav K
Doug Bunting
N. Taylor Mullen