Re-enable HTTPS tests (#1273).

This commit is contained in:
Cesar Blum Silveira 2017-01-03 14:23:49 -08:00
parent 57b368566d
commit cf77813c82
7 changed files with 16 additions and 17 deletions

View File

@ -28,5 +28,5 @@
"configProperties": {
"System.GC.Server": true
}
}
}
}

View File

@ -36,14 +36,14 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
await RegisterAddresses_Success(addressInput, testUrls);
}
[Theory(Skip = "SslStream hanging on write after update to CoreFx 4.4 (https://github.com/dotnet/corefx/issues/14698)"), MemberData(nameof(IPEndPointRegistrationDataRandomPort))]
[ConditionalTheory, MemberData(nameof(IPEndPointRegistrationDataRandomPort))]
[IPv6SupportedCondition]
public async Task RegisterIPEndPoint_RandomPort_Success(IPEndPoint endPoint, Func<IPEndPoint, string> testUrl)
{
await RegisterIPEndPoint_Success(endPoint, testUrl);
}
[ConditionalTheory(Skip = "SslStream hanging on write after update to CoreFx 4.4 (https://github.com/dotnet/corefx/issues/14698)"), MemberData(nameof(IPEndPointRegistrationDataPort443))]
[ConditionalTheory, MemberData(nameof(IPEndPointRegistrationDataPort443))]
[IPv6SupportedCondition]
[PortSupportedCondition(443)]
public async Task RegisterIPEndPoint_Port443_Success(IPEndPoint endpoint, Func<IPEndPoint, string> testUrl)

View File

@ -27,7 +27,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
}
}
[Fact(Skip = "SslStream hanging on write after update to CoreFx 4.4 (https://github.com/dotnet/corefx/issues/14698)")]
[Fact]
public async Task GetStringAsyncHttps()
{
using (var host = StartHost(protocol: "https"))
@ -54,7 +54,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
}
}
[Fact(Skip = "SslStream hanging on write after update to CoreFx 4.4 (https://github.com/dotnet/corefx/issues/14698)")]
[Fact]
public async Task PostAsyncHttps()
{
using (var host = StartHost(protocol: "https",

View File

@ -91,7 +91,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
}
// Regression test for https://github.com/aspnet/KestrelHttpServer/issues/1103#issuecomment-246971172
[Fact(Skip = "SslStream hanging on write after update to CoreFx 4.4 (https://github.com/dotnet/corefx/issues/14698)")]
[Fact]
public async Task DoesNotThrowObjectDisposedExceptionOnConnectionAbort()
{
var x509Certificate2 = new X509Certificate2("TestResources/testCert.pfx", "testPassword");
@ -104,7 +104,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
listenOptions.UseHttps("TestResources/testCert.pfx", "testPassword");
});
})
.UseUrls("https://127.0.0.1:0/")
.UseLoggerFactory(loggerFactory)
.Configure(app => app.Run(async httpContext =>
{
@ -144,7 +143,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
Assert.False(loggerFactory.ErrorLogger.ObjectDisposedExceptionLogged);
}
[Fact(Skip = "SslStream hanging on write after update to CoreFx 4.4 (https://github.com/dotnet/corefx/issues/14698)")]
[Fact]
public async Task DoesNotThrowObjectDisposedExceptionFromWriteAsyncAfterConnectionIsAborted()
{
var tcs = new TaskCompletionSource<object>();

View File

@ -14,7 +14,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
{
public class LoggingConnectionAdapterTests
{
[Fact(Skip = "SslStream hanging on write after update to CoreFx 4.4 (https://github.com/dotnet/corefx/issues/14698)")]
[Fact]
public async Task LoggingConnectionFilterCanBeAddedBeforeAndAfterHttpsFilter()
{
var host = new WebHostBuilder()

View File

@ -65,7 +65,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
}
}
[Theory(Skip = "SslStream hanging on write after update to CoreFx 4.4 (https://github.com/dotnet/corefx/issues/14698)")]
[Theory]
[MemberData("LargeUploadData")]
public async Task LargeUpload(long? maxRequestBufferSize, bool ssl, bool expectPause)
{

View File

@ -28,7 +28,7 @@ namespace Microsoft.AspNetCore.Server.KestrelTests
// https://github.com/aspnet/KestrelHttpServer/issues/240
// This test currently fails on mono because of an issue with SslStream.
[Fact(Skip = "SslStream hanging on write after update to CoreFx 4.4 (https://github.com/dotnet/corefx/issues/14698)")]
[Fact]
public async Task CanReadAndWriteWithHttpsConnectionAdapter()
{
var serviceContext = new TestServiceContext();
@ -52,7 +52,7 @@ namespace Microsoft.AspNetCore.Server.KestrelTests
}
}
[Fact(Skip = "SslStream hanging on write after update to CoreFx 4.4 (https://github.com/dotnet/corefx/issues/14698)")]
[Fact]
public async Task RequireCertificateFailsWhenNoCertificate()
{
var serviceContext = new TestServiceContext();
@ -76,7 +76,7 @@ namespace Microsoft.AspNetCore.Server.KestrelTests
}
}
[Fact(Skip = "SslStream hanging on write after update to CoreFx 4.4 (https://github.com/dotnet/corefx/issues/14698)")]
[Fact]
public async Task AllowCertificateContinuesWhenNoCertificate()
{
var serviceContext = new TestServiceContext();
@ -139,7 +139,7 @@ namespace Microsoft.AspNetCore.Server.KestrelTests
}
[Fact(Skip = "SslStream hanging on write after update to CoreFx 4.4 (https://github.com/dotnet/corefx/issues/14698)")]
[Fact]
public async Task CertificatePassedToHttpContext()
{
var serviceContext = new TestServiceContext();
@ -178,7 +178,7 @@ namespace Microsoft.AspNetCore.Server.KestrelTests
}
}
[Fact(Skip = "SslStream hanging on write after update to CoreFx 4.4 (https://github.com/dotnet/corefx/issues/14698)")]
[Fact]
public async Task HttpsSchemePassedToRequestFeature()
{
var listenOptions = new ListenOptions(new IPEndPoint(IPAddress.Loopback, 0))
@ -197,7 +197,7 @@ namespace Microsoft.AspNetCore.Server.KestrelTests
}
}
[Fact(Skip = "SslStream hanging on write after update to CoreFx 4.4 (https://github.com/dotnet/corefx/issues/14698)")]
[Fact]
public async Task DoesNotSupportTls10()
{
var serviceContext = new TestServiceContext();
@ -325,7 +325,7 @@ namespace Microsoft.AspNetCore.Server.KestrelTests
}
}
[Fact(Skip = "SslStream hanging on write after update to CoreFx 4.4 (https://github.com/dotnet/corefx/issues/14698)")]
[Fact]
public async Task CertificatePassedToHttpContextIsNotDisposed()
{
var serviceContext = new TestServiceContext();