Commit Graph

4325 Commits

Author SHA1 Message Date
James Newton-King dfae9c208a
Add IParameterTransformer support (#8329) 2018-09-12 21:46:41 +12:00
James Newton-King 105f8b47a1
Fix endpoint support for area/controller/action in attribute route (#8447) 2018-09-12 21:16:50 +12:00
N. Taylor Mullen ec489da586 Add additional logging to diagnose flaky cache tag test.
#8281
2018-09-11 14:09:36 -07:00
James Newton-King 6e27a04bf3
No HttpContext to route constraints in MvcEndpointDataSource (#8436) 2018-09-11 10:12:09 +12:00
Ryan Nowak f573b8840a Fix aspnet/Routing#782
Currently MVC is still running the IActionConstraint implementations for
features that we've already moved into the routing layer. This has a
significant perf cost associated with, and so we want to skip it because
it's redundant. However if anyone has implemented their own
`IActionConstraint`-based features, they still need to just work.

This change takes the approach of skipping the action constraint phase
at runtime unless we see something 'unknown'. This is an all or nothing
choice, and will run action constraints if **any** action constraint we
don't special case exists. This is the most compatible behavior (running
redundant constraints) when the application is using constraints that
the developer implemented.

Another approach I considered was to eliminate these constraints as part
of the process of building ADs. I don't think that's ideal because
people have written code that introspects action constraints. We should
consider something like this in 3.0.
2018-09-09 15:17:05 -07:00
ASP.NET CI 87c1389b5a Update dependencies.props
[auto-updated: dependencies]
2018-09-09 12:23:38 -07:00
Pranav K dbf744c523
Merge pull request #8404 from aspnet/prkrishn/remove-experimental
Remove experimental analyzers
2018-09-07 16:19:47 -07:00
Pranav K 013697ad89
Remove experimental analyzers 2018-09-07 16:03:06 -07:00
Ryan Brandenburg 9895593926 Include diagnosticMessages from xunit for Functional tests 2018-09-07 15:00:33 -07:00
Joni 72f7e52e1e Remove blank line 2018-09-07 14:48:17 -07:00
gqqnbig fd80509fef LocalizedHtmlString.Value doesn't include arguments (#8376)
* Clarify that Value is prior to formatting with any constructor arguments
2018-09-07 08:58:52 -07:00
Casey O'Brien 74ba9898f4 [Fixes #8250] Improve the error message when TEntryPoint is not in an entry point assembly
Validates that the type used as a generic argument in WebApplicaitonFactory is contained within the entry point to assembly and throws InvalidOperationException otherwise
2018-09-06 18:02:21 -07:00
James Newton-King 863b1c2c97
Action endpoint metadata contains attributes from action and controller (#8395) 2018-09-07 10:01:40 +12:00
Pranav K 07cc9e66c6
Add a feature to disable file watching in Razor pages (#8369)
* Add a feature to disable file watching in Razor pages

Fixes https://github.com/aspnet/Mvc/issues/8362
2018-09-06 10:16:31 -07:00
Simon Cropp b156dee4f1 Fix some spelling (#8378) 2018-09-06 07:39:01 -07:00
Takaaki Suzuki c0f3a46ffe
Don't call GetValidity method twice. 2018-09-06 07:33:48 -07:00
Ben Adams e174d277bd Inline 2018-09-05 20:53:06 -07:00
Ben Adams 337bc462de Fast-path async in PagedBufferedTextWriter 2018-09-05 20:53:06 -07:00
Ryan Nowak fabe189470 React to LinkGenerator changes 2018-09-05 20:52:37 -07:00
Ben Adams b48b282ad8 Add RazorRendering benchmarkapp (#8366)
* Add RazorRendering benchmarkapp
2018-09-05 17:07:04 -07:00
Hassan Hashemi bca3160190 Remove redundant check
fixed https://github.com/aspnet/Mvc/issues/8374
2018-09-05 17:04:20 -07:00
Nate McMaster 6498c89f88
Update branding to 2.2.0-preview3 2018-09-05 16:28:46 -07:00
ASP.NET CI b9793f0a1d Update dependencies.props
[auto-updated: dependencies]
2018-09-02 12:21:18 -07:00
Pranav K d8b7dbd1f3
Avoid null refs when IStatusCodeActionResult cannot be discovered 2018-08-30 15:17:09 -07:00
Ryan Nowak 1128bd572c Add a functional test for middleware after routing
It came up during routing discussions that we don't have any tests for
this scenario.
2018-08-30 14:51:56 -07:00
Ben Adams 3dfa26f7e3 Resolve virtual ViewContext max once per method 2018-08-30 14:04:08 -07:00
Pranav K f90a47c5af
Introduce ProducesErrorResponseTypeAttribute
Fixes https://github.com/aspnet/Mvc/issues/8288
2018-08-30 11:24:03 -07:00
James Newton-King 927e7c8bfc
Support route data tokens with Endpoint Routing (#8360) 2018-08-30 15:14:34 +12:00
James Newton-King 5cdc172b17
Fix obsolete constraint resolver usage (#8361) 2018-08-30 13:28:46 +12:00
Kristian Hellang ffdbea9dc1
Add analyzer support for status code methods and constructors 2018-08-29 18:23:52 -07:00
Ben Adams 2a426dfea5 Make ViewBuffer methods more inlinable (#8339)
* Make ViewBuffer methods more inlinable
2018-08-29 17:07:45 -07:00
Ben Adams c7f6e7ab2f Grumpy XUnit 2018-08-29 16:18:25 -07:00
Ben Adams 22a40b6f2b Use Pages as List 2018-08-29 16:18:25 -07:00
Ben Adams 7bd9f9cc3e Reduce IList interface calls 2018-08-29 16:18:25 -07:00
Pranav K 82a01a414d
Set trace id in ProblemDetalsClientErrorFactory 2018-08-29 16:03:08 -07:00
James Newton-King b649133eec
Refactor KnownRouteValueConstraint to not require HttpContext (#8352) 2018-08-30 08:57:53 +12:00
James Newton-King 28f96bf832
Fix obsolete build warning (#8358) 2018-08-30 08:16:57 +12:00
Ryan Brandenburg 234b003b31 Set longRunningTestSeconds for Functional tests 2018-08-29 11:02:43 -07:00
Pranav K d09c3c9e28
Polish ProblemDetails
* Add ability to set extended members on ProblemDetails
* Skip empty valued properties when serializing ProblemDetails

Fixes #8296
Fixes #8317
2018-08-28 16:21:39 -07:00
Pranav K 667ad4daff Use ClientErrorData to configure ClientErrorResultFilter
Fixes #8289
2018-08-28 13:35:32 -07:00
Massimiliano Donini 17d72c2b94 Fix msbuild targets to correctly copy deps.json 2018-08-28 13:32:48 -07:00
Ryan Nowak 96b77c8663 Fix aspnet/Routing#721 2018-08-28 12:26:13 -07:00
Nate McMaster 10e1b619c3
Merge branch 'release/2.1' into release/2.2 2018-08-28 10:27:03 -07:00
Nate McMaster 5a4fd3e792
Bumping version from 2.1.2 to 2.1.3 2018-08-28 09:07:51 -07:00
Ryan Nowak 0fcf2448c3 Fix aspnet/Routing#722
Exposes a separate change token that will be triggered after action
descriptors have been updated.
2018-08-27 17:24:21 -07:00
Doug Bunting 501df09fd6
Merge remote-tracking branch 'origin/release/2.1' into release/2.2 2018-08-27 16:26:05 -07:00
James Newton-King 8ed9d0aac2
Use Endpoint instead of RouteEndpoint where possible (#8331) 2018-08-28 11:00:11 +12:00
Ryan Nowak a634f6b116 add another test 2018-08-27 15:34:37 -07:00
Ryan Nowak cb0627b28a Addressing a skipped test
I think something that was meant to be revisited in a PR got left
behing. I found this while fixing aspnet/Routing#772 and it seems worth
addressing.

This change removes the hardcoding of action/controller/area in the
data source, and corrects the behavior of required route values when
they aren't in that set.
2018-08-27 15:34:37 -07:00
Pranav K a7301120b1
Unwrap filter factories in TypeFilterAttribute & ServiceFilterAttribute
Fixes #7855
2018-08-24 14:15:40 -07:00