Ryan Brandenburg
dc0be8d747
SaveTempDataFilter handle write to body
...
(cherry picked from commit 03cdd15e5c )
2017-02-03 10:41:36 -08:00
Ryan Nowak
cf70ed663b
Merge tag 'rel/1.1.1' into dev
2017-02-03 10:31:17 -08:00
Ajay Bhargav Baaskaran
1777f7babd
Enabling Razor Instrumentation
2017-02-01 15:29:09 -08:00
Ryan Nowak
4c62eb89af
Unit tests for VCTH and model directive
2017-01-31 13:14:20 -08:00
Ryan Nowak
3ade209bf0
Delete using chunk tests
...
This feature is implemented by Razor and already has tests there.
2017-01-31 12:42:57 -08:00
Ryan Nowak
6c55754823
Fix failing linemappings tests
...
Need to use a consistent newline, since these fail on xplat.
2017-01-31 12:41:54 -08:00
Ryan Nowak
705369ee51
Add unit tests for ModelExpressionPass
...
Add unit tests for @inject
2017-01-30 19:08:39 -08:00
Ryan Nowak
b79f8384b0
Make some methods public for ViewCompilation.
2017-01-30 13:46:27 -08:00
Ryan Nowak
84d2e027f5
Use new Razor in MVC
2017-01-30 10:55:49 -08:00
Jass Bagga
7449ffad74
Add include and exclude attributes to EnvironmentTagHelper
...
Addresses #5671
2017-01-27 14:46:53 -08:00
Joonas Westlin
d44c9aee1e
Added printing of route values when a route is not matched
2017-01-27 11:31:05 -08:00
Kiran Challa
17dc23a024
[ Fixes #5637 ] Make CookieName of CookieTempDataProvider configurable
2017-01-27 11:01:26 -08:00
Ryan Brandenburg
03cdd15e5c
SaveTempDataFilter handle write to body
2017-01-27 10:54:00 -08:00
Pranav K
3e214e2399
Introducing IPageModelActivatorProvider
...
Fixes #5480
2017-01-26 11:31:14 -08:00
Doug Bunting
cc584ada39
Remove extra lines in 1840d68
2017-01-26 08:20:52 -08:00
Andrei Ignat
1840d6823b
Addresses #5694 ( #5695 )
...
* Add "
`Microsoft.AspNetCore.StaticFiles": "1.2.0-*"`
to project,json
Add
`app.UseStaticFiles();`
in the
`public void Configure(IApplicationBuilder app)`
from `Startup` class.
Addresses #5694
2017-01-26 08:18:19 -08:00
Jass Bagga
9b1271ba19
Remove obsolete DefaultHtmlGenerator ctor ( #5711 )
2017-01-25 16:25:12 -08:00
Kiran Challa
42ae78a360
[ Fixes #5012 ] ProducesAttribute should not inherit from ResultFilterAttribute
2017-01-25 14:00:35 -08:00
Kiran Challa
8ac6b6699f
[ Fixes #4945 ] Simple string returned by controller action is not a valid JSON!
2017-01-25 13:29:18 -08:00
Ryan Nowak
5885feb7c0
Fixes a parsing bug with the AcceptHeaderParser
...
When we find an invalid character at the end of a media type value we
should advance and skip over it.
2017-01-23 13:12:40 -08:00
Ryan Brandenburg
305748a800
Move classes out of .Internal
2017-01-19 11:11:28 -08:00
Ryan Brandenburg
6396e14504
Add null-check back to MediaType
2017-01-18 16:56:08 -08:00
Pranav K
24efd4268b
Pin the version of RazorTooling packages to 1.1.0-preview4-final
2017-01-17 11:55:15 -08:00
Pranav K
e749a80b30
Check for empty location in ViewsFeatureProvider
...
Fixes #5675
2017-01-17 11:07:48 -08:00
Doug Bunting
ce53675b87
Add `[ValidateNever]` and `IPropertyValidationFilter`
...
- #5642
- lazy-load `ValidationEntry.Model`
- avoids `Exception`s when moving to a property that will not be validated
nits:
- remove duplicate code in `ValidationVisitor`
- clarify "all properties of" doc comments
- also add missing `<param>` doc in `ViewDataInfo`
2017-01-15 21:40:29 -08:00
Jass Bagga
07c22f2b29
Mutate API description parameter type from JsonPatchDocument to Operation[]
...
Addresses #5464
2017-01-13 16:39:08 -08:00
Jass Bagga
f95d49c870
Change datetime to datetime-local
...
Addresses #4871
2017-01-13 15:40:30 -08:00
Ryan Brandenburg
93774a0234
Mitigate MediaType overflow
2017-01-13 12:51:19 -08:00
Pranav K
a7abdeabcd
Introducing PageActionInvoker
2017-01-13 11:49:02 -08:00
Pranav K
6b0282fa84
Commonize code from ControllerActionInvokerCache and PageFilterFactoryProvider
2017-01-11 10:53:23 -08:00
Kiran Challa
de0f277892
Fix attribute routing error message related to replace tokens
2017-01-04 15:43:57 -08:00
Pranav K
78492b39d8
Introduce a base type for executing auth and resource filters.
2017-01-03 11:14:15 -08:00
Pranav K
2b8233932a
Add IPageFactory and IPageActivator
2016-12-29 15:11:29 -08:00
Jass Bagga
9146fce4ec
Add extension method for IParameterModelConvention. ( #5640 )
2016-12-27 16:49:12 -08:00
Pranav K
a42006d295
Workarond type collision
...
Fixes compilation error "The type 'XmlNode' exists in both 'System.Xml.ReaderWriter, Version=4.2.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'System.Xml.XmlDocument, Version=4.0.1.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'"
2016-12-21 16:47:14 -08:00
Pranav K
2b50ec99df
Updating to 4.4 CoreFx packages
2016-12-21 16:47:14 -08:00
Ryan Brandenburg
b2340d327e
Order IgnoreAntiforgeryTokenAttribute and add test
2016-12-12 14:55:36 -08:00
Pranav K
cfa9631ce8
Resolve path traversals in RazorViewEngine
...
This change moves the onus of path resolution from individual IFileProvider instances to RazorViewEngine.
Fixes #5574
Fixes https://github.com/aspnet/MvcPrecompilation/issues/33
2016-12-08 11:20:06 -08:00
Joonas Westlin
1dd1d49321
Redirects with fragment ( #5519 )
...
- Added implementation of overloads where you can specify the fragment to redirect to.
- Added unit tests
- Added XML comments, including missing documentation of existing members
2016-12-06 10:32:01 -08:00
Doug Bunting
48546dbb28
Add more to `MvcCoreServiceCollectionExtensionsTest`
...
- 2nd half of #5554
- follow-on to #5540 PR
2016-12-05 20:05:24 -08:00
Ryan Brandenburg
8f8bf5af34
Seperate view and model for enum display
2016-11-30 11:13:38 -08:00
Pranav K
52ee9afc31
Adding PageActionDescriptorProvider
...
Fixes #5353
2016-11-23 16:53:06 -08:00
Pranav K
5b2a4aecb6
Make Microsoft.AspNetCore.Mvc.TestCommon a regular project
...
* This allows specifying all it's dependencies rather than for consuming projects to do this
* Remove unused APIs
* Fix weird downgrade warnings that show up due to P2P references
2016-11-23 16:23:56 -08:00
Steve Smith
34dd9472ba
Comment typo ( #5557 )
2016-11-22 13:55:24 -08:00
Pranav K
296b12abc3
Pinning missed tools and dependencies
2016-11-18 12:41:45 -08:00
Pranav K
74c9194aee
Pinning versions for 1.1.0 release
2016-11-18 12:12:52 -08:00
Pranav K
3b4d8e2e3d
Fix downgrade warnings during restore
2016-11-17 10:50:47 -08:00
Pranav K
975dc212b7
Fix package versions
2016-11-17 10:19:48 -08:00
Pranav K
c5a5ba1fee
Add support for updateable ActionDescriptorCollection
...
Fixes #5350
2016-11-17 10:08:38 -08:00
Pranav K
177fb2a6b1
Temporarily disable running tests on Microsoft.AspNetCore.RazorPages.Test
2016-11-17 10:08:38 -08:00
Pranav K
29cd24f66b
Add Microsoft.AspNetCore.Mvc.RazorPages projects
2016-11-17 10:08:38 -08:00
Pranav K
1506a44cd5
Fix downgrade warnings
2016-11-10 09:22:11 -08:00
Pranav K
b82969a557
Updating versions to 1.2.0-*
2016-11-09 14:18:46 -08:00
Doug Bunting
6d4361218e
Add builder extensions to simplify use of `CookieTempDataProvider`
...
- #5515
2016-11-08 15:32:09 -08:00
Jass Bagga
576c0e6a65
Throw an exception if configurationType to CreateConfigureDelegate is abstract/has no parameterless ctor
...
Addresses #5431
2016-11-08 14:16:03 -08:00
Kiran Challa
07a2f1de06
Fixes CookieTempDataProvider to set the secure attribute of a cookie only if a request is secure
2016-11-08 13:30:28 -08:00
Kiran Challa
a3c06b00cc
Fixes CookieTempDataProvider to handle empty request PathBase while setting cookie options
2016-11-08 13:30:27 -08:00
Marcus Schweda
24d5dfb552
Dynamic assembly checks to prevent NotSupprotedExceptions from System.Reflection.Emit
...
Fixes #5487
2016-11-07 12:49:49 -08:00
Jass Bagga
9caa688a30
Modified exception message for duplicate keys exception in CandidateResolver
...
Addresses #5289
2016-11-07 11:16:11 -08:00
Jass Bagga
304000095a
Added logging for precompiled views in RazorViewEngine
...
Addresses #5462
2016-11-07 10:46:54 -08:00
Hugh Bellamy
1dc4b28bbe
Add AcceptedAtActionResult tests
2016-11-07 09:53:19 -08:00
Kiran Challa
0cee00aae1
[ Fixes #5352 ] When replacing Controller.Dispose with an explicit implementation the base Dispose is an action
2016-11-04 09:34:30 -07:00
Ajay Bhargav Baaskaran
7985121bab
[ Fixes #5207 ] Support IsIndexer for ViewComponent tag helpers
2016-11-03 16:50:22 -07:00
Kiran Challa
047def1aaf
Added/Updated JsonPatchExtensionsTest
2016-11-03 14:49:48 -07:00
Doug Bunting
f04286562e
Treat `ContentType==null` and `MediaType.GetEncoding(ContentType)==null` differently
...
- now, if client sends e.g. `Content-type: text/json;charset=[invalid]`, service will respond with HTTP/415
- if client sends `Content-type: text/json`, service will still try UTF-8 (or updated default encoding)
- intentional (and slight) behaviour change from 1ac7315
- include and a few new tests and some cleanup from same commit
2016-11-03 10:51:39 -07:00
Doug Bunting
116c927e61
Revert "Do not call `Encoding.GetEncoding()` with a string from the request"
...
- #5351 should be Won't Fix
This reverts commit 1ac731519a .
2016-11-03 10:51:39 -07:00
Pranav K
8ad7c19379
Remove references to Iddentity
2016-11-03 10:42:20 -07:00
Ryan Brandenburg
01b237dda9
Antiforgery goes at the end of filters
2016-11-02 16:50:27 -07:00
Kiran Challa
82b2e9c75c
Added functional tests for Antiforgery related to setting no-cache headers
2016-11-02 16:29:34 -07:00
Ajay Bhargav Baaskaran
c28ad48e98
[ Fixes #5216 ] Make generic parameters work with ViewComponent tag helpers
2016-11-02 15:55:23 -07:00
Kiran Challa
32710bbfbe
[ #5430 ] CookieTempDataProvider chunking broken
2016-11-01 16:13:27 -07:00
Jass Bagga
5d5b282dbd
Moved CaseSensitiveTagHelperAttributeComparer to Razor.TagHelpers.Testing.Sources
...
Addresses #5323
2016-11-01 14:51:37 -07:00
Pranav K
dd29d562b8
Adding functional test to verify error page middleware includes raw compilation content.
2016-10-31 10:28:04 -07:00
Doug Bunting
ada42ea913
Move value source information from `<remarks>` to `<summary>`
...
- #1999
- may have reordered the precedence comments as I double-checked the implementations
- `CheckBox()` and `RadioButton()` were examples of such updates
nits:
- use SSL in documentation links
- simplify mentions of format strings
- remove a few phrases that didn't say much and duplicated `<remarks>`
2016-10-28 16:43:59 -07:00
Jass Bagga
0eea3c2651
Log messages added to BodyModelBinder for input formatters ( #5451 )
...
Addresses #5367
2016-10-27 09:43:53 -07:00
Doug Bunting
1ac731519a
Do not call `Encoding.GetEncoding()` with a string from the request
...
- #5351
- fix affects only `TextInputFormatter`
- `TextOutputFormatter` already does the Right Thing™️ with `Accept-Charset` headers
- `ResponseContentTypeHelper` uses `Encoding.GetEncoding()` but is not passed request data
2016-10-24 14:59:49 -07:00
Ryan Brandenburg
60c59b576e
Replace HashSet with a Hybrid HashSet/List
...
to improve performance on less nested models
2016-10-24 14:47:49 -07:00
Doug Bunting
3fdcaecaa8
Correctly handle quoted media type parameter values
...
- #5349
- fix or add comments about other parsing errors and inconsistencies
- `MediaType` did not skip whitespace before the type
nits:
- use `+=`
- `<code>` -> `<c>` since the former is not for use within a paragraph
- split tests up to remove `bool expectedResult` parameters
2016-10-24 13:16:09 -07:00
Ajay Bhargav Baaskaran
5b9c01e54d
Added a functional test for ViewComponent tag helpers
...
- Added Copyright ViewComponent tag helper
- Added Dan ViewComponent tag helper
2016-10-21 16:17:13 -07:00
Jass Bagga
f629f9a659
Check for null arguments in GetArgumentDictionary
...
Addresses #5423
2016-10-20 13:40:39 -07:00
Jass Bagga
79e576b86c
ProducesResponseTypeAttribute(int statusCode) ctor added
...
Addresses #4863
2016-10-19 17:08:06 -07:00
jacalvar
d5b0ebd10c
Merge branch 'rel/1.1.0-preview1' into dev
2016-10-18 14:26:12 -07:00
jacalvar
9579806306
[ Fixes #5150 ] parsing issue on asp.net when request quality factor is specified
2016-10-18 12:52:53 -07:00
joheredi
38aa48651f
Fix for Issue#5150
2016-10-18 12:52:30 -07:00
John Luo
d8c6c4ab34
Add support for VaryByQueryKey #2894
2016-10-18 12:31:04 -07:00
Ajay Bhargav Baaskaran
3004fb822b
Merge branch 'rel/1.1.0-preview1' into dev
2016-10-18 12:02:42 -07:00
Ajay Bhargav Baaskaran
61de7fec6f
[ Fixes #5421 ] Visit children when accepting TagHelperChunk
...
- Fixes ViewComponentTagHelpers in nested scenarios
2016-10-18 12:00:07 -07:00
Jaspreet Bagga
c2fee4d74d
AcceptedResult(), AcceptedAtActionResult(), AcceptedAtRouteResult() support
...
Addresses #4937
2016-10-18 09:48:26 -07:00
Jaspreet Bagga
e7c992ff06
Added fragment to FormActionTagHelper and FormActionTagHelper
...
Addresses #4917
2016-10-18 09:46:50 -07:00
Doug Bunting
eea297975d
Reduce `HtmlContentBuilder` allocations
...
- #3918
- lazy-load `TagBuilder.InnerHtml`; add `HasInnerHtml` property for conservative use
- depends on aspnet/HtmlAbstractions@0781b5a (adds `HtmlContentBuilder.Count`)
- don't use a `HtmlContentBuilder` at all in `DefaultHtmlGenerator.GenerateValidationSummary()`
- avoid instantiating `HtmlContentBuilder` when short-circuits make it unnecessary
- provide correct `HtmlContentBuilder` capacity where known
2016-10-17 14:38:30 -07:00
Pranav K
a52d692de0
Updating to netcoreapp1.1
2016-10-13 11:21:09 -07:00
Pranav K
ed1378a365
Revert "Updating to netcoreapp1.1"
...
This reverts commit 398a104810 .
2016-10-12 16:09:12 -07:00
Pranav K
398a104810
Updating to netcoreapp1.1
2016-10-12 14:24:52 -07:00
Kiran Challa
d09e921c4a
Check for default constructor in ComplexTypeModelBinderProvider
2016-10-07 16:46:13 -07:00
Kiran Challa
e7fe635dab
Modified FormCollectionModelBinderProvider to throw when binding for FormCollection model type.
...
[Fixes #4895 ] No parameterless Constructor defined
2016-10-07 16:46:11 -07:00
Ajay Bhargav Baaskaran
e987e2107f
[ Fixes #5379 ] Dont generate TagHelperDescriptors for ViewComponents with generic parameters
2016-10-07 12:26:53 -07:00
Yves57
ed3b750ad2
Less allocations in ViewBuffer when there is only one ViewBufferPage
2016-10-07 11:25:30 -07:00
Kiran Challa
80da4611d9
Updated JsonPatchExtensionsTest exception message (Reacting to JsonPatch repo commit: 393c25988a)
2016-10-07 05:40:52 -07:00
jbagga
41f00eea23
Default Status Code for void types changed to 200
...
Fixes #4838
2016-10-06 14:39:04 -07:00
Kiran Challa
de7cea4000
Getting RouteDataRequestCultureProvider from Microsoft.AspNetCore.Localization.Routing package
2016-10-04 12:39:57 -07:00