Commit Graph

772 Commits

Author SHA1 Message Date
Pawel Kadluczka cc42b0eaef Fixing a bug where cancellation could result in HubException
When the client cancels a streaming method the server would send an error completion. This was not correct because cancellation is not an error. We did not see this because our client ignores any messages for a given streaming invocation after sending a CancelInvokationMessage but other clients may want to drain messages before considering a streaming method canceled.
2017-11-01 20:20:43 -07:00
BrennanConroy 8c446fc02d
[Redis] Save a few bytes for acks (#1070) 2017-11-01 16:48:36 -07:00
Nate McMaster e15a38a14c Pin package and tool versions to make build more repeatable 2017-11-01 16:40:51 -07:00
moozzyk 1d2e0fedb0 Enabling byte[] 2017-11-01 15:50:18 -07:00
Pawel Kadluczka 4d6383727a Updating jasmine
Needed for typed array verification
2017-11-01 15:50:18 -07:00
moozzyk 52862b23d7 Updating msgpack5 to the latest version 2017-11-01 15:50:18 -07:00
BrennanConroy 2419867dfc
Handle errors in Redis subscription callbacks (#1069) 2017-11-01 10:29:02 -07:00
Nate McMaster 8a7f495141
Specify NodeJS as a required toolset to build this repo (#1065) 2017-10-31 14:18:19 -07:00
BrennanConroy 83bb07d5a4
Fix parameter name (#1066) 2017-10-30 12:55:12 -07:00
Pawel Kadluczka 18f770e937
Late parameter binding (#1049)
Late parameter binding

Storing exception thrown during parameter binding and rethrowing when the method is about to throw. This allows completing invocations with a HubException and keeping the connection open.
We will also no longer close the connection if parameters for client side methods cannot be bound. We will log and continue.

Fixes: #818

(Also fixing #1005 because I was just touching this line)
2017-10-30 11:31:57 -07:00
Mikael Mengistu eec6b4f2f5 Removing Connected event from TestConnection (#1055) 2017-10-24 23:23:56 -07:00
BrennanConroy 30e7422407 Enable reconnect for Redis connection by default (#1037) 2017-10-24 14:30:13 -07:00
Mikael Mengistu 1768a081ba Updating default pattern(#1046) 2017-10-23 22:20:31 -07:00
Pawel Kadluczka e7e84035c0 Adding StreamCompletion message to the HubProtocol spec (#1041)
Adding StreamCompletion message to the HubProtocol spec
2017-10-23 10:45:14 -07:00
Pawel Kadluczka 57d2382c46 Http Post section revision (#1042)
* Http Post section revision

Fixes: #993
2017-10-23 10:29:47 -07:00
Pawel Kadluczka caff492cdc Removing sending OPTIONS request if WebSocket transport requested (#1036)
Removing sending OPTIONS request if WebSocket transport requested

This removes session stickiness requirement for WebSockets

Fixes: #1035
2017-10-23 10:28:33 -07:00
Mikael Mengistu 5ffb082acb Add Missing Await in Test (#1045) 2017-10-22 23:37:12 -07:00
BrennanConroy 9cc5d13a40 [Redis] Adding same group to connection multiple times should NOP (#1040)
* Added some additional tests too
2017-10-20 14:29:08 -07:00
Pawel Kadluczka 6bddb258cd Adding StreamCompletion message (TS) 2017-10-19 18:20:03 -07:00
Pawel Kadluczka 8d1d6d0300 Adding StreamCompletion message (C#) 2017-10-19 18:20:03 -07:00
Pawel Kadluczka 236aa63467 Don't build TS client needlessly (#1034) 2017-10-18 22:49:44 -07:00
Pawel Kadluczka a903a74db1 Adding roundtripping test for CancelInvocation message (#1031)
* Adding roundtripping test for CancelInvocation message
2017-10-18 22:49:15 -07:00
Mikael Mengistu 04d4da2987 Replace Received Event with OnReceived (#1006) 2017-10-18 17:10:51 -07:00
BrennanConroy bb308ff72e LoggerDefine for Redis (#1002) 2017-10-18 10:46:03 -07:00
Gurgen Hakobyan b3ac9f4bf8 Not very important code optimization (#1030)
Code optimization
2017-10-18 09:23:32 -07:00
BrennanConroy 0e70c7950b Adding Redis Unit tests (#1013) 2017-10-17 15:48:29 -07:00
BrennanConroy 878a70226c [Redis] Remove groups properly from connection diconnection (#1010)
And properly short circuit group actions for local connections
2017-10-17 14:15:00 -07:00
gurgen af286c81bb Groups collection without lock 2017-10-17 12:06:05 -07:00
Ryan Brandenburg 0aea1e851b Add RepositoryRoot 2017-10-16 14:54:38 -07:00
RoBackman a709158e8a Summary of changes\n\t- Improved logging to browser console\n\nAddresses #802 2017-10-16 10:29:17 -07:00
BrennanConroy de34990241 Short Circuit message to local connection in Redis (#1009) 2017-10-11 13:17:49 -07:00
BrennanConroy 8701baf73d Add negotiate timeout option to hub options (#1003) 2017-10-11 08:59:37 -07:00
BrennanConroy de535422d7 Optional error and complete functions for observables (#1000) 2017-10-10 16:42:50 -07:00
Ryan Brandenburg 6d9dd3c1cc Update bootstrappers 2017-10-09 12:43:40 -07:00
BrennanConroy de2e0967c3 Adding CancelInvocation message (#979)
* For Streaming only. And C# client only.
2017-10-06 15:55:39 -07:00
ivankarpey 665f166d67 fix issue with incorrect user detection when Invoking for User (#747)
* fix issue with incorrect user detection when Invoking for User

* fix failed testcases

* use proper extension method to avoid potential null reference exception

* fix for channel name in redis version + follow SignalR team recommendations

* remove unncessary freespace

* remove whitespaces

* introduce IUserIdProvider to resolve user id

* Move IUserIdProvider from HubLifetimeManager to HubConnectionContext

* setting user id to connection context in hubendpoint
2017-10-06 11:58:18 -07:00
Kai Ruhnau 3c5d283689 Fix the VarInt example for the 2GiB
`0x7fffffff` has 31 binary ones. The first four bytes of the VarInt account for 4*7=28, so the fifth byte only needs the remaining three
2017-10-06 10:38:21 -07:00
Mikael Mengistu 72514f3943 Removing the connected event (#989) 2017-10-05 11:12:18 -07:00
Pawel Kadluczka ba1c210f03 Fixing JS end-to-end tests 2017-10-04 12:04:08 -07:00
Pawel Kadluczka 8ab629d8f3 Merge branch 'rel/1.0.0-alpha2' into dev 2017-10-04 10:24:09 -07:00
Pawel Kadluczka 1887c7bb62 Changing version to final 2017-10-03 17:08:39 -07:00
Pawel Kadluczka 83bc056085 Merge branch 'rel/1.0.0-alpha2' into dev 2017-10-03 11:10:32 -07:00
Pawel Kadluczka aa0d5ec659 Updating HubProtocol spec to account for using VarInt to encode length prefix 2017-10-02 14:21:51 -07:00
Pawel Kadluczka 7c90e80b3f Merge branch 'rel/1.0.0-alpha2' into dev 2017-10-02 10:07:16 -07:00
Pawel Kadluczka 70df19c8a2 Fixing MsgPack serializing byte[] as string Part 1
Enabling sending byte[] from server to client.
2017-09-29 17:05:24 -07:00
Pawel Kadluczka 05da66ada0 Merge branch 'rel/1.0.0-alpha2' into dev 2017-09-28 17:52:25 -07:00
Pawel Kadluczka 602ca479b8 Checking if window.document defined before trying to resolve url 2017-09-28 17:01:34 -07:00
Pawel Kadluczka 4f4fb174ea Replacing 8-byte-long length prefix with varint 2017-09-28 17:00:49 -07:00
David Fowler 2adf24d1c6 Merge branch 'rel/1.0.0-alpha2' into dev 2017-09-25 23:44:25 -07:00
David Fowler e17cdae046 Added overloads from 0-n arguments (#949)
- Added 0 arg overload for InvokeAsync
2017-09-25 23:42:05 -07:00