Commit Graph

16192 Commits

Author SHA1 Message Date
Ryan Brandenburg 03460d81ce
Add retries to CDN downloads (#7881)
Add retries to CDN downloads
2019-02-25 14:44:22 -08:00
Mikael Mengistu 3d17ac3d4c
Handle onReceive logic in background thread (#7809) 2019-02-25 14:24:07 -08:00
Steve Sanderson 87f4ca7299
[Templates] Imports and CSS tweaks for forms/validation (#7914)
* Add Microsoft.AspNetCore.Components.Forms to default Components imports

* Add default validation CSS rules in Components/Blazor templates

* Add default validation CSS styles to Components testassets projects
2019-02-25 21:50:12 +00:00
Steve Sanderson 61098b6680
Make InputBase use EventCallback for ValueChanged (#7915)
* Make InputBase use EventCallback for ValueChanged

... so that the host component gets re-rendered automatically after each value change (like when binding to DOM elements).

* Improve E2E test code

... so that the host component gets re-rendered automatically after each value change (like when binding to DOM elements).
2019-02-25 21:49:28 +00:00
Hao Kung 9e21faeafb
Skip failing identity tests (#7926) 2019-02-25 12:55:35 -08:00
Nate McMaster d2d60000eb
Create Linux installers for the aspnetcore targeting pack (#7776)
This creates 3 new build outputs:

* aspnetcore-targeting-pack-$(version).tar.gz
* aspnetcore-targeting-pack-$(version)-linux-x64.deb
* aspnetcore-targeting-pack-$(version)-linux-x64.rpm

Other changes:
* Make RPM packaging consistent with other installers. Vendor == Microsoft Corporation
* Add shared properties for building the targeting pack (or not building it in a servicing build)
2019-02-25 12:00:36 -08:00
John Beisner f0cb6cc68b Modify the 'InstallLocation' registry key. (#7877)
Before = SOFTWARE\dotnet\Setup\InstalledVersions\<arch>\sdk
After = SOFTWARE\dotnet\Setup\InstalledVersions\<arch>
2019-02-25 11:05:00 -08:00
Javier Calvarro Nelson 23c528c176 [Azure] [Fixes #6033, #6580, #6669] Various fixes and cleanups.
* Adds an Azure AD Sample and adds a page to test access denied.
* Renames AzureAD and AzureADB2C internal classes for easier to debug
  stacktraces.
* Fixes service registration for options configuration.
* Adds missing deps to the solution.
2019-02-25 10:18:59 -08:00
Jiping a3e0a45d20 [Azure][Fixes #6669] AccessDeniedPath is wrong 2019-02-25 10:18:59 -08:00
Pavel Krymets 78bc2a10b9
Reenable IISExpress on helix (#7586) 2019-02-25 09:05:19 -08:00
Chris Ross ff79e9bda5
Replace EnvironmentName with Environments #7733 (#7899) 2019-02-25 08:13:48 -08:00
Nate McMaster f2658821b5
React to System.Runtime.CompilerServices.Unsafe moving into Microsoft.NETCore.App
React to dotnet/corefx#35526
2019-02-24 15:37:03 -08:00
Nate McMaster 5c525915cd
Update generated source code 2019-02-24 09:45:27 -08:00
Nate McMaster e02e047dcb
Merge branch 'master' into merge/release/3.0-preview3-to-master 2019-02-24 09:31:17 -08:00
BrennanConroy f8368097a9
Remove web::uri usage from public API (#7834) 2019-02-23 13:35:37 -08:00
Nate McMaster 1b27c9905c
Update dependencies and react to changes (#7844)
* Add workaround for dotnet/sdk#2976
* Add new restore sources
* Update BAR manifest to point to  https://dotnetfeed.blob.core.windows.net/aspnet-aspnetcore/index.json
* Obsolete WithCulture
* Add retries to dockerbuild.sh
* Ensure each test run gets a unique in-memory database
2019-02-22 19:09:08 -08:00
Pavel Krymets f1b188611a
Fix generated code (#7883) 2019-02-22 18:15:13 -08:00
John Luo e65004907a
Docker support not available for multi-project templates (#7878) 2019-02-22 16:55:30 -08:00
Stephen Halter 90e893ed07
React to #7751 (#7842) 2019-02-22 16:24:01 -08:00
BrennanConroy be63df852f
Skip RunsWithIterationEnvVariable (#7879) 2019-02-22 16:04:43 -08:00
Javier Calvarro Nelson efaaa55d44 [Templating] Add favicon.ico to the components template 2019-02-22 16:00:58 -08:00
Chris Ross 26d71e6ef6
Fix up Security samples #7765 (#7767) 2019-02-22 15:45:20 -08:00
Nate McMaster 7fe3b7640d
Merge branch 'release/3.0-preview3' 2019-02-22 15:07:50 -08:00
Nate McMaster f0ef784783 Run yarn import to convert package-lock.json to yarn.lock 2019-02-22 13:30:19 -08:00
Nate McMaster 5be7d30231 Replace npm commands with yarn 2019-02-22 13:30:19 -08:00
Ryan Nowak 3d448f7197 Fix #5055 use of page parameter (#7441)
This change introduces some new heuristics to make it easier to use
'page' or other resevered parameter names as parameters in URL
generation.

--

The main change here is to allow the link generation tree to *ignore* a
value passed in to URL generation when it conflicts with an endpoint's
required values.

The main concern of this feature area is "how do we tell whether you are
linking to an action or a page?". Routing attempts to do the right thing
will requiring very little from the user in terms of expressing intent.

In this case, we try to tell the difference between an attempt to generate
a link to an action due to the presence of the 'action' parameter and
absence of the 'page' parameter. This obviously doesn't work when you
want to use 'page' as a non-reserved parameter in an action. The same
case occurs for pages, but users are already used to the idea that
'action' is a reserved word in MVC.

We can loosen this restriction when the value that's supplied for 'page'
is known not to be any existing value of the 'page' route value.

This approach seems somewhat reasonable but has many of the problems inherent
to this area. When it fails (the value you want to use for 'page' causes
a conflict) - it's going to be esoteric and hard to understand.
2019-02-22 11:44:43 -08:00
Steve Sanderson 99d7d34447 In Razor Components template, use <environment> tag helper for bootstrap CSS. Fixes #6886 2019-02-22 17:39:00 +00:00
Chris Ross 7d90d4d1e7
Use friendly obsolete messages (#7831) 2019-02-22 08:40:34 -08:00
Justin Kotalik 57092e96ac
Implement Kestrel Request PipeReader (#7603) 2019-02-22 08:26:23 -08:00
Steve Sanderson 5315446054 Avoid UI flickering during transition from prerendered to live content 2019-02-22 16:25:44 +00:00
Pranav K 6a57218e14 Remove more references to JSRuntime.Current 2019-02-21 23:11:45 -08:00
Ryan Brandenburg 511538a19e
Revert bad merge in React app (#7769) 2019-02-21 21:46:27 -08:00
Javier Calvarro Nelson 2d9cba86fd [Components] Prerrendering startup experience (#7770)
[Components] Prerrendering startup experience
* Introduces an IComponentPrerrenderer to handle Prerrendering
  * MVC registers a basic static prerrrenderer.
  * Components registers a more feature complete prerrender that will
    handle reconnection to the original circuit after prerrendering in
    the future to allow for prerrendered interactive components.
* Removes UseRazorComponents
  * Removes the SPA fallback in favor of a catch all route in
    Index.cshtml
  * Moves the framework files to be served by the default StaticFiles
    middleware in the pipeline by way of plugging specific providers
    through options.
  * Lifts UseSignalR(r => r.MapHub<ComponentHub>()) into startup and
    replaces it with a shorthand for MapHub using endpoint routing.
  * Adds extension methods to map components to selectors for a given
    hub.
* Updates the razor component templates to include prerendering and use a razor page as the entry 
   point.
2019-02-21 16:26:44 -08:00
Javier Calvarro Nelson ea97934127 [Templating]Api authorization spa integration (#7721)
[Templating] Adds authentication support for the SPA templates
* Adds a new -auth option to the Angular and React templates with None and Individual values.
* When using authentication it configures the server to use the ApiAuthorization support built for 3.0
* For angular it adds an ApiAuthorization Angular module that handles the authentication flows through 
   a Login and a Logout components and exposes an Http client interceptor, a routing guard and a Login 
   menu component for the main Angular application to integrate authentication into the app.
* For react it adds a Login and Logout components to handle the authentication flows, an 
  AuthorizeRoute component to protect access to other routes and a Login menu component to 
  integrate authentication into the application.
2019-02-21 16:23:55 -08:00
John Luo 2fd9e40b58 Merge branch 'release/3.0-preview3' 2019-02-21 16:01:22 -08:00
Artak Mkrtchyan 26006e5b10 Updated the survey link for 0.9 release 2019-02-21 15:40:16 -08:00
BrennanConroy 6a06bf8532
Skip RunsWithIterationEnvVariable (#7814) 2019-02-21 15:31:40 -08:00
John Luo 4c0b114b12
Add gRPC templates (#7561) 2019-02-21 15:12:13 -08:00
Pavel Krymets 9355c7c1a5
Add reference assemblies support (#7764) 2019-02-21 14:33:35 -08:00
Ryan Nowak ebb527d347 [wip] Update Razor SDK and resolve issues
I'm still chasing one more issue.

(cherry picked from commit 616a4a36f5)
2019-02-21 11:42:23 -08:00
Nate McMaster 4451a80447
Merge branch 'release/3.0-preview3' 2019-02-21 10:30:11 -08:00
Nate McMaster 7a87e8c6a7
Re-enable building runtime packs
Also, sort debug output in SharedFx tests for improved readability
2019-02-21 09:38:11 -08:00
JulijaRamoskiene e5f4400257 FormFeature -Added exception for invalid content-disposition header (#7525) 2019-02-21 09:38:06 -08:00
Nate McMaster 6252351da7
Targeting pack and shared framework fixups (#7794)
* Fix package type to match spec ('DotnetPlatform')
* Fix missing metadata in MSI installer
* Fix incorrect target order which caused duplicate assemblies in netcore.app and aspnetcore.app
2019-02-21 09:28:58 -08:00
Ryan Nowak 616a4a36f5 [wip] Update Razor SDK and resolve issues
I'm still chasing one more issue.
2019-02-21 09:14:17 -08:00
Pranav K 51e2bea403
Throw if CORS policy is configured to allow credentials and any origin (#7751)
* Throw if CORS policy is configured to allow credentials and any origin

Fixes https://github.com/aspnet/AspNetCore/issues/3106
2019-02-21 09:06:00 -08:00
Pranav K 5418698f39 Disable CORS functional tests from running in parallel
Fixes https://github.com/aspnet/AspNetCore-Internal/issues/1845
2019-02-21 06:20:11 -08:00
Ryan Brandenburg 019a1be305 Make the linter happy 2019-02-20 17:02:56 -08:00
Ryan Brandenburg 918f3d3c40 Fix merge doubling 2019-02-20 16:35:52 -08:00
Ryan Brandenburg b2ee8e6b66 Merge branch 'merge/release/2.2-to-master' of https://github.com/dotnet-maestro-bot/AspNetCore into merge/release/2.2-to-master 2019-02-20 16:21:24 -08:00
Pranav K cc60fa9a18 Ensure templates are packed in the Blazor VSIX 2019-02-20 16:19:45 -08:00
Ryan Brandenburg 5a7bfbbc01
Use Bootstrap 3.4.1 and 4.3.1 (#7719)
Use Bootstrap 3.4.1. and 4.3.1
2019-02-20 15:55:49 -08:00
Mikael Mengistu f33cc20dbf
Add support for Async On Delegates (#7700) 2019-02-20 15:44:54 -08:00
Stephen Halter 001b6ea08a
Use .NET Core SequenceReader (#7003)
* Use .NET Core SequenceReader

Remove BufferReader and use SequenceReader<T> which now ships in CoreFX.

This is related to https://github.com/aspnet/KestrelHttpServer/pull/3068 which builds on the functionality added to the reader.

* Use var
2019-02-20 14:39:45 -08:00
BrennanConroy e455c2c22b
Add negotiation response support (#7675) 2019-02-20 12:38:43 -08:00
Nate McMaster 9a2db43848
Follow-up to VS2019 conversion (#7753)
* Set VS version in file to 16.0.0.0
* Fix for restore failure on Microsoft.AspNetCore.App.Runtime.csproj
2019-02-20 11:02:38 -08:00
Nate McMaster 85ae18c723
Make Visual Studio 2019 a prerequisite to building this repo (#7005)
Changes:

* Make Visual Studio 2019 a prerequisite for building this repo
* Update .sln files
* Update Windows SDK to 17134
* Update developer docs
* Disable ANCM tests
* Update to .NET Core SDK 3.0 Preview 2
* Use Microsoft.NET.Sdk.Razor as a package consistently accross the repo
* React to changes in metadata from Microsoft.NETCore.App
* React to changes in .NET Core SDK
* Attempt to workaround CodeCheck.ps1 failure which doesn't repro locally or on different agents. Possibly due to differences in the version of the PowerShell task?
* Remove dead YML file
* Rename usages of win7-{x64,x86} to win-{x64,x86}
* Update KoreBuild to 3.0.0-build-20190219.1
2019-02-20 09:53:53 -08:00
Steve Sanderson 895e1c69e0
Components/Blazor template updates (#7709)
* In Blazor hosted template, only UseBlazorDebugging in development environment. Fixes #7275

* Enable HTTPS in the Razor Components template. Fixes #6928

* Reduce Razor Components template to one project. Fixes #6883

* Minor phrasing tweak

* In Razor Components template, change .cshtml to .razor, except _ViewImports.cshtml

* Put back LangVersion

* Update RazorComponentsTemplateTest
2019-02-20 13:16:05 +00:00
Steve Sanderson 7a2dfd3200
Components: Forms and validation (#7614) 2019-02-20 09:56:32 +00:00
Chris Ross 4e44025a52
Replace IHostingEnvironment with IWebHostEnvironment (#7725) 2019-02-19 21:11:52 -08:00
Matthias Laroche 7af971838e Set Content-Length to 0, when returning an empty body
When returning 416 RangeNotSatisfiable in FileResultExecutorBase, set the Content-Length based on the length of the body instead of the length of the original file.
Bugfix for  :
https://github.com/aspnet/AspNetCore/issues/4943
2019-02-19 17:54:11 -08:00
Matthias Laroche 134f28f71d Update FileResult tests to detect a bug for the status 416 RangeNotSatisfiable
Update FileResult tests to detect a bug for the status 416 RangeNotSatisfiable :
https://github.com/aspnet/AspNetCore/issues/4943
When the body is empty, the Content-Length header should be 0 to match the body length.
2019-02-19 17:54:11 -08:00
Nate McMaster a9c358bbbd
Build MSI installers for targeting pack (#7726)
Part of #6501 

This adds a new Windows installer for the targeting pack. It places *.dll and *.xml (docs) in `[DOTNETHOME]\packs\Microsoft.AspNetCore.App.Ref\$(version)\ref\netcoreapp3.0`.

Outputs:
* aspnetcore-targeting-pack-$(version).zip
* aspnetcore-targeting-pack-$(version)-win-x64.exe (defaults to C:\Program Files\dotnet)
* aspnetcore-targeting-pack-$(version)-win-x86.exe (defaults to C:\Program Files (x86)\dotnet)

These all include the same files. These are meant to be bundled in the .NET Core SDK installer, but can be launched directly too.
2019-02-19 16:28:08 -08:00
Doug Bunting 8d6d300bfc
Improve service reference filenames and class names (#7447)
- #4927
- fully-sanitize class names and filenames
  - use aspnet/AspNetCore-Tooling's `CSharpIdentifier` class
- default metadata in sequence [URI or project&document name ->] `%(DocumentPath)` -> `%(OutputPath)` -> `%(ClassName)`
  - if user sets metadata explicitly, the override affects defaults later in the sequence
- separate some nested validations and defaulting steps
  - provide default `%(DocumentName}` even if `%(DocumentPath}` is set explicitly
  - validate URI is absolute even if `%(DocumentPath}` is set explicitly

other:
- don't write out an empty Open API / Swagger file

nits:
- do not use default `%(DocumentName}` in default `%(DocumentPath)` for `<ServiceProjectReference>` items
- do not use empty URI path or query string in default `%(DocumentPath)` for `<ServiceUriReference>` items
2019-02-19 16:05:54 -08:00
Ryan Nowak c725089e8b Add missing conversions on EventCallbackFactory 2019-02-19 15:48:16 -08:00
BrennanConroy f37d30833d
Ignore unexpected stream items and completions from client (#7511) 2019-02-19 15:25:50 -08:00
Doug Bunting 14b7184c09
Improve documentation of `BinderType` and `BindingSource` properties (#7218)
- add regression test for #4939
- add `[BindProperty]` doc comments
- add `<remarks>` to `BinderType` properties that recommend setting `BindingSource` in some cases

smaller issues:
- catch invalid `BinderType` values up front
- complete `BindingSource.ModelBinding` implementation: `IValueProvider` filtering was faulty

nits:
- accept VS suggestions e.g. remove unused variables
- "model binder" -> `<see cref="IModelBinder" /> implementation` in some doc comments
2019-02-19 15:22:04 -08:00
Doug Bunting 3e0c75187c
Place limits on model binding collection size and recursion depth (#7214)
- #7052
- add MvcOptions.MaxModelBindingCollectionSize` and `MvcOptions.MaxModelBindingRecursionDepth`

nits:
- update syntax of a few `Resources.Designer.cs` files (I ran `/t:resx` on Mvc.sln)
- take VS suggestions in a few test classes
2019-02-19 15:17:56 -08:00
Ryan Brandenburg 69abefa06f
[Design] Harden template package installer and fix name (#7624)
Harden template package installer and fix name
2019-02-19 14:41:59 -08:00
Mikael Mengistu d1fac57734
Ensure SignalR client messages are processed in order (#7697) 2019-02-19 11:48:22 -08:00
TimTim dffe9abf6b Fix connection ID (#7681) 2019-02-18 17:13:53 -08:00
Ben Adams 3e47fa7c69 Inline BufferWriter .ctor (#7674) 2019-02-17 21:30:29 -08:00
Ryan Nowak 98fe8a8328 Improvements to bind and event handling
The changes here make event dispatching (including bind) more
user-friendly by avoiding the need for manual calls to StateHasChnaged.

We also introduce a new type `EventCallback` (and `EventCallback<T>`).
This is a new primitive that is like a super-powered version of a
delegate. When writing a component that accepts delegates as parameters,
consider using `EventCallback` for the following reasons:
- Allows consumer to pass a variety of different delegate signatures
- Does proper event dispatching and error handling

Using `EventCallback` will eliminate most of the remaining cases where a
manual `StateHasChanged` is required when components are passing content
and delegates to each other.

`EventCallback` is inherently async for the reason that this is really
the only way to provide correct error handling.

-----

The fix for this will be two-phase by first creating a set of APIs that
can be targeted by the compiler that has the desired behaviour and then
updating the compiler to target this new infrastructure.
2019-02-17 15:58:08 -08:00
James Newton-King cc7b35439c
Add test for HTTP method metadata order (#7225) 2019-02-18 09:20:12 +13:00
Ben Adams 6b7e821913 Don't hardcode fixed size for GetMemory in ChunkedTests 2019-02-17 09:29:57 -08:00
Chris R b571246c93 Suppress warnings for obsolete Extensions types 2019-02-17 09:29:57 -08:00
Justin Kotalik 49a720c1dc Fix GetMemory to not pass in size hint 2019-02-17 09:29:57 -08:00
Mikael Mengistu af43b80b1a Make server timeout configurable (#7340) 2019-02-17 07:57:36 -08:00
Stephen Halter 8ae4c4dbd6 Add SignalR web worker sample and test (#7378) 2019-02-17 07:52:18 -08:00
Ben Adams 4646ed5618 Work around WriteBarrier assign for nulling struct (#7659) 2019-02-16 20:09:39 -08:00
David Fowler 0fd753bfc2
Align host behavior with respect to exceptions (#7657)
- Don't catch errors in IHostedService.StartAsync
- Only catch errors when executing StopAsync but rethrow an aggregate
- Updated the tests
2019-02-16 19:09:14 -08:00
David Fowler 799b91a324
Change the namespace of the extension methods (#7651)
- The other routing extension methods use Microsoft.AspNetCore.Builder
2019-02-16 00:36:59 -08:00
James Newton-King c2d1ab925e
Remove obsolete APIs from routing (#7371) 2019-02-16 18:37:51 +13:00
Mikael Mengistu c806c5a61a
Wait for stop to complete in SignalR test to prevent flakiness. (#7634) 2019-02-15 18:42:04 -08:00
Ben Adams 639d290b19 Lock-free IOQueue (#6154)
Second half of https://github.com/aspnet/AspNetCore/pull/4060
2019-02-15 18:26:30 -08:00
Chris Ross 191fb03de7
ITlsHandshakeFeature requires Win8+ (#7629) 2019-02-15 16:28:04 -08:00
Justin Kotalik 60b00fa007
Make reads that return canceled ReadResult throw (#7618) 2019-02-15 16:11:57 -08:00
Chris Ross 93a24b03bb
Disable AllowSynchronousIO by default in all servers #4774 (#5120)
* Disable AllowSynchronousIO by default in all servers
2019-02-15 16:05:49 -08:00
Pranav K 7daa0e0145
Convert BlazorExtension to SDK style project (#7588)
* Convert BlazorExtension to SDK style project

Fixes https://github.com/aspnet/AspNetCore/issues/7135
2019-02-15 15:14:19 -08:00
Pranav K fe1c2c84ee
Remove uses of JSRuntime.Current (#7599)
* Remove uses of JSRuntime.Current

Prerequisite for https://github.com/aspnet/AspNetCore/issues/6828
2019-02-15 15:14:00 -08:00
Pavel Krymets 9afdc48f13
Disable remote symbol loading for dump files in CI (#7620) 2019-02-15 14:42:36 -08:00
Chris Ross cc62bcebfc
Skip HttpSys.Https tests on Helix Internal/#1816 (#7578) 2019-02-15 12:33:23 -08:00
David Fowler 5ef51822de
Added endpoint routing support (#7608)
- Basic endpoint routing support to for SignalR hubs, ConnectionHandler and IConnectionBuilder endpoints
- Updated all functional tests and samples to use it
- Added all attributes as metadata from Hubs and ConnectionHandlers
- Added a test to verify client is rejected if auth is ineffective
2019-02-15 12:32:01 -08:00
Pavel Krymets 6bafb7cb6f
Log before releasing streams and firing tokens (#7583)
Might fix: https://github.com/aspnet/AspNetCore-Internal/issues/1659

I think writes complete too fast so we don't observe when the message gets logged
2019-02-15 10:41:21 -08:00
Justin Kotalik 25f1f59378
Make first write use the same BufferWriter (#7505) 2019-02-15 08:26:57 -08:00
Nikita Potapenko 98ad532822 Removed comments
Fixes #7579
2019-02-15 13:20:14 +00:00
Ajay Bhargav Baaskaran c565386a3e
Merge pull request #7597 from aspnet/ajbaaska/merge-master
Merge branch 'release/2.2' to master
2019-02-14 23:20:18 -08:00
Doug Bunting b711d6cf67
Merge branch 'release/2.1' into release/2.2 2019-02-14 21:18:02 -08:00
Ajay Bhargav Baaskaran b3d3f5e7fb Updated missed slns 2019-02-14 17:35:48 -08:00
Ryan Brandenburg 4932a4bad5 Fix typemismatch 2019-02-14 17:15:41 -08:00
Ryan Brandenburg 3b1a0e4755 Fix algos 2019-02-14 17:15:41 -08:00
Ryan Brandenburg a47139f033 Fix sha tests 2019-02-14 17:15:41 -08:00
Ryan Brandenburg f8dea0e7f9 Fix integrity checks 2019-02-14 17:15:41 -08:00
Ryan Brandenburg 15c5dfec2e Upgrade bootstrap versions 2019-02-14 17:15:41 -08:00
Ryan Brandenburg bd4af873b0 Fix urls 2019-02-14 17:13:06 -08:00
Ryan Brandenburg 137d2d2357 Fix whitespace 2019-02-14 17:13:06 -08:00
Ryan Brandenburg 6786f97526 Update simpleapp test 2019-02-14 17:13:06 -08:00
Ryan Brandenburg 271e222b51 Update to bootstrap 3.4.1 2019-02-14 17:13:06 -08:00
Nate McMaster 6defaadb8b
Update location of obj/ and bin/ directories to match Arcade conventions (#7585) 2019-02-14 16:27:53 -08:00
Ajay Bhargav Baaskaran 7a26d27e8b Merge branch 'release/2.2' 2019-02-14 16:08:51 -08:00
BrennanConroy 9fda946f0f
[Backport] Add CancelInvocation support to MsgPack in TS client (#7404) 2019-02-14 13:49:49 -08:00
Ajay Bhargav Baaskaran a8277408d9
Merge pull request #7542 from dotnet-maestro-bot/merge/release/2.1-to-release/2.2
[automated] Merge branch 'release/2.1' => 'release/2.2'
2019-02-14 10:43:50 -08:00
Chris Ross 44e6813452
Use new version of h2spec #6691 (#7559) 2019-02-14 09:28:58 -08:00
Joseph Musser 50587d7d6d Fix “must comprised of” (#7519)
* Fix missing word

* Replace ‘comprise’ with simpler wording
2019-02-14 09:27:55 -08:00
BrennanConroy bca85b92fc
More C++ Client cleanup (#7551) 2019-02-14 08:31:15 -08:00
Ryan Brandenburg 6ea3f27dbb
Merge pull request #4565 from martinpe36/master
Update React-Redux client app to use TypeScript instead of JavaScript
2019-02-14 08:14:07 -08:00
Nate McMaster 0ec25d3167
Create new 'runtime pack' nuget packages for Microsoft.AspNetCore.App (#7475)
* Create a new package  - Microsoft.AspNetCore.App.Runtime.${rid} - which contains crossgen-ed versions of shared framework assemblies. This will be used by the SDK to replace rid-split packages
* Add a task which can generate the .deps.json file for the shared framework. Unlike the existing task we have, this does not rely on consuming a .deps.json file generated by first running a restore on packages.
* Move the reference to xunit.runner.console into the normal targets and files for managing dependencies
* Produce binlogs during build
2019-02-14 07:25:13 -08:00
Vakhtangi Abashidze a314cb2773 PointerID type string replaced to long (#7426)
Solves issue [#7418](https://github.com/aspnet/AspNetCore/issues/7418) - Blazor onpointerdown event gives error
2019-02-14 03:24:13 -08:00
Stephen Halter 132a1ad31b
Remove capture of "this" from local function (#7467) 2019-02-14 00:21:39 -08:00
Doug Bunting d102d10a81 Update branding to 2.2.3
- new version
- update baselines
- grab latest released Microsoft.NetCore.App and Microsoft.NETCore.DotNetAppHost

nit:
- updated ZipManifestGenerator's README.md to use 2.2 examples
2019-02-13 23:15:58 -08:00
James Newton-King 05895cde64
Fix endpoint routing flaky test on build server in 2.2 (#7489) 2019-02-14 17:48:22 +13:00
Nate McMaster 94109e6655
Add package override manifest to the targeting pack (#7555) 2019-02-13 19:32:47 -08:00
Ryan Nowak f2a1a4542e
Introduce dynamic endpoints and fix #7011 (#7445)
* Add IDynamicEndpointMetadata for dynamic endpoints

* Use a dynamic endpoint policy for pages
2019-02-13 18:52:07 -08:00
Pranav K 27e54a1b7a Skipping flaky test 2019-02-13 16:45:36 -08:00
Pranav K 9053bc6e29 Re-enable skipped runtime compilation tests 2019-02-13 16:45:36 -08:00
BrennanConroy 9de42d516e
Copy Kestrel perf changes (#7480) 2019-02-13 16:31:37 -08:00
Ajay Bhargav Baaskaran a2f27426a5 Add missed tests 2019-02-13 16:25:31 -08:00
Jeremy Kuhne a02ac20183 Use var 2019-02-13 16:20:34 -08:00
Jeremy Kuhne 2c649b2409 Use .NET Core SequenceReader
Remove BufferReader and use SequenceReader<T> which now ships in CoreFX.

This is related to https://github.com/aspnet/KestrelHttpServer/pull/3068 which builds on the functionality added to the reader.
2019-02-13 16:20:34 -08:00
Chris Ross d1aa53721b
Add launchSettings.json to worker template (#7550)
* Add launchSettings.json to worker template #7545
* Switch back to the Web SDK
2019-02-13 15:54:15 -08:00
Ajay Bhargav Baaskaran 0c2ee920a1 Merge branch 'release/2.1' into release/2.2 2019-02-13 14:52:38 -08:00
Nate McMaster 338de4710a
Automatically set 'PrivateAssets=All' for .Sources references (#7539)
When a `<Reference>` is named `*.Sources`, set PrivateAssets=All (exclude from generated nuspec) and IncludeAssets=ContentFiles (only consume content files, not .dll's)
2019-02-13 14:31:15 -08:00
Pranav K cddbc2e888
Improve Components error handling (#7165)
* Improve Components error handling

* Change event handlers IHandleEvent, IHandleAfterEvent to be async.
* Return faulted tasks to Renderer instead of handling exceptions in ComponentBase
* Use ILogger in RemoteRenderer, and log to console in WebAssemblyRenderer
* Cleaning up touched files

Fixes https://github.com/aspnet/AspNetCore/issues/4964
2019-02-13 14:22:46 -08:00
Ajay Bhargav Baaskaran 4cceccd568
Make Mvc repo folder layout consistent (#7518) 2019-02-13 10:53:39 -08:00
Mikael Mengistu 3d3ad96206
SignalR Java Client LongPolling Transport (#6856) 2019-02-13 10:27:07 -08:00
Nate McMaster 2ac4619635
Replace custom targets for generating assembly attributes and source control info by using SDK features (#7504) 2019-02-13 10:22:03 -08:00
Chris Ross 06d7fe73a9
Implement ITlsHandshakeFeature for HttpSys (#7284) 2019-02-13 08:39:45 -08:00
Nate McMaster 3fd8a97af2
Add targets to generate the list of shared framework assemblies from project property (#7510)
Changes:
* Add support for a property, `IsAspNetCoreApp`, in the .csproj file of assemblies which are part of the shared framework. 
* Remove unused dependencies
* Remove reference which have become part of 'netcoreapp3.0'
2019-02-12 23:00:19 -08:00
Doug Bunting 5bbf7109a5
Fail `ComplexTypeModelBinder` after `CanCreateModel(...)` in some cases (#6793)
- #4802 and #6616
- also reduces the impact incorrect metadata as in #4939
- postpone some property binding in `ComplexTypeModelBinder`
2019-02-12 22:15:43 -08:00
Hao Kung 9ab72f6202
Skip flaky Components test on Helix (#7488) 2019-02-12 21:15:28 -08:00
Doug Bunting 447306cbb9
Merge branch 'release/2.1' into release/2.2 2019-02-12 19:32:03 -08:00
Doug Bunting 5bb5bafbed Update branding to 2.1.9 2019-02-12 19:12:20 -08:00
BrennanConroy 1c6651a1ae
Fixup handshake logic and layering (#7470) 2019-02-12 17:06:56 -08:00
Chris Ross 8f72b87981
Enable docker for the worker template #6817 (#7508) 2019-02-12 15:09:27 -08:00
Pranav K 173b2f91fb
Trim Async suffix on action names (#7420)
Fixes https://github.com/aspnet/AspNetCore/issues/4849
2019-02-12 13:30:38 -08:00
Javier Calvarro Nelson 6827bb7443
[Templating] Razor class library for components (#7461)
* [Components] Razor class library for components
* Updates the Razor Class Library to be a portable components library by
  default.
* Adds an option to support the old RCL that includes support for Views
  and pages.
* Usage:
  * `dotnet new razorclasslib` produces the same traditional Razor Class Library.
  * `dotnet new razorclasslib -s false` produces a Razor Class Library without views and pages support.
2019-02-12 06:08:11 -08:00
David Fowler c1bc210e8e
Fix returning buffered data after stream is drained (#7476)
- Change TryRead to return the buffer if the Stream is completed
2019-02-11 20:45:15 -08:00
Chris Ross 05923e9151
Get worker tempalte showing up in VS (#7478) 2019-02-11 20:25:17 -08:00
Ryan Nowak acd1cf3251
Update MVC/Routing Startup Experience (#7425)
* Relayer MvcEndpointDataSource

Separates the statefulness of the data source from the business logic of
how endpoints are created.

I'm separating these concerns because one of the next steps will split
the MvcEndpointDataSource into two data sources.

* Simplify MvcEndpointInfo

Removing things that are unused and leftovers from the 2.2 design of
this feature.

* Remove per-route conventions

Removes the ability to target endpoint conventions
per-conventional-route. This was a neat idea but we have no plans to
ship it for now.

Simplified MvcEndpointInfo and renamed it to reflect its new purpose.

* Remove filtering from MvcEndpointDataSource

This was neat-o but we're not going to ship it like this. We're going to
implement filtering in another place. Putting this in the data source is
pretty clumsy and doesn't work with features like application parts that
need to be baked in addservices

* Simplify ActionEndpointFactory

* Split up data sources

* Use UseRouting in functional tests

I've rejiggered our functional tests to de-emphasize UseMvc(...) and
only use it when we're specifically testing the old scenarios.
UseMvc(...) won't appear in templates in 3.0 so it's legacy.

* Update templates

* Add minor PR feedback

* one more
2019-02-11 19:18:05 -08:00
Justin Kotalik 2a9caa0343
AsTask => GetAsTask() (#7468)
* AsTask => GetAsTask()

* Another spot

* Another spot
2019-02-11 16:55:28 -08:00