Skip HttpSys.Https tests on Helix Internal/#1816 (#7578)

This commit is contained in:
Chris Ross 2019-02-15 12:33:23 -08:00 committed by GitHub
parent 5ef51822de
commit cc62bcebfc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 2 deletions

View File

@ -48,6 +48,6 @@ This will restore, and then publish all of the test projects including some boot
## How to skip tests on helix
There are two main ways to opt out of helix
- Skipping the entire test project via `<BuildHelixPayload>false</BuildHelixPayload>` in csproj (the default value for this is IsTestProject).
- Skipping an individual test via `[SkipOnHelix]` which might require including a compile reference to: `<Compile Include="$(SharedSourceRoot)test\xunit\SkipOnHelixAttribute.cs" />`
- Skipping an individual test via `[SkipOnHelix]` which might require including a compile reference to: `<Compile Include="$(SharedSourceRoot)test\SkipOnHelixAttribute.cs" />`
Make sure to file an issue for any skipped tests and include that in a comment next to either of these

View File

@ -17,6 +17,7 @@ using Xunit;
namespace Microsoft.AspNetCore.Server.HttpSys
{
[SkipOnHelix] // https://github.com/aspnet/AspNetCore-Internal/issues/1816
public class HttpsTests
{
[ConditionalFact]

View File

@ -8,6 +8,7 @@
<ItemGroup>
<Reference Include="Microsoft.AspNetCore.Server.HttpSys" />
<Reference Include="System.Net.Http.WinHttpHandler" />
<Compile Include="$(SharedSourceRoot)test\SkipOnHelixAttribute.cs" />
</ItemGroup>
<PropertyGroup>

View File

@ -9,7 +9,7 @@ namespace Microsoft.AspNetCore.Testing.xunit
/// Skip test if a given environment variable is not enabled. To enable the test, set environment variable
/// to "true" for the test process.
/// </summary>
[AttributeUsage(AttributeTargets.Method, AllowMultiple = false)]
[AttributeUsage(AttributeTargets.Method | AttributeTargets.Class, AllowMultiple = false)]
public class SkipOnHelixAttribute : Attribute, ITestCondition
{
public bool IsMet