Commit Graph

20471 Commits

Author SHA1 Message Date
Chris Ross aeb3537b61
Quarantine InputRadioGroupsWithNamesNestedInteractWithEditContext (#24853) 2020-08-13 00:23:53 +00:00
Chris Ross ac6b62b5df
Merge branch 'master' into merge/release/3.1-to-master 2020-08-12 16:42:51 -07:00
James Newton-King 7532d730ed
Remove unused HTTP/2 streams from pool (#24767) 2020-08-13 10:11:15 +12:00
Chris Ross 3b9c16ce28
Cherry pick preview8 changes into master (#24849)
* Pass RequestAborted to SendFileAsync

* Fix HttpSys tests
2020-08-12 21:30:04 +00:00
James Newton-King ffeeb034f5
Add gRPC standard headers to known headers (#24714) 2020-08-13 08:59:44 +12:00
Safia Abdalla 577f1a760f
Add tests for navigate on form submit (#24684)
* Add tests for navigate on form submit
* Add fix for re-render after event dispatch
* Remove deferred event handling in .NET
* Only dispatch events with registered handlers once
2020-08-12 09:57:58 -07:00
Mackinnon Buck 40869f8969
InputRadio validation styling fix (#24762) 2020-08-12 09:03:29 -07:00
msftbot[bot] 4092201629
Merge pull request #24823 from dotnet-maestro-bot/merge/release/5.0-preview8-to-master
[automated] Merge branch 'release/5.0-preview8' => 'master'
2020-08-12 03:56:30 +00:00
Stephen Halter 292cb9c5dd
Kestrel SNI from config (#24286) 2020-08-11 19:18:37 -07:00
Pranav K c3a12cefae
Include the DebugProxy binaries in DevServer (#24817)
* Remove unused nuspec property that relied on relative path
2020-08-11 19:14:35 -07:00
James Newton-King 57b5321417
Fix flaky keepalive ping test (#24804)
* Fix flaky keepalive ping test

* Clean up stream
2020-08-12 00:23:56 +00:00
JLeczycki 7632afc4eb
Pass the exception to HealthCheckEnd log message (#24786)
There was null intead of exception passed.
2020-08-11 10:58:51 -07:00
Doug Bunting 522088b6be
Do not run hostname tests on macOS 2020-08-11 10:45:39 -07:00
David Fowler fcf2823f3a
Support linking with IHubFilter (#24780)
- Mark AddFilter to make sure constructors don't get erased during aggressive linking
2020-08-11 10:39:52 -07:00
Pranav K 8e5533f2a3
Use BlazorWebAssemblySDK (#24371)
* Use BlazorWebAssemblySDK

* Update projects to use the BlazorSDK
* Remove tasks and targets from RazorSDK
* Remove workarounds from BlazorSDK

* Fixup

* Fixup
2020-08-11 17:29:01 +00:00
Doug Bunting 7efec87a14
Fix fetch of package version in eng/Publishing.props (#24777)
- target project is a test project; need to undo `$(SkipTestBuild)` impact in these jobs

nit: remove a comment from DeveloperCertificates project that's irrelevant now
2020-08-11 10:10:24 -07:00
github-actions[bot] 6f802812a3
Sync shared code from runtime (#24784)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2020-08-11 11:29:32 +00:00
Pranav K 059e2fdc49
Remove Internal.AspNetCore.Analyzers (#24693)
* Remove Internal.AspNetCore.Analyzers

This resolves build flakiness caused by referencing the analyzer:

```
2020-08-07T21:22:39.1149296Z ##[error].dotnet\sdk\5.0.100-rc.1.20379.10\Microsoft.Common.CurrentVersion.targets(4188,5): error MSB3026: (NETCORE_ENGINEERING_TELEMETRY=Build)
Could not copy "F:\workspace\_work\1\s\artifacts\obj\Internal.AspNetCore.Analyzers\Release\netstandard1.3\Internal.AspNetCore.Analyzers.dll"
to "F:\workspace\_work\1\s\artifacts\bin\Internal.AspNetCore.Analyzers\Release\netstandard1.3\Internal.AspNetCore.Analyzers.dll". Beginning retry 1 in 1000ms.
The process cannot access the file 'F:\workspace\_work\1\s\artifacts\bin\Internal.AspNetCore.Analyzers\Release\netstandard1.3\Internal.AspNetCore.Analyzers.dll' because it is being used by another process.
```

The analyzer checks if pubternal types are being exposed in public APIs. We no longer author pubternal types, so this is no longer a concern.

* Remove DisablePubternalApiCheck
2020-08-11 03:08:55 +00:00
James Newton-King 5fbd1eb007
Reset KeepAliveTimeout on HTTP/2 ping (#24644) 2020-08-11 14:59:24 +12:00
Pranav K fb5dd8564e
Quarantine tests (#24757)
* Quarantine LinkedApplicationWorks

* Quarantine flaky tests

* Quarantine CanBindTextbox_Decimal_InvalidInput

* React to NetworkException type

* One more test
2020-08-11 01:06:20 +00:00
Pranav K fd1a5c5a9c
Merge pull request #24641 from dotnet-maestro-bot/merge/release/5.0-preview8-to-master
[automated] Merge branch 'release/5.0-preview8' => 'master'
2020-08-10 17:13:51 -07:00
James Newton-King 3de55dfd21
Increase HTTP/2 stream pool max size to 100 (#24712) 2020-08-11 10:29:41 +12:00
Levi Broderick bbf7c8780c
Clean up some usage of SHA1 and SHA256 in the code base (#24696)
* AntiForgery: Use SHA256 one-shot

* AuthN: Use SHA256 one-shot APIs

* MVC/Razor: Cleanup SHA256 references

* WebSockets: Use SHA1 one-shots

* dotnet-openapi: Use preferred SHA256 factory

* SignalR: Prefer RNG.Fill over RNG.GetBytes
2020-08-10 14:26:41 -07:00
David Fowler 0e592df3ec
Make authentication linker friendly (#24708)
* Make authentication linker friendly
- Preserve constructors wherever open generics or type arguments exist
2020-08-10 13:06:19 -07:00
dotnet-maestro[bot] 927ddab349
[master] Update dependencies from dotnet/runtime dotnet/efcore (#24717)
* Update dependencies from https://github.com/dotnet/runtime build 20200808.3

System.ComponentModel.Annotations , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Extensions.Internal.Transport , Microsoft.Extensions.Http , Microsoft.Extensions.Hosting , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting.Abstractions , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry , Microsoft.Win32.SystemEvents , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Ref , System.Drawing.Common , System.Text.Encodings.Web , System.Text.Json , System.Threading.Channels , System.Windows.Extensions , System.ServiceProcess.ServiceController , System.Security.Principal.Windows , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Net.WebSockets.WebSocketProtocol , System.Reflection.Metadata , System.Resources.Extensions , System.Runtime.CompilerServices.Unsafe , System.Security.AccessControl , System.Security.Cryptography.Cng , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions
 From Version 5.0.0-rc.1.20406.11 -> To Version 5.0.0-rc.1.20408.3

* Update dependencies from https://github.com/dotnet/runtime build 20200809.3

System.ComponentModel.Annotations , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Extensions.Internal.Transport , Microsoft.Extensions.Http , Microsoft.Extensions.Hosting , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting.Abstractions , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry , Microsoft.Win32.SystemEvents , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Ref , System.Drawing.Common , System.Text.Encodings.Web , System.Text.Json , System.Threading.Channels , System.Windows.Extensions , System.ServiceProcess.ServiceController , System.Security.Principal.Windows , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Net.WebSockets.WebSocketProtocol , System.Reflection.Metadata , System.Resources.Extensions , System.Runtime.CompilerServices.Unsafe , System.Security.AccessControl , System.Security.Cryptography.Cng , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions
 From Version 5.0.0-rc.1.20406.11 -> To Version 5.0.0-rc.1.20409.3

* Update dependencies from https://github.com/dotnet/efcore build 20200810.1

Microsoft.EntityFrameworkCore.Tools , Microsoft.EntityFrameworkCore.SqlServer , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.InMemory
 From Version 5.0.0-rc.1.20406.4 -> To Version 5.0.0-rc.1.20410.1

* Update dependencies from https://github.com/dotnet/efcore build 20200810.2

Microsoft.EntityFrameworkCore.Tools , Microsoft.EntityFrameworkCore.SqlServer , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.InMemory
 From Version 5.0.0-rc.1.20406.4 -> To Version 5.0.0-rc.1.20410.2

* React to S.T.Json changes

* Update LangVersion=9.0 in the repo to use T?
* Remove LangVersion project project files

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Pranav K <prkrishn@hotmail.com>
2020-08-10 19:50:18 +00:00
Pranav K 56be06bc7d
Update test runner to 2.4.3 (#24685) 2020-08-10 12:32:04 -07:00
Eric Erhardt d25a7658c8
Remove LinkerWorkaround.xml (#24748)
* Remove LinkerWorkaround.xml

The workaround file is no longer needed, now that the underlying bugs are fixed in the dotnet/runtime libraries.

Fix #23262

* Also remove LinkerWorkaround from Components/WebAssembly
2020-08-10 18:59:59 +00:00
Pranav K 6e006e3e2a
Merge remote-tracking branch 'origin/release/5.0-preview8' 2020-08-10 11:39:18 -07:00
Safia Abdalla 15ba83248f
Add guard check for cleared closest DOM element (#24707)
* Add guard check for cleared closest DOM element

* Update src/Components/Web.JS/src/Rendering/BrowserRenderer.ts

Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>

Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
2020-08-10 16:50:50 +00:00
David Fowler 24f35bc76f
Update ReferenceEqualityComparer.cs (#24728)
We don't support running on mono 4.x anymore
2020-08-10 09:08:45 -07:00
David Fowler fa0cb71186
Make the default route constraints linkable (#24727)
- Added a helper that gives the linker the ability to preserve the constructors of these types
2020-08-09 20:23:54 -07:00
github-actions[bot] 983e7ed635
Sync shared code from runtime (#24699)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2020-08-08 13:00:25 +00:00
Kahbazi d0a8117ac4
Use HasFlag in ForwardedheadersMiddleware (#24660) 2020-08-08 02:36:19 +00:00
Pranav K 383a272f36
Quarantine falky test ServerEventTest.EventDuringBatchRendering_CanTriggerDOMEvents (#24691)
* Quarantine falky test ServerEventTest.EventDuringBatchRendering_CanTriggerDOMEvents

Blazor's E2E testing uses a much shorter timeout after a test failure. This test run had several test failures, but most of these appear to be the result of
an incredibly short timeot. This PR quarantines the one test that appears to be a genuine failure and also increases the timeout duration for after test failure.

* Quarantine ServerExecutionTests.ServerGlobalizationTest.CanSetCultureAndParseCultureSensitiveNumbersAndDates
2020-08-07 23:16:53 +00:00
Adam Sitnik a196a6a0db
stop using RuntimeInformation.IsOSPlatform(OSPlatform.Browser) (removed in upcoming builds) (#24652)
switch back to RuntimeInformation.IsOSPlatform(OSPlatform.Create("BROWSER"))
2020-08-07 19:10:02 +00:00
Justin Kotalik 6020fdef0b
Add reset support for IIS (#24552) 2020-08-07 11:08:40 -07:00
Steve Sanderson 8ba7c7b457
Throw if a component produces an invalid render tree. Fixes #24579 (#24650) 2020-08-07 16:41:08 +01:00
Safia Abdalla 7eb58e045d
Add workaround for deprecated overload in authentication scenarios (#24600)
* Add workaround for deprecated overload in authentication scenarios

* Respond to feedback from peer review

* Use explicit version in Version.props

* Temporarily disable NU1065 warning

* Always use latest package version
2020-08-07 08:37:16 -07:00
Pranav K 146d316bc5
Add a middleware for browser refresh. (#24574)
* Add a middleware for browser refresh.

* Introduce a middleware that can connect to the dotnet-watch change server
* dotnet-watch: Inject the middleware in 3.1 or apps using start hooks \ hosting startup

https://github.com/dotnet/aspnetcore/issues/23412

* Update src/Tools/dotnet-watch/BrowserRefresh/src/StartupHook.cs

* Changes per PR comments

* Add a test for reading the script

* Changes per PR comments

* Updates docs

* Fixup test

* Add project ref
2020-08-06 17:20:51 -07:00
github-actions[bot] 973a97fc4b
Sync shared code from runtime (#24630)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2020-08-06 21:26:32 +00:00
Mackinnon Buck 6c35e2e84d
Fixed flaky test 'CanInfluenceHeadDuringPrerender'. (#24624) 2020-08-06 14:02:30 -07:00
Justin Kotalik 9d783c5b76
Quarantine CanInfluenceHeadDuringPrerender (#24603)
* Update PrerenderingTest.cs

* using
2020-08-06 18:40:38 +00:00
Justin Kotalik c924af3bd7
IIS HTTP/2 Response Trailers (#24120) 2020-08-06 09:21:51 -07:00
David Fowler ed5034eb8e
Actually fix the CopyToAsync this time (#24609)
* Actually fix the CopyToAsync this time
- Hard code the 4K buffer length for CopyToAsync
- Write a test this time :D
2020-08-05 21:11:57 -07:00
Roman Marusyk a28c2b62dc
Update documentation for returns of indexer in IRequestCookieCollection when key is not present (#24497) 2020-08-05 19:36:07 -07:00
David Fowler 8cbe97df4b
Added connection logs (#24607) 2020-08-05 18:57:14 -07:00
dotnet-maestro[bot] f52077f599
[master] Update dependencies from dotnet/runtime dotnet/efcore (#24496)
* React to SDK changes

* Skip instead of quar

* Rely on transitive Microsoft.Bcl.AsyncInterfaces since it's now part of DependencyInjection.
    - This was introduced as part of: https://github.com/dotnet/runtime/pull/40189
    - Prior to this we'd get version conflicts for our referenced Bcl.AsyncInterfaces.

* Update global.json
    - move to RC1 SDK

* React to runtime nullability changes with DataAnnotations.
    - ValidationResult was updated to declare its nullability: a9009db46e (diff-8e86bc8fee3eb0242c5b8368dfabe065)

* Stop using HttpRequestMessage.Properties in favor of non-obsoleted HttpRequestMessage.Options.
    - Introduced in 3eda592cf4

* Stop using more HttpRequestMessage.Properties in Component's web assembly project.
    - Introduced in dotnet/runtime@3eda592

* Update dependencies from https://github.com/dotnet/runtime build 20200804.16

System.ComponentModel.Annotations , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Extensions.Internal.Transport , Microsoft.Extensions.Http , Microsoft.Extensions.Hosting , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting.Abstractions , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry , Microsoft.Win32.SystemEvents , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Ref , System.Drawing.Common , System.Text.Encodings.Web , System.Text.Json , System.Threading.Channels , System.Windows.Extensions , System.ServiceProcess.ServiceController , System.Security.Principal.Windows , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Net.WebSockets.WebSocketProtocol , System.Reflection.Metadata , System.Resources.Extensions , System.Runtime.CompilerServices.Unsafe , System.Security.AccessControl , System.Security.Cryptography.Cng , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions
 From Version 5.0.0-rc.1.20370.4 -> To Version 5.0.0-rc.1.20404.16

* Ignitor to 5.0

* Constants

* Update dependencies from https://github.com/dotnet/efcore build 20200805.3

Microsoft.EntityFrameworkCore.Tools , Microsoft.EntityFrameworkCore.SqlServer , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.InMemory
 From Version 5.0.0-rc.1.20372.13 -> To Version 5.0.0-rc.1.20405.3

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Pranav K <prkrishn@hotmail.com>
Co-authored-by: wtgodbe <wigodbe@microsoft.com>
Co-authored-by: N. Taylor Mullen <nimullen@microsoft.com>
Co-authored-by: Justin Kotalik <jukotali@microsoft.com>
2020-08-05 18:42:25 -07:00
Stephen Halter b052c4fcc2
Upgrade Gradle used for the SignalR Java client from 6.1 to 6.5 (#24495) 2020-08-05 17:23:32 -07:00
msftbot[bot] 4752d95a76
Merge pull request #24596 from dotnet-maestro-bot/merge/release/5.0-preview8-to-master
[automated] Merge branch 'release/5.0-preview8' => 'master'
2020-08-05 22:01:31 +00:00
Kahbazi b2c7d514c9
[Kestrel] Move to GenericHost (#24279)
* [Kestrel] Move to GenericHost

* Change TransportSelector

* Add an empty app for TestServer

* Add an empty app for TestServer

* Set app

* Stop host

* Stop the TestSserver

* Stop more hosts!

* Stop host in dispose

* implement IAsyncDisposable for TestServer

* configure await

* catch OperationCanceledException

* Apply suggestions from code review

Co-authored-by: Brennan <brecon@microsoft.com>
2020-08-05 21:48:53 +00:00
Pranav K b8b438d945
Add additional constructor to HealthReport (#24597)
Co-authored-by: Serg046 <serg046@outlook.com>
2020-08-05 21:21:55 +00:00
Justin Kotalik e75a5c166a Merge branch 'release/5.0-preview8' into master 2020-08-05 13:47:27 -07:00
witskeeper 2831aaa08a
fix : failureStatus (#21175)
* fix : failureStatus

use HealthCheckRegistration.FailureStatus when CheckHealthAsync failure

Fixes https://github.com/dotnet/aspnetcore/issues/22503
2020-08-05 13:00:08 -07:00
Pranav K b654051748
Remove Blazor internal profiling infrastructure (#24468) (#24589)
* Put back InternalCalls

* Removing .NET profiling calls

* Remove JS side profiling

Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
2020-08-05 12:45:42 -07:00
WuYafeng 748798889b
Fix:ControllerLinkGeneratorExtensions.GetAmbientValues throws NullReferenceException (#24576)
- related issue #24412
- add null check on GetAmbientValues(HttpContext)
2020-08-05 09:33:31 -07:00
Steve Sanderson f05827484e
Speed up multiple attributes overwrite detection. Fixes #24467 (#24561) 2020-08-05 16:39:36 +01:00
Steve Sanderson d99644ef9c
Move reconnection delay mechanism into framework code (#24566) 2020-08-05 16:00:54 +01:00
Pranav K bb9653532a
Add nullable annotations to M.A.Hosting and DefaultBuilder (#24571)
* Turn on nullability annotations for public types in M.A.Hosting
* Turn on nullability annotations for Microsoft.AspNetCore and
  Microsoft.AspNetCore.Server.Abstractions

Contributes to https://github.com/dotnet/aspnetcore/issues/5680
2020-08-05 01:07:11 +00:00
Pranav K 84b30133a7
Merge branch 'master' into merge/release/5.0-preview8-to-master 2020-08-04 16:21:58 -07:00
Tanay Parikh 29ceed2b2a
Razor TagHelperDescriptor Hashing (#24551)
* Razor TagHelperDescriptor Hashing and Caching

1/2 PRs for https://github.com/dotnet/aspnetcore/issues/23170

The other PR will be in aspnetcore-tooling to utilize these changes.

https://github.com/dotnet/aspnetcore-tooling/pull/2307
2020-08-04 13:06:42 -07:00
David Fowler cfd20ad2d7
Fix some linker warnings, report others (#24553)
* Fix some linker warnings, report others
- Added RequiresUnreferencedCode to UseStartup that takes a string
- Added some suppressions
- Fixed ConfigureContainer calls
- Fixed HostingStartupAttribute
2020-08-04 12:40:42 -07:00
Doug Bunting e13368391b
Keep `@(Reference)` metadata when creating `@(ProjectReference)` items (#21567)
- #20818, fix e.g. references to Microsoft.Web.Xdt.Extensions in our packages
- make `@(Reference)` items much more broadly applicable
- emit an error when `@(ProjectReference)` is used instead of `@(Reference)`
    - then get rid of the errors (!!)
- rename a couple of projects to match their assembly names
    - then regenerate the `@(ProjectReferenceProvider)` items
- switch intersection approach from Exclude / Exclude to Copy / Update / Copy

Projects of particular interest:
- src/DefaultBuilder/src/Microsoft.AspNetCore.csproj
    - honouring metadata left e.g. Microsoft.AspNetCore.Components.WebAssembly.DevServer package unchanged
    - removed redundant metadata after that confirmation
- src/Razor/tools/Microsoft.AspNetCore.Razor.Internal.Transport/
    - content of this package unchanged but metadata avoids extra work
    - add a comment about the extra work
- src/SiteExtensions/LoggingAggregate/src/Microsoft.AspNetCore.AzureAppServices.SiteExtension/
    - success! removes Microsoft.Web.Xdt.Extensions dependency from the package
- src/SiteExtensions/Runtime/Microsoft.AspNetCore.Runtime.SiteExtension.pkgproj
    - add a `Condition` to avoid an ordering issue I hit here
- src/Tools/Extensions.ApiDescription.Server/src/
    - avoid errors the new build ordering and timing caused

Separately, up the timeout in the `<DownloadFile />` task
- hit repeated timeouts downloading dotnet-runtime-5.0.0-rc.1.20370.4-win-x64.zip

nits:
- remove dupe `@(Reference)` item in Microsoft.AspNetCore.Components.WebAssembly.DevServer.csproj
- remove useless `%(ProjectReference.IsImplicitlyDefined)` metadata as well as its misspellings
- remove extra spaces from ProjectReferences.props
- clean up a few comments in ResolveReferences.targets

* !fixup! Correct other references to renamed projects
2020-08-04 10:05:55 -07:00
SQL-MisterMagoo 1be16fb4c9
Add delay before showing Reconnection UI (#24137)
* Add CSS delay before showing Reconnection UI

* rebuild yet again to try and get past the conflict
2020-08-04 04:14:46 +00:00
Mackinnon Buck 4ef5e10e6d
Virtualization support (#24179) 2020-08-03 17:02:12 -07:00
Pranav K fcabe6f0fd
Turn off full GC (#24545)
Using the full gc sometimes leads to an infinite recursion resulting
in a browser freeze. This was noted as part of running Blazor's benchmarks.
This is being addressed in rc1, in the meanwhile this reverts the behavior to 3.2 defaults.

Browser freezes when using a Blazor WASM application.

Yes. Full GC on is new to WASM on .NET Core

Low. Off by default is the behavior we had in 3.2.
2020-08-03 15:43:34 -07:00
David Fowler 3f15d26851
Obsolete the ResponseCookiesFeature constructor (#24546) 2020-08-03 14:47:20 -07:00
David Fowler 1f5149a663
Implement CopyToAsync in the FileBufferingReadStream (#24499)
* Implement CopyToAsync in the FileBufferingReadStream
- overrride Span and Memory overloads and implement array overloads in terms of those overloads.
- Implemented CopyToAsync (but not CopyTo)
- Added tests

Fixes #24032
2020-08-03 14:14:42 -07:00
Daniel Roth e31998c94b
Update Blazor Server survey link for .NET 5 (#24507) 2020-08-03 13:46:09 -07:00
Steve Sanderson 1885af9634
Add console runner for measuring Blazor perf on desktop interpreter (#24469) 2020-08-03 21:42:44 +01:00
Safia Abdalla 0335ac60a6
Check completed task in circuit termination tests (#24450)
* Check completed task in circuit termination tests
* Remove extraneous whitespace
* Update CircuitGracefulTerminationTests.cs
2020-08-03 13:40:29 -07:00
Steve Sanderson 7e11c3c264
Cache parameter writer lookups (#24536) 2020-08-03 21:01:16 +01:00
Steve Sanderson 38e166fd59
Optimize render tree building via RenderTreeFrameArrayBuilder (#24484) 2020-08-03 18:42:31 +01:00
Cédric Luthi 749450ac7b
[HTTPS] Fix the CertificateManagerEventSource event ids (#24519) 2020-08-03 07:30:52 -07:00
David Fowler 404d817677
Dipping toes into linker friendliness (#24458)
- Annotated UseMiddleware and UseStartup to preserve constructors and public methods.
- Annotated UseHub and MapHub preserve constructors and public methods.
- Added a test to verify UseStartup and UseMiddleware works
- The linker.xml preserves constructors all of the types that are registered in DI. This should be removed once we get the linker friendly DI changes.
2020-08-03 06:54:03 -07:00
Doug Bunting b534f92589
Remove unused HTML files (#24488)
- just a bit confusing to leave these around
- the files haven't been used since @pakrym removed the resources in 56c064bd53
2020-08-02 11:46:10 -07:00
Daniel Roth 4bb01a5a43
Update Blazor WebAssembly in-product survey link for .NET 5. (#24508) 2020-08-02 09:59:30 -07:00
Steve Sanderson 6f7a3dfd4e
Remove Blazor internal profiling infrastructure (#24468)
* Put back InternalCalls

* Removing .NET profiling calls

* Remove JS side profiling
2020-07-31 22:04:48 +01:00
Pranav K f495fcb151
Avoid doing unncecessary work when generating component declaration files. (#24445)
The output of the declaration file for Razor components are unaffected by all inputs other than the input .razor file.
Consequently we can avoid regenerating these files if the output is newer than the input. This is the same heuristic we apply to Blazor WebAsssembly's
compression artifacts.

This PR combines these two improvements for a ~90ms (10%) improvement in the inner loop.

```
       17 ms  GenerateBlazorWebAssemblyBootJson          1 calls
       22 ms  Copy                                       8 calls
       39 ms  ProcessFrameworkReferences                 1 calls
       40 ms  RazorTagHelper                             1 calls
       51 ms  ResolveAssemblyReference                   1 calls
       70 ms  GetFileHash                                1 calls
       80 ms  RazorGenerate                              2 calls
      111 ms  Csc                                        2 calls

      Time Elapsed 00:00:00.95
```

```
       17 ms  GenerateBlazorWebAssemblyBootJson          1 calls
       21 ms  Copy                                       8 calls
       37 ms  ProcessFrameworkReferences                 1 calls
       51 ms  ResolveAssemblyReference                   1 calls
       70 ms  Csc                                        1 calls
       72 ms  GetFileHash                                1 calls
       79 ms  RazorGenerate                              2 calls

Time Elapsed 00:00:00.86
```

In after: Csc calls reduced to one, RazorTagHelper call removed.
2020-07-31 20:40:52 +00:00
Hao Kung e6b9a3d295
Remove debian 8 from helix runs (#24454)
* Add display environment

* Print out env variables as part of helix runs

* Update TestRunner.cs

* Remove Debian 8 from helix matrix

* Remove Debian 8 skip

* Remove debian 8 skip

* Remove debian 8

* Remove debian 8 skip

* Remove Debian 8 skip

* Remove debian 8

* Update Program.cs

* Update TestRunner.cs

* Update TestRunner.cs
2020-07-31 20:35:54 +00:00
Safia Abdalla c0c0a26000
Wait for component to mount before checking for output (#24451)
* Wait for component to mount before checking for output
* Use Exists to check for element with timeout
* Update ComponentRenderingTest.cs
2020-07-31 12:44:27 -07:00
Brennan 4290bcc782
Pass serialization exceptions to Hub disconnect (#24408) 2020-07-31 10:13:28 -07:00
Steve Sanderson f28ef7c3e8
Use ordinal comparison when detecting event handler attributes. Fixes #24465 (#24471) 2020-07-31 17:54:35 +01:00
Pranav K 3e1e69ecce
Add nullable annotations to Authenticator.Core & Authentication.Cookies (#24307)
Contributes to https://github.com/dotnet/aspnetcore/issues/5680
2020-07-30 17:09:14 -07:00
Kahbazi 799014cfe7
Throw BadHttpRequestException in HttpSys (#24213) 2020-07-30 16:29:38 -07:00
Kahbazi d0cca519b4
Set ContentLength for TestHost (#24107) 2020-07-30 16:10:58 -07:00
Miha Zupan e3501ddd4a
H/QPackEncoder overloads accepting Encoding (#24448) 2020-07-30 20:11:58 +00:00
marlongerson b9e663bffb
[Identity] Updated RenderSection to use async method. (#24121) 2020-07-30 13:03:11 -07:00
Safia Abdalla d6ed98044d
Merge branch 'master' into merge/release/5.0-preview8-to-master 2020-07-30 10:54:18 -07:00
William Godbe cf728173d1
Quarantine failing test (#24415)
* Quarantine failing test

* Update DefaultControllerFactoryTest.cs
2020-07-29 15:51:44 -07:00
Huei Feng ae840db2cc
Add a readonly modifier to a missing readonly field (#24379) 2020-07-29 15:00:23 -07:00
Pranav K 17687f538c
Improve detection of Record types (#24409) 2020-07-29 13:27:27 -07:00
Safia Abdalla f88034902a
Don't render route component if OnNavigateAsync task in-progress (#24225) 2020-07-29 11:37:52 -07:00
John Luo fd9f17ddf9
Update blazor templates with Microsoft.Identity.Web APIs (#24268)
* Update blazor and components web templates

* Update Identity.Web version to 0.2.1-preview
2020-07-29 10:31:47 -07:00
Steve Sanderson 5e49fc336e
In CSS scoping, support ::deep alongside other combinators (#24376) 2020-07-29 14:49:50 +01:00
Kahbazi 01e05359d6
Dispose CTS in WebHost.StopAsync (#24399) 2020-07-29 12:43:46 +00:00
Stephen Halter e225057370
Add missing .ConfigureAwait(false) to WebHost (#24390) 2020-07-28 18:22:44 -07:00
Javier Calvarro Nelson 3cf39cf7e1
Update the templates CSS to leverage CSS isolation (#24380)
* Template changes

* Template changes + scope computation update

* Template updates

* tmp

* Fix style path

* Webassembly template changes

* Update tests

* Undo blazor.server.js changes

* WebAssembly cleanups

* Undo unwanted change

* Undo another unwanted change

* Fix server-side login combinator

* update tests, switch from app to div id=app
2020-07-28 15:29:57 -07:00
Tanay Parikh 4aa5e03207
Unquarantine Tests (#24295)
* Unquarantine Tests
2020-07-28 11:21:33 -07:00
msftbot[bot] 8de0c7386c
Merge pull request #24373 from dotnet-maestro-bot/merge/release/5.0-preview8-to-master
[automated] Merge branch 'release/5.0-preview8' => 'master'
2020-07-28 18:21:05 +00:00
Kahbazi 085921305a
[IIS] Move to GenericHost (#24280) 2020-07-28 11:02:09 -07:00