Commit Graph

1195 Commits

Author SHA1 Message Date
James Newton-King acc0b7ad0d
Serialize NegotiateResponse with IBufferWriter (#1881) 2018-04-07 15:50:13 +12:00
David Fowler f632330d7f
Allocate pipe writer stream per connection (#1885)
- Don't create the PipeWriterStream per operation, make it per Connection
- Reduce the buffer size for CopyToAsync operations to 4K where possible instead of 81K (the default)
2018-04-06 14:36:35 -07:00
David Fowler e51676fb47 Policheck errors 2018-04-06 13:01:20 -07:00
David Fowler e3d90bdf6a
Fix graceful closing of pipes (#1882)
- Closing pipes gracefully in most cases. The only case where we forcefully close the pipes is during application shutdown
- Return 404 if sending to connection after disposal
- Added tests
2018-04-06 10:59:40 -07:00
David Fowler 84d43cb2d8
Remove extra class (#1884)
- Merged 2 DI classes in SignalR
2018-04-06 08:16:19 -07:00
Mikael Mengistu 4ddf8664c0
Don't throw from Observer's OnNext (#1872) 2018-04-06 00:35:04 -07:00
James Newton-King 36edadabb4
Lock when sending data to connection (#1876) 2018-04-06 16:25:47 +12:00
James Newton-King cb5ece8a24
HttpTransportType refactor (#1873)
- Rename file to HttpTransportType.cs
- Add HttpTransportType.None
- Move All to static readonly field
- Make TransportType on client and service HttpConnectionOptions consistent
- Move setting defaults into ctor
2018-04-06 16:18:47 +12:00
James Newton-King 921986d561
Fix AccessTokenFactory not being called with each request (#1880) 2018-04-06 15:46:36 +12:00
BrennanConroy b0c4e9d0f7
0 byte read in WebSockets (#1878) 2018-04-05 18:50:30 -07:00
Andrew Stanton-Nurse a29b8ae396
fix #1874 by adding RedisProtocolBenchmark (#1875) 2018-04-05 17:47:41 -07:00
BrennanConroy 307ed01051
ReEnable SSETransportStopsSendAndReceiveLoopsWhenTransportStopped (#1877) 2018-04-05 17:16:39 -07:00
Andrew Stanton-Nurse 19b2fea0d8
Preserialize for all formats when sending through Redis (#1843) 2018-04-05 13:48:14 -07:00
David Fowler 39f693b9ed
Found these while looking at a flaky test (#1871)
- Fix crashing test
- Dispose the ClientWebsocket in StopAsync
2018-04-05 12:47:39 -07:00
BrennanConroy b9e88923e7
Comment why we set X-Requested-With (#1870) 2018-04-05 11:38:15 -07:00
David Fowler 11343ea15d
Add logging by default to HubConnectionBuilder (#1867)
- Use the AddLogging extension method by default in the HubConnection
- Removed WithConsoleLogger extension methods
- Removed WithLoggerFactory extension method (moved to test only)
- Added WithLogger that uses the new the new ILoggerBuilder
2018-04-05 10:05:07 -07:00
David Fowler 35b6d81f77
Don't dispose on cancellation (#1859)
- We're already disposing now at the end of enumeration
2018-04-05 09:22:46 -07:00
David Fowler 61c3d0c403
Added Microsoft.AspNetCore.SignalR.Protocols.Json (#1861)
- Fixed package descriptions
- Call AddJsonProtocol from both the SignalR.Core (client and server)
2018-04-05 01:32:10 -07:00
James Newton-King e9db9e64c7
Add streaming benchmarks (#1854) 2018-04-05 20:27:37 +12:00
James Newton-King f7fc2647de
var all the things (#1855) 2018-04-05 18:41:13 +12:00
Mikael Mengistu e51852d0fc
Use Anchor tag to normalize urls(#1828) 2018-04-04 21:43:25 -07:00
Andrew Stanton-Nurse fccc9d1b50
fix #1815 by disposing linked cts (#1849) 2018-04-04 21:12:21 -07:00
James Newton-King 6b76d1355e
Add SendAsyncGroup to broadcast benchmarks (#1852) 2018-04-05 14:58:00 +12:00
BrennanConroy 32b4d5cc6c
Set X-Requested-With on all requests (#1848) 2018-04-04 17:12:50 -07:00
BrennanConroy 80f87e7730
Add Handshake timeout to C# Client (#1840) 2018-04-04 15:54:42 -07:00
David Fowler 490fd088f9 Merge branch 'release/2.1' into dev 2018-04-04 15:02:47 -07:00
David Fowler 924272ad1a Revert "Merged release/2.1"
This reverts commit cf45fac634, reversing
changes made to 313772ef03.
2018-04-04 15:02:20 -07:00
David Fowler cf45fac634 Merged release/2.1 2018-04-04 14:48:26 -07:00
David Fowler 1c7ca7fa3a
Remove lazily initialization of the pipes (#1850)
- This fixes race condition
2018-04-04 14:43:34 -07:00
David Fowler 5e190b404f Remove lazily initialization of the pipes
- This fixes race condition
2018-04-04 13:00:20 -07:00
Andrew Stanton-Nurse 313772ef03
fix #1727 by adding polyfills for IE (#1841) 2018-04-04 10:20:38 -07:00
BrennanConroy afa56e3012
MsgPack perf (#1845) 2018-04-04 07:11:16 -07:00
James Newton-King e7b84b753b
Refactor HubConnectionBuilder (#1830) 2018-04-04 21:19:13 +12:00
Andrew Stanton-Nurse 99ae47be09
Add ability to log message content (#1792) 2018-04-03 18:46:25 -07:00
Mikael Mengistu 7c2d9e87e9
Clean up pipe pair on transport start failure (#1836) 2018-04-03 17:08:04 -07:00
Mikael Mengistu ba0131a731
Rename TransportTypes to HttpTransportTypes (#1839) 2018-04-03 16:00:20 -07:00
David Fowler 5e38303377
Use xhr.onreadystatechange instead of xhr.onload (#1838) 2018-04-03 15:53:16 -07:00
ASP.NET CI 2a71d18a6a Update dependencies.props
[auto-updated: dependencies]
2018-04-03 22:42:56 +00:00
David Fowler 9c9d732da6 Upgraded dependencies 2018-04-03 15:12:51 -07:00
Pavel Krymets d23f2beafc
Merge release/2.1 into dev (#1834) 2018-04-03 10:45:44 -07:00
BrennanConroy 221c95e0af Couple logging additions (#1827)
- Added logging in a couple more places in HubConnection
- Increase DEFAULT_TIMEOUT_INTERVAL to 20 seconds
2018-04-02 19:25:47 -07:00
James Newton-King 416b27c6d6
Fix build (#1825) 2018-04-03 11:45:05 +12:00
Pavel Krymets 6a1367ff70
Reaction to *Memory changes (#1824) 2018-04-02 16:44:31 -07:00
James Newton-King 3460d44848
Fix non-serializable tests (#1820) 2018-04-03 09:31:52 +12:00
BrennanConroy 5ce672dfe6
ThreadStatic MemoryBufferWriter (#1821) 2018-04-02 11:25:04 -07:00
BrennanConroy 6640f14e35
Detailed errors enabled for functional tests (#1822) 2018-04-02 10:42:26 -07:00
David Fowler e9d58154ec
Added TCP client sample to HubSample (#1805)
- Ripped of Kestrel's SocketConnection to make a TcpConnection
IConnection implementation.
- Fixed issue with SignalR assuming there will always be a non-null user
on the ConnectionContext.
2018-04-02 09:50:50 -07:00
David Fowler ef30e2e2df
Clean up the SSE client side transport (#1816)
- Renamed StreamPipeConnection to PipeReaderFactory
- Flow the transport cancellation token to the CopyToAsync routine 
- Other small cleanup and nits to make the style consistent with the other pipe reader loops
- Return a cancelled ValueTask from PipeWriterStream.WriteAsync
- Move event stream request to start itself
- We no longer need to pass the tcs through.
- It also cleans up handling failure in start since the application pipe hasn't been read or written to
2018-04-01 21:11:59 -07:00
David Fowler bb7cb14a1c
Clean up the logging style for HttpConnectionManager (#1819)
- Remove nameof usage
2018-04-01 19:34:11 -07:00
David Fowler 82bda4a9c8
Added micro benchmarks for SSE parsing and Writing (#1818) 2018-04-01 09:19:07 -07:00