Artak
a9004e503e
Merge pull request #2061 from aspnet/artakm/RestrictChildrenComments
...
Ignoring HTML comments in tag helper's body. Updated the markup parser to be aware of HTML Comments.
2018-03-12 11:17:57 -07:00
Artak Mkrtchyan
ae94c3c452
- Updated naming for methods to be more intuitive.
...
- Added extra tests for clarity
- Added extra comments to clarify complex areas
2018-03-09 18:18:16 -08:00
Artak Mkrtchyan
3e22c16930
Added extra tests for non-covered scenarios:
...
- For older version of Razor the HTML comments will be complained about by TahHelperRewriter
- RazorParserFeatureFlags tests now ensure that AllowHtmlCommentsInTagHelpers is true in 2.1 version and false in older versions
- Added extra test for IsHtmlCommentAhead to make sure Razor code transition is allowed in comment tag
- Moved the unallowed html comment ending to a static array.
2018-03-09 17:18:57 -08:00
Pranav K
483fba5972
Generate application part attributes
...
* Add support for generating attributes on Razor assembly
* Generate ProvideApplicationPartFactoryAttribute on Razor assembly
* Generate RelatedAssemblyAttribute on application assembly
2018-03-09 14:36:55 -08:00
Artak Mkrtchyan
e8eb3b7b1c
Added extra test to cover extra dash in closing comment
2018-03-09 11:52:23 -08:00
Artak Mkrtchyan
6c8c6a777c
- Clarified the code where the comment content ending is checked to be allowed or not.
...
- Added more unit tests
2018-03-09 09:16:17 -08:00
Artak Mkrtchyan
1318a83511
Fixed the NextIs method to put back the symbol, when at the end of the file
2018-03-08 17:13:34 -08:00
Artak Mkrtchyan
faccd90aa5
Added unit-tests to validate new methods
2018-03-08 16:36:56 -08:00
Ryan Nowak
2f79b90af5
Merge branch 'rel/vs15.7' into dev
2018-03-08 15:49:01 -08:00
Ryan Nowak
989a6c699f
Don't add the tag helper provider by default
...
Since the default tag helper provider is used by MVC then MVC should
include it. Now that Blazor is in the mix we shouldn't include it for
all configurations.
2018-03-08 15:41:34 -08:00
N. Taylor Mullen
07e672159e
Merge remote-tracking branch 'origin/dev' into nimullen/vs15.7merge
2018-03-08 14:44:14 -08:00
Artak Mkrtchyan
f194979b78
Merge branch 'artakm/RestrictChildrenComments' of https://github.com/aspnet/Razor into artakm/RestrictChildrenComments
2018-03-08 13:38:59 -08:00
Artak Mkrtchyan
7357fa04ea
Applied PR feedback (unit testst will be added as part of a separate commit)
2018-03-08 13:38:35 -08:00
Artak Mkrtchyan
32e2c533c7
Naming improvements and test code cleanup
2018-03-08 13:37:05 -08:00
Artak Mkrtchyan
632c9dead7
Added tests for the LookaheadUntil method
2018-03-08 13:37:05 -08:00
Artak Mkrtchyan
33814fb634
Updated the Comments detection to comply with HTML 5 specification
2018-03-08 13:37:04 -08:00
Artak Mkrtchyan
6885fb15d0
Updated the test TagHelperBlockRewriteTest class
2018-03-08 13:37:04 -08:00
Artak Mkrtchyan
0af42204eb
Added the AllowHtmlCommentsInTagHelpers feature flag to control behavior of having comments in TagHelpers
2018-03-08 13:37:04 -08:00
Artak Mkrtchyan
6f515bb763
Fixed all the tests to reflect HtmlComment block type support
2018-03-08 13:37:03 -08:00
Artak Mkrtchyan
e1fbea24f1
HtmlMarkupParser is now aware of HtmlComment blocks. Majority (if not all, will confirm soon) tests have been updated to account for HtmlComment blocks.
2018-03-08 13:37:03 -08:00
Artak Mkrtchyan
ad8485addd
Added new BlockType - HtmlComment
...
Updated the HtmlMarkupParser to understand the HtmlCOmments, and treat those as blocks.
2018-03-08 13:37:03 -08:00
Artak Mkrtchyan
a940a4cd91
Moved the comment check into the "ValidateParentAllowsContent" method
2018-03-08 13:37:02 -08:00
Artak Mkrtchyan
679acdc5d4
Ignoring razor comments during validation
2018-03-08 13:37:02 -08:00
Artak Mkrtchyan
47228dd822
Revert unnecessary change
2018-03-08 13:37:01 -08:00
Artak Mkrtchyan
41b7d90ea8
Ignoring markup comments during validation
2018-03-08 13:37:01 -08:00
Artak Mkrtchyan
e6f68eb244
Added a unit test to repro the issue
2018-03-08 13:37:01 -08:00
Artak Mkrtchyan
ca65c5e308
Merged with incoming changes
2018-03-08 13:35:00 -08:00
Artak Mkrtchyan
42362bea97
Applied PR feedback (unit testst will be added as part of a separate commit)
2018-03-08 13:29:18 -08:00
ASP.NET CI
69c2d08326
Update dependencies.props
...
[auto-updated: dependencies]
2018-03-08 13:11:37 -08:00
Artak
8a1d04e0bc
Merge pull request #2141 from aspnet/dev
...
Merging changes from dev
2018-03-07 16:39:04 -08:00
Artak Mkrtchyan
f2b9696298
Naming improvements and test code cleanup
2018-03-07 16:34:12 -08:00
Artak Mkrtchyan
0f820c5f11
Added tests for the LookaheadUntil method
2018-03-07 14:52:33 -08:00
Ajay Bhargav Baaskaran
e085441ad3
Don't limit parallel threads for xunit tests
2018-03-07 10:43:25 -08:00
Ajay Bhargav Baaskaran
c96d8e4bab
Skip test correctly
2018-03-06 17:47:43 -08:00
Ryan Brandenburg
6bc5c976de
Remove AppVeyor status tag.
2018-03-06 10:58:22 -08:00
Ryan Brandenburg
16a0b69b5b
Remove AppVeyor file until reliability improves
2018-03-06 10:56:38 -08:00
Pranav K
5502e90565
Prepend FeatureBranchVersionPrefix if FeatureBranchVersionSuffix is specified
2018-03-06 10:05:37 -08:00
Pranav K
53b3ebb680
Use dotnet-core feed in repos
2018-03-06 10:05:37 -08:00
Nate McMaster
0dc95887ee
Set MSBuild dependency version to 15.6.82
...
This is the latest stable release of MSBuild package versions
2018-03-06 09:46:30 -08:00
Pranav K
c4ba279fb5
Skipping flaky test and additional additional diagnositcs to Shutdown command
2018-03-06 09:15:53 -08:00
Pranav K
0d321771ad
Make UseRazorBuildServer=true by default
2018-03-06 09:15:52 -08:00
N. Taylor Mullen
5c456fbd04
Merge branch 'rel/vs15.7' into dev
...
# Conflicts:
# build/dependencies.props
# src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/DefaultProjectSnapshot.cs
# src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/DefaultProjectSnapshotManager.cs
# src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/DefaultProjectSnapshotWorker.cs
# src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/DefaultProjectSnapshotWorkerFactory.cs
# src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/ProjectSnapshot.cs
# src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/ProjectSnapshotUpdateContext.cs
# src/Microsoft.VisualStudio.Editor.Razor/DefaultVisualStudioDocumentTracker.cs
# src/Microsoft.VisualStudio.LanguageServices.Razor/Legacy/LegacyTagHelperResolver.cs
# src/Microsoft.VisualStudio.LanguageServices.Razor/Microsoft.VisualStudio.LanguageServices.Razor.csproj
# src/Microsoft.VisualStudio.LanguageServices.Razor/ProjectSystem/Rules/RazorConfiguration.cs
# src/Microsoft.VisualStudio.LanguageServices.Razor/ProjectSystem/Rules/RazorExtension.cs
# src/Microsoft.VisualStudio.LanguageServices.Razor/ProjectSystem/Rules/RazorGeneral.cs
# src/Microsoft.VisualStudio.LanguageServices.Razor/ProjectSystem/Rules/RazorProjectProperties.cs
# test/Microsoft.CodeAnalysis.Razor.Workspaces.Test/ProjectSystem/DefaultProjectSnapshotTest.cs
# test/Microsoft.VisualStudio.Editor.Razor.Test/Microsoft.VisualStudio.Editor.Razor.Test.csproj
2018-03-05 22:58:07 -08:00
Artak Mkrtchyan
9c3adba40f
Updated the Comments detection to comply with HTML 5 specification
2018-03-05 17:28:23 -08:00
Ajay Bhargav Baaskaran
27e6c699e5
Don't print normal output as error
2018-03-05 15:22:37 -08:00
Ajay Bhargav Baaskaran
7e18efbf1f
Fixed flaky shutdown tests
2018-03-05 11:55:56 -08:00
Pranav K
41c923926e
Make RazorCompileOnBuild=true
...
Fixes #1986
2018-03-05 11:29:44 -08:00
ASP.NET CI
69a32c68e2
Update dependencies.props
...
[auto-updated: dependencies]
2018-03-04 12:26:25 -08:00
Pranav K
c444f65c5d
Import capabilities to support solution explorer nesting
...
Fixes #2047
2018-03-02 11:18:11 -08:00
Pranav K
29bd5f49dd
Fix build break
2018-03-02 10:05:44 -08:00
Pranav K
5bd650bdd1
Pack should pack symbol nupkg
...
* Update path calculation for BuiltProjectOutputGroupOutput to include full path. This matches
the behavior of Microsoft.Common.targets.
* Add Razor symbols to DebugSymbolsProjectOutputGroupOutput
Fixes #2116
2018-03-02 07:45:24 -08:00