a375cba359
Copy action constraints and EndPointMetadata when setting up a PageActionDescriptor ( #8208 )
...
* Copy action constraints and EndPointMetadata when setting up a PageActionDescriptor
Fixes #8207
2018-08-03 12:04:44 -07:00
ac410b76d9
Change MvcEndpointInfo to internal ( #8210 )
2018-08-03 16:30:57 +12:00
ce8fc29728
ConsumesAttribute accepts requests without content type
...
Fixes #8174
2018-08-02 16:27:23 -07:00
e2b6f07778
Respect LowercaseUrls in ApiExplorer
...
Fixes #8006
2018-08-02 14:58:41 -07:00
5a20037965
Move API convention analyzers to Microsoft.AspNetCore.Mvc.Api.Analyzers
...
Fixes #8153
2018-08-02 13:53:33 -07:00
6d9aa281c5
Render `maxlength` attribute for an input tag, when MaxLength or StringLength validation attributes are applied to the model class.
2018-08-02 13:44:19 -07:00
b7335ac768
Add a code fix that applies ProducesResponseTypeAttributes
2018-08-02 09:40:18 -07:00
2b289d2f2c
Use MatcherPolicy for Consumes
2018-08-01 19:05:04 -07:00
44f5b54f5f
React to routing API review ( #8194 )
2018-08-02 13:37:43 +12:00
814a803ed8
Use local instances of MemoryCache in script, link and image tag helper
2018-08-01 10:14:31 -07:00
f4ff537a31
Fix flaky test by using a different instance of contract resolver
...
[Fixes #8175 ] FlakyTest: ExecuteAsync_ErrorDuringSerialization_DoesNotCloseTheBrackets
2018-08-01 07:33:37 -07:00
ab84d17bb3
Unskip endpoint routing functional tests
2018-08-01 07:22:42 -07:00
046af405b6
Rename global routing to endpoint routing ( #8179 )
2018-08-01 15:05:49 +12:00
0726b8b98b
Make publicly exposed Roslyn types internal
2018-07-31 11:08:22 -07:00
d346255db6
Add analyzer and codefix that suggests removing unnecessary invalid model state validity checks
...
Fixes #8146
2018-07-30 13:14:20 -07:00
367717760b
Handle subtype with suffix being a subtype without a suffix ( #8170 )
2018-07-30 12:05:41 -07:00
0102d4efab
Introduce ApiConventionMethodAttribute
...
Fixes #8147
2018-07-30 11:13:25 -07:00
41de26a546
Add UseMvc unit tests ( #8164 )
2018-07-29 16:58:50 +12:00
fbae57cde1
React to the removal of EndpointConstraint
2018-07-28 19:03:16 -07:00
c01c7075be
Add EndpointMetadata to ActionDescriptor and hookup CORS ( #8158 )
2018-07-28 16:12:54 +12:00
556880872d
Ensure later validations of `null` models do not overwrite `Invalid` state
...
- #8078
2018-07-26 13:49:22 -07:00
0d427a60e5
Use `TheoryData` properties to avoid duplicate test data
...
- couldn't just remove duplicate `[TheoryData]` in `GlobalRoutingTest`
- xUnit analyzers don't understand `[InlineData]` is inherited (though runtime certainly does)
2018-07-26 10:12:50 -07:00
498fa2d72f
Avoid `InvalidOperationException` when serializing `SerializableError`
...
- #8055
- provide unique name (`<Empty-Key>`) for XML elements that would otherwise be nameless
nits:
- remove now-useless Mono special case in updated test class
- extend updated tests to involve square brackets as well as empty keys
2018-07-26 08:56:02 -07:00
f31ab716ee
Change MvcEndpointDataSource to use GetChangeToken ( #8137 )
2018-07-26 09:20:26 +12:00
10ce77b9ca
Updated MvcEndpointDataSource to create endpoints with SuppressLinkGenerationMetadata
2018-07-25 06:41:57 -07:00
b71d5da05e
Fix test break due to 405 returned from routing
2018-07-24 22:15:32 -07:00
c08504b08a
MVC startup experience ( #8131 )
2018-07-25 14:30:51 +12:00
630aeade07
Added tests related to generating urls with route name
2018-07-24 15:06:16 -07:00
52c1e942c6
Added UseCamelCasing and UseMemberCasing extension methods to MvcJsonOptions ( #7256 )
2018-07-23 10:11:04 -07:00
196e3f109f
React to Routing branding
...
This is a reaction PR for the branding changes in progress in Routing.
This can be merged after the changes to in to Routing.
2018-07-22 19:47:15 -07:00
c0ba374549
Custom error messages with validation message tag helper #8035
...
#8035
PR #8087
https://github.com/aspnet/Razor/issues/2497
2018-07-22 17:55:06 +05:30
e1e7ec0f28
Enable couple of skipped Dispatching functional tests
2018-07-21 04:44:38 -07:00
d4beab5d09
CompositeValidationAttribute
...
- Add abstract CompositeValidationAttribute.
- Change DataAnnotationsMetadataProvider.CreateValidationMetadata to
populate ValidatorMetadata with validation attributes from CompositeValidationAttribute.
2018-07-20 15:31:14 -07:00
5c488bf09c
make feature branch build
2018-07-20 12:57:43 -07:00
3ba6f35495
React to RoutePattern changes in Routing
2018-07-20 12:57:43 -07:00
53930af0e3
Set ProblemDetails status field during ObjectResult formatting
2018-07-19 17:57:55 -07:00
36d90c9bc2
Run request service constraint test with dispatching ( #8112 )
2018-07-19 16:43:51 +12:00
ec8976ffaf
Update MvcEndpointDataSource on raised change token ( #8108 )
2018-07-19 16:43:24 +12:00
42218d5fb5
Versioning with endpoint constraint ( #8098 )
2018-07-17 16:37:45 +12:00
b62499e02c
Ensure PageContext.ViewData and ViewContext.ViewData are the same instance
...
Fixes #7675
2018-07-16 11:16:03 -07:00
9d951325b2
Re-organize shared src packages so we can do true IVT between src assemblies
2018-07-16 11:15:58 -07:00
35fad0881b
Mark unused `ParameterBinder.BindModelAsync(...)` overloads as `[Obsolete]`
...
- #7660
- also addresses part of #7317 , only in `ComplexTypeModelBinderIntegrationTest`
2018-07-13 13:26:56 -07:00
f2608c2ff4
Do not suppress `ModelValidationState.Invalid` entries
...
- #7992 , #7963
2018-07-13 13:21:43 -07:00
dfbdb37979
Refactorings for codefix ( #8067 )
...
* Refactorings for codefix
- Move some common code in SymbolApiResponseMetadataProvider
- Don't run diagnostics for 1006 if we are unable to parse a return type
2018-07-13 13:05:49 -07:00
f12f9b46ed
Add startup filter to set MiddlewareFilterBuilder.ApplicationBuilder
2018-07-13 12:23:30 +12:00
a5083d525b
Fix regression with Authorize + IPolicyProvider ( #8068 )
2018-07-12 15:36:03 -07:00
46189abda7
Refactoring for ApiConvention analyzers
2018-07-12 14:26:27 -07:00
a67d9363e2
Consumes endpoint constraint ( #8057 )
2018-07-12 16:35:33 +12:00
c367e1d681
Fix dispatching functional tests not using dispatching startup ( #8052 )
2018-07-12 14:19:48 +12:00
183ecd85d6
Fix MVC integration with UseEndpoint ( #8047 )
2018-07-11 11:47:33 +12:00
0812279464
Merge branch 'release/2.1' into kichalla/21.to.22.mergecommit
...
# Conflicts:
# build/dependencies.props
# korebuild-lock.txt
# src/Microsoft.AspNetCore.Mvc.ApiExplorer/DefaultApiDescriptionProvider.cs
# test/Microsoft.AspNetCore.Mvc.Core.Test/Internal/ApiBehaviorApplicationModelProviderTest.cs
# version.props
2018-07-09 13:00:10 -07:00
bd995d4cb1
[ Fixes #7959 ] Conventional routing with custom templates not working when you have area attributes
2018-07-09 12:35:14 -07:00
dc2ae93c3f
Add fallback attribute to partial tag helper.
...
Addresses #7515
2018-07-09 12:24:26 -07:00
dee479fda7
Add partial helper to Razor Page \ PageModel
...
Fixes #7885
2018-07-09 11:01:15 -07:00
d2bb674b0a
Add support for default response ( #8028 )
...
* Add support for default response
Fixes #6828
2018-07-06 16:44:07 -07:00
335500ab0e
Use ModelMetadata from actual types for validation
...
Fixes https://github.com/aspnet/Mvc/issues/7952
2018-07-02 11:23:16 -07:00
c2fcfabdf3
Add optional property to PartialTagHelper ( #7991 )
...
* Add optional to PartialTagHelper
Addresses #7268
2018-06-29 16:02:38 -07:00
133d49c57e
Fix Api Explorer not returning type with ActionResult<T> and no type in ProducesResponseTypeAttribute
2018-06-29 13:55:30 -07:00
7f2a64e32b
Razor runtime compilation produces errors if running on a shared runtime that's rolled forward
...
Do not provide compilation references from runtime MVC assemblies. This avoids cases where the app is compiled
against an older MVC but running against a newer one (e.g. shared fx roll forward) resulting in compiling against multiple
versions of MVC assemblies
Fixes #7969
2018-06-29 13:55:22 -07:00
82f7f2aab8
Fix Api Explorer not returning type with ActionResult<T> and no type in ProducesResponseTypeAttribute
2018-06-29 12:00:16 -07:00
c4d5ef94a9
Razor runtime compilation produces errors if running on a shared runtime that's rolled forward
...
Do not provide compilation references from runtime MVC assemblies. This avoids cases where the app is compiled
against an older MVC but running against a newer one (e.g. shared fx roll forward) resulting in compiling against multiple
versions of MVC assemblies
Fixes #7969
2018-06-29 11:17:25 -07:00
192e8073ee
Work around `CryptographicException`s thrown in some full framework test runs
...
- always skip affected tests on full framework
2018-06-28 15:52:19 -07:00
54c14b8782
Reacting to Routing repo's EndpointFinder changes
2018-06-28 12:40:04 -07:00
4dd4e5ef3e
Shorten names so MVC repo can be cloned on Windows benchmarks server
2018-06-27 14:33:31 -07:00
e1af5b8b6d
Array or List in query string does not get parsed #7712 ( #7967 )
...
- exclude collections when detecting complex types in `ApiBehaviorApplicationModelProvider`
- add test cases
2018-06-26 11:43:46 -07:00
94a7c83998
Change DefaultApiConventions ( #7939 )
...
* Change DefaultApiConventions
* Introduce attributes for matching by name and type.
* Move discovery of ApiConventionAttribute to ApiBehaviorApplicationModelProvider. This is required
for us to detect during startup if the convention is incorrectly authored.
2018-06-25 08:24:30 -07:00
53857d052f
Add BasicApi and BasicViews apps
...
- #7805
- make initial copy of apps from aspnet/Performance repo
- add apps to solution
- add Readme for the benchmark apps
- update BasicApi app to actually do authentication and authorization
- bug in the ported app
- refactor `Main` methods and add `CreateWebHostBuilder(...)` methods
- change projects to understand `$(BenchmarksTargetFramework)`
- use NuGet.org EF packages to avoid changing the Universe build graph
- use SQLite instead of LocalDb by default
- remove unnecessary appsettings.json files and JSON configuration support
- add EF migrations
- (greatly) reduce startup times compared to creating / deleting databases
- add MySql, PostgreSQL, and SqlServer support
- load BasicApi data in a `DbContext.OnModelCreating(...)` override
- no longer need seed.sql
- generalize migrations to support multiple providers
- use negative seeding indices to work around npgsql/Npgsql.EntityFrameworkCore.PostgreSQL#36
- work around Pomelo lack of strong name (PomeloFoundation/Pomelo.EntityFrameworkCore.MySql#603 )
- use BenchmarksOnly* properties for EF dependencies
- see also aspnet/Universe#1224
- drop databases (if SQLite) or migrations (otherwise) in `IApplicationLifetime.ApplicationStopping` handlers
- add functional tests
- drop SQLite database at end of test run
- add benchmarks automation
- add anonymous BasicApi action i.e. require no authorization
- add non-antiforgery BasicViews actions
Address PR comments
- remove `AntiforgeryTestHelper` workarounds
- use `[ApiController]`
- use `ActionResult<Pet>`
- remove unused classes
nits:
- take VS suggestions in added files
- optionally display create and delete SQL scripts for per-database migrations
- merge `InsertData(...)` calls for consistency with most supported EF providers
- SQLite is the only one that requires separate `INSERT`s and EF does the splitting
2018-06-22 16:41:17 -07:00
6911e192e4
Add IsRequired and DefaultValue to ApiParameterDescription
2018-06-22 06:51:58 -07:00
17d2545b55
Throw if the type parameter for ActionResult<T> is an action result ( #7942 )
...
Fixes #7931
2018-06-21 07:51:12 -07:00
2599e0f5cc
Fix up a few pieces for the fallback integrity check feature.
...
- Regenerated test baselines.
- Update code styling in TagHelpers.
- Modified some comments for clarity.
- Renamed fallback integrity attribute for both script and link tags.
#7845
2018-06-20 16:10:52 -07:00
8a77ed23d3
Added support for ignoring integrity attribute on fallback for the Link TagHelper
...
- Do not include integrity attribute when asp-fallback-intergrity-check is false
- Added Unit Tests, manual tests
Addresses #7845
2018-06-20 16:10:52 -07:00
4f7e849cc1
Setting up for ApiConventionAttribute analyzers ( #7912 )
...
* Setting up for ApiConventionAttribute analyzers
2018-06-20 15:22:53 -07:00
e7ab81fe0b
Ensure analyzer package is referenced by Microsoft.AspNetCore.Mvc
...
Fixes #7684
2018-06-19 16:11:47 -07:00
3d32b6da2f
Upgrade deps and unskip tests ( #7936 )
2018-06-19 14:58:40 -07:00
3547341762
Add support for conventional routes with dispatching ( #7928 )
2018-06-20 09:02:52 +12:00
58aa16ee69
Centralize routing and dispatching functional test logic ( #7938 )
2018-06-19 23:24:15 +12:00
a0a9c2c585
Integrate Dispatcher's link generator
...
Related to https://github.com/aspnet/Routing/issues/530
2018-06-19 04:14:05 -07:00
e07054e0a7
Skip failing tests
2018-06-18 09:20:08 -07:00
a712ccc98a
Fix up error message when compilation references are missing
2018-06-18 09:20:08 -07:00
1aea6fd5bd
Remove instrumentation functional tests
...
Fixes #7921
2018-06-15 12:42:37 -07:00
a7406d4497
Add MvcEndpointDataSource and functional tests ( #7886 )
2018-06-14 11:03:45 +12:00
287a3c5e69
Allow IgnoreAntiForgeryToken applied on Razor Page models to work
...
Fixes #7795
2018-06-13 11:59:47 -07:00
6c2ef122f8
Add support for conventions in DefaultApiDescriptionProvider
2018-06-11 16:07:09 -07:00
df6b798117
Remove `xUnit1026` workaround in test projects
...
- contained a typo (colon versus semicolon) and just doesn't matter
2018-06-08 15:24:36 -07:00
c29527f992
Add some assertions for controllers and controller actions
2018-06-08 15:00:19 -07:00
f2eb6f8d37
Add some tests for CodeAnalysisExtensions
2018-06-08 14:58:29 -07:00
592ed3b4f5
Create an analyzer to warn users not to decorate filters on page handler methods
...
Fixes #7684
2018-06-05 17:23:30 -07:00
2d63669695
[ Fixes #7609 ] ApiBehaviorApplicationModelProvider overwrites existing BindingInfo in entirety when inferring binding sources
2018-05-30 05:30:10 -07:00
984cd46c4d
Fix ActionMethodExecutor incorrectly setting DeclaredType on ObjectResult
...
Fixes #7782
2018-05-29 14:35:42 -07:00
632425d0e6
Unskip skipped tests
2018-05-29 12:10:59 -07:00
8e31319215
Prevent null refs in some simple cases in CachedExpressionCompiler
...
Fixes #6928
2018-05-29 11:09:48 -07:00
edf4e8fd9e
DataAnnotations of Enum values use DataAnnotationLocalizerProvider
2018-05-25 16:00:00 -07:00
418aac57f4
[ Fixes #7609 ] ApiBehaviorApplicationModelProvider overwrites existing BindingInfo in entirety when inferring binding sources
2018-05-24 14:28:42 -07:00
49c653ed0b
Infer BindingSource.FormFile for IEnumerable<IFormFile>
...
Fixes #7770
2018-05-22 11:05:09 -07:00
077b1d87a9
#7024 Request: ServiceBasedPageModelActivatorProvider [Review Changes]
2018-05-22 10:23:08 -07:00
b8e5036e20
#7024 Request: ServiceBasedPageModelActivatorProvider
2018-05-22 10:23:08 -07:00
0c795c4f33
#7024 Request: ServiceBasedPageModelActivatorProvider
2018-05-22 10:23:08 -07:00
e1eaf6a6e0
Cleanup TestCommon
2018-05-18 10:45:57 -07:00
624a5ed522
Fix ActionMethodExecutor incorrectly setting DeclaredType on ObjectResult
...
Fixes #7782
2018-05-18 10:43:28 -07:00
19d82928ba
Making Razor compilation cache replaceable ( #7780 )
2018-05-15 11:36:47 -07:00
Pranav K
James Newton-King
Artak Mkrtchyan
Ryan Nowak
Kiran Challa
Justin Kotalik
Doug Bunting
Ryan Nowak
Kiran Challa
Alexej Timonin
kishan.anem
Kristian Hellang
Hao Kung
hishamco
Nathanael Marchand
kishanAnem
N. Taylor Mullen
jmhmaine
Ajay Bhargav Baaskaran
Ryan Brandenburg
Nisha Kaushik
Sébastien Ros