Unskip skipped tests

This commit is contained in:
Pranav K 2018-05-29 11:20:35 -07:00
parent 8e31319215
commit 632425d0e6
3 changed files with 12 additions and 23 deletions

View File

@ -30,8 +30,7 @@ namespace Microsoft.AspNetCore.Mvc
Assert.Equal("text/plain", result.ContentType.ToString());
}
[ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
[Fact]
public async Task ContentDispositionHeader_IsEncodedCorrectly()
{
// See comment in FileResult.cs detailing how the FileDownloadName should be encoded.
@ -55,8 +54,7 @@ namespace Microsoft.AspNetCore.Mvc
Assert.Equal(@"attachment; filename=""some\\file""; filename*=UTF-8''some%5Cfile", httpContext.Response.Headers["Content-Disposition"]);
}
[ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
[Fact]
public async Task ContentDispositionHeader_IsEncodedCorrectly_ForUnicodeCharacters()
{
// Arrange
@ -78,8 +76,7 @@ namespace Microsoft.AspNetCore.Mvc
httpContext.Response.Headers["Content-Disposition"]);
}
[ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
[Fact]
public async Task ExecuteResultAsync_DoesNotSetContentDisposition_IfNotSpecified()
{
// Arrange
@ -104,8 +101,7 @@ namespace Microsoft.AspNetCore.Mvc
Assert.Equal(Stream.Null, httpContext.Response.Body);
}
[ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
[Fact]
public async Task ExecuteResultAsync_SetsContentDisposition_IfSpecified()
{
// Arrange
@ -126,8 +122,7 @@ namespace Microsoft.AspNetCore.Mvc
Assert.Equal("attachment; filename=filename.ext; filename*=UTF-8''filename.ext", httpContext.Response.Headers["Content-Disposition"]);
}
[ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
[Fact]
public async Task ExecuteResultAsync_ThrowsException_IfCannotResolveLoggerFactory()
{
// Arrange
@ -234,8 +229,7 @@ namespace Microsoft.AspNetCore.Mvc
Assert.Equal(expectedOutput, actual);
}
[ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
[Fact]
public async Task SetsAcceptRangeHeader()
{
// Arrange
@ -538,4 +532,4 @@ namespace Microsoft.AspNetCore.Mvc
}
}
}
}
}

View File

@ -21,8 +21,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
{
public class ControllerActionInvokerCacheTest
{
[ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
[Fact]
public void GetControllerActionMethodExecutor_CachesFilters()
{
// Arrange
@ -43,8 +42,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
Assert.Equal(cacheEntry1.filters, cacheEntry2.filters);
}
[ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
[Fact]
public void GetControllerActionMethodExecutor_CachesEntry()
{
// Arrange

View File

@ -165,8 +165,7 @@ namespace Microsoft.AspNetCore.Mvc.RazorPages.Internal
});
}
[ConditionalTheory]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
[Theory]
[InlineData("/Areas/About.cshtml")]
[InlineData("/Areas/MyArea/Index.cshtml")]
public void TryParseAreaPath_ReturnsFalse_IfPathDoesNotConform(string path)
@ -182,8 +181,7 @@ namespace Microsoft.AspNetCore.Mvc.RazorPages.Internal
Assert.False(success);
}
[ConditionalTheory]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
[Theory]
[InlineData("/Areas/MyArea/Views/About.cshtml")]
[InlineData("/Areas/MyArea/SubDir/Pages/Index.cshtml")]
[InlineData("/Areas/MyArea/NotPages/SubDir/About.cshtml")]
@ -200,8 +198,7 @@ namespace Microsoft.AspNetCore.Mvc.RazorPages.Internal
Assert.False(success);
}
[ConditionalTheory]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
[Theory]
[InlineData("/Areas/MyArea/Pages/Index.cshtml", "MyArea", "/Index")]
[InlineData("/Areas/Accounts/Pages/Manage/Edit.cshtml", "Accounts", "/Manage/Edit")]
public void TryParseAreaPath_ParsesAreaPath(