Commit Graph

4569 Commits

Author SHA1 Message Date
Pranav K 8d66f104f7 Make types in Microsoft.AspNetCore.Mvc.Internal namespace internal 2018-11-08 14:00:16 -08:00
James Newton-King 9f1a222d90
React to AuthorizationMiddleware (#8697) 2018-11-09 07:11:55 +13:00
Pranav K 65af12f1f5 Update Sdk \ KoreBuild to one that works 2018-11-05 17:17:17 -08:00
Pranav K 7ea301cc0a Fix RazorRendering 2018-11-01 19:19:59 -07:00
Ryan Nowak 6c3ae2ff9e fix RazorRendering build 2018-10-31 21:43:11 -07:00
Pranav K 17ed44c868
React to Razor.Design package removal (#8680)
* React to Razor.Design package removal

* Remove references to packages (Razor.Design, Razor.Extensions) solely used to bring in compiler \ targets
* Target netcoreapp3.0 in samples and tests to allow Sdk to infer values
2018-10-31 15:38:22 -07:00
Doug Bunting e4292c236c
Merge pull request #8682 from dotnet-maestro-bot/merge/release/2.2-to-master
[automated] Merge branch 'release/2.2' => 'master'
2018-10-31 14:47:16 -07:00
Doug Bunting a6199bbfba
Add integration and functional tests of `[BindRequired]` on page properties (#8677)
- #7353
2018-10-31 14:15:14 -07:00
Pranav K f2af66bc31
Cleanup InferParameterBindingInfoConvention (#8665)
* Cleanup InferParameterBindingInfoConvention

* Infer BindingSource for collection parameters as Body. Fixes https://github.com/aspnet/Mvc/issues/8536
* Introduce a compat switch to keep 2.1.x LTS behavior for collection parameters
* Do not infer BinderModelName in InferParameterBindingInfoConvention
2018-10-31 12:24:37 -07:00
Pranav K 54579f9bf5
Merge pull request #8673 from dotnet-maestro-bot/merge/release/2.2-to-master
[automated] Merge branch 'release/2.2' => 'master'
2018-10-31 09:46:33 -07:00
Doug Bunting 579341c8d6
Merge branch 'master' into merge/release/2.2-to-master 2018-10-30 21:08:15 -07:00
Doug Bunting c74a945dda
Convert `RouteValueDictionary` values to `string` using `CultureInfo.InvariantCulture` (#8674)
* Convert `RouteValueDictionary` values to `string` using `CultureInfo.InvariantCulture`
- #8578
- user may override this choice in one case:
  - register a custom `IValueProviderFactory` to pass another `CultureInfo` into the `RouteValueProvider`
- values are used as programmatic tokens outside `RouteValueProvider`

nits:
- take VS suggestions in changed classes
- take VS suggestions in files I had open :)
2018-10-30 20:09:17 -07:00
Pranav K 734b919b02 Respect SuppressInferBindingSourcesForParameters
Fixes https://github.com/aspnet/Mvc/issues/8657
2018-10-30 14:37:21 -07:00
Pranav K 16b15fcb2a
Merge pull request #8672 from dotnet-maestro-bot/merge/release/2.2-to-master
[automated] Merge branch 'release/2.2' => 'master'
2018-10-30 13:33:07 -07:00
Piotr Wosiek af6527dcef Fix XML doc on HttpMethodAttribute and derived ones 2018-10-30 13:21:15 -07:00
Pranav K 4015c9863e
Merge pull request #8664 from dotnet-maestro-bot/merge/release/2.2-to-master
[automated] Merge branch 'release/2.2' => 'master'
2018-10-29 12:54:42 -07:00
Pranav K 13cf754425
Merge pull request #8663 from dotnet-maestro-bot/merge/release/2.2-to-master
[automated] Merge branch 'release/2.2' => 'master'
2018-10-29 09:59:34 -07:00
Pranav K 35d2ab37f7 Allow passing a dictionary to ValidationProblemDetails
Fixes https://github.com/aspnet/Mvc/issues/8645
2018-10-29 09:56:17 -07:00
Pranav K ccde910b29 Specify TaskCreationOptions when using TCS
Fixes https://github.com/aspnet/Mvc/issues/8558
2018-10-29 09:33:05 -07:00
Doug Bunting 3f52894b1b
Merge pull request #8662 from dotnet-maestro-bot/merge/release/2.2-to-master
[automated] Merge branch 'release/2.2' => 'master'
2018-10-28 21:36:51 -07:00
Doug Bunting 0b6932dc15 Quick fix: Clean up test warnings
- avoid "Skipping test case with duplicate ID" messages
  - xUnit gets confused when `[Theory]`s are overridden
- avoid "falling back to single test case" messages
  - fix inspired by aspnet/SignalR#1820
2018-10-28 21:18:57 -07:00
Doug Bunting 0cea1b2a5f
Merge pull request #8656 from dotnet-maestro-bot/merge/release/2.2-to-master
[automated] Merge branch 'release/2.2' => 'master'
2018-10-27 16:53:19 -07:00
Doug Bunting 37e562902f Support single `IDocumentProvider` method signature
- #8593
- also find `IDocumentProvider` using a more-laborious process
  - `Type.GetType(string)` requires an assembly-qualified name and we don't know the assembly
- default method name now `GenerateAsync`
- only supported signature is `public Task GenerateAsync(string, TextWriter)`

also:
- handle more error cases in the tool's inside man
- avoid an empty document file if `IDocumentProvider.GenerateAsync(...)` fails
- unwrap an `AggregateException`

nits:
- remove duplicate comments
- change `GetDocumentCommandWorker.TryProcess(...)` to return `false` on failure
  - minor because return value is currently ignored
- rename `GetDocumentCommandContext.Output` -> `OutputPath`
- reflect recent change to `dotnet-getdocument`'s `Resources.resx` file in its designer file
2018-10-27 15:27:33 -07:00
James Newton-King 1a093686e6
Merge pull request #8653 from aspnet/jamesnk/master
Merge release/2.2
2018-10-27 12:31:37 +13:00
James Newton-King 1c61f3538e
Merge release/2.2 2018-10-27 11:56:04 +13:00
Pranav K ae50cd619f
Merge pull request #8651 from aspnet/prkrishn/master
Merge pull request #8641 from dotnet-maestro-bot/merge/release/2.2-to…
2018-10-26 12:15:34 -07:00
James Newton-King 6bb292cfcc
Add test for metadata precedence (#8642) 2018-10-27 07:59:15 +13:00
Pranav K 6c0bbc7458
Merge remote-tracking branch 'origin/release/2.2' into prkrishn/master 2018-10-26 11:36:55 -07:00
Pranav K 5656e7f455 React to CORS changes 2018-10-26 11:10:54 -07:00
Pranav K ce11eb9b71
Merge pull request #8641 from dotnet-maestro-bot/merge/release/2.2-to-master
[automated] Merge branch 'release/2.2' => 'master'
2018-10-24 11:19:50 -07:00
Pranav K 2544926b2f Provide a convenience API to configure ApiBehaviorOptions 2018-10-24 10:10:33 -07:00
James Newton-King 5c51e831aa
Merge pull request #8633 from dotnet-maestro-bot/merge/release/2.2-to-master
[automated] Merge branch 'release/2.2' => 'master'
2018-10-23 23:04:29 +13:00
James Newton-King 79117fa08a
Merge 2.2 to master 2018-10-23 22:04:56 +13:00
James Newton-King 40959a97e7
Fix link generation of routes with default values (#8616) 2018-10-23 16:10:43 +13:00
James Newton-King e9737a90e5
Endpoing routing 3.0 registration (#8470) 2018-10-23 14:04:12 +13:00
Ryan Nowak a3e999762f
Merge pull request #8630 from dotnet-maestro-bot/merge/release/2.2-to-master
[automated] Merge branch 'release/2.2' => 'master'
2018-10-22 07:58:36 -07:00
Ryan Nowak 76a30b0911 Remove LinkGenerationTemplate
This doesn't really accomplish our goals for 2.2 - I don't have a clear
scenario where I would tell a developer to use this VS something else.
Will reevaluate in 3.0
2018-10-21 15:39:59 -07:00
Pranav K 79458c16fd
Merge pull request #8626 from dotnet-maestro-bot/merge/release/2.2-to-master
[automated] Merge branch 'release/2.2' => 'master'
2018-10-19 13:57:59 -07:00
Patrick Westerhoff ddbe0fef26 Allow custom handling of antiforgery failures
To enable custom handling of antiforgery validation failures, use an
`AntiforgeryValidationFailedResult` which is just a `BadRequestResult`
but allows to be identified explicitly inside always-running result
filters using the `IAntiforgeryValidationFailedResult` marker interface.
2018-10-19 13:47:08 -07:00
Pranav K 8a183bb4f4 Allow serving Razor files with leading underscore
Fixes https://github.com/aspnet/Mvc/issues/8617
2018-10-19 13:43:35 -07:00
Pranav K 6503265bc6
Merge pull request #8619 from dotnet-maestro-bot/merge/release/2.2-to-master
[automated] Merge branch 'release/2.2' => 'master'
2018-10-18 10:48:27 -07:00
Pranav K 1c1aabc605
Merge branch 'master' into merge/release/2.2-to-master 2018-10-17 16:22:55 -07:00
Pranav K 27e75e7a51
Add a switch to allow turning on ValidationVisitor shortcircuiting (#8599) 2018-10-17 15:47:01 -07:00
Ryan Nowak 5502c43159
Merge pull request #8610 from dotnet-maestro-bot/merge/release/2.2-to-master
[automated] Merge branch 'release/2.2' => 'master'
2018-10-16 13:35:46 -07:00
ASP.NET CI 10a94aa7bb
Update package branding for 2.2 RTM 2018-10-16 12:48:18 -07:00
Ryan Nowak a2a8a5ce36
Merge pull request #8598 from aspnet/rynowak/compat-version-docs
Update docs for compat switch value
2018-10-15 17:04:17 -07:00
Ryan Nowak c421178a22 Update docs for compat switch value 2018-10-15 07:43:18 -07:00
Pranav K 5f42d5063e
Merge remote-tracking branch 'origin/release/2.2' 2018-10-12 15:58:08 -07:00
Pranav K fb57810f29 Shortcircuit validation when using default validator providers and no validation metadata is discovered
Fixes https://github.com/aspnet/Mvc/issues/5887
2018-10-12 14:47:06 -07:00
Pranav K a40c1f2d02 Use compat flag to drive XML ProblemDetails formatting 2018-10-12 14:15:28 -07:00