36e272fdc2
React to Microsoft.AspNetCore.Razor.Evolution => Microsoft.AspNetCore.Razor.Language.
...
aspnet/Razor#1169
2017-04-10 10:20:19 -07:00
90acd055fe
Make [FromBody] treat empty request bodies as invalid ( #4750 )
2017-04-10 16:55:14 +01:00
1e7972bd8f
Add convenience methods for redirecting from a Razor Page back to itself
...
Fuxes #5953
2017-04-07 10:03:42 -07:00
4032de064e
Removing _PageStart.cshtml
...
Pages now also use _ViewStart.cshtml
Also contains some naming/text cleanup that was missed in the previous
commit.
2017-04-06 08:14:37 -07:00
c6e4609096
Getting rid of _PageImports
...
Pages will just use _ViewImports.
2017-04-06 08:14:37 -07:00
9e8d4db7d8
Move TempDataPropertyProvider into filter
2017-04-05 12:04:02 -07:00
925ad75cdf
Add convenience methods for redirecting to another Razor Page
...
Fixes #5956
2017-04-04 14:36:22 -07:00
2d19a82678
Update more resource designer files
2017-04-04 13:54:20 -07:00
b18e96717a
React to https://github.com/aspnet/Razor/issues/1098
2017-04-03 16:41:55 -07:00
d37b1548f8
Update to new resx format
2017-04-03 16:37:22 -07:00
10d2d7c9f6
Remove System.Reflection.TypeExtensions added to workaround test failures
...
Fixes #6005
2017-04-03 14:47:14 -07:00
fe3d45fad1
Adding AllowAnonymousToPage & AllowAnonymousToFolder
...
Fixes #5884
2017-03-31 20:17:31 -07:00
d19150ed22
Fix comment typos in preceding commit
2017-03-31 10:36:53 +01:00
4f351bd37c
Add support for media type suffixes ( #5273 , #6032 )
2017-03-31 10:20:43 +01:00
c47825944d
Remove Microsoft.AspNetCore.Mvc.Razor.Host
2017-03-29 16:50:39 -07:00
959324b337
Add EditorBrowsable attribute
2017-03-29 16:24:44 -07:00
eda5028cf4
Add TagHelperComponentTagHelper
...
Addresses #5728
2017-03-29 11:29:24 -07:00
c18f0780c1
[ Fixes #5413 ] JsonOutputFormatter adds all closing brackets when exceptions are thrown
2017-03-28 23:09:18 -07:00
b22326323a
Add properties to Page and PageModel
...
Fixes #6008
2017-03-28 13:26:38 -07:00
9c5b33dd8a
Upgraded Json.Net version to 10.0.1
2017-03-28 11:28:43 -07:00
d21af1f26d
React to MemoryCache trigger removal
2017-03-27 12:45:54 -07:00
58317b18ce
Fixing NRE when CacheTagHelper throws and exception ( #5989 )
...
Fixes #5988
2017-03-27 12:45:22 -07:00
575fe68b2b
Order enum values by DisplayAttribute.Order
...
Fixes #4297
2017-03-27 12:22:35 -07:00
6436538068
Rename `IHtmlHelper.TextBox()` parameter (for consistency)
...
- #5394
2017-03-27 10:24:30 -07:00
824d65ca3d
Remove `ValueProviderResultExtensions`
...
- #5063
- update tests that used one extension method to instead use `ModelBindingHelper` directly
nit: `mbc` -> `context`
2017-03-24 22:17:34 -07:00
cc6f0f6a26
ITagHelperComponent build fix
...
Fix build
In reaction to aspnet/Razor#1096
2017-03-24 15:23:03 -07:00
e7101f248a
Support model binding to Razor Pages properties on page and PageModel classes
...
Fixes #5952
2017-03-24 07:45:19 -07:00
d2430f0f4e
Merge pull request #6004 from CoskunSunali/dev
...
Avoid entry point assembly being loaded twice during assembly parts discovery
2017-03-22 22:07:28 -07:00
705c36921a
Use alternate workaround for #6005
2017-03-22 19:14:46 -07:00
e80abc1950
React to Razor changes
2017-03-22 18:06:18 -07:00
1152c468be
Disable API Check in projects with untracked breaking changes
2017-03-22 08:34:48 -07:00
badb6ce8e5
Remove net451 as a cross-compile target
2017-03-22 06:32:50 -07:00
11d265bddd
Avoid entry point assembly being loaded twice during assembly parts discovery.
...
Addresses https://github.com/aspnet/Mvc/issues/6003
2017-03-22 04:37:06 +03:00
5c79d4e8ee
Remove Usage of RazorIrNodeVisitorOfT ( #5991 )
2017-03-20 14:52:30 -07:00
270f66198f
Remove Razor from projects
2017-03-17 15:00:39 -07:00
1fdc5132cb
React to TagHelper descriptors api cleanup
2017-03-17 10:51:02 -07:00
1197657e5b
TempData property attribute
...
Addresses #5600
2017-03-16 16:34:35 -07:00
8f4ca32f48
Fix #5807 - Race condition in Invoker
...
This change addressed a race condition in the ObjectMethodExecutor where
the default argument values array can become visible before it is
initialized. If a second observer accesses the array while it is being
initialized, it can observe a null value for a reference type parameter,
leading to a nullref.
The fix here is to make everything immutable and initialize it all up
front. There's no reason to create an OME without eventually running it,
so there's no downside to doing the initialization up front.
2017-03-15 17:19:29 -07:00
6f7717a381
Unify dependency versions to one file
2017-03-15 16:54:32 -07:00
bee1a55cff
Use RazorPagesOptions.RootDirectory when looking for page hierarchies.
...
Fixes #5915
2017-03-14 18:56:50 -07:00
de25357c28
Do not throw if a library does not have a runtime component
...
Fixes #5690
2017-03-14 15:07:50 -07:00
82d87df166
Fix warning as error
2017-03-14 12:44:57 -07:00
365ae19c8b
Add InvalidTagHelperIndexerAssignment to RazorPageBase
2017-03-14 10:04:15 -07:00
e44d875df4
Adding AuthorizePage & AuthorizeFolder without requiring a policy
...
Refactoring
2017-03-13 16:39:52 -07:00
f7fd5114b3
Introduce MvcRazorTemplateEngine
2017-03-13 16:33:13 -07:00
4faef7afaf
Cache more things in HandlerMethodDescriptor
...
Add tests for DefaultPageHandlerMethodSelector
2017-03-13 13:15:26 -07:00
7b53ba1f6b
Reacting to https://github.com/aspnet/Razor/issues/1063
2017-03-13 09:46:36 -07:00
1c74e31715
Add tests for PageActionInvokerProvider ( #5882 )
2017-03-09 16:19:20 -08:00
7f3f6957be
Set path in DefaultPageFactory ( #5911 )
2017-03-09 16:15:43 -08:00
3cd8c8c14d
[ Fixes #5932 ] Add constructor taking the BinderType to ModelBinderAttribute
2017-03-09 08:16:00 -08:00
015dafc25f
[Feature] String should be an acceptable value for a checkbox if it can be parsed as a boolean ( #5845 )
...
- `string` should be an acceptable value for a checkbox if it can be parsed as a `bool`
- `throw` with different resources when `ModelType` isn't `bool` or `string` and when `string` value is not acceptable
2017-03-08 14:22:28 -08:00
d9d280d1ef
Make CookieTempDataProvider the default ITempDataProvider ( #5892 )
2017-03-07 16:04:47 -08:00
7bca31d079
Add convenience extension methods for IPageApplicationModelConvention
2017-03-06 15:28:44 -08:00
b6a6b50776
Fixing up an error in the XML Comments ( #5888 )
2017-03-06 11:07:16 -08:00
de1d0919e5
Add Http Response Codes to doc comments ( #5867 )
2017-03-06 10:00:07 -08:00
00c38fca59
Add ModelState to Page
2017-03-03 17:27:39 -08:00
145d27f9b3
Add a PagesOption type that allows configuring the root for Page file discovery
...
Fixes #5785
2017-03-03 17:20:07 -08:00
85e28ae478
Trim quotes from template ( #5838 )
2017-03-03 09:52:36 -08:00
7cadb58e12
Add convenience extension methods for IPageApplicationModelConvention
2017-03-02 17:38:04 -08:00
f6d25f7117
Fix build warning
2017-03-02 17:20:20 -08:00
f7c2e5bffc
[ Fixes #5844 ] Using ExtensionIRNode for Inject directive
2017-03-01 09:45:47 -08:00
acfad83aa6
Migrate to MSBuild
...
- thanx to @NTaylorMullen for initial conversion
- e.g. AssemblyInfo.cs files were already minimized or removed :)
- allow `>=` RC3 CLI's to build and run MVC
- work around several dotnet migration issues; see #5482
- disable full .NET Framework runs of functional tests; see #5873
- remove `Microsoft.DotNet.InternalAbstractions` and `System.Xml.XmlDocument` dependencies
- remove project.json (!!), *.xproj, .notest, and web.config files
Redo earlier changes:
- apply test migration to .NET 4.5.2 in *.csproj world
- see 63507c80097e40#5768
- work around Microsoft/vstest#392
- rename tests to avoid duplicates
- work around Microsoft/vstest#419
- set up created `AppDomain`s with current `ApplicationBase`
2017-02-28 21:20:39 -08:00
0e914e55fa
Remove double null check ( #5862 )
...
Address #5834
2017-02-28 12:00:23 -08:00
ae61c7005c
React to Microsoft.CodeAnalysis.Razor version change
2017-02-27 17:12:37 -08:00
de30c5822a
* Cache ExecutorFactory as part of CompiledActionDescriptor
...
* Add tests for ExecutorFactory
2017-02-24 11:56:13 -08:00
498c1c570d
Update error message
...
Update error message based on PR feedback to less C# specific.
2017-02-23 14:21:58 -08:00
9950325269
Update view compilation error message
...
Update view compilation error message for csproj instead of
project.json.
2017-02-23 14:21:58 -08:00
f3b1f2ca29
Fixing doc comments
2017-02-23 11:13:34 -08:00
e11e6b3be7
Add TempData property and some functional tests
2017-02-22 08:14:02 -08:00
19331f9532
Adding some basic functional tests
...
I ran into a blocking issue where page handlers aren't picked up, so I
fixed it. Logging another issue to follow up with better tests for this.
2017-02-21 16:41:25 -08:00
39f41eae3c
Fixing typo (an -> a)
2017-02-21 06:52:30 -08:00
11d747fc33
React to CSharpTokenIRNode being removed
2017-02-17 19:31:33 -08:00
0f5d5ff3b5
React to aspnet/Razor#1017
2017-02-17 16:01:54 -08:00
927e75870d
Add BindingSourceMetadataProvider
...
Addresses #5673
2017-02-17 13:22:10 -08:00
366dbde378
Add culture constructor to RouteValueProvider
2017-02-16 14:47:34 -08:00
239e2202e1
ActionContextAccessor netstandard behave like net451 ( #5810 )
2017-02-16 14:34:13 -08:00
401296ac43
Remove unneeded InternalsVisibleTo ( #5809 )
2017-02-16 12:01:42 -08:00
0097e40e46
Downgrade to stable packages
2017-02-15 14:23:48 -08:00
a00acceaa9
Merge branch 'rel/1.1.2' into dev
2017-02-15 12:43:37 -08:00
29647fda33
[ Fixes #5801 ] Move call to validate constructor in ComplexTypeModelBinder into CreateModel
2017-02-15 12:33:01 -08:00
38e1e7d14e
React to aspnet/Razor#996
2017-02-14 15:11:39 -08:00
eb820106e2
Generate the class name from relative path
2017-02-14 09:41:05 -08:00
44048331e9
Make `ViewComponent.View()` overloads respect explicitly passed in model even when `null`
2017-02-13 17:08:48 -08:00
35edc299d7
Fix test failures
...
Fixes #5794
2017-02-13 12:03:10 -08:00
2cdd84f437
Remove pranav's hack
...
This is part 1 of the right fix for the directive getting removed. This
pass has the wrong order, an it should be running sooner before the
directive is processed by the default processor.
2017-02-13 09:23:58 -08:00
af5648c1f7
Merge branch 'rel/1.1.2' into dev
2017-02-13 08:34:18 -08:00
531c11df2a
Fix 5594 - ExceptionHandled + Result is broken
...
This change ensures that setting ExceptionContext.Result will always
execute if set. The problem with 1.1.0 is that when we had a real short
circuit the wrong set of conditions were checked. I suspect that when you
set ExceptionFilter.Result and didn't short circuit that result filters
were also running (which is a bug).
Added a few tests that verify that the result doesn't trigger result
filters.
I did some general cleanup on this code path to make the state transitions
more clear.
No exception was thrown -> BeginResult
Exception was handled -> ExceptionHandled
Exception was not handled -> gets rethrown
2017-02-13 07:58:32 -08:00
4bddb5ff1b
Small follow up to 8ee3d45
...
- rename `containsIndexers` to `doNotCache` in `ExpressionHelper`
2017-02-10 16:46:55 -08:00
fc40985412
Merge branch 'rel/1.1.2' into dev
2017-02-10 14:55:32 -08:00
8ee3d45ef1
Do not cache expressions containing method calls
...
- #5655
- also make `ExpressionTextCache` more robust for defence-in-depth
nits:
- two `null` expression nodes are equal
- declare data properties as `TheoryData<T>`
2017-02-10 14:50:09 -08:00
1652bf554f
Workaround APICheck errors
2017-02-10 12:46:15 -08:00
842d661ac2
[ Fixes #5698 ] Regression in 1.1 model binding for model types without default constructor
...
- Also reverts "Check for default constructor in ComplexTypeModelBinderProvider" commit d09e921c4a
2017-02-10 11:10:02 -08:00
bc3a741eee
Use DocumentClassifierPassBase
...
Workaround issue with the model directive disappearing
2017-02-09 20:30:31 -08:00
8b03e9ef73
Make PageStart work
...
Move more API to RazorPageBase
2017-02-09 18:23:01 -08:00
bd9e431873
Order IgnoreAntiforgeryTokenAttribute and add test ( #5765 )
2017-02-08 09:37:43 -08:00
f474d8bc52
React to optional Razor directive token feature
2017-02-07 21:58:31 -08:00
9264f3aa2d
Add TryUpdateModelAsync to pages
2017-02-07 21:16:40 -08:00
314aa366e1
Add TempData property support for Pages
2017-02-07 15:27:02 -08:00
690ef186a3
Add PageActionDescriptorChangeProvider to allow reloading on page changes
2017-02-07 12:53:44 -08:00
2ff80ffb49
Porting DefaultPageHandlerMethodSelector and ExecutorFactory
2017-02-07 12:44:27 -08:00
624909763b
Make _PageImports work
...
Add support for generating the Model property
2017-02-07 11:13:15 -08:00
9f3dfd9819
Make RazorPages work E2E
2017-02-06 19:05:31 -08:00
c349929cc1
Port old Razor tests to new Razor
2017-02-03 17:09:18 -08:00
8d5abd433f
Add support for PageStarts
2017-02-03 15:57:00 -08:00
c95c2a5a6d
[ Fixes #5686 ] Extend `ModelMetadata` to reduce ugliness
2017-02-03 11:37:28 -08:00
dc0be8d747
SaveTempDataFilter handle write to body
...
(cherry picked from commit 03cdd15e5c
2017-02-03 10:41:36 -08:00
cf70ed663b
Merge tag 'rel/1.1.1' into dev
2017-02-03 10:31:17 -08:00
1777f7babd
Enabling Razor Instrumentation
2017-02-01 15:29:09 -08:00
4c62eb89af
Unit tests for VCTH and model directive
2017-01-31 13:14:20 -08:00
705369ee51
Add unit tests for ModelExpressionPass
...
Add unit tests for @inject
2017-01-30 19:08:39 -08:00
b79f8384b0
Make some methods public for ViewCompilation.
2017-01-30 13:46:27 -08:00
84d2e027f5
Use new Razor in MVC
2017-01-30 10:55:49 -08:00
7449ffad74
Add include and exclude attributes to EnvironmentTagHelper
...
Addresses #5671
2017-01-27 14:46:53 -08:00
d44c9aee1e
Added printing of route values when a route is not matched
2017-01-27 11:31:05 -08:00
17dc23a024
[ Fixes #5637 ] Make CookieName of CookieTempDataProvider configurable
2017-01-27 11:01:26 -08:00
03cdd15e5c
SaveTempDataFilter handle write to body
2017-01-27 10:54:00 -08:00
3e214e2399
Introducing IPageModelActivatorProvider
...
Fixes #5480
2017-01-26 11:31:14 -08:00
9b1271ba19
Remove obsolete DefaultHtmlGenerator ctor ( #5711 )
2017-01-25 16:25:12 -08:00
42ae78a360
[ Fixes #5012 ] ProducesAttribute should not inherit from ResultFilterAttribute
2017-01-25 14:00:35 -08:00
8ac6b6699f
[ Fixes #4945 ] Simple string returned by controller action is not a valid JSON!
2017-01-25 13:29:18 -08:00
5885feb7c0
Fixes a parsing bug with the AcceptHeaderParser
...
When we find an invalid character at the end of a media type value we
should advance and skip over it.
2017-01-23 13:12:40 -08:00
305748a800
Move classes out of .Internal
2017-01-19 11:11:28 -08:00
6396e14504
Add null-check back to MediaType
2017-01-18 16:56:08 -08:00
6f7fc4fb34
Remove obsolete ViewEngine ( #5699 )
2017-01-18 16:29:20 -08:00
24efd4268b
Pin the version of RazorTooling packages to 1.1.0-preview4-final
2017-01-17 11:55:15 -08:00
e749a80b30
Check for empty location in ViewsFeatureProvider
...
Fixes #5675
2017-01-17 11:07:48 -08:00
ce53675b87
Add `[ValidateNever]` and `IPropertyValidationFilter`
...
- #5642
- lazy-load `ValidationEntry.Model`
- avoids `Exception`s when moving to a property that will not be validated
nits:
- remove duplicate code in `ValidationVisitor`
- clarify "all properties of" doc comments
- also add missing `<param>` doc in `ViewDataInfo`
2017-01-15 21:40:29 -08:00
07c22f2b29
Mutate API description parameter type from JsonPatchDocument to Operation[]
...
Addresses #5464
2017-01-13 16:39:08 -08:00
f95d49c870
Change datetime to datetime-local
...
Addresses #4871
2017-01-13 15:40:30 -08:00
93774a0234
Mitigate MediaType overflow
2017-01-13 12:51:19 -08:00
a7abdeabcd
Introducing PageActionInvoker
2017-01-13 11:49:02 -08:00
13b32adeae
Move InvokeAsync to ResourceInvoker
2017-01-11 11:13:05 -08:00
6b0282fa84
Commonize code from ControllerActionInvokerCache and PageFilterFactoryProvider
2017-01-11 10:53:23 -08:00
9cc20ff114
Edited docs, removed unnecessary usings for ApiDescription ( #5634 )
...
Addresses #5625
2017-01-04 17:44:47 -08:00
473337ea33
CompositeChangeToken moved to aspnet/Common Microsoft.Extensions.Primitives
...
Addresses Common Issue aspnet/Common#163
2017-01-04 17:32:20 -08:00
de0f277892
Fix attribute routing error message related to replace tokens
2017-01-04 15:43:57 -08:00
5070526f43
replaced hardcoded message with Resources.ArgumentCannotBeNullOrEmpty
2017-01-04 10:47:21 -08:00
78492b39d8
Introduce a base type for executing auth and resource filters.
2017-01-03 11:14:15 -08:00
2b8233932a
Add IPageFactory and IPageActivator
2016-12-29 15:11:29 -08:00
9146fce4ec
Add extension method for IParameterModelConvention. ( #5640 )
2016-12-27 16:49:12 -08:00
2b50ec99df
Updating to 4.4 CoreFx packages
2016-12-21 16:47:14 -08:00
b2340d327e
Order IgnoreAntiforgeryTokenAttribute and add test
2016-12-12 14:55:36 -08:00
cfa9631ce8
Resolve path traversals in RazorViewEngine
...
This change moves the onus of path resolution from individual IFileProvider instances to RazorViewEngine.
Fixes #5574
Fixes https://github.com/aspnet/MvcPrecompilation/issues/33
2016-12-08 11:20:06 -08:00
de1b763d96
Update IControllerModelConvention.cs
2016-12-07 11:11:57 -08:00
b2f0438562
Fixing comment typo
2016-12-07 11:10:54 -08:00
6fbe514626
Fixing comment typos
2016-12-07 11:07:31 -08:00
1dd1d49321
Redirects with fragment ( #5519 )
...
- Added implementation of overloads where you can specify the fragment to redirect to.
- Added unit tests
- Added XML comments, including missing documentation of existing members
2016-12-06 10:32:01 -08:00
7178464ed2
Munch on less memory when handling property metadata
...
- #5499
- switch `foreach` to `for` and use less Linq when accessing `modelMetadata.Properties`
- change backing field for `ModelExplorer.Properties` from a list to an array
2016-12-05 20:47:45 -08:00
48546dbb28
Add more to `MvcCoreServiceCollectionExtensionsTest`
...
- 2nd half of #5554
- follow-on to #5540 PR
2016-12-05 20:05:24 -08:00
f32d0f2505
Update MvcCoreServiceCollectionExtensions.cs
2016-12-05 20:01:30 -08:00
8f8bf5af34
Seperate view and model for enum display
2016-11-30 11:13:38 -08:00
52ee9afc31
Adding PageActionDescriptorProvider
...
Fixes #5353
2016-11-23 16:53:06 -08:00
74c9194aee
Pinning versions for 1.1.0 release
2016-11-18 12:12:52 -08:00
2bacb6003f
Fix typo in XML doc
2016-11-18 10:56:46 -08:00
975dc212b7
Fix package versions
2016-11-17 10:19:48 -08:00
c5a5ba1fee
Add support for updateable ActionDescriptorCollection
...
Fixes #5350
2016-11-17 10:08:38 -08:00
29cd24f66b
Add Microsoft.AspNetCore.Mvc.RazorPages projects
2016-11-17 10:08:38 -08:00
5deda80e5a
Downgrade Microsoft.Extensions.DependencyModel to 1.1.0
2016-11-09 18:16:49 -08:00
b82969a557
Updating versions to 1.2.0-*
2016-11-09 14:18:46 -08:00
7c05d62a6e
Use request PathBase value to set cookie path only if it has a non-null & non-empty value
2016-11-09 04:43:08 -08:00
6d4361218e
Add builder extensions to simplify use of `CookieTempDataProvider`
...
- #5515
2016-11-08 15:32:09 -08:00
576c0e6a65
Throw an exception if configurationType to CreateConfigureDelegate is abstract/has no parameterless ctor
...
Addresses #5431
2016-11-08 14:16:03 -08:00
07a2f1de06
Fixes CookieTempDataProvider to set the secure attribute of a cookie only if a request is secure
2016-11-08 13:30:28 -08:00
a3c06b00cc
Fixes CookieTempDataProvider to handle empty request PathBase while setting cookie options
2016-11-08 13:30:27 -08:00
24d5dfb552
Dynamic assembly checks to prevent NotSupprotedExceptions from System.Reflection.Emit
...
Fixes #5487
2016-11-07 12:49:49 -08:00
9caa688a30
Modified exception message for duplicate keys exception in CandidateResolver
...
Addresses #5289
2016-11-07 11:16:11 -08:00
304000095a
Added logging for precompiled views in RazorViewEngine
...
Addresses #5462
2016-11-07 10:46:54 -08:00
bfe50ddd8c
Created public API baselines
2016-11-04 23:53:26 -07:00
abd80b5f07
Remove unused source package references.
2016-11-04 15:58:20 -07:00
0cee00aae1
[ Fixes #5352 ] When replacing Controller.Dispose with an explicit implementation the base Dispose is an action
2016-11-04 09:34:30 -07:00
7985121bab
[ Fixes #5207 ] Support IsIndexer for ViewComponent tag helpers
2016-11-03 16:50:22 -07:00
63d7d35bd2
Filter out generic invoke methods in ViewComponents
2016-11-03 15:15:44 -07:00
f04286562e
Treat `ContentType==null` and `MediaType.GetEncoding(ContentType)==null` differently
...
- now, if client sends e.g. `Content-type: text/json;charset=[invalid]`, service will respond with HTTP/415
- if client sends `Content-type: text/json`, service will still try UTF-8 (or updated default encoding)
- intentional (and slight) behaviour change from 1ac7315
2016-11-03 10:51:39 -07:00
116c927e61
Revert "Do not call `Encoding.GetEncoding()` with a string from the request"
...
- #5351 should be Won't Fix
This reverts commit 1ac731519a
2016-11-03 10:51:39 -07:00
01b237dda9
Antiforgery goes at the end of filters
2016-11-02 16:50:27 -07:00
c28ad48e98
[ Fixes #5216 ] Make generic parameters work with ViewComponent tag helpers
2016-11-02 15:55:23 -07:00
ea701f2cd6
Added UserClaimsPrincipal to ViewComponent
...
Addresses #4964
2016-11-02 10:30:22 -07:00
32710bbfbe
[ #5430 ] CookieTempDataProvider chunking broken
2016-11-01 16:13:27 -07:00
5d5b282dbd
Moved CaseSensitiveTagHelperAttributeComparer to Razor.TagHelpers.Testing.Sources
...
Addresses #5323
2016-11-01 14:51:37 -07:00
8f6a0fc4fa
Updating to 1.1.0 build of ResponseCaching
2016-10-28 18:23:40 -07:00
ada42ea913
Move value source information from `<remarks>` to `<summary>`
...
- #1999
- may have reordered the precedence comments as I double-checked the implementations
- `CheckBox()` and `RadioButton()` were examples of such updates
nits:
- use SSL in documentation links
- simplify mentions of format strings
- remove a few phrases that didn't say much and duplicated `<remarks>`
2016-10-28 16:43:59 -07:00
0eea3c2651
Log messages added to BodyModelBinder for input formatters ( #5451 )
...
Addresses #5367
2016-10-27 09:43:53 -07:00
3d2710a6c4
Changed MiddlewareFilter accessibility to internal ( #5455 )
...
Fixes #5432
2016-10-26 11:05:36 -07:00
1ac731519a
Do not call `Encoding.GetEncoding()` with a string from the request
...
- #5351
- fix affects only `TextInputFormatter`
- `TextOutputFormatter` already does the Right Thing™️ with `Accept-Charset` headers
- `ResponseContentTypeHelper` uses `Encoding.GetEncoding()` but is not passed request data
2016-10-24 14:59:49 -07:00
60c59b576e
Replace HashSet with a Hybrid HashSet/List
...
to improve performance on less nested models
2016-10-24 14:47:49 -07:00
3fdcaecaa8
Correctly handle quoted media type parameter values
...
- #5349
- fix or add comments about other parsing errors and inconsistencies
- `MediaType` did not skip whitespace before the type
nits:
- use `+=`
- `<code>` -> `<c>` since the former is not for use within a paragraph
- split tests up to remove `bool expectedResult` parameters
2016-10-24 13:16:09 -07:00
f629f9a659
Check for null arguments in GetArgumentDictionary
...
Addresses #5423
2016-10-20 13:40:39 -07:00
79e576b86c
ProducesResponseTypeAttribute(int statusCode) ctor added
...
Addresses #4863
2016-10-19 17:08:06 -07:00
d5b0ebd10c
Merge branch 'rel/1.1.0-preview1' into dev
2016-10-18 14:26:12 -07:00
9579806306
[ Fixes #5150 ] parsing issue on asp.net when request quality factor is specified
2016-10-18 12:52:53 -07:00
38aa48651f
Fix for Issue#5150
2016-10-18 12:52:30 -07:00
d8c6c4ab34
Add support for VaryByQueryKey #2894
2016-10-18 12:31:04 -07:00
3004fb822b
Merge branch 'rel/1.1.0-preview1' into dev
2016-10-18 12:02:42 -07:00
61de7fec6f
[ Fixes #5421 ] Visit children when accepting TagHelperChunk
...
- Fixes ViewComponentTagHelpers in nested scenarios
2016-10-18 12:00:07 -07:00
c2fee4d74d
AcceptedResult(), AcceptedAtActionResult(), AcceptedAtRouteResult() support
...
Addresses #4937
2016-10-18 09:48:26 -07:00
e7c992ff06
Added fragment to FormActionTagHelper and FormActionTagHelper
...
Addresses #4917
2016-10-18 09:46:50 -07:00
4e1ec39a1f
Store `GetFullHtmlFieldName()` and `CreateSanitizedId()` values
...
- #3918
- don't repeat allocations for identical calls; helps w/ e.g. label / input / validation clusters
- add `NameAndIdProvider`; it stores `PreviousNameAndId` in `HttpContext.Items`
- `PreviousNameAndId` allocated only when `string`s are allocated e.g. "id"s were sanitized
2016-10-17 21:50:56 -07:00
3ef7d01bb6
Small code cleanup ( #5388 )
...
* Removed unused private GetUrlHelper method in LocalRedirectResult class.
* Minor code formatting improvements.
* Fixed white space and casing of 'URL' in comment in RedirectResultExecutor.
2016-10-17 20:45:47 -07:00
eea297975d
Reduce `HtmlContentBuilder` allocations
...
- #3918
- lazy-load `TagBuilder.InnerHtml`; add `HasInnerHtml` property for conservative use
- depends on aspnet/HtmlAbstractions@0781b5a (adds `HtmlContentBuilder.Count`)
- don't use a `HtmlContentBuilder` at all in `DefaultHtmlGenerator.GenerateValidationSummary()`
- avoid instantiating `HtmlContentBuilder` when short-circuits make it unnecessary
- provide correct `HtmlContentBuilder` capacity where known
2016-10-17 14:38:30 -07:00
69b4b64fd5
Cache ModelMetadata HashCode
2016-10-17 12:06:14 -07:00
a80d7d744a
Speed up MSD.GetNode
2016-10-17 10:48:36 -07:00
c5a09327eb
Revert "Downgrade to 1.0.0 Microsoft.Extensions.DependencyModel"
...
This reverts commit 45337c1fc2
2016-10-10 21:21:04 -07:00
4a1c437f60
Don't fail precompiled view discovery if assembly is not managed
2016-10-09 20:39:13 -07:00
d09e921c4a
Check for default constructor in ComplexTypeModelBinderProvider
2016-10-07 16:46:13 -07:00
e7fe635dab
Modified FormCollectionModelBinderProvider to throw when binding for FormCollection model type.
...
[Fixes #4895 ] No parameterless Constructor defined
2016-10-07 16:46:11 -07:00
e987e2107f
[ Fixes #5379 ] Dont generate TagHelperDescriptors for ViewComponents with generic parameters
2016-10-07 12:26:53 -07:00
ed3b750ad2
Less allocations in ViewBuffer when there is only one ViewBufferPage
2016-10-07 11:25:30 -07:00
a623b4edd1
Use Assembly's containing directory to locate precompiled views assembly
2016-10-07 10:36:39 -07:00
45337c1fc2
Downgrade to 1.0.0 Microsoft.Extensions.DependencyModel
...
Work around for https://github.com/dotnet/core-setup/issues/423
2016-10-06 16:40:37 -07:00
41f00eea23
Default Status Code for void types changed to 200
...
Fixes #4838
2016-10-06 14:39:04 -07:00
5820854940
Load precompiled views binary from the bin directory
...
Work around for Assembly.Load in CoreCLR no longer loading arbitrary binaries from the bin directory.
2016-10-06 10:32:18 -07:00
268617ddba
DefaultViewComponentFactory no longer allocates new lambda delegate on each call to CreateViewComponent
2016-10-05 09:12:05 -07:00
4e6fd823cf
Fix bounds checking in `PagedCharBuffer` and related code
...
- #5347
- inconsistent bounds checking caused problems after `ArrayPool<char>` fell back to `new char[2048]`
- would fail a `Debug` assertion in Debug builds and loop endlessly in Release builds
- change to `CacheTagHelper+CharBufferHtmlContent` is for correctness only
- always uses a `CharArrayBufferSource` and that returns arrays of the exact size requested
2016-10-04 10:19:44 -07:00
f3ba776257
Remove null check for setupAction
...
there is already one which throws an ArgumentNullException
2016-10-03 21:39:46 -07:00
6d235e4ef5
Update partner package versions
2016-10-03 14:27:20 -07:00
89bd6dc1cd
[ Fixes #5212 ] Added a cookie based ITempDataProvider
2016-10-03 14:04:57 -07:00
4cca6b09f0
Reduce allocations during HTML generation
...
- #3918
- precompute size of `StringBuilder` in `ExpressionHelper`
- reduce `string` allocations in `ViewDataEvaluator`
- also get rid of `Enumeration` state machines
- reduce the size of a few objects; use more expression-valued properties
- e.g. don't store `_modelType` in `ModelExplorer`
- add `EmptyArray<TElement>`; make empty arrays consistently `static`
- avoid `string.Split()` in HTML and tag helpers
nits:
- make `ExpressionHelperTest` tests more stringent
- correct `Message` for an `ArgumentNullException`
- remove excess `using`s in classes I touched (but often ended up leaving otherwise unchanged)
- improve doc comments
- remove `ToString()` call on a `string`
- avoid encoding `string.Empty`
- fix test file name
- remove useless variables
- correct spelling
- improve whitespace
2016-10-03 12:17:47 -07:00
92682b71f3
Addresses #5251
2016-10-03 11:23:18 -07:00
8fb339483d
Move HttpContext property up a level
2016-10-03 08:34:23 -07:00
261f73abc7
Add NonViewComponentAttribute
2016-09-30 10:56:08 -07:00
60d600dd5c
Issue #5310 ( #5334 )
...
* Issue #5310
2016-09-30 09:40:53 -07:00
a04f5cba9a
Remove ViewDataEvaluator.GetPropertyValue Closure ( #5325 )
...
- part of #3918
2016-09-28 15:23:17 -07:00
0a4c06eefb
Suppress validation summary `<div>` when nothing is generated
...
- #2372
- make the `ValidationSummaryTagHelper` behave consistently with `Html.ValidationSummar()`
2016-09-27 15:51:51 -07:00
6cdd0451da
DisplayMetadata use DisplayNameAttribute
2016-09-27 15:24:21 -07:00
f222fa4349
Correct examination of `IHtmlHelper.Label()` return value
...
- #5317
- previously worked only because `TagBuilder` cannot be empty and `HtmlString` overrides `ToString()`
- `TagBuilder.ToString()` (now the type's `FullName`) is also never empty
- copy `NullHtmlEncoder` from Razor and give it a better name (`PassThroughHtmlEncoder`)
- not available in this project and (from its namespace) not intended for general use
2016-09-27 10:00:29 -07:00
27e4822a7b
Preserve `class` casing when merging a `TagBuilder` into a `TagHelperOutput`
...
- #5313
Also:
- preserve existing `TagHelperAttribute.ValueStyle`
- fix this in `UrlResolutionTagHelper`, `LinkTagHelper`, and `ScriptTagHelper` as well
- correct handling of non-`string` `classAttribute.Value`s in `TagHelperOutputExtensions`
- relates to #3918 because new `ClassAttributeHtmlContent` is smaller than any concatenated attribute value
nit: clean up `CacheTagHelper` whitespace and `using`s
2016-09-26 15:56:30 -07:00
0d782d9d9a
Adding design time support for ViewComponent TagHelpers
2016-09-23 16:58:01 -07:00
03b3d6bec8
Use DataAnnotationLocalizerProvider for Display localization
2016-09-23 10:05:42 -07:00
01f7ecd9d9
[ Fixes #5154 ] Stream should be suppressed from model metadata validation
2016-09-19 11:10:03 -07:00
3c05d10430
Set designTime to false
2016-09-19 10:49:01 -07:00
b3fe8b30ac
Moved VCTHDFactory to .Internal namespace
2016-09-16 15:50:44 -07:00
5ad5f7a3f9
Addressed feedback
2016-09-16 11:01:51 -07:00
0cfd5363f8
Added ViewComponentTagHelperDescriptorResolver and related stuff
2016-09-15 17:12:43 -07:00
760c8f3867
Ensure Append writes to the right page after Clear
2016-09-14 18:57:21 -07:00
42027b6cc2
[ Fixes #5243 ] Handle null values in TempData properly
2016-09-14 15:41:38 -07:00
d9ff1d81d6
PagedBufferedTextWriter does not flush synchronous data prior to writing data asynchronously
...
Fixes #5241
2016-09-14 14:52:06 -07:00
43071319aa
Buffer rendered CacheTagHelper content strings to a custom TextWriter
...
Fixes #4893
2016-09-14 14:47:37 -07:00
a480378a44
Make AuthorizeFilter constructable
...
* Make AuthorizeFilter constructable
Fixes #5253
2016-09-14 13:43:56 -07:00
994835ce47
Remove IViewsProvider and make view lookup to the feature provider
2016-09-14 13:40:05 -07:00
809d2bf7ec
Add `ValidationHtmlAttributeProvider` to make `AddValidationAttributes()` available
...
- #5028
- helpers similar to our HTML or tag helpers can use the new singleton to examine or add validation attributes
- in the most common case, helpers add validation attributes to a `TagBuilder`
- separate `DefaultValidationHtmlAttributeProvider` from `DefaultHtmlGenerator`
- avoids creating two instances of the `DefaultHtmlGenerator` singleton
- would be even uglier to require callers to cast an `IHtmlGenerator` to `ValidationHtmlAttributeProvider`
- `[Obsolete]` old `DefaultHtmlGenerator` constructor
2016-09-13 21:07:18 -07:00
4a5e1f4a72
Use as cast instead of C-style cast for IVewContextAware helpers
...
Fixes #5254
2016-09-12 16:34:02 -07:00
eee1a9fef4
Do not generate a validation summary when `excludePropertyErrors` unless specific model has an error
...
- #5209
- update affected `HtmlHelperValiationSummaryTest` and functional tests
- add `ValidationSummaryTagHelperTest` tests to cover related scenarios
##### Behaviour changes when no errors exist for the model:
###### Tag helper
``` html
<div asp-validation-summary="ModelOnly" class="order"><h3>Oopsie<h3></div>
```
previously generated
``` html
<div class="order validation-summary-errors"><h3>Oopsie</h3><ul><li style="display:none"></li>
</ul></div>
```
and now generates
``` html
<div class="order"><h3>Oopsie</h3></div>
```
###### HTML helper
``` c#
@Html.ValidationSummary(excludePropertyErrors: true, message: "Oopsie")
```
previously generated
``` html
<div class=\"validation-summary-errors\"><span>Oopsie</span>
<ul><li style=\"display:none\"></li>
</ul></div>
```
and now generates nothing (`@HtmlString.Empty`).
2016-09-08 15:36:47 -07:00
43a0a5a9f1
Replace ConfigureOptions with IConfigureOptions
2016-09-08 15:19:07 -07:00
4677bf13fa
Reverting accidental changes
2016-09-08 08:28:51 -07:00
05392cbf35
Added view component tag helper code generator. ( #5195 )
...
This addresses #1051 . There is one more pull request that needs to be completed/merged (for `CompositeTagHelperDescriptorResolver` and friends). After that, runtime should work!
2016-09-07 20:30:09 -04:00
830983a477
Fixes #5198 Stops caching of Enum display values ( #5185 )
...
Fixes #5197 GetEnumSelectList uses IStringLocalizer
Fixes #4215 Html.DisplayFor now checks DisplayAttributes on enums
2016-09-07 16:00:17 -07:00
21236cc98e
[ Fixes #5016 ] Perf: Check for OPTIONS before looking for CORS headers
2016-09-06 14:48:57 -07:00
a5db01169a
Fixed comment in Filters/FilterCollection ( #5225 )
2016-09-03 11:04:58 -07:00
fae0e9a66e
Handle `!ConvertEmptyStringToNull` cases correctly in `SimpleTypeModelBinder`
...
- #4988
- preserve whitespace as the setting demands
- correct previous `string.IsNullOrEmpty()` call to match previous `ValueProviderResultExtensions.ConvertTo()` use
- short-circuit other `string`-to-`string` conversions (as `ValueProviderResultExtensions.ConvertTo()` does)
- correct documentation of `ConvertEmptyStringToNull` properties
- add more tests of these scenarios and remove duplicate `BindModel_ValidValueProviderResult_ConvertEmptyStringsToNull()` test
2016-09-02 16:15:18 -07:00
6016966dcf
Typo in comment of MvcJsonMvcOptionsSetup ( #5221 )
2016-09-02 14:30:50 -07:00
N. Taylor Mullen
Steve Sanderson
Pranav K
Ryan Nowak
Ryan Brandenburg
Hisham Bin Ateya
Jass Bagga
Kiran Challa
John Luo
twirpx
Derek Gray
Doug Bunting
David Fowler
Coskun Sunali
Stefan Nikolei
Ajay Bhargav Baaskaran
Nate McMaster
jacalvar
Nick Chapsas
Steve Gordon
martincostello
Steve Smith
Nate McMaster
Joonas Westlin
hiiru
Joonas Westlin
Daniel Roth
Julian Dominguez
Marcus Schweda
Jass Bagga
joheredi
Vladislav Karamfilov
Ben Adams
Yves57
apxoht
campersau
Kristian Hellang
cjrosa
Crystal Qian
Christian Weiss