Nate McMaster
1eb7f9e032
Add CookieBuilder to CookieTempDataProviderOptions and obsolete duplicate API ( #6472 )
2017-07-05 10:19:13 -07:00
Javier Calvarro Nelson
ef43b100a6
Fix a null reference exception and add some null checks
2017-07-04 14:24:40 -07:00
Ryan Nowak
8d9c16132a
Fix #6479 - remove IFileProvider constructor
...
The RazorProject implementation used by MVC at runtime has a constructor
that takes an IFileProvider (used by tests). This causes ambiguities
when a user registers an IFileProvider in DI.
Cleaning up tests to use a mock instead of the file provider directly
2017-07-04 13:48:56 -07:00
Ryan Nowak
a23307e2b1
Check for properties that can't befound
...
If you give ModelExpressionProvider a lambda with a private property
you'll end up here. This wasn't common before, but it seems like users
are more likely to try it with pages.
Model Metadata and Model Binding don't handle private properties, so
supporting it in Model Expressions seems less than useful.
This isn't a breaking change because this case would have resulted in a
null-ref. Addresses #6400
2017-07-04 13:26:17 -07:00
Doug Bunting
c351712419
Add `FloatingPointTypeModelBinderProvider` and related binders
...
- #5502
- support thousands separators for `decimal`, `double` and `float`
- add tests demonstrating `SimpleTypeModelBinder` does not support thousands separators for numeric types
- add tests demonstrating use of commas (not thousands separators) with `enum` values
2017-07-03 17:55:04 -07:00
Javier Calvarro Nelson
c50f55d1de
Add a default sliding expiration of 30 seconds on Memory and Distributed Cache Tag Helpers.
2017-07-03 17:06:47 -07:00
Ryan Brandenburg
057a853de7
DiagnosticSource to 4.4.1
2017-07-03 15:03:34 -07:00
Sébastien Ros
13e76c24d3
Dispose CancellationTokenSource created in CacheTagHelper ( #6293 )
...
Fixes #5649
2017-07-03 14:59:48 -07:00
Hao Kung
eeee3ef731
Add SignOut overload + Use new auth api ( #6476 )
2017-07-03 12:32:11 -07:00
Javier Calvarro Nelson
d917504c14
[ Fixes #6468 ] Clean up the productionized testing infrastructure
2017-07-03 10:15:06 -07:00
Pranav K
7c5a16c105
Add RemoveType methods of PageConventionCollection
2017-06-30 16:27:51 -07:00
Pranav K
bc4328de16
Add entry to breakingchanges.json
2017-06-30 15:44:21 -07:00
Henk Mollema
948982ebff
Create custom collection for model binder providers
...
Fixes #6161
2017-06-30 15:44:07 -07:00
Pranav K
bc86ea4e47
Move convention extensions from RazorPagesOptions to PageConventionCollectionsExtensions
...
Fixes #6462
2017-06-30 14:25:10 -07:00
Doug Bunting
f76a390a4e
Fall back to linear search for prefix matches
...
- #6469
2017-06-30 10:59:07 -07:00
Doug Bunting
293ac81fe1
Use ordinal comparisons in `ExpressionTextCache`
...
- #6349
- C# field and property names are case-sensitive
- it's not important (where this cache is used) that HTML field names are case-insenstive
2017-06-29 14:59:06 -07:00
Jass Bagga
17f6b17a6d
Add RequestSizeLimitAttribute ( #6453 )
...
Addresses #6352
2017-06-29 13:04:27 -07:00
Ryan Nowak
579aca0121
Define semantics for pagemodels
...
Fixes #6210
Now a pagemodel requires a [PageModel] somewhere in it's hierarchy. We
don't do a guess at whether or not your model class is a PageModel.
2017-06-29 09:24:57 -07:00
Doug Bunting
a90f4118ad
Do not include type names in `ModelState` error messages
...
- #6076
- add resources and accessors specifically for the element / parameter cases
- avoid `metadata.GetDisplayName()` where possible
- fill in the `ValidationContext` that `ValidatorObjectAdapter` uses
- e.g. `Validate_NestedComplexType_IValidatableObject_Invalid()` test fails without this
Possible future work:
- improve error message used for `ModelMetadata.IsRequired` elements and parameters
- use something besides the type for `ValidationContext.DisplayName` of elements and parameters
nits:
- trailing whitespace
- use more `out var`
2017-06-28 15:16:23 -07:00
Pranav K
8df3032540
Add support for specifying filters on page models.
...
Fixes #6334
2017-06-28 14:43:02 -07:00
Henk Mollema
7166dfecd7
Add generic overloads on FilterCollection
2017-06-28 09:03:48 -07:00
Ryan Nowak
1886d53d89
Remove [BindProperty] on class
...
This isn't a good fit with consistency with controllers. Discussed with
@DamianEdwards and we agreed to remove this for now and bring it back in
the future if there's a real need for it.
2017-06-28 08:18:42 -07:00
Pranav K
9acfc8d221
Watch _ViewImports outside the pages root for changes
...
Fixes #6428
2017-06-27 09:30:07 -07:00
Pranav K
d1813a7cd7
Normalize paths returned by view location expanders
...
Fixes #6448
2017-06-27 08:48:07 -07:00
Ryan Nowak
3536cf5aad
Fix #5183 - update docs of CreateWriter
2017-06-26 18:59:36 -07:00
Ryan Nowak
0ad9c7d4eb
Making Pages Binding Consistent
...
This changeset reckonciles the binding work we did for pages with
controllers.
A quick summary:
- Moves [BindProperty] to the MVC namespace (#6401 )
- Makes [FromRoute] and friends behave consistently (#6402 )
- Makes [BindProperty] work with controllers (untracked)
2017-06-26 18:11:44 -07:00
Jass Bagga
f4a86f5511
Add DiagnosticSource to RazorView ( #6386 )
...
Addresses #6222
2017-06-26 15:35:31 -07:00
Pranav K
e5da44a82f
Generate full pdbs for views on desktop and re-enable runtime error tests ( #6442 )
...
* Generate full pdbs for views on desktop and re-enable runtime error tests
StackTraceHelper \ PortablePdbReader used by Diagnostics is only useful for
reading portable pdbs on disk. However pdbs produced by views are entirely
in memory and therefore cannot be read. Consequently
we choose to generate full pdbs for views on Windows (when possible).
2017-06-26 10:46:12 -07:00
Javier Calvarro Nelson
03e555a24e
Fix packing issue
2017-06-23 19:43:04 -07:00
Javier Calvarro Nelson
052db40567
Fix documentation and target files issues
2017-06-23 19:09:45 -07:00
Javier Calvarro Nelson
35152d5933
[ Fixes #6233 ] Productionize and harden our functional testing infrastructure
2017-06-23 18:12:41 -07:00
Pranav K
aa5a348385
_ViewStart.cshtml not picked up when added to the root of the app
...
Fixes #6308
2017-06-23 08:25:58 -07:00
Pranav K
0dfffd45c2
RazorPages page directives missing quotes should alert user
...
Fixes #5868
2017-06-22 15:13:38 -07:00
Jass Bagga
9d138affa2
Suppress JsonPatchDocument validation ( #6429 )
...
Addresses aspnet/JsonPatch#80
2017-06-22 14:14:11 -07:00
Ryan Nowak
de64c84610
React to RazorIRNode renames
2017-06-21 13:44:58 -07:00
Pranav K
c89f0a1e43
Allow AddPageRoute to route to pages root. ( #6412 )
...
* Allow AddPageRoute to route to pages root.
Fixes #6338
2017-06-20 12:33:33 -07:00
Pranav K
f824704741
Cleanup fileLength use
2017-06-18 11:05:49 -07:00
Kiran Challa
3fc3d8d060
Merge branch 'rel/2.0.0-preview2' into dev-gate
2017-06-15 03:48:49 -07:00
Kiran Challa
0c6460ab64
Changed WebApiCompatShim projects to use PackageTargetFallback
2017-06-14 16:08:04 -07:00
Ryan Brandenburg
8832014516
PackageTarget->AssetTarget
2017-06-14 15:03:43 -07:00
N. Taylor Mullen
080836e1c5
React to FileName => FilePath renames in Razor.
...
aspnet/Razor#1423
2017-06-13 11:39:38 -07:00
Ryan Nowak
dfe04bc917
Fix #5979 - Remove hardcoding of tempdata for pages
2017-06-12 15:05:36 -07:00
Pranav K
c27b07ef3f
Use C# 7 features
2017-06-11 22:11:51 -07:00
Pranav K
1c4b0fcdf3
Code clean up
2017-06-09 22:38:46 -07:00
Pranav K
6961cf9211
Cleanup unused precompilation code
2017-06-09 16:45:43 -07:00
Pranav K
b1b7252ddc
Merge pull request #6383 from aspnet/rel/2.0.0-preview2
...
Modify ControllerBase.RedirectToPageResult to call the correct overload
2017-06-09 15:11:23 -07:00
Pranav K
d92d8cddeb
Modify ControllerBase.RedirectToPageResult to call the correct overload
2017-06-09 14:40:29 -07:00
N. Taylor Mullen
6c69cb8f36
Make SHA256 algorithm creation FIPS compliant.
...
#6354
2017-06-08 10:20:36 -07:00
Pranav K
a5f3a6425e
Remove TaskCache and TaskCacheOfT
2017-06-08 08:19:20 -07:00
Pranav K
8662422e18
Merge pull request #6376 from aspnet/rel/2.0.0-preview2
...
Perform case insensitive lookups for precompiled views
2017-06-07 15:19:42 -07:00
Pranav K
1124eb5016
Perform case insensitive lookups for precompiled views
2017-06-07 15:19:21 -07:00
Eilon Lipton
32e21e2a5c
Merge pull request #6363 from JamesNK/patch-1
...
Return a shared contract resolver
2017-06-07 14:37:18 -07:00
Pranav K
8f883e8e13
Use RazorViewAttribute \ RazorPageAttribute for view discovery
2017-06-07 13:49:24 -07:00
Nate McMaster
e9362360c6
Remove unused dependency and update corefx version
2017-06-06 17:12:47 -07:00
Ajay Bhargav Baaskaran
fa2d162ac1
React to razor
2017-06-06 16:43:28 -07:00
Jass Bagga
7ffd88757d
Respond to RangeHelper refactor ( #6348 )
...
Respond to https://github.com/aspnet/StaticFiles/pull/200
2017-06-06 11:22:35 -07:00
Kiran Challa
f1dd475eae
Merge branch 'rel/2.0.0-preview2' into dev
2017-06-06 09:35:33 -07:00
Kiran Challa
af91b58bd3
Enabled a way to buffer request body in formatters
2017-06-06 09:33:32 -07:00
James Newton-King
07e975a0ed
Return a shared contract resolver
...
Return a shared contract resolver from CreateSerializerSettings for performance
2017-06-06 17:52:18 +12:00
Pranav K
628dfc39c1
Remove model type from RazorPageAttribute
2017-06-05 16:07:14 -07:00
Pranav K
20c04d099e
Update to use Razor parser to parse page directive
2017-06-05 14:02:24 -07:00
Ryan Nowak
b796bc0f39
Add Page filters
2017-06-05 08:05:49 -07:00
Kiran Challa
03e696a05e
Merge branch 'rel/2.0.0-preview2' into dev
2017-06-01 15:19:13 -07:00
Jass Bagga
4e91e4e36f
Correct short-circuit log message for result filters ( #6350 )
...
Addresses #6318
2017-06-01 14:01:08 -07:00
Kiran Challa
0f0cfdfe94
Removed unnecessary package references
2017-06-01 12:02:05 -07:00
Jass Bagga
a0d9b08f58
Set Content-Length and increase BufferSize ( #6347 )
...
Addresses #6045
2017-06-01 11:27:49 -07:00
John Luo
3a4cae72bd
Use Strict SameSite mode for temp data cookies
2017-05-30 21:04:32 -07:00
Pranav K
3089bf74fe
Remove reference to Microsoft.Extensions.PlatformAbstractions
2017-05-27 17:22:05 -07:00
Pranav K
597a0c9a11
Add support for friendly routes in pages
...
FIxes #6325
2017-05-26 14:29:00 -07:00
Ryan Nowak
688e518991
Add result filters to pages
2017-05-26 12:33:46 -07:00
Ryan Nowak
84e007a2a7
Move exception and result filters in base
2017-05-26 12:33:46 -07:00
Ryan Nowak
e7bd6cfc06
Refactor invoker tests for reuse
2017-05-26 12:33:46 -07:00
Ryan Nowak
b7db6dbc8e
Remove pass-through activator for pages
...
This change removes a 'pass through' IRazorPageActivator that we were
using to avoid the default one initializing the Page twice.
The fix is to add an adapter so that the IRazorPage that the RazorView has
isn't the *real* page, it's the adapter. The adapter doesn't have anything
interesting to activate :).
2017-05-26 12:29:10 -07:00
Ryan Nowak
c3f7613725
Make RazorReferenceManage public
...
Fix for #4938 . This change makes the reference manager public and
documented so that it can be replaced.
2017-05-26 10:58:45 -07:00
Doug Bunting
9f4ff22c4a
React to breaking change latest API Check detects
...
- see PR aspnet/BuildTools#259 and issue aspnet/BuildTools#146
- relates to 014a786b45
2017-05-26 09:53:46 -07:00
Hao Kung
4c2d727e38
React to Auth + switch to Policy Evaluator
2017-05-25 18:23:41 -07:00
Pranav K
bb5eb96625
Load the precompilation type from the loaded assembly
2017-05-25 15:00:12 -07:00
Ryan Brandenburg
9ea37a1bbb
Fix TFM build breaks
2017-05-25 13:12:39 -07:00
Ryan Brandenburg
03404cd3df
Return to NetStandard
2017-05-25 10:34:16 -07:00
Pranav K
452578e4a8
Revisit the architecture of CompilerCache
...
Fixes #5912
2017-05-25 08:54:15 -07:00
Ryan Nowak
2992f8e38a
Separate PageContext and ViewContext
...
This change decouples PageContext and ViewContext completely.
2017-05-24 16:01:52 -07:00
Ryan Nowak
6094c6ff52
Remove use of AssemblyLoadContext
...
This will be needed for the switch back to net46.
2017-05-24 11:05:58 -07:00
Ryan Nowak
a6d97d35e3
Add back support for AddTagHelpersAsServices
...
This doesn't go through the Razor tag helper discovery pipeline because
this can really only ever work for ITagHelper based taghelpers. So
there's really no point in reusing that logic, which would be hard
anyway.
2017-05-23 14:04:42 -07:00
Chris R
53c56f558b
React to StringSegment changes
2017-05-23 14:01:44 -07:00
Jass Bagga
e681c23d5c
Add ITagHelperComponentManager ( #6302 )
...
Addresses #6282
2017-05-23 13:22:15 -07:00
Pranav K
39f1f5c933
Move Pages filter creation to application model provider
...
Fixes #6198
2017-05-23 11:03:19 -07:00
Pranav K
c5f771d96d
Use factory pattern for caching in ControllerActionInvoker
2017-05-22 13:05:55 -07:00
Jass Bagga
9d38e2523c
Add methods to TagBuilder ( #6287 )
...
Addresses #5689
2017-05-19 12:23:16 -07:00
Jass Bagga
9aff0a67c1
Range support for FileResult( #6150 )
...
Addresses #3702
2017-05-19 10:51:46 -07:00
Mardoxx
ece5e748ad
Minor documentation fix for SerializableError
...
ModelStateEntry -> ModelStateDictionary
2017-05-18 11:02:23 -07:00
Ryan Nowak
97bbdafde3
React to Razor changes
2017-05-16 14:58:37 -07:00
Jass Bagga
51c142ae91
Modify GetProperties overload ( #6276 )
...
Addresses https://github.com/aspnet/Common/issues/219
2017-05-16 13:34:14 -07:00
Ryan Nowak
4d905a4110
Make our executor methods virtual
...
Fixes #5874 - we are marking these methods virtual just in case someone
wants to customize the executors. These are in the 'public internal'
namespace but can't really be replaced because they aren't sufficiently
virtual.
2017-05-16 08:43:45 -07:00
Henrik W. Moe
af7303cd8d
Corrected xml-comment for the User-property
...
Removed comment about setting the User. `User` property only supports `get`.
2017-05-16 08:01:38 -07:00
Ajay Bhargav Baaskaran
5662717983
Add null check in WriteLiteral
2017-05-15 15:08:50 -07:00
Jass Bagga
cd6befdef1
Assign unique event Ids in the logger ( #6270 )
...
Addresses #6062
2017-05-15 11:52:52 -07:00
Ryan Nowak
b2d95ffb21
Remove usage of NotFoundProjectItem
...
We're making this type internal in Razor, using a mock here is fine.
Also renamed some types with a generic name. The actual 'default'
RazorProject class lives in Razor and is internal.
2017-05-12 15:55:36 -07:00
Jass Bagga
b758a86a38
Modify ViewComponent_CannotFindComponent error message ( #6263 )
2017-05-12 14:15:29 -07:00
Ajay Bhargav Baaskaran
5eabae55cb
Added PushWriter and PopWriter to RazorPageBase
...
- Removed WriteXYZTo methods
2017-05-11 15:21:42 -07:00
Pranav K
42a4e9a143
Make uses of ObjectMethodExecutor internal
2017-05-10 21:17:51 -07:00