Ryan Nowak
5d4c4d648f
Make WaitAssert report browser errors
...
It turns out we frequently have errors in the browser console in cases
where we're hitting a "timeout".
2019-08-11 10:49:14 -07:00
Ryan Nowak
ab006e10b0
Harden ArrayBuilder
...
Since we're using the ArrayPool, it's really essential that we prevent
use-after-free bugs. I'm currently tracking one down.
2019-08-11 10:49:14 -07:00
Ryan Nowak
89bf58445f
Use a ConcurrentDictionary
...
This is used from a bunch of static methods. Dictionary isn't thread
safe. Encountered this while debugging some other things.
2019-08-11 10:49:14 -07:00
Ryan Nowak
9b4ec6ec71
Add semaphore to selenium tests
...
This change prevents thread pool starvation when running a bunch of
selenium-based tests, by turning the blocking wait for a WebDriver to
start into an async wait.
This also seems to help with speed, and reliability since we're not
running too many browsers at once. I was experencing timeouts, and
seeing them in the debugger while running tests locally, this no longer
happens.
2019-08-11 10:49:14 -07:00
Ryan Nowak
18f5ec71ed
Terminate circuit on error
...
Fixes : #11845
See: https://github.com/aspnet/AspNetCore/pull/12857 for detailed notes.
2019-08-11 10:49:14 -07:00
Doug Bunting
9d25e33246
Merge branch 'release/2.2' => 'release/3.0' ( #13006 )
2019-08-10 22:43:24 -07:00
John Luo
88a3a74dbb
Multitarget packages to remove dependencies for source build ( #12936 )
2019-08-09 19:25:48 -07:00
Mikael Mengistu
8ef285620c
Remove references to OnReaderCompleted and OnWriterCompleted ( #13018 )
2019-08-09 19:04:33 -07:00
Pratik Sanglikar
09db3ebbae
Enable Docker Support checkbox for Blazor Server apps and gRPC apps. ( #13016 )
...
* Enable the checkbox "Add Docker Support" for Blazor apps.
Enable the checkbox "Add Docker Support" for Blazor apps.
* Enable "Enable Docker Support" checkbox for gRPC projects.
Enable "Enable Docker Support" checkbox for gRPC projects.
2019-08-09 18:55:52 -07:00
Daniel Roth
920d8018e8
Update Blazor survey link for preview 9 ( #13008 )
2019-08-09 14:44:19 -07:00
Ryan Brandenburg
391806283a
Don't serve angular static files in dev mode ( #12885 )
...
Don't serve angular static files in dev mode
2019-08-09 14:30:46 -07:00
Ryan Brandenburg
afcfeaf0ac
Improve template Accessibility ( #12891 )
...
Add aria-label to table to give title
2019-08-09 14:25:25 -07:00
Justin Kotalik
7416acb849
Merge branch 'release/2.2' into release/3.0
2019-08-09 14:17:34 -07:00
Ryan Brandenburg
14f17fa7cd
Obsolete Microsoft.AspNetCore.SpaServices and Microsoft.AspNetCore.No… ( #12892 )
...
Obsolete Microsoft.AspNetCore.SpaServices and Microsoft.AspNetCore.NodeServices
2019-08-09 13:47:51 -07:00
Ryan Brandenburg
3ab8ebff42
Extend timeout and enforce usings ( #12952 )
...
Extend timeout and enforce usings
2019-08-09 13:38:09 -07:00
Doug Bunting
b1fdf27f61
Clean up #12854 a bit
...
- remove incorrect comment
- do not completely overwrite `$(RestoreAdditionalProjectSources)` values
2019-08-09 12:07:54 -07:00
Stephen Halter
92977140ac
Timeout all top-level awaits in TestUnixDomainSocket ( #12986 )
2019-08-09 11:40:38 -07:00
Chris Ross
6e25a9fc53
Granular error handling for Negotiate #12566 ( #12958 )
2019-08-09 11:28:39 -07:00
Pranav K
dda84bc7fc
Use TValue as the generic type parameter ( #12953 )
...
* Use TValue as the generic type parameter
Fixes https://github.com/aspnet/AspNetCore/issues/12926
2019-08-09 10:19:33 -07:00
Justin Kotalik
735807d6ff
Skip flaky HTTPS devcert test on 2.2 ( #12980 )
2019-08-09 09:53:31 -07:00
Brennan
ecd6c11c46
Remove unused SignalR benchmarks app ( #12954 )
2019-08-09 09:14:12 -07:00
Justin Kotalik
8dd3cd4129
Merge pull request #12877 from dotnet-maestro-bot/merge/release/3.0-preview8-to-release/3.0
...
[automated] Merge branch 'release/3.0-preview8' => 'release/3.0'
2019-08-09 08:37:19 -07:00
Javier Calvarro Nelson
5c71742e4a
[Identity] Add warnings when using Bootstrap3 and errors when using an unknown framework version ( #12988 )
...
* [Identity] Add warnings when using Bootstrap3 and errors when using an unknown framework version
2019-08-09 15:56:09 +02:00
Mikael Mengistu
e4b4476b37
Add test for canceling start in transport ( #12846 )
2019-08-08 20:14:56 -07:00
Justin Kotalik
a00bafd70f
Fix retries with port selection ( #12984 )
2019-08-08 16:28:34 -07:00
Steve Sanderson
d716ca9d62
Remove .Web IVTs and refactor. Fixes #12713 ( #12967 )
...
* Remove IVTs from Microsoft.AspNetCore.Components.Web to .Blazor/.Server
* Eliminate RendererRegistry from .Web, as it's not needed for server-side Blazor
* Reintroduce RendererRegistry as a WebAssembly-specific concept. Refactor event data parsing.
* Remove redundant guard
* Corresponding test updates
* Update ref sources
* CR: Remove renderer ID fully from server-side Blazor code
* CR: Make WebEventData internal and shared-source
* Hub test updates
* Clean whitespace
* Update binaries
* Regenerate binaries AGAIN
* Update Jest test
* CR: Replace constructor with static parse
* Yet again attempt to refresh the .js binaries
* Fix ref assembly
* Fix test
2019-08-09 00:03:40 +01:00
Justin Kotalik
4c49a9206e
Merge pull request #12974 from dotnet-maestro-bot/merge/release/2.2-to-release/3.0
...
[automated] Merge branch 'release/2.2' => 'release/3.0'
2019-08-08 14:56:39 -07:00
Ryan Nowak
fc2d3e588f
Fix dynamic routes with no route values
...
Fixes : #12915
This was just missing a null check.
Also added unit tests that were missing for these types.
2019-08-08 14:38:59 -07:00
Brennan
5adeaddfe6
Test ValueTask hub methods ( #12898 )
2019-08-08 14:04:43 -07:00
Brennan
bd01c67e88
Add test for supported scenario ( #12931 )
2019-08-08 14:04:16 -07:00
Justin Kotalik
0574a3fc94
Merge branch 'release/3.0-preview8' into release/3.0
2019-08-08 13:35:15 -07:00
Stephen Halter
55632872eb
Timeout all top-level awaits in TestUnixDomainSocket
2019-08-08 13:21:58 -07:00
Justin Kotalik
c6e1bcb66c
Fix Max Request Body Size test ( #12981 )
2019-08-08 13:17:36 -07:00
Artak
4ca819ec99
Update localized strings for templates ( #12927 ) ( #12982 )
2019-08-08 12:55:09 -07:00
Pranav K
d6d4bb2772
Ensure IFormFile binding for nested properties works ( #12847 )
...
* Ensure IFormFile binding for nested properties works
Fixes https://github.com/aspnet/AspNetCore/issues/9510
2019-08-08 12:28:54 -07:00
Justin Kotalik
e32844033a
Merge branch 'release/2.2' into release/3.0
2019-08-08 10:45:31 -07:00
Justin Kotalik
76c62a5768
Update patch config for 2.2 ( #12955 )
2019-08-08 09:00:12 -07:00
Steve Sanderson
3bd838f9d4
Making InteropReliabilityTests as flaky
2019-08-08 11:37:58 +01:00
Steve Sanderson
ebd02cdb71
Fix building Components solution in VS
2019-08-08 11:37:58 +01:00
Ryan Brandenburg
22df034ae6
Allow retries of SSL exceptions
2019-08-07 10:41:49 -07:00
Javier Calvarro Nelson
1b477405ca
[Blazor][ Fixes #12940 ] Make interop tests timeouts more conservative to fix flakiness.
...
Increases the implicit timeout for each operation from 500 milliseconds to 5 seconds.
2019-08-07 17:41:28 +02:00
Javier Calvarro Nelson
25c240bef5
[Blazor] Graceful disconnection
...
* Adds a new API endpoint to trigger graceful disconnection from blazor clients.
* Uses the sendBeacon API on the Blazor client to trigger graceful disconnections on the client when the document gets unloaded, which happens when closing the window, navigating away from the page or refreshing the page.
2019-08-07 17:40:02 +02:00
Steve Sanderson
92869c677f
Revalidating auth improvement. Fixes #12692 ( #12909 )
2019-08-07 15:15:26 +01:00
Ryan Nowak
15e4b605eb
Blazor API Review: RenderTree types ( #12869 )
...
* Add analzyer for pubternal
This is based on some existing code from EF. I'm having a discussion
with them right now on the best way to share this logic.
I also added support for parameters here which was missing. We might
want to make this code converge with `BannedApiAnalyzer` which is much
more thorough than this.
This is using our existing package for testing analyzers thats the
*official* way to do it in our repo. Filed #12868 to track that.
* Add S C A R Y warnings to render tree types
* PR feedback
2019-08-06 22:41:02 -07:00
Pranav K
7e59a26846
Ignore line-ending differences in test ( #12921 )
2019-08-06 15:01:26 -07:00
Steve Sanderson
08349aba69
Ensure render batches aren't started from inside each other ( #12917 )
2019-08-06 22:40:02 +01:00
dotnet-maestro[bot]
594916344d
[release/3.0] Update dependencies from 4 repositories ( #12854 )
...
* Update dependencies from https://github.com/dotnet/arcade build 20190804.1
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19404.1
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19404.1
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19404.1
* React to RenderTreeBuilder namespace change
* Correct builds and tests needing additonal feeds
- use `$(RestoreAdditionalProjectSources)` properties instead of generated NuGet.config files
- this is closer to the previous approach but avoids `$(RestoreSources)` for the common feeds
- also remove few remaining `$(RestoreSources)` mentions from SiteExtension.targets
- no need to copy NuGet.config or add feeds in dotnet-watch tests
- test projects restore within the repo (not in `$env:Temp`) and need no additional feeds
nits:
- $(NuGetConfigFile) hack in eng\Workarounds.props was getting in the way of previous approach and wasn't necessary
* Update dependencies from https://github.com/aspnet/Blazor build 20190805.1
- Microsoft.AspNetCore.Blazor.Mono - 3.0.0-preview9.19405.1
* Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190805.6
- Microsoft.NET.Sdk.Razor - 3.0.0-preview9.19405.6
- Microsoft.CodeAnalysis.Razor - 3.0.0-preview9.19405.6
- Microsoft.AspNetCore.Razor.Language - 3.0.0-preview9.19405.6
- Microsoft.AspNetCore.Mvc.Razor.Extensions - 3.0.0-preview9.19405.6
* Update dependencies from https://github.com/aspnet/EntityFrameworkCore build 20190805.13
- Microsoft.EntityFrameworkCore.Tools - 3.0.0-preview9.19405.13
- Microsoft.EntityFrameworkCore.SqlServer - 3.0.0-preview9.19405.13
- dotnet-ef - 3.0.0-preview9.19405.13
- Microsoft.EntityFrameworkCore - 3.0.0-preview9.19405.13
- Microsoft.EntityFrameworkCore.InMemory - 3.0.0-preview9.19405.13
- Microsoft.EntityFrameworkCore.Relational - 3.0.0-preview9.19405.13
- Microsoft.EntityFrameworkCore.Sqlite - 3.0.0-preview9.19405.13
Dependency coherency updates
- Microsoft.AspNetCore.Analyzer.Testing - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.AspNetCore.BenchmarkRunner.Sources - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.ActivatorUtilities.Sources - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Caching.Abstractions - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Caching.Memory - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Caching.SqlServer - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Caching.StackExchangeRedis - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.CommandLineUtils.Sources - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.Abstractions - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.AzureKeyVault - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.Binder - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.CommandLine - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.EnvironmentVariables - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.FileExtensions - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.Ini - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.Json - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.KeyPerFile - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.UserSecrets - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.Xml - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.DependencyInjection.Abstractions - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.DependencyInjection - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.DiagnosticAdapter - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Diagnostics.HealthChecks - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.FileProviders.Abstractions - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.FileProviders.Composite - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.FileProviders.Embedded - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.FileProviders.Physical - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.FileSystemGlobbing - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.HashCodeCombiner.Sources - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Hosting.Abstractions - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Hosting - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.HostFactoryResolver.Sources - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Http - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Localization.Abstractions - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Localization - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.Abstractions - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.AzureAppServices - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.Configuration - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.Console - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.Debug - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.EventSource - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.EventLog - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.TraceSource - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.Testing - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.ObjectPool - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Options.ConfigurationExtensions - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Options.DataAnnotations - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Options - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.ParameterDefaultValue.Sources - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Primitives - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.TypeNameHelper.Sources - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.ValueStopwatch.Sources - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.WebEncoders - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Internal.Extensions.Refs - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.JSInterop - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Mono.WebAssembly.Interop - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Internal.AspNetCore.Analyzers - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.AspNetCore.Testing - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
* !fixup! close tag properly
2019-08-06 11:05:09 -07:00
Justin Kotalik
94856d049f
Use target architecture for building ANCM symbol packages. ( #12816 )
2019-08-06 10:57:06 -07:00
Ryan Nowak
2b0a1686c3
Improve SetParametersAsync docs ( #12826 )
...
* Improve SetParametersAsync docs
Fixes : #12820
* Clarify semantics of clashing cascading parameters
This change attempts to lock down the semantics of how cascading
parameters behave inside ParameterView.SetParameterProperties.
Previously a cascading value could be used to set a non-cascading
parameter, and vice-versa. We were just missing tests in general for how
cascading values are interpreted by the parameter set logic.
2019-08-06 07:37:49 -07:00
Javier Calvarro Nelson
31cfa2e305
[Blazor][ Fixes #11964 ] Limit the amount of pending renders ( #12763 )
...
[Blazor][Fixes #11964 ] Limit the amount of pending renders
* Adds a default limit of 10 queued pending renders per application.
* Stops producing new render batches after that limit is hit.
* Resumes producing render batches as soon as the client acknowledges a batch.
2019-08-06 16:22:07 +02:00