Commit Graph

4066 Commits

Author SHA1 Message Date
Nate McMaster 5a4fd3e792
Bumping version from 2.1.2 to 2.1.3 2018-08-28 09:07:51 -07:00
kishanAnem 5e20c313d9
Array or List in query string does not get parsed #7712 (#7967)
- exclude collections when detecting complex types in `ApiBehaviorApplicationModelProvider`
- add test cases
2018-08-14 12:06:27 -07:00
Nate McMaster d46948da1d
Pin version variables to the ASP.NET Core 2.1.2 baseline
This reverts our previous policy of cascading versions on all servicing updates.
This moves variables into the 'pinned' section, and points them to the latest
stable release (versions that were used at the time of the 2.1.2 release).
2018-07-12 18:32:17 -07:00
Nate McMaster 66cac69adf
Updating dependencies to 2.1.2 and adding a section for pinned variable versions 2018-07-12 13:44:05 -07:00
Pranav K 174c5eaa6c Make fewer public API changes 2018-07-12 12:46:49 -07:00
Pranav K 4f1b7ccca6 Use ModelMetadata from actual types for validation
Fixes https://github.com/aspnet/Mvc/issues/7952
2018-07-12 12:46:49 -07:00
Kiran Challa bd995d4cb1 [Fixes #7959] Conventional routing with custom templates not working when you have area attributes 2018-07-09 12:35:14 -07:00
Nathanael Marchand 82f7f2aab8 Fix Api Explorer not returning type with ActionResult<T> and no type in ProducesResponseTypeAttribute 2018-06-29 12:00:16 -07:00
Pranav K c4d5ef94a9 Razor runtime compilation produces errors if running on a shared runtime that's rolled forward
Do not provide compilation references from runtime MVC assemblies. This avoids cases where the app is compiled
against an older MVC but running against a newer one (e.g. shared fx roll forward) resulting in compiling against multiple
versions of MVC assemblies

Fixes #7969
2018-06-29 11:17:25 -07:00
Ryan Brandenburg 78fc49ba0c Set 2.1 baselines 2018-06-14 11:09:19 -07:00
Nate McMaster 7c3a4d45ba
Bumping version from 2.1.1 to 2.1.2 2018-06-12 14:01:32 -07:00
ASP.NET CI 9d3243c38d Update dependencies.props
[auto-updated: dependencies]
2018-06-12 19:28:26 +00:00
Kiran Challa 2d63669695 [Fixes #7609] ApiBehaviorApplicationModelProvider overwrites existing BindingInfo in entirety when inferring binding sources 2018-05-30 05:30:10 -07:00
Pranav K 984cd46c4d Fix ActionMethodExecutor incorrectly setting DeclaredType on ObjectResult
Fixes #7782
2018-05-29 14:35:42 -07:00
ASP.NET CI c08b29beda Update dependencies.props
[auto-updated: dependencies]
2018-05-29 09:46:51 -07:00
Nate McMaster 7b16b56112
Bumping version from 2.1.0 to 2.1.1 2018-05-23 15:35:20 -07:00
Nate McMaster 74c0d0c287
Fix experimental package version when IsFinalBuild=true 2018-05-07 15:32:18 -07:00
Ryan Nowak a8e1a1fd40 Bump Roslyn dependency to 2.8.0 2018-05-07 12:09:11 -07:00
ASP.NET CI 63c370ddf3 Update dependencies.props
[auto-updated: dependencies]
2018-05-04 07:44:13 -07:00
Kiran Challa 35f7d3f09c Added tests to verify that RazorPages and FuzzyMatching with Head requests work 2018-05-01 14:01:00 -07:00
Kiran Challa 19c41c0494 Revert "[Fixes #6902] Added an overload for StatusCode that takes in System.Net.HttpStatusCode"
This reverts commit c567a690bc.

[Fixes #7709] Revert https://github.com/aspnet/Mvc/pull/6902
2018-05-01 13:27:57 -07:00
Nate McMaster (automated) ec80c5f8b8
Bump version to 2.1.0-rtm 2018-04-30 14:51:43 -07:00
Ajay Bhargav Baaskaran 595e83d0eb Added nuspec file to Mvc.Analyzers assembly 2018-04-20 14:53:46 -07:00
Pranav K 5d5222cdd8 Introduce BindPropertiesAttribute
* Allow controller and Razor Page models to be annotated with BindPropertiesAttribute
* Disallow BindPropertyAttribute from being declared on types.
* Do not allow arbitrary binding attributes to be applied to Razor Page models.

Fixes #7686
2018-04-20 14:32:14 -07:00
ASP.NET CI 31f9432a39 Update dependencies.props
[auto-updated: dependencies]
2018-04-19 22:30:20 -07:00
Nate McMaster 8ec3870a92
Set NETStandardImplicitPackageVersion via dependencies.props 2018-04-19 16:43:15 -07:00
Ajay Bhargav Baaskaran 44e282e8d4 Generate symbols.nupkg for Mvc.Razor 2018-04-19 12:32:36 -07:00
Pranav K 60a9810268 Allow PartialTagHelper to specify a null model. Fixes #7667 2018-04-18 14:16:44 -07:00
Kiran Challa faca3da42f Ensure ViewData is set on PageResult after a handler method executes
[Fixes #7665] Initializing PageResult.Page as part of result execution breaks Identity UI
2018-04-18 11:44:04 -07:00
Kiran Challa 4f7d53f4e7 [Fixes #7658] FileStreamResultExecutor fails to Dispose FileStream 2018-04-18 11:43:09 -07:00
Kiran Challa 6e4bd1eb46 Fixed PageFilter docs 2018-04-18 11:42:40 -07:00
Javier Calvarro Nelson 1cede88f26 [Fixes #7656] Deps file for netstandard2.0 targeting projects copied by Microsoft.AspNetCore.Mvc.Testing does not play well with Mvc 2018-04-18 11:03:52 -07:00
Javier Calvarro Nelson e781cd38cf [Fixes #7635] Provide a way to configure HTTP Client instances 2018-04-17 12:52:56 -07:00
Javier Calvarro Nelson e0b4c13895 [Fixes #7587] Default to Development environment in tests 2018-04-17 12:52:51 -07:00
Doug Bunting e0e96ce53b
Include parameter type's attributes in ModelMetadata
- #7595
- #7595 relates to #7350 but does not have the same root cause
  - did _not_ revert the src changes in #7350 fix (d995b0418a)
- make non-`[Obsolete]` `ModelAttributes` constructor overload `internal`
  - should generally use `static` methods and not any constructor
  - change some unit tests to use `[Obsolete]` constructor overloads (with suppressions)
- fix test `ParameterBinderExtensions` to use current `ParameterBinder.BindModelAsync(...)` overload
  - found some tests updated `IModelMetadataProvider`, `MvcOptions`, etc. instances but didn't register them in DI
- extend `ModelBindingTestHelper` and `ModelBindingTestContext`
  - reorder some tests to use correct `MvcOptions` and `IModelMetadataProvider` everywhere
  - fixes above issues

nits:
- take a few VS suggestions
- remove an old comment indended only for PR "Reviewers:"
2018-04-17 12:40:38 -07:00
Ryan Brandenburg 864a4e39c3 Branching for 2.1.0-rc1 2018-04-16 17:00:28 -07:00
Pranav K d8fc2d4009 Fix test failures
* Disable deps file generation in class library project. This workarounds known issue - https://github.com/dotnet/core-setup/issues/3726
* Update RazorProjectRouteModelProvider to not specify a trailing slash. This produces paths with a single slash as opposed to two slashes messing with route creation.
* React to Microsoft.AspNetCore.Mvc.Razor.Extensions.Reference that shows up in the deps file.
2018-04-15 16:31:41 -07:00
ASP.NET CI 128c7e0a17 Update dependencies.props
[auto-updated: dependencies]
2018-04-15 14:19:34 -07:00
Doug Bunting cc5ae02b7d
Fix binding & validating dictionaries of non-simple types in jQuery requests
- #7423
- retry failed inner bindings with alternate syntax in `ModelStateDictionary`
  - use property syntax if first attempt tried index syntax and visa versa
- instantiate `ShortFormDictionaryValidationStrategy` with full `ModelState` keys
  - can now provide exact `ModelState` keys that `ModelStateDictionary` used in inner bindings
- normalize model names without a leading period in `JQueryKeyValuePairNormalizer`

nits:
- take a few VS suggestions
2018-04-14 10:41:00 -07:00
Kiran Challa e52933e4e3 Removed UrlTestEncoder references in tests
This is because with the following commit, Routing no longer depends on DI to get a UrlEncoder and always uses UrlEncoder.Default.
4184b2406d
2018-04-14 06:08:20 -07:00
Javier Calvarro Nelson 4984dd2cdd Revert "[Fixes #7587] No easy way to change ASPNETCORE_ENVIRONMENT"
This reverts commit 22510e1377.
2018-04-13 16:51:25 -07:00
Javier Calvarro Nelson 86a036cf76 Revert "[Fixes #7635] Provide a way to configure clients in WebApplicationFactory"
This reverts commit 1e26571ba6.
2018-04-13 16:50:38 -07:00
Javier Calvarro Nelson 1e26571ba6 [Fixes #7635] Provide a way to configure clients in WebApplicationFactory 2018-04-13 16:02:56 -07:00
Javier Calvarro Nelson 22510e1377 [Fixes #7587] No easy way to change ASPNETCORE_ENVIRONMENT 2018-04-13 16:02:56 -07:00
Kiran Challa d5e044f693 [Fixes #7373] Assigning to the context's Result property, when implementing IPageFilter, causes an exception 2018-04-13 15:11:44 -07:00
Ajay Bhargav Baaskaran bfbd286ab6 Remove usages of obsolete APIs 2018-04-13 14:54:35 -07:00
Pranav K d995b0418a Allow BindPropertyAttribute to be specified on controller classes
Fixes #7350
2018-04-13 13:58:44 -07:00
John Luo c35030267c Update usage of TestSink 2018-04-13 10:21:41 -07:00
Nate McMaster e6be423c33
Remove netcoreapp2.0 from MvcSandbox 2018-04-13 09:42:05 -07:00
Martin Costello 2e761415e4 Implement IDisposable for derived types for WebApplicationFactory<T> (#7637)
* Implement IDisposable for derived types for WebApplicationFactory<T>

Add a protected Dispose method and a finalizer to WebApplicationFactory<T> for use in classes that derive from it and want to dispose of their own resources.
Resolves #7631.

* Address review feedback

Only dispose of fields if disposing is true.
2018-04-13 09:30:33 -07:00