d8e363d99c
Added parameter validation to RazorTagHelper and RazorGenerate tasks
2018-03-16 12:02:51 -07:00
b74582e101
Ensure PreserveCompilationContext is set if we're targeting precompilation tool
...
PreserveCompilationContext must be set for precompilation tool to work, even when
the app has no views.
Fixes #2168
2018-03-15 12:49:56 -07:00
5f69a01cc5
RazorSdk - Attribute code generation fixes
...
* Allow the type name for ProvideApplicationPartFactoryAttribute to be specified.
* Generate ReleatedAssemblyAttribute in class library projects
2018-03-14 23:09:28 -07:00
f9ad346be8
Fix RazorDirectiveCompletionProvider MEF dependency.
2018-03-14 14:41:22 -07:00
1d602d1205
Add host project system for VS4Mac.
...
- Tied into VS4Macs ProjectExtensions in order to bootstrap our Razor world.
- We currently watch all DotNet projects with the expectation that they're the only ones that can potentially turn into Razor compatible projects.
- Added a fallback Razor project host which is used for pre-Razor SDK Razor versions (< 2.1).
- Added a default Razor project host which consumes all MSBuild data from the users packages and sets up the Razor world accordingly.
- Had to modify some existing contracts to work better with new expectations. one of these was the VS4Mac specific Workspace accessor; essentially we needed to be able to lookup a workspace from a solution.
- Some of our previous expectations about addins were wrong (not being able to directly reference your libraries). To avoid using reflection to bootstrap our types I tried out directly referencing our libraries and all worked fine.
- Refactored the DefaultRazorProjectHost in windows (since we had to in Mac) for testing purposes.
#2081
2018-03-13 15:31:45 -07:00
492e958114
Change HostProjectBuildComplete to persist workspace projects.
...
- This was missed in the VS15.7 movement to dev.
2018-03-13 15:11:21 -07:00
1eab654620
Fix typo in Razor.props
2018-03-13 14:01:23 -07:00
425724ce28
Avoid generating RelatedAssemblyAttribute when RazorSdk isn't in play
2018-03-13 13:54:02 -07:00
9fc6b8fcf5
Clean up mac completion broker.
2018-03-13 10:04:29 -07:00
6b2b47a8e6
[VSfM] Fix code completion disappearing/reseting because C# part of .cshtml in regenerated
...
Razor AddIn generation of C# projection content inside .cshtml depends on code completion being visible hence it needs to know state.
Since we are using Roslyn code completion API which doesn't have method to check if code completion is visible and also it's internal, only other way would be to make some public static field inside CSharpBinding which indicates visibility of code completion, hence it's better to just store this value inside textView.Properties. We should be able to remove this in 15.8 when we switch to new VSEditor code completion API.
2018-03-13 09:59:52 -07:00
fcd4484542
Fix TagHelperDescriptor.Kind serialization
2018-03-12 15:44:38 -07:00
a9004e503e
Merge pull request #2061 from aspnet/artakm/RestrictChildrenComments
...
Ignoring HTML comments in tag helper's body. Updated the markup parser to be aware of HTML Comments.
2018-03-12 11:17:57 -07:00
ae94c3c452
- Updated naming for methods to be more intuitive.
...
- Added extra tests for clarity
- Added extra comments to clarify complex areas
2018-03-09 18:18:16 -08:00
3e22c16930
Added extra tests for non-covered scenarios:
...
- For older version of Razor the HTML comments will be complained about by TahHelperRewriter
- RazorParserFeatureFlags tests now ensure that AllowHtmlCommentsInTagHelpers is true in 2.1 version and false in older versions
- Added extra test for IsHtmlCommentAhead to make sure Razor code transition is allowed in comment tag
- Moved the unallowed html comment ending to a static array.
2018-03-09 17:18:57 -08:00
483fba5972
Generate application part attributes
...
* Add support for generating attributes on Razor assembly
* Generate ProvideApplicationPartFactoryAttribute on Razor assembly
* Generate RelatedAssemblyAttribute on application assembly
2018-03-09 14:36:55 -08:00
6c8c6a777c
- Clarified the code where the comment content ending is checked to be allowed or not.
...
- Added more unit tests
2018-03-09 09:16:17 -08:00
1318a83511
Fixed the NextIs method to put back the symbol, when at the end of the file
2018-03-08 17:13:34 -08:00
faccd90aa5
Added unit-tests to validate new methods
2018-03-08 16:36:56 -08:00
2f79b90af5
Merge branch 'rel/vs15.7' into dev
2018-03-08 15:49:01 -08:00
989a6c699f
Don't add the tag helper provider by default
...
Since the default tag helper provider is used by MVC then MVC should
include it. Now that Blazor is in the mix we shouldn't include it for
all configurations.
2018-03-08 15:41:34 -08:00
07e672159e
Merge remote-tracking branch 'origin/dev' into nimullen/vs15.7merge
2018-03-08 14:44:14 -08:00
7357fa04ea
Applied PR feedback (unit testst will be added as part of a separate commit)
2018-03-08 13:38:35 -08:00
32e2c533c7
Naming improvements and test code cleanup
2018-03-08 13:37:05 -08:00
33814fb634
Updated the Comments detection to comply with HTML 5 specification
2018-03-08 13:37:04 -08:00
0af42204eb
Added the AllowHtmlCommentsInTagHelpers feature flag to control behavior of having comments in TagHelpers
2018-03-08 13:37:04 -08:00
e1fbea24f1
HtmlMarkupParser is now aware of HtmlComment blocks. Majority (if not all, will confirm soon) tests have been updated to account for HtmlComment blocks.
2018-03-08 13:37:03 -08:00
ad8485addd
Added new BlockType - HtmlComment
...
Updated the HtmlMarkupParser to understand the HtmlCOmments, and treat those as blocks.
2018-03-08 13:37:03 -08:00
a940a4cd91
Moved the comment check into the "ValidateParentAllowsContent" method
2018-03-08 13:37:02 -08:00
679acdc5d4
Ignoring razor comments during validation
2018-03-08 13:37:02 -08:00
47228dd822
Revert unnecessary change
2018-03-08 13:37:01 -08:00
41b7d90ea8
Ignoring markup comments during validation
2018-03-08 13:37:01 -08:00
e6f68eb244
Added a unit test to repro the issue
2018-03-08 13:37:01 -08:00
c4ba279fb5
Skipping flaky test and additional additional diagnositcs to Shutdown command
2018-03-06 09:15:53 -08:00
0d321771ad
Make UseRazorBuildServer=true by default
2018-03-06 09:15:52 -08:00
5c456fbd04
Merge branch 'rel/vs15.7' into dev
...
# Conflicts:
# build/dependencies.props
# src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/DefaultProjectSnapshot.cs
# src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/DefaultProjectSnapshotManager.cs
# src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/DefaultProjectSnapshotWorker.cs
# src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/DefaultProjectSnapshotWorkerFactory.cs
# src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/ProjectSnapshot.cs
# src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/ProjectSnapshotUpdateContext.cs
# src/Microsoft.VisualStudio.Editor.Razor/DefaultVisualStudioDocumentTracker.cs
# src/Microsoft.VisualStudio.LanguageServices.Razor/Legacy/LegacyTagHelperResolver.cs
# src/Microsoft.VisualStudio.LanguageServices.Razor/Microsoft.VisualStudio.LanguageServices.Razor.csproj
# src/Microsoft.VisualStudio.LanguageServices.Razor/ProjectSystem/Rules/RazorConfiguration.cs
# src/Microsoft.VisualStudio.LanguageServices.Razor/ProjectSystem/Rules/RazorExtension.cs
# src/Microsoft.VisualStudio.LanguageServices.Razor/ProjectSystem/Rules/RazorGeneral.cs
# src/Microsoft.VisualStudio.LanguageServices.Razor/ProjectSystem/Rules/RazorProjectProperties.cs
# test/Microsoft.CodeAnalysis.Razor.Workspaces.Test/ProjectSystem/DefaultProjectSnapshotTest.cs
# test/Microsoft.VisualStudio.Editor.Razor.Test/Microsoft.VisualStudio.Editor.Razor.Test.csproj
2018-03-05 22:58:07 -08:00
27e6c699e5
Don't print normal output as error
2018-03-05 15:22:37 -08:00
41c923926e
Make RazorCompileOnBuild=true
...
Fixes #1986
2018-03-05 11:29:44 -08:00
c444f65c5d
Import capabilities to support solution explorer nesting
...
Fixes #2047
2018-03-02 11:18:11 -08:00
5bd650bdd1
Pack should pack symbol nupkg
...
* Update path calculation for BuiltProjectOutputGroupOutput to include full path. This matches
the behavior of Microsoft.Common.targets.
* Add Razor symbols to DebugSymbolsProjectOutputGroupOutput
Fixes #2116
2018-03-02 07:45:24 -08:00
0f1bc0e0bd
Fix flaky dispatcher test
2018-03-01 14:29:25 -08:00
a9dca60a10
Added support for AssemblyMetadata caching during build server TagHelper discovery
2018-03-01 13:08:56 -08:00
00485d9f1b
Fix #2099 - make AssemblyExtension public
...
This is needed when a runtime wants to construct its own configuration
manually, especially useful in tests.
(cherry picked from commit 92c511b2b4
2018-03-01 11:05:35 -08:00
3e0360a891
Fix #2041 - Add static constructor to DocumentWriter
...
The instance Create method was always supposed to be static.
(cherry picked from commit e05c2abd94
2018-03-01 10:54:16 -08:00
92c511b2b4
Fix #2099 - make AssemblyExtension public
...
This is needed when a runtime wants to construct its own configuration
manually, especially useful in tests.
2018-02-28 17:58:21 -08:00
e05c2abd94
Fix #2041 - Add static constructor to DocumentWriter
...
The instance Create method was always supposed to be static.
2018-02-28 13:46:18 -08:00
d6784b5f16
Report faults on Razor project system exceptions
...
Using the async-tasks service will automatically handle and report
exceptions from the project system
2018-02-28 13:04:42 -08:00
62df770c39
PreserveCompilationContext needs to be set only if a project has any Razor files
...
Fixes #2077
2018-02-28 11:45:20 -08:00
251d57942b
Clean up error message when Razor compiler is not referenced
...
Fixes #1974
2018-02-27 18:08:34 -08:00
f51ddf68a6
Add RazorGenerate items to UpToDateCheckInput
...
Fixes #2048
2018-02-27 15:01:27 -08:00
aa21a6be6e
Use File.Open overload that overwrites file entirely in DiscoverCommand ( #2110 )
...
* Use File.Open overload that overwrites file entirely in DiscoverCommand
Re-enable TagHelper discovery incrementalism test
Fixes #2104
2018-02-26 10:22:29 -08:00
Ajay Bhargav Baaskaran
Pranav K
N. Taylor Mullen
David Karlaš
Artak
Artak Mkrtchyan
Ryan Nowak