huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Added parameter validation to RazorTagHelper and RazorGenerate tasks

This commit is contained in:
Ajay Bhargav Baaskaran 2018-03-12 16:33:22 -07:00
parent 61fe0d6448
commit d8e363d99c
2 changed files with 54 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/Microsoft.AspNetCore.Razor.Tasks/RazorGenerate.cs
View File

@ -45,6 +45,12 @@ namespace Microsoft.AspNetCore.Razor.Tasks
protected override bool ValidateParameters()
{
if (!Directory.Exists(ProjectRoot))
{
Log.LogError("The specified project root directory {0} doesn't exist.", ProjectRoot);
return false;
}
if (Configuration.Length == 0)
{
Log.LogError("The project {0} must provide a value for {1}.", ProjectRoot, nameof(Configuration));

48
src/Microsoft.AspNetCore.Razor.Tasks/RazorTagHelper.cs
View File

@ -47,6 +47,42 @@ namespace Microsoft.AspNetCore.Razor.Tasks
return false;
}
protected override bool ValidateParameters()
{
if (!Directory.Exists(ProjectRoot))
{
Log.LogError("The specified project root directory {0} doesn't exist.", ProjectRoot);
return false;
}
if (Configuration.Length == 0)
{
Log.LogError("The project {0} must provide a value for {1}.", ProjectRoot, nameof(Configuration));
return false;
}
for (var i = 0; i < Assemblies.Length; i++)
{
if (!Path.IsPathRooted(Assemblies[i]))
{
Log.LogError("The assembly path {0} is invalid. Assembly paths must be rooted.", Assemblies[i]);
return false;
}
}
for (var i = 0; i < Extensions.Length; i++)
{
if (!EnsureRequiredMetadata(Extensions[i], Identity) ||
!EnsureRequiredMetadata(Extensions[i], AssemblyName) ||
!EnsureRequiredMetadata(Extensions[i], AssemblyFilePath))
{
return false;
}
}
return base.ValidateParameters();
}
protected override string GenerateResponseFileCommands()
{
var builder = new StringBuilder();
@ -81,5 +117,17 @@ namespace Microsoft.AspNetCore.Razor.Tasks
return builder.ToString();
}
private bool EnsureRequiredMetadata(ITaskItem item, string metadataName)
{
var value = item.GetMetadata(metadataName);
if (string.IsNullOrEmpty(value))
{
Log.LogError($"Missing required metadata '{metadataName}' for '{item.ItemSpec}.");
return false;
}
return true;
}
}
}