c8cabde1f1
Improve logging - individual filters
2017-12-18 13:16:06 -08:00
4c4a7b3c6c
Improve logging - filter pipeline execution
...
Related to issue #6498 : When enabling "Trace" logging for MVC loggers, I should be buried in log messages
2017-12-14 11:22:13 -08:00
5d9f04cf34
Run `[RequireHttps]` filter early in pipeline
2017-12-14 10:40:57 -08:00
7e26af908e
[ Fixes #6514 ] Add default ctor overload to AuthorizeFilter
2017-12-12 14:07:02 -08:00
821daa5ad0
[ Fixes #7085 ] ApplicationModelConventionExtensions should make a copy of collections when iterating them
2017-12-12 14:03:35 -08:00
629f87181a
[ Fixes #6858 ] Changes to MvcOption's settings (SuppressInputFormatterBuffering & AllowBindingUndefinedValueToEnumType) are not taking affect
2017-12-04 14:25:41 -08:00
0bb3f18049
Add support for BadRequest in RazorPages ( #7097 )
...
Addresses #7095
2017-12-01 12:03:24 -08:00
008a562bf5
Move property definitions below constructor in ValidationVisitor
...
Remove incorrect virtual modifier on one of the Validate overloads
2017-11-22 07:50:37 -08:00
3a132e4af5
Open up private methods in ValidationVisitor
...
- Allows for other validation libraries to customize validation behaviour
Addresses #7014
2017-11-22 07:50:37 -08:00
959e7027b0
Add ValidateComplexTypesIfChildValidationFails to ValidationVisitor
...
- Allows more granular control of when model-level validation should run.
Addresses #7014
2017-11-22 07:50:37 -08:00
d9825d1547
Better JSON deserialization errors. Implements #4607 , #4862
2017-11-06 23:02:13 +00:00
ab4c519dd5
Infer multipart/form-data for FromFile parameters
2017-11-02 09:36:31 -07:00
2e4bc548f5
Pin tool and package versions to make builds more repeatable ( #7013 )
2017-10-31 19:18:14 -07:00
861d78fb78
Refactor content negotiation code into a service ( #6998 )
...
* Refactor content negotiation code into a service
This is a refactor in anticipation of using this logic in some other
places
2017-10-31 16:32:37 -07:00
de2aef61ba
Make controllers with ApiControllerAttribute visible in ApiExplorer
2017-10-27 12:04:12 -07:00
0989e60f73
[ Fixes #6943 ] Unit Testing Page Model Throws Null Ref On ModelState check
2017-10-26 14:37:42 -07:00
c567a690bc
[ Fixes #6902 ] Added an overload for StatusCode that takes in System.Net.HttpStatusCode
2017-10-26 12:41:34 -07:00
8946a68923
Infer binding sources for ApiController parameters
...
Fixes #6847
2017-10-16 15:20:43 -07:00
7ba167fcd8
Add 'default response' to API Response Type
...
Also some cleanup and unit tests.
2017-10-09 19:48:52 -07:00
d0a8b5f78f
Port fix for URL helper redirect ( #6917 )
...
Fixes #6910
2017-10-05 11:24:18 -07:00
950db6587c
Require attribute routing with [ApiController]
...
Fixes #6870
2017-10-04 13:13:20 -07:00
e659b578f6
Typo fix
2017-10-04 09:00:34 -07:00
e3ce1f52d4
Added Conflict result helper to ControllerBase
...
- Added ConflictObjectResult and ConflictResult types.
- Conflict(), Conflict(object error), Conflict(ModelState modelState)
added to ControllerBase.cs.
Fixes #6172
2017-10-02 15:05:57 -07:00
be5d4ec11e
Undo a breaking change
2017-10-02 13:12:25 -07:00
2fcfc6be7c
Add EnableRangeProcessing ( #6895 )
...
Addresses #6780
2017-09-29 18:39:45 -07:00
eeac99985a
Only set Content-Length when serving body ( #6886 )
...
Addresses #6875
2017-09-25 15:07:12 -07:00
83c3ac62fb
Updated formatters to wrap exceptions in InputFormatException for invalid input
2017-09-22 14:33:17 -07:00
f24d71136a
Add breaking changes file
2017-09-22 13:53:51 -07:00
a8eda83222
Add MVC 2.0 baselines
2017-09-22 12:53:12 -07:00
38712609bb
Design extensibility for executors
...
We have all of these executors but they aren't really
documented/supported for extensibility today. This change introduces a
pattern for action result executors so we can make them extensible.
2017-09-22 10:32:55 -07:00
5d1603c37f
Replace ProblemDetailsAttribute with ApiControllerAttribute
2017-09-22 10:26:13 -07:00
97fab8711a
Add UnprocessableEntityResult, UnprocessableEntityObjectResult and ControllerBase.UnprocessableEntity methods ( #6851 )
...
* Added UnprocessableEntityResult
* Added UnprocessableEntityObjectResult
* Added UnprocessableEntity overloads to ControllerBase
Fixes https://github.com/aspnet/Mvc/issues/6795
2017-09-22 09:27:29 -07:00
197ef139d6
Provide a way within the Page/PageModel to run code before any handler runs
...
Fixes #6606
2017-09-22 09:25:22 -07:00
236ef5d1d1
Support validation and BindBehavior on top-level action parameters and bound properties. Fixes #6790
2017-09-22 10:13:48 +01:00
324db455d9
ControllerBase helpers refactored with lambda syntax.
...
- Addresses #6864
2017-09-21 13:19:33 -07:00
7f214492b8
Introduce a filter to send bad request results with details when ModelState is invalid ( #6849 )
...
* Introduce a filter to send bad request results with details when ModelState is invalid
Fixes #6789
2017-09-21 11:09:32 -07:00
f0a5af2ba7
Revisit the unwrapping code in ControllerActionInvoker
...
Fixes #6679
2017-09-19 09:49:37 -07:00
23b7d8f62a
Added RequestFormLimits filter.
...
[Fixes #5128 ] Overriding Request Form max upload limit
2017-09-18 13:48:15 -07:00
e114911d77
Introduce [ApiController]
...
This puts a de-facto metadata approach in the box to declare
unambiguously 'Hey, I am an API!'.
I think this is worth us doing at this point because I haven't really
seen anyone in the community running with targeting conventions at
equivalence classes of controllers.
Now that we're putting API-specific, opinionated behaviors in the box,
we need to away to make it opt-in and declarative.
2017-09-18 12:43:05 -07:00
c09575dbd0
Fix #4914 patternize filter overrides
...
Adding some convenience methods to the context class and updating our
code to use them.
2017-09-18 12:12:44 -07:00
776c2604f8
Introduce opinionated API defaults.
...
* Introduce ProblemDescriptionAttribute to enhance some 4xx messages and produce better API description.
* Introduce IErrorDescriptionProvider to modify the shape of error response.
Fixes #6785 , Fixes #6786
2017-09-14 17:07:34 -07:00
35601f95b3
Added a model binder for handling Enum types. [ Fixes #6329 ] Why don't we check for Enum.IsDefined on action parameters of enum type
2017-09-14 08:25:05 -07:00
db2d9ee56f
Additional fixes for #4604
2017-09-13 23:39:00 -07:00
4f18d99d02
Added RedirectToAction overload with no arguments
2017-09-12 17:17:48 -07:00
06f6de6c11
Changed RequestSizeLimitAttribute to create an authorization filter rather than a resource filter.
...
[Fixes #6777 ] RequestSizeLimit is ignored
2017-09-12 17:03:24 -07:00
de38922601
Allow BindPropertyAttribute to be applied on PageModel
...
Fixes #6653
2017-09-12 10:34:19 -07:00
a8b7904b00
Fix logger category of FileStreamResultExecutor
...
FileStreamResultExecutor creates a logger for VirtualFileResultExecutor. I suspect this is a copy-and-paste error and creating one for FileStreamResultExecutor was intended instead.
2017-09-08 11:09:20 -07:00
717f1e6f7d
Normalize paths in RazorViewEngine prior to invoking page factory
...
Fixes #6672
2017-09-07 11:36:31 -07:00
a7cc243942
Introduce ProblemDescription
2017-09-06 18:46:35 -07:00
151cf44607
Introduce ActionResult<T>
2017-09-06 18:46:06 -07:00
1d1a5203db
Fix spelling mistakes in xml comments ( #6755 )
2017-09-05 12:52:13 -07:00
257d202a14
Make AddMvcCore docs scarier
...
Fixes #6632
2017-08-31 08:01:29 -07:00
16c267d95e
House Cleaning - Spelling and grammar 🚿
2017-08-30 14:58:44 -07:00
b811e69d00
Use PackageLineup to manage PackageReference versions
...
- Move the Mvc.Performance project from test/ to benchmarks/.
- Remove the Version attribute on PackageReference.
- Add a reference to two PackageLineup's.
- Add snippet to README explaining the additional requirement to run build.cmd /t:restore.
- Add a target to check that packages have been pinned.
2017-08-30 12:14:11 -07:00
900a5c7c4c
Add support for ResponseCache in Razor Pages
...
Fixes #6437
2017-08-18 16:25:40 -07:00
b43b244830
Use Directory.Build.props/targets
2017-08-16 12:30:13 -07:00
f2a8c1cea7
Refactor CORS support out of MVC Core
2017-08-14 11:40:56 -07:00
a5b55edb93
Fix filter order ( #6577 )
...
* Fix filter order
2017-07-21 10:50:34 -07:00
36e24b7a31
Fix AuthZ Regression ( #6574 )
2017-07-20 21:18:53 -07:00
b4fe715c71
Revert breaking change ( #6519 )
...
Addresses #6518
2017-07-07 17:09:36 -07:00
288da1a405
RedirectToPage(page, handler) does not work ( #6503 )
...
Fixes #6436
2017-07-06 14:12:57 -07:00
c351712419
Add `FloatingPointTypeModelBinderProvider` and related binders
...
- #5502
- support thousands separators for `decimal`, `double` and `float`
- add tests demonstrating `SimpleTypeModelBinder` does not support thousands separators for numeric types
- add tests demonstrating use of commas (not thousands separators) with `enum` values
2017-07-03 17:55:04 -07:00
057a853de7
DiagnosticSource to 4.4.1
2017-07-03 15:03:34 -07:00
eeee3ef731
Add SignOut overload + Use new auth api ( #6476 )
2017-07-03 12:32:11 -07:00
bc4328de16
Add entry to breakingchanges.json
2017-06-30 15:44:21 -07:00
948982ebff
Create custom collection for model binder providers
...
Fixes #6161
2017-06-30 15:44:07 -07:00
f76a390a4e
Fall back to linear search for prefix matches
...
- #6469
2017-06-30 10:59:07 -07:00
17f6b17a6d
Add RequestSizeLimitAttribute ( #6453 )
...
Addresses #6352
2017-06-29 13:04:27 -07:00
a90f4118ad
Do not include type names in `ModelState` error messages
...
- #6076
- add resources and accessors specifically for the element / parameter cases
- avoid `metadata.GetDisplayName()` where possible
- fill in the `ValidationContext` that `ValidatorObjectAdapter` uses
- e.g. `Validate_NestedComplexType_IValidatableObject_Invalid()` test fails without this
Possible future work:
- improve error message used for `ModelMetadata.IsRequired` elements and parameters
- use something besides the type for `ValidationContext.DisplayName` of elements and parameters
nits:
- trailing whitespace
- use more `out var`
2017-06-28 15:16:23 -07:00
7166dfecd7
Add generic overloads on FilterCollection
2017-06-28 09:03:48 -07:00
1886d53d89
Remove [BindProperty] on class
...
This isn't a good fit with consistency with controllers. Discussed with
@DamianEdwards and we agreed to remove this for now and bring it back in
the future if there's a real need for it.
2017-06-28 08:18:42 -07:00
9acfc8d221
Watch _ViewImports outside the pages root for changes
...
Fixes #6428
2017-06-27 09:30:07 -07:00
0ad9c7d4eb
Making Pages Binding Consistent
...
This changeset reckonciles the binding work we did for pages with
controllers.
A quick summary:
- Moves [BindProperty] to the MVC namespace (#6401 )
- Makes [FromRoute] and friends behave consistently (#6402 )
- Makes [BindProperty] work with controllers (untracked)
2017-06-26 18:11:44 -07:00
f824704741
Cleanup fileLength use
2017-06-18 11:05:49 -07:00
c27b07ef3f
Use C# 7 features
2017-06-11 22:11:51 -07:00
1c4b0fcdf3
Code clean up
2017-06-09 22:38:46 -07:00
b1b7252ddc
Merge pull request #6383 from aspnet/rel/2.0.0-preview2
...
Modify ControllerBase.RedirectToPageResult to call the correct overload
2017-06-09 15:11:23 -07:00
d92d8cddeb
Modify ControllerBase.RedirectToPageResult to call the correct overload
2017-06-09 14:40:29 -07:00
a5f3a6425e
Remove TaskCache and TaskCacheOfT
2017-06-08 08:19:20 -07:00
7ffd88757d
Respond to RangeHelper refactor ( #6348 )
...
Respond to https://github.com/aspnet/StaticFiles/pull/200
2017-06-06 11:22:35 -07:00
f1dd475eae
Merge branch 'rel/2.0.0-preview2' into dev
2017-06-06 09:35:33 -07:00
af91b58bd3
Enabled a way to buffer request body in formatters
2017-06-06 09:33:32 -07:00
b796bc0f39
Add Page filters
2017-06-05 08:05:49 -07:00
03e696a05e
Merge branch 'rel/2.0.0-preview2' into dev
2017-06-01 15:19:13 -07:00
4e91e4e36f
Correct short-circuit log message for result filters ( #6350 )
...
Addresses #6318
2017-06-01 14:01:08 -07:00
0f0cfdfe94
Removed unnecessary package references
2017-06-01 12:02:05 -07:00
a0d9b08f58
Set Content-Length and increase BufferSize ( #6347 )
...
Addresses #6045
2017-06-01 11:27:49 -07:00
3089bf74fe
Remove reference to Microsoft.Extensions.PlatformAbstractions
2017-05-27 17:22:05 -07:00
84e007a2a7
Move exception and result filters in base
2017-05-26 12:33:46 -07:00
e7bd6cfc06
Refactor invoker tests for reuse
2017-05-26 12:33:46 -07:00
4c2d727e38
React to Auth + switch to Policy Evaluator
2017-05-25 18:23:41 -07:00
9ea37a1bbb
Fix TFM build breaks
2017-05-25 13:12:39 -07:00
03404cd3df
Return to NetStandard
2017-05-25 10:34:16 -07:00
2992f8e38a
Separate PageContext and ViewContext
...
This change decouples PageContext and ViewContext completely.
2017-05-24 16:01:52 -07:00
53c56f558b
React to StringSegment changes
2017-05-23 14:01:44 -07:00
c5f771d96d
Use factory pattern for caching in ControllerActionInvoker
2017-05-22 13:05:55 -07:00
9aff0a67c1
Range support for FileResult( #6150 )
...
Addresses #3702
2017-05-19 10:51:46 -07:00
ece5e748ad
Minor documentation fix for SerializableError
...
ModelStateEntry -> ModelStateDictionary
2017-05-18 11:02:23 -07:00
4d905a4110
Make our executor methods virtual
...
Fixes #5874 - we are marking these methods virtual just in case someone
wants to customize the executors. These are in the 'public internal'
namespace but can't really be replaced because they aren't sufficiently
virtual.
2017-05-16 08:43:45 -07:00
af7303cd8d
Corrected xml-comment for the User-property
...
Removed comment about setting the User. `User` property only supports `get`.
2017-05-16 08:01:38 -07:00
cd6befdef1
Assign unique event Ids in the logger ( #6270 )
...
Addresses #6062
2017-05-15 11:52:52 -07:00
42a4e9a143
Make uses of ObjectMethodExecutor internal
2017-05-10 21:17:51 -07:00
cf64b335f6
Remove unnecessary package references ( #6252 )
2017-05-10 12:06:10 -07:00
7d28714d9a
Pin build of ObjectMethodExecutor to allow breaking change to go thru first
2017-05-10 10:15:14 -07:00
014a786b45
Replace IModelBindingMessageProvider with new highly-virtual base class ( #6241 )
...
Replace IModelBindingMessageProvider with new highly-virtual base class. Fixes #6069
2017-05-10 16:02:18 +01:00
e2cb8e8ac8
A new and exciting implementation of action selection
...
This is an improved implementation of the ActionSelector for conventional
routing. This will do fewer dictionary lookups than the decision tree, and
will avoid OrdinalIgnoreCase hashing in the common case.
2017-05-05 17:54:09 -07:00
64ffcfaa89
Merge pull request #6236 from aspnet/rel/2.0.0-preview1
...
Change TFM to netcoreapp2.0 (#6234 )
2017-05-04 22:18:48 -07:00
1c5e417606
Change TFM to netcoreapp2.0 ( #6234 )
...
* Change TFM to netcoreapp2.0
2017-05-04 18:11:26 -07:00
6f3a295041
React to new ObjectMethodExecutor in Common
2017-05-03 15:40:02 +01:00
42b988ad88
./ paths relative on page.
2017-04-25 11:57:58 -07:00
bd39d36d75
Update API Check related files
...
React to aspnet/BuildTools#238
2017-04-25 08:19:00 -07:00
649ee4d28d
Add support for page handler to URL generating APIs.
2017-04-24 22:56:58 -07:00
04fd762943
Rename form-action -> handler
2017-04-24 14:15:35 -07:00
141b637d20
Bump `MemoryPoolHttpResponseStreamWriter` buffer size up to 16K `char`s
...
- #3516
- fix tests that relied on otherwise-unused `HttpResponseStreamWriter.DefaultBufferSize`
2017-04-23 16:15:58 -07:00
f568d3c2bc
Support finding "sibling" pages when using RedirecToPage
...
Fixes #6083
2017-04-21 18:12:52 -07:00
8eac7c2d6c
[ Fixes #6117 ] Added RedirectToPage overloads to Controller
2017-04-21 12:19:35 -07:00
025870e8b9
Fix #6159 - Fix deep copy for ControllerModel and ActionModel
2017-04-21 07:41:14 -07:00
ea3becb3ca
Reenable APICheck
2017-04-20 13:48:26 -07:00
a975d7fa01
react to removal of PlatformAbstractions ( #6164 )
2017-04-20 11:09:18 -07:00
4bf518b09b
Fix #6140 - Allow linking between controller and page
...
The issue here is that route values used for action selection are
'global'. That means that pages need to have a 'null' route value for
'action' and controllers need to have a 'null' route value for pages. This
is the same way that areas work.
The fix is to move the 'merge' of route values up to a level where pages
and controllers can work together. Since ADPs use the russian-doll
pattern, the fix is to run this 'merge' in the controller ADP, but after
all of the ADs have been created.
2017-04-19 16:48:38 -07:00
6cd487e15f
Disable api check temporarily to unblock build
2017-04-19 16:07:23 -07:00
c9bfd2296d
Parity between Controller and Page/PageModel
2017-04-19 15:02:06 -07:00
3e8cd1e7c9
MVC => Auth 2.0
2017-04-19 11:57:04 -07:00
8fa95d66d4
Add support for suppressing inbound and outbound routing
2017-04-14 17:02:45 -07:00
c8a1bb6914
React to deps file casing change
...
Fixes #6122
2017-04-13 13:09:00 -07:00
1a8ac88da7
Add PreserveMethod ( #6075 )
...
Addresses #5609
2017-04-10 17:31:59 -07:00
90acd055fe
Make [FromBody] treat empty request bodies as invalid ( #4750 )
2017-04-10 16:55:14 +01:00
d37b1548f8
Update to new resx format
2017-04-03 16:37:22 -07:00
10d2d7c9f6
Remove System.Reflection.TypeExtensions added to workaround test failures
...
Fixes #6005
2017-04-03 14:47:14 -07:00
d19150ed22
Fix comment typos in preceding commit
2017-03-31 10:36:53 +01:00
4f351bd37c
Add support for media type suffixes ( #5273 , #6032 )
2017-03-31 10:20:43 +01:00
c47825944d
Remove Microsoft.AspNetCore.Mvc.Razor.Host
2017-03-29 16:50:39 -07:00
824d65ca3d
Remove `ValueProviderResultExtensions`
...
- #5063
- update tests that used one extension method to instead use `ModelBindingHelper` directly
nit: `mbc` -> `context`
2017-03-24 22:17:34 -07:00
e7101f248a
Support model binding to Razor Pages properties on page and PageModel classes
...
Fixes #5952
2017-03-24 07:45:19 -07:00
d2430f0f4e
Merge pull request #6004 from CoskunSunali/dev
...
Avoid entry point assembly being loaded twice during assembly parts discovery
2017-03-22 22:07:28 -07:00
705c36921a
Use alternate workaround for #6005
2017-03-22 19:14:46 -07:00
badb6ce8e5
Remove net451 as a cross-compile target
2017-03-22 06:32:50 -07:00
11d265bddd
Avoid entry point assembly being loaded twice during assembly parts discovery.
...
Addresses https://github.com/aspnet/Mvc/issues/6003
2017-03-22 04:37:06 +03:00
8f4ca32f48
Fix #5807 - Race condition in Invoker
...
This change addressed a race condition in the ObjectMethodExecutor where
the default argument values array can become visible before it is
initialized. If a second observer accesses the array while it is being
initialized, it can observe a null value for a reference type parameter,
leading to a nullref.
The fix here is to make everything immutable and initialize it all up
front. There's no reason to create an OME without eventually running it,
so there's no downside to doing the initialization up front.
2017-03-15 17:19:29 -07:00
6f7717a381
Unify dependency versions to one file
2017-03-15 16:54:32 -07:00
de25357c28
Do not throw if a library does not have a runtime component
...
Fixes #5690
2017-03-14 15:07:50 -07:00
3cd8c8c14d
[ Fixes #5932 ] Add constructor taking the BinderType to ModelBinderAttribute
2017-03-09 08:16:00 -08:00
b6a6b50776
Fixing up an error in the XML Comments ( #5888 )
2017-03-06 11:07:16 -08:00
de1d0919e5
Add Http Response Codes to doc comments ( #5867 )
2017-03-06 10:00:07 -08:00
acfad83aa6
Migrate to MSBuild
...
- thanx to @NTaylorMullen for initial conversion
- e.g. AssemblyInfo.cs files were already minimized or removed :)
- allow `>=` RC3 CLI's to build and run MVC
- work around several dotnet migration issues; see #5482
- disable full .NET Framework runs of functional tests; see #5873
- remove `Microsoft.DotNet.InternalAbstractions` and `System.Xml.XmlDocument` dependencies
- remove project.json (!!), *.xproj, .notest, and web.config files
Redo earlier changes:
- apply test migration to .NET 4.5.2 in *.csproj world
- see 63507c80097e40#5768
- work around Microsoft/vstest#392
- rename tests to avoid duplicates
- work around Microsoft/vstest#419
- set up created `AppDomain`s with current `ApplicationBase`
2017-02-28 21:20:39 -08:00
0e914e55fa
Remove double null check ( #5862 )
...
Address #5834
2017-02-28 12:00:23 -08:00
927e75870d
Add BindingSourceMetadataProvider
...
Addresses #5673
2017-02-17 13:22:10 -08:00
366dbde378
Add culture constructor to RouteValueProvider
2017-02-16 14:47:34 -08:00
239e2202e1
ActionContextAccessor netstandard behave like net451 ( #5810 )
2017-02-16 14:34:13 -08:00
0097e40e46
Downgrade to stable packages
2017-02-15 14:23:48 -08:00
a00acceaa9
Merge branch 'rel/1.1.2' into dev
2017-02-15 12:43:37 -08:00
29647fda33
[ Fixes #5801 ] Move call to validate constructor in ComplexTypeModelBinder into CreateModel
2017-02-15 12:33:01 -08:00
af5648c1f7
Merge branch 'rel/1.1.2' into dev
2017-02-13 08:34:18 -08:00
531c11df2a
Fix 5594 - ExceptionHandled + Result is broken
...
This change ensures that setting ExceptionContext.Result will always
execute if set. The problem with 1.1.0 is that when we had a real short
circuit the wrong set of conditions were checked. I suspect that when you
set ExceptionFilter.Result and didn't short circuit that result filters
were also running (which is a bug).
Added a few tests that verify that the result doesn't trigger result
filters.
I did some general cleanup on this code path to make the state transitions
more clear.
No exception was thrown -> BeginResult
Exception was handled -> ExceptionHandled
Exception was not handled -> gets rethrown
2017-02-13 07:58:32 -08:00
fc40985412
Merge branch 'rel/1.1.2' into dev
2017-02-10 14:55:32 -08:00
842d661ac2
[ Fixes #5698 ] Regression in 1.1 model binding for model types without default constructor
...
- Also reverts "Check for default constructor in ComplexTypeModelBinderProvider" commit d09e921c4a
2017-02-10 11:10:02 -08:00
9f3dfd9819
Make RazorPages work E2E
2017-02-06 19:05:31 -08:00
c95c2a5a6d
[ Fixes #5686 ] Extend `ModelMetadata` to reduce ugliness
2017-02-03 11:37:28 -08:00
cf70ed663b
Merge tag 'rel/1.1.1' into dev
2017-02-03 10:31:17 -08:00
d44c9aee1e
Added printing of route values when a route is not matched
2017-01-27 11:31:05 -08:00
42ae78a360
[ Fixes #5012 ] ProducesAttribute should not inherit from ResultFilterAttribute
2017-01-25 14:00:35 -08:00
8ac6b6699f
[ Fixes #4945 ] Simple string returned by controller action is not a valid JSON!
2017-01-25 13:29:18 -08:00
5885feb7c0
Fixes a parsing bug with the AcceptHeaderParser
...
When we find an invalid character at the end of a media type value we
should advance and skip over it.
2017-01-23 13:12:40 -08:00
6396e14504
Add null-check back to MediaType
2017-01-18 16:56:08 -08:00
ce53675b87
Add `[ValidateNever]` and `IPropertyValidationFilter`
...
- #5642
- lazy-load `ValidationEntry.Model`
- avoids `Exception`s when moving to a property that will not be validated
nits:
- remove duplicate code in `ValidationVisitor`
- clarify "all properties of" doc comments
- also add missing `<param>` doc in `ViewDataInfo`
2017-01-15 21:40:29 -08:00
93774a0234
Mitigate MediaType overflow
2017-01-13 12:51:19 -08:00
13b32adeae
Move InvokeAsync to ResourceInvoker
2017-01-11 11:13:05 -08:00
6b0282fa84
Commonize code from ControllerActionInvokerCache and PageFilterFactoryProvider
2017-01-11 10:53:23 -08:00
473337ea33
CompositeChangeToken moved to aspnet/Common Microsoft.Extensions.Primitives
...
Addresses Common Issue aspnet/Common#163
2017-01-04 17:32:20 -08:00
de0f277892
Fix attribute routing error message related to replace tokens
2017-01-04 15:43:57 -08:00
5070526f43
replaced hardcoded message with Resources.ArgumentCannotBeNullOrEmpty
2017-01-04 10:47:21 -08:00
78492b39d8
Introduce a base type for executing auth and resource filters.
2017-01-03 11:14:15 -08:00
9146fce4ec
Add extension method for IParameterModelConvention. ( #5640 )
2016-12-27 16:49:12 -08:00
2b50ec99df
Updating to 4.4 CoreFx packages
2016-12-21 16:47:14 -08:00
de1b763d96
Update IControllerModelConvention.cs
2016-12-07 11:11:57 -08:00
b2f0438562
Fixing comment typo
2016-12-07 11:10:54 -08:00
6fbe514626
Fixing comment typos
2016-12-07 11:07:31 -08:00
1dd1d49321
Redirects with fragment ( #5519 )
...
- Added implementation of overloads where you can specify the fragment to redirect to.
- Added unit tests
- Added XML comments, including missing documentation of existing members
2016-12-06 10:32:01 -08:00
7178464ed2
Munch on less memory when handling property metadata
...
- #5499
- switch `foreach` to `for` and use less Linq when accessing `modelMetadata.Properties`
- change backing field for `ModelExplorer.Properties` from a list to an array
2016-12-05 20:47:45 -08:00
48546dbb28
Add more to `MvcCoreServiceCollectionExtensionsTest`
...
- 2nd half of #5554
- follow-on to #5540 PR
2016-12-05 20:05:24 -08:00
f32d0f2505
Update MvcCoreServiceCollectionExtensions.cs
2016-12-05 20:01:30 -08:00
52ee9afc31
Adding PageActionDescriptorProvider
...
Fixes #5353
2016-11-23 16:53:06 -08:00
74c9194aee
Pinning versions for 1.1.0 release
2016-11-18 12:12:52 -08:00
2bacb6003f
Fix typo in XML doc
2016-11-18 10:56:46 -08:00
c5a5ba1fee
Add support for updateable ActionDescriptorCollection
...
Fixes #5350
2016-11-17 10:08:38 -08:00
5deda80e5a
Downgrade Microsoft.Extensions.DependencyModel to 1.1.0
2016-11-09 18:16:49 -08:00
b82969a557
Updating versions to 1.2.0-*
2016-11-09 14:18:46 -08:00
576c0e6a65
Throw an exception if configurationType to CreateConfigureDelegate is abstract/has no parameterless ctor
...
Addresses #5431
2016-11-08 14:16:03 -08:00
24d5dfb552
Dynamic assembly checks to prevent NotSupprotedExceptions from System.Reflection.Emit
...
Fixes #5487
2016-11-07 12:49:49 -08:00
9caa688a30
Modified exception message for duplicate keys exception in CandidateResolver
...
Addresses #5289
2016-11-07 11:16:11 -08:00
bfe50ddd8c
Created public API baselines
2016-11-04 23:53:26 -07:00
0cee00aae1
[ Fixes #5352 ] When replacing Controller.Dispose with an explicit implementation the base Dispose is an action
2016-11-04 09:34:30 -07:00
7985121bab
[ Fixes #5207 ] Support IsIndexer for ViewComponent tag helpers
2016-11-03 16:50:22 -07:00
f04286562e
Treat `ContentType==null` and `MediaType.GetEncoding(ContentType)==null` differently
...
- now, if client sends e.g. `Content-type: text/json;charset=[invalid]`, service will respond with HTTP/415
- if client sends `Content-type: text/json`, service will still try UTF-8 (or updated default encoding)
- intentional (and slight) behaviour change from 1ac7315
2016-11-03 10:51:39 -07:00
116c927e61
Revert "Do not call `Encoding.GetEncoding()` with a string from the request"
...
- #5351 should be Won't Fix
This reverts commit 1ac731519a
2016-11-03 10:51:39 -07:00
5d5b282dbd
Moved CaseSensitiveTagHelperAttributeComparer to Razor.TagHelpers.Testing.Sources
...
Addresses #5323
2016-11-01 14:51:37 -07:00
8f6a0fc4fa
Updating to 1.1.0 build of ResponseCaching
2016-10-28 18:23:40 -07:00
ada42ea913
Move value source information from `<remarks>` to `<summary>`
...
- #1999
- may have reordered the precedence comments as I double-checked the implementations
- `CheckBox()` and `RadioButton()` were examples of such updates
nits:
- use SSL in documentation links
- simplify mentions of format strings
- remove a few phrases that didn't say much and duplicated `<remarks>`
2016-10-28 16:43:59 -07:00
0eea3c2651
Log messages added to BodyModelBinder for input formatters ( #5451 )
...
Addresses #5367
2016-10-27 09:43:53 -07:00
3d2710a6c4
Changed MiddlewareFilter accessibility to internal ( #5455 )
...
Fixes #5432
2016-10-26 11:05:36 -07:00
Kiran Challa
Doug Bunting
Jass Bagga
Jeremy Skinner
Steve Sanderson
Pranav K
Nate McMaster
Ryan Nowak
Javier Calvarro Nelson
Dale Palmer
Sébastien Ros
Doug Bunting
Kristian Hellang
Charlie Daly
Christiaan
Adrian Wright
bchavez
Nate McMaster
Hao Kung
Ryan Brandenburg
Henk Mollema
Hao Kung
Chris R
Mardoxx
Henrik W. Moe
Pavel Krymets
Steve Sanderson
Smit Patel
Ajay Bhargav Baaskaran
Christopher Dresel
Andrew Stanton-Nurse
David Fowler
Coskun Sunali
Steve Gordon
N. Taylor Mullen
Stefan Nikolei
Joonas Westlin
hiiru
Steve Smith
Joonas Westlin
Daniel Roth
Julian Dominguez
Marcus Schweda
Jass Bagga