Pranav K
4f7e849cc1
Setting up for ApiConventionAttribute analyzers ( #7912 )
...
* Setting up for ApiConventionAttribute analyzers
2018-06-20 15:22:53 -07:00
Pranav K
e7ab81fe0b
Ensure analyzer package is referenced by Microsoft.AspNetCore.Mvc
...
Fixes #7684
2018-06-19 16:11:47 -07:00
Ajay Bhargav Baaskaran
3d32b6da2f
Upgrade deps and unskip tests ( #7936 )
2018-06-19 14:58:40 -07:00
James Newton-King
3547341762
Add support for conventional routes with dispatching ( #7928 )
2018-06-20 09:02:52 +12:00
James Newton-King
58aa16ee69
Centralize routing and dispatching functional test logic ( #7938 )
2018-06-19 23:24:15 +12:00
Kiran Challa
a0a9c2c585
Integrate Dispatcher's link generator
...
Related to https://github.com/aspnet/Routing/issues/530
2018-06-19 04:14:05 -07:00
Pranav K
e07054e0a7
Skip failing tests
2018-06-18 09:20:08 -07:00
Pranav K
a712ccc98a
Fix up error message when compilation references are missing
2018-06-18 09:20:08 -07:00
Pranav K
1aea6fd5bd
Remove instrumentation functional tests
...
Fixes #7921
2018-06-15 12:42:37 -07:00
James Newton-King
a7406d4497
Add MvcEndpointDataSource and functional tests ( #7886 )
2018-06-14 11:03:45 +12:00
Pranav K
287a3c5e69
Allow IgnoreAntiForgeryToken applied on Razor Page models to work
...
Fixes #7795
2018-06-13 11:59:47 -07:00
Pranav K
6c2ef122f8
Add support for conventions in DefaultApiDescriptionProvider
2018-06-11 16:07:09 -07:00
Doug Bunting
df6b798117
Remove `xUnit1026` workaround in test projects
...
- contained a typo (colon versus semicolon) and just doesn't matter
2018-06-08 15:24:36 -07:00
Pranav K
c29527f992
Add some assertions for controllers and controller actions
2018-06-08 15:00:19 -07:00
Pranav K
f2eb6f8d37
Add some tests for CodeAnalysisExtensions
2018-06-08 14:58:29 -07:00
Pranav K
592ed3b4f5
Create an analyzer to warn users not to decorate filters on page handler methods
...
Fixes #7684
2018-06-05 17:23:30 -07:00
Pranav K
632425d0e6
Unskip skipped tests
2018-05-29 12:10:59 -07:00
Pranav K
8e31319215
Prevent null refs in some simple cases in CachedExpressionCompiler
...
Fixes #6928
2018-05-29 11:09:48 -07:00
Ryan Brandenburg
edf4e8fd9e
DataAnnotations of Enum values use DataAnnotationLocalizerProvider
2018-05-25 16:00:00 -07:00
Kiran Challa
418aac57f4
[ Fixes #7609 ] ApiBehaviorApplicationModelProvider overwrites existing BindingInfo in entirety when inferring binding sources
2018-05-24 14:28:42 -07:00
Pranav K
49c653ed0b
Infer BindingSource.FormFile for IEnumerable<IFormFile>
...
Fixes #7770
2018-05-22 11:05:09 -07:00
Nisha Kaushik
077b1d87a9
#7024 Request: ServiceBasedPageModelActivatorProvider [Review Changes]
2018-05-22 10:23:08 -07:00
Nisha Kaushik
b8e5036e20
#7024 Request: ServiceBasedPageModelActivatorProvider
2018-05-22 10:23:08 -07:00
Nisha Kaushik
0c795c4f33
#7024 Request: ServiceBasedPageModelActivatorProvider
2018-05-22 10:23:08 -07:00
Pranav K
e1eaf6a6e0
Cleanup TestCommon
2018-05-18 10:45:57 -07:00
Pranav K
624a5ed522
Fix ActionMethodExecutor incorrectly setting DeclaredType on ObjectResult
...
Fixes #7782
2018-05-18 10:43:28 -07:00
Sébastien Ros
19d82928ba
Making Razor compilation cache replaceable ( #7780 )
2018-05-15 11:36:47 -07:00
Pranav K
d9f035ad7c
CacheTagHelper should be able to vary by culture
...
Fixes #3398
2018-05-13 14:21:08 -07:00
Pranav K
1ca6ce3377
setupAction parameter in MvcLocalizationServices.AddLocalizationServices is never used
...
Fixes #7761
2018-05-09 18:12:15 -07:00
Doug Bunting
ec2d5c7aa4
Run functional tests with a `TestLoggerFactory`
...
- #7744
2018-05-08 11:52:20 -07:00
Ryan Brandenburg
9f7629b448
Upgrade to netcoreapp22
2018-05-08 10:51:17 -07:00
Pranav K
26454fb1da
Add ViewComponentResult helper methods to Page \ PageModel
...
Fixes #7051
2018-05-07 16:35:29 -07:00
Pranav K
f52c9c0f97
Update analyzer tests to use Microsoft.AspNetCore.Analyzer.Testing
2018-05-07 16:06:01 -07:00
Pranav K
777782ac6e
Test cleanup
2018-05-03 16:03:42 -07:00
Kiran Challa
35f7d3f09c
Added tests to verify that RazorPages and FuzzyMatching with Head requests work
2018-05-01 14:01:00 -07:00
Ajay Bhargav Baaskaran
595e83d0eb
Added nuspec file to Mvc.Analyzers assembly
2018-04-20 14:53:46 -07:00
Pranav K
5d5222cdd8
Introduce BindPropertiesAttribute
...
* Allow controller and Razor Page models to be annotated with BindPropertiesAttribute
* Disallow BindPropertyAttribute from being declared on types.
* Do not allow arbitrary binding attributes to be applied to Razor Page models.
Fixes #7686
2018-04-20 14:32:14 -07:00
Pranav K
60a9810268
Allow PartialTagHelper to specify a null model. Fixes #7667
2018-04-18 14:16:44 -07:00
Kiran Challa
faca3da42f
Ensure ViewData is set on PageResult after a handler method executes
...
[Fixes #7665 ] Initializing PageResult.Page as part of result execution breaks Identity UI
2018-04-18 11:44:04 -07:00
Kiran Challa
4f7d53f4e7
[ Fixes #7658 ] FileStreamResultExecutor fails to Dispose FileStream
2018-04-18 11:43:09 -07:00
Javier Calvarro Nelson
e781cd38cf
[ Fixes #7635 ] Provide a way to configure HTTP Client instances
2018-04-17 12:52:56 -07:00
Javier Calvarro Nelson
e0b4c13895
[ Fixes #7587 ] Default to Development environment in tests
2018-04-17 12:52:51 -07:00
Doug Bunting
e0e96ce53b
Include parameter type's attributes in ModelMetadata
...
- #7595
- #7595 relates to #7350 but does not have the same root cause
- did _not_ revert the src changes in #7350 fix (d995b0418a )
- make non-`[Obsolete]` `ModelAttributes` constructor overload `internal`
- should generally use `static` methods and not any constructor
- change some unit tests to use `[Obsolete]` constructor overloads (with suppressions)
- fix test `ParameterBinderExtensions` to use current `ParameterBinder.BindModelAsync(...)` overload
- found some tests updated `IModelMetadataProvider`, `MvcOptions`, etc. instances but didn't register them in DI
- extend `ModelBindingTestHelper` and `ModelBindingTestContext`
- reorder some tests to use correct `MvcOptions` and `IModelMetadataProvider` everywhere
- fixes above issues
nits:
- take a few VS suggestions
- remove an old comment indended only for PR "Reviewers:"
2018-04-17 12:40:38 -07:00
Pranav K
d8fc2d4009
Fix test failures
...
* Disable deps file generation in class library project. This workarounds known issue - https://github.com/dotnet/core-setup/issues/3726
* Update RazorProjectRouteModelProvider to not specify a trailing slash. This produces paths with a single slash as opposed to two slashes messing with route creation.
* React to Microsoft.AspNetCore.Mvc.Razor.Extensions.Reference that shows up in the deps file.
2018-04-15 16:31:41 -07:00
Doug Bunting
cc5ae02b7d
Fix binding & validating dictionaries of non-simple types in jQuery requests
...
- #7423
- retry failed inner bindings with alternate syntax in `ModelStateDictionary`
- use property syntax if first attempt tried index syntax and visa versa
- instantiate `ShortFormDictionaryValidationStrategy` with full `ModelState` keys
- can now provide exact `ModelState` keys that `ModelStateDictionary` used in inner bindings
- normalize model names without a leading period in `JQueryKeyValuePairNormalizer`
nits:
- take a few VS suggestions
2018-04-14 10:41:00 -07:00
Kiran Challa
e52933e4e3
Removed UrlTestEncoder references in tests
...
This is because with the following commit, Routing no longer depends on DI to get a UrlEncoder and always uses UrlEncoder.Default.
4184b2406d
2018-04-14 06:08:20 -07:00
Kiran Challa
d5e044f693
[ Fixes #7373 ] Assigning to the context's Result property, when implementing IPageFilter, causes an exception
2018-04-13 15:11:44 -07:00
Ajay Bhargav Baaskaran
bfbd286ab6
Remove usages of obsolete APIs
2018-04-13 14:54:35 -07:00
Pranav K
d995b0418a
Allow BindPropertyAttribute to be specified on controller classes
...
Fixes #7350
2018-04-13 13:58:44 -07:00
John Luo
c35030267c
Update usage of TestSink
2018-04-13 10:21:41 -07:00