Commit Graph

43992 Commits

Author SHA1 Message Date
Kahbazi 4573f6894e
Call StartAsync in CompleteAsync (#24058) 2020-07-20 08:14:51 -07:00
Zachary Becknell 0889a62250
Fix #18539 - add Blazor catch-all route parameter (#24038)
* Fix #18539 - add Blazor catch-all route parameter

* Add E2E tests for catch-all parameter

* Adjust E2E test for catch-all params

* Remove ** scenarios for catch-all params

* Fix typo causing test failure
2020-07-17 17:44:24 -07:00
Ajay Bhargav B 5aeac39949
Merge pull request #24034 from dotnet-maestro-bot/merge/release/3.1-to-master
[automated] Merge branch 'release/3.1' => 'master'
2020-07-17 17:29:12 -07:00
Doug Bunting 9f1b61e2fa
Merge pull request #24078 from dotnet-maestro-bot/merge/release/5.0-preview8-to-master
[automated] Merge branch 'release/5.0-preview8' => 'master'
2020-07-17 17:13:55 -07:00
Ajay Bhargav B 39859c0c18
Unquarantine some tests (#24075)
* Unquarantine some tests

* Quarantine

* Link issue
2020-07-17 23:33:19 +00:00
Doug Bunting b1921f38bc
Merge remote-tracking branch 'origin/release/5.0-preview8' into 'master' 2020-07-17 15:03:15 -07:00
Doug Bunting 5266918ed2
Use Roslyn to create ref/ assemblies (#23403)
* Remove all ref/ projects

* Remove GenAPI infrastructure

* Remove notion of a reference assembly project
  - remove `$(IsReferenceAssemblyProject)`, `$(ReferenceReferenceAssemblies)` and `$(ReferenceImplementationAssemblies)`
    - remove unnecessary `$(NoWarn)` settings

nits:
- remove a few misleading comments
- wrap some long lines

* Move .0 package version workaround into Versions.props
  - touch up SharedFramework.External.props

* Expose `%(LatestPackageReference.RTMVersion)` metadata
  - automate use of properties in the `@(LatestPackageReference)` item group to make this maintainable
    - add a couple of special cases at the bottom of eng/Dependencies.props
    - add one more `$(...PackageVersion)` property to avoid yet-another special case

* Enable Roslyn reference assemblies
  - exclude ref/ assembly from packages other than targeting pack
  - update Microsoft.AspNetCore.App.Ref.csproj
    - `%(IsReferenceAssembly)` and `%(ReferenceGrouping)` metadata no longer relevant
    - only ref/ assemblies are in `@(ReferencePathWithRefAssemblies)` item group

nits:
  - remove now-unnecessary workaround
    - issues with TFM transition are behind us
  - clean up Microsoft.AspNetCore.App.Runtime.csproj slightly
    - use `GeneratePathProperty="true"`
        - reorder item / property settings for meta-expansion
    - correct spelling errors and phrasing in comments

* Update documentation to reflect recent changes
  - remove CrossRepoBreakingChanges.md; was tied to old TeamCity infrastructure
    - also much less relevant given repo merges
  - adjust details and examples in ReferenceResolution.md
    - reflect repo merges, Dependencies.props changes, and current Maestro++ channels
    - add a few more details e.g. specific files where Version.Details.xml versions are used

* !fixup! Remove another irrelevant doc file

* !fixup! Address PR review suggestions
  - convert a couple of warnings to errors
  - use consistent casing for Microsoft.NETCore.App.Runtime.* packages
  - reduce `%(LatestPackageReference.Version)` metadata special cases
  - add and improve comments e.g.
    - improve comments about `$(*V0PackageVersion)` properties
    - improve placement of comments about item removal in ResolveReferences.targets
    - confirmed `$(*V0PackageVersion)` property list is complete

nits:
- fix solution example in ReferenceResolution.md
- remove item group definition for `@(LatestPackageReference)`
- remove `%(LatestPackageReference.VersionName)` metadata after use; large item group
    - similarly, remove `%(LatestPackageReference.RTMVersion)` when not needed; just complicates `Condition`s

When I squash, I must remember this fixes
- #14801
- dotnet/aspnetcore-internal#2693

* Actually use `%(LatestPackageReference.RTMVersion)` metadata
  - gather RTM package references in a new project
    - a (very) separate project to work around package conflict resolution
    - empty `Test` target works around Arcade's testing approach
  - new target in ResolveReferences.targets updates relevant assembly paths to use the RTM packages
    - done as soon as possible after `ResolvePackageAssets` determines the paths
    - done for all compilation inputs, not just ref/ assemblies
2020-07-17 13:35:17 -07:00
Jonathan a8bc7ba612
Change btn class for delete button (#24002)
Set delete account button as a secondary action instead of a primary action.
2020-07-17 13:22:34 -07:00
Pranav K 59b94e4b92
Ensure analyzer does not appear in build and publish outputs (#24072)
Also make the analyzer actually work
2020-07-17 13:20:52 -07:00
Ajay Bhargav B 0c6187d3bc
Merge branch 'master' into merge/release/3.1-to-master 2020-07-17 13:00:53 -07:00
Michael Randers-Pehrson 472fc5058e
[Blazor][Fixes #20935] Adds an Environment parameter to WebAssemblyStartOptions to provide or override the Environment value set by the host 2020-07-17 08:21:37 -07:00
Jan-Willem Spuij 4b943417a7 Switched order of attribute initialization and DOM addition.
Fixes #6218.
2020-07-17 12:04:35 +01:00
Stephen Lorello ec4b2221c2
[Blazor][Fixes #22679] Flow the Resource to the authorization service in AuthorizeRouteView
AuthorizeRouteView combines AuthorizeView and RouteView on one abstraction for convenience, but it was missing a Resource parameter to capture and flow the resource to pass on to the AuthorizationService. This PR adds a new Resource parameter and makes sure that the value is passed to the authorization service so that it is available for the authorization handlers in a policy.
2020-07-17 03:54:48 -07:00
Chris Sainty 71327921ed
Modified EditForm to return _fixedEditContext via the EditContext parameter (#24007)
* Modified EditForm to return _fixedEditContext via the EditContext parameter. Also added some tests to cover the new functionality

* Swapped to boolean to track provided EditContext

* Patched ref assembly

* Simplified setting _hasSetEditContextExplicitly

* Renamed _fixedEditContext to _editContext

* Updated null check in OnParametersSet

* Simplified check for EditContext updates based on Model changes
2020-07-16 19:06:50 -07:00
Vladimir Samoilenko 1455aaeff1
Blazor: add support for ontoggle event (#24036)
Summary of the changes
- Implemented `@ontoggle` event
- Added test component to BasicTestApp

Fix Issue: #20859
2020-07-16 18:09:06 -07:00
Pranav K 28b8a39cc8
Fix various minor spelling mistakes (#24019)
* fix various minor spelling mistakes
2020-07-16 17:24:30 -07:00
Pranav K bace984f60
Update BuildFromSource.md (#24020) 2020-07-17 00:03:49 +00:00
Brennan 9e635724c0
StopAsync resets state on inactive connection (#20083) (#23962) 2020-07-16 16:46:15 -07:00
Safia Abdalla 049f421cff
Resolve type error when running JS tests locally (#24026)
* Resolve type error when running JS tests locally

* Update pre-compiled JavaScript
2020-07-16 22:20:56 +00:00
Stephen Halter 6940249de2
Handle exception thrown by ProcessName during ProcessEx timeout (#23990)
* Handle exception thrown by ProcessName during ProcessEx timeout

* Update src/Shared/Process/ProcessEx.cs

Co-authored-by: Brennan <brecon@microsoft.com>

* PR feedback

Co-authored-by: Brennan <brecon@microsoft.com>
2020-07-16 22:13:24 +00:00
Haytam Zanid 5bc2c49ed5
Add DisplayName to inputs (#24029)
Add a `DisplayName` parameter to `InputBase`, which is used in validation messages instead of `FieldIdentifier.FieldName`.
- This works for `InputDate`, `InputNumber` and `InputSelect`.
- Extracted some shared code, just like what @StephanZahariev did in his PR.

Addresses #11414
2020-07-16 15:08:09 -07:00
Adrian Wright b459a7e333 Merge branch 'master' of https://github.com/adrianwright109/aspnetcore 2020-07-16 22:24:17 +01:00
Adrian Wright 5b10c2d1fa undo changes to submodule 2020-07-16 22:23:55 +01:00
Keiichi IGUCHI b8a0fa74dc
arcade requires MSBuild 16.3 (#21878) 2020-07-16 12:43:38 -07:00
Adrian Wright 615e70bf84
Update src/Components/Components/test/ParameterViewTest.Assignment.cs
Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
2020-07-16 20:30:10 +01:00
Safia Abdalla bbb5bb7755
Update setup instructions in BuildFromSource (#24025) 2020-07-16 19:24:32 +00:00
Stephen Halter 30c33aad11
Quarantine flaky tests (#23995) 2020-07-16 11:47:47 -07:00
Zachary Becknell 1d658ab488
Blazor: Add empty InvokeAsync() overload for EventCallback (#24021)
Adds an empty InvokeAsync() overload for both EventCallback and EventCallbackOfT.
Updated tests to simply use this new overload instead of InvokeAsync(null).

Addresses #23603.
2020-07-16 11:31:15 -07:00
Josh Dadak b8261dfe9d
Return null in getCacheToUseIfEnabled when the protocol is not https (#24012)
Addresses #23082 
If served over http the cache is assumed compromised, this can happen when the page first loads over http before the https redirect.
2020-07-16 10:59:39 -07:00
Adrian Wright 2c66f9ee64 fix various minor spelling mistakes 2020-07-16 17:21:30 +01:00
Kahbazi cf77999a3b
Dispost CancellationTokenSource in WebHostExtensions (#23969) 2020-07-16 08:16:39 -07:00
Michael Randers-Pehrson cee763b189
[Blazor][Fixes #22895] Page header can be covered by other elements when there is a lot of content on the page (#24005)
Adds z-index to top-row to avoid the header being covered by other elements
2020-07-16 07:44:16 -07:00
github-actions[bot] 410eb6db53
Sync shared code from runtime (#24000)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2020-07-16 06:57:05 -07:00
Javier Calvarro Nelson 763ccb21b5
[Blazor] Async disposable support for Blazor (#23813)
* [Blazor] Support IAsyncDisposable in components
* Handles async disposal of components within the Blazor pipeline.
* Renders remain synchronous and don't wait for disposal to complete.
* Synchronous disposal executions remain inlined.
* Async disposal executions can trigger renders in different batches.
* Async disposals are handled individually and not grouped based on the batch they were generated on.
2020-07-16 04:21:56 -07:00
msftbot[bot] b7c3b48353
Merge pull request #23997 from dotnet-maestro-bot/merge/release/5.0-preview8-to-master
[automated] Merge branch 'release/5.0-preview8' => 'master'
2020-07-16 06:16:34 +00:00
msftbot[bot] 09d3713b36
Merge pull request #23996 from dotnet-maestro-bot/merge/release/3.1-to-master
[automated] Merge branch 'release/3.1' => 'master'
2020-07-16 05:34:58 +00:00
Eric Erhardt 427bfc8d6b
Default new runtime feature switches (#23932) (#23987)
* Default new runtime feature switches

These new feature switches have been added to the runtime to make applications smaller. Setting reasonable defaults to Blazor wasm projects.

Fix #23716

* PR feedback
2020-07-15 21:48:12 -07:00
John Luo 3d0252694e
Merge pull request #23935 from dotnet-maestro-bot/merge/release/2.1-to-release/3.1
[automated] Merge branch 'release/2.1' => 'release/3.1'
2020-07-15 20:55:22 -07:00
John Luo 8691921c7d Merge branch 'release/2.1' into release/3.1 2020-07-15 18:59:55 -07:00
Stephen Halter 7f4af095f7
Add timeout to all awaits in GlobbingAppTests (#23938) 2020-07-15 18:52:37 -07:00
Eric Erhardt 7b42cf1275
Default new runtime feature switches (#23932)
* Default new runtime feature switches

These new feature switches have been added to the runtime to make applications smaller. Setting reasonable defaults to Blazor wasm projects.

Fix #23716

* PR feedback
2020-07-16 01:19:07 +00:00
Matt Mitchell 757e5aa69f
Add additional environment variables to dockerbuild (#23956)
These are used by the publish/asset manifest creation tasks to fill out
some attributes. Without these in the docker environment, manifests will
be inconsistent between those produced on plain machines and ones produced
in docker files.
2020-07-15 14:54:04 -07:00
dotnet-maestro[bot] 49672ee452
Update dependencies from https://github.com/dotnet/efcore build 20200715.2 (#23970)
Microsoft.EntityFrameworkCore.Tools , Microsoft.EntityFrameworkCore.SqlServer , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.InMemory
 From Version 5.0.0-preview.8.20360.8 -> To Version 5.0.0-preview.8.20365.2

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
2020-07-15 21:34:40 +00:00
N. Taylor Mullen 2293fc243b
Add Razor Tooling Bug report issue template (#23961)
* Add Razor Tooling Bug report issue template

- Given we're going to start providing a new Razor tooling editor experience we expect our users to hit a number of issues. To optimize their path of filing an issue we're creating a bug template for them to use. In parallel we're also working with the VS report an issue tool to gather additioanl data so we can encourage users to go the typical "report a bug" route for VS scenarios.

Fixes dotnet/aspnetcore#23551

* Addressed code review feedback.

* More feedback.
2020-07-15 20:31:44 +00:00
Doug Bunting 38126419b8
Update branding to RC1 (#23943) 2020-07-15 12:02:45 -07:00
msftbot[bot] 30ded547d0
Merge pull request #23939 from dotnet-maestro-bot/merge/release/3.1-to-master
[automated] Merge branch 'release/3.1' => 'master'
2020-07-15 18:26:40 +00:00
John Luo 028cb6b108
Remove duplicate test added automatically by merge 2020-07-15 01:01:04 -07:00
John Luo a494961c3b
Merge branch 'master' into merge/release/3.1-to-master 2020-07-15 00:29:31 -07:00
Safia Abdalla 303a9bfe33
Spruce up async handling in OnNavigateAsync callback in Blazor router (#23835)
* Spruce up async handling in OnNavigateAsync

* Apply suggestions from code review

Co-authored-by: Günther Foidl <gue@korporal.at>

* Ensure previous task awaited before starting next one

* Apply suggestions from code review

Co-authored-by: Pranav K <prkrishn@hotmail.com>

* Validate no exceptions throw on multiple invocations

* Address feedback from peer review

Co-authored-by: Günther Foidl <gue@korporal.at>
Co-authored-by: Pranav K <prkrishn@hotmail.com>
2020-07-15 04:20:08 +00:00
Sean G. Wright d05427580b
Update MiddlewareFilterBuilder.cs (#23793)
Comment grammar typo for _pipelinesCache
2020-07-14 17:29:49 -07:00