Commit Graph

2466 Commits

Author SHA1 Message Date
Ryan Nowak 420f442487 Fixes #3818 - Support Consumes in ApiExplorer
This change adds a list of ApiRequestFormat objects to ApiDescription
object which include the content type and formatter for each supported
content type which can be understood by the action.

Computation is aware of the [Consumes] attribute via the
IApiRequestMetadataProvider metadata interface, and aware of Input
Formatters via the new IApiRequestFormatMetadataProvider interface.

This algorithm is essentially the same as what we do for
produces/output-formatters. We iterate the filters and ask them what
content types they think are supported. Then we cross check that list with
the formatters, and ask them which from that list are supported. If no
[Consumes] filters are used, the formatters will include everything they
support by default.

This feature and data is only available when an action has a [FromBody]
parameter, which will naturally exclude actions that handle GET or DELETE
and don't process the body.
2016-01-13 12:32:17 -08:00
John Luo 32bb324886 Removing redundant null logger after hosting fix 2016-01-13 12:14:38 -08:00
Ryan Nowak 70cee90186 Add optional filter caching 2016-01-13 09:11:08 -08:00
John Luo c5cab7a786 Reacting to hosting API changes 2016-01-12 18:07:17 -08:00
javiercn 6ba05add3f [Fixes #3230] Remove use of reflection in MutableObjectModelBinder 2016-01-12 15:52:27 -08:00
jacalvar 1ca25c48af Fix warning in documentation due to mising using 2016-01-12 15:45:34 -08:00
javiercn 2063356f24 [Fixes #3683] Replace implementations in MediaTypeComparisons and
MediaTypeEncodings with memory efficient implementations using a MediaType
struct.
2016-01-12 15:09:48 -08:00
javiercn 739f83a978 Support caching of the Content-Type string used by OutputFormatter
when the encoding is Utf-8.
2016-01-12 15:09:46 -08:00
jacalvar 830fd410f5 Remove runtime dependency usage of MediaTypeHeaderValue.
Removes usage of MediaTypeHeaderValue in ApiExplorer, InputFormatters and
OutputFormatters

Public interface changes with stub implementation.
2016-01-12 15:09:46 -08:00
Pranav K 32d15186a0 Remove Razor precompilation 2016-01-12 14:51:33 -08:00
Steve Gordon d0046cafe9 Fixing minor error with comment 2016-01-12 12:11:17 -08:00
ryanbrandenburg cad7d44686 * Add a sample for SubAreas 2016-01-12 11:48:09 -08:00
N. Taylor Mullen 947d070678 Skip TagHelperSample index test due to mono encoding bug.
Due to aspnet/External#50.
2016-01-12 10:13:47 -08:00
N. Taylor Mullen dbb69ef952 Add `TagHelperSample.Web` functional tests.
- Validated that each of `TagHelperSample.Web`s sites work properly.
- Found that the `ConditionalCommentTagHelper` page wasn't working as intended due to never being updated after `TagHelperContent` encoding changes.
- Added content verification for the `TagHelper/ConditionalComment` endpoint only since it's static HTML.

#3530
2016-01-11 17:12:47 -08:00
Ryan Nowak ddce8a4dbc Fix incorrect usage of flush on encoder 2016-01-11 13:08:58 -08:00
Pranav K b118aa95c5 Remove use of `String.Split` in Environment taghelper
Fixes #3617
2016-01-11 09:41:21 -08:00
John Luo c8a59d7f3e Reacting to new middleware options pattern 2016-01-08 18:07:36 -08:00
Ryan Nowak 2eb6cd655b Write our ViewBuffer values asynchronously 2016-01-08 17:12:27 -08:00
Pavel Krymets 57bf12311b Revert DependencyContext changes untill dotnet-cli packages get sorted out 2016-01-08 15:59:53 -08:00
Pavel Krymets b5c48de651 Forgotten files 2016-01-08 14:51:21 -08:00
Pavel Krymets 566790577d Add dependency context fallback to razor view compilation 2016-01-08 13:43:52 -08:00
Ajay Bhargav Baaskaran 0bb772a815 [Fixes #3755] Added logging for view compilation 2016-01-08 11:58:09 -08:00
John Luo c68f742dd0 Disabling hanging FlushPoint test 2016-01-08 11:56:31 -08:00
Ajay Bhargav Baaskaran bf1fcf6b56 Return BadRequest response when antiforgery token validation fails 2016-01-08 10:35:00 -08:00
John Luo 8afe28c05d Updating tests to add options to services 2016-01-07 23:54:55 -08:00
John Luo c0800bea9f Remove redundant AddOptions which is now a default hosting service 2016-01-07 18:46:10 -08:00
Ryan Nowak c304984a8d Fix #3501 - Issues with Flush
Calling Flush[Async]() on the writer will NOT flush the stream.
Calling Flush[Async]() in Razor will flush both the writer and the stream.

Our normal flow will be to flush the writer, but not the stream. This
avoids chunking, but allows us to do a WriteAsync on the stream as part of
the call to FlushAsync. This is done to avoid a synchronous write due to
Dispose calling Flush on the writer, which needs to call Write on the
stream.

See issue for extensive background.
2016-01-07 14:52:22 -08:00
Ryan Nowak 676bde29b9 Make Begin[Route]Form include antiforgery 2016-01-07 13:24:01 -08:00
N. Taylor Mullen 2b83dbb52e Make `ExpressionRewriter` more resilient to unconvertible types.
#3825
2016-01-07 11:41:14 -08:00
Pranav K dc878f2777 Capture exceptions thrown during compilation
Fixes #3870
2016-01-07 11:21:45 -08:00
Ryan Nowak ff00c07b85 Rename ActionDescriptorsCollection
ActionDescriptorsCollection -> ActionDescriptorCollection
2016-01-07 10:26:12 -08:00
Pranav K 9168cd1f37 Optimize allocations in Script/Link TagHelpers
Fixes #3618
2016-01-07 09:56:24 -08:00
Ryan Nowak a500a93dfb Smarter antiforgery
Adds the concept of an IAntiforgeryPolicy marker interface as well as
the ability to overide policy with a 'closer' filter.

Adds a new [IgnoreAntiforgeryToken] attribute for overriding a scoped
antiforgery policy.

Adds a new [AutoValidateAntiforgeryToken] attribute (good name tbd) for
applying an application-wide antiforgery token. The idea is that you can
configure this as a global filter if your site is acting as a pure
browser-based or 1st party SPA. This new attribute only validates the
token for unsafe HTTP methods, so you can apply it broadly.
2016-01-05 17:24:33 -08:00
Pranav K 0a2b6205c9 Reacting to Routing changes 2016-01-05 12:05:20 -08:00
Ryan Nowak 7f38773531 React to breaking change in routing 2016-01-05 11:49:44 -08:00
Ryan Nowak 4141fcae69 Optimize MvcRouteHandler
- Check MVC services once at startup
- Make action selector sync

We've never really had a scenario for the action selector being async, it
just ended up that way. None of our extensibility here lets you do
anything async without replacing it wholesale, which we don't
recommend.
2016-01-05 11:31:43 -08:00
Ben Adams c125b4e59b Correct and more accurate timestamp
As per https://github.com/aspnet/Hosting/pull/543
Resolves  #3849
2016-01-05 10:21:06 -08:00
Ajay Bhargav Baaskaran 47a3aee2c1 [Fixes #3361] Changed the value provider preference to be backwards compatible 2016-01-04 12:55:35 -08:00
Ajay Bhargav Baaskaran 1f87442092 [Fixes #3749] Expose ActionContext on IUrlHelper 2016-01-04 10:33:42 -08:00
Ajay Bhargav Baaskaran dc968bc1bf [Fixes #3779] Using explicit StringComparison in startswith 2016-01-04 10:23:01 -08:00
Doug Bunting 568b061441 Mock `HttpContext`, not `DefaultHttpContext`
- build break
- recent HttpAbstractions changes made `DefaultHttpContext` harder to mock (would need `CallBase=true`)
2016-01-03 14:25:42 -08:00
David Fowler ba5fe60cf5 Revert "Change PhysicalFileResult and VirtualFileResult to use SendFileAsync"
This reverts commit 5aa2e06305.
2015-12-31 16:17:53 -08:00
David Fowler 5aa2e06305 Change PhysicalFileResult and VirtualFileResult to use SendFileAsync
- SendFileAsync does the proper fallback to stream copy when the feature
isn't available. Take advantage of it in MVC. There are plans to use the
buffer pool as part of the stream copy so MVC will get that benefit for
free.
- Left CopyToAsync in SendFileAsync when the file doesn't have a
physical path
2015-12-31 15:28:50 -08:00
Pranav K 2f66c041fd Remove long form Dispose
Fixes #3834
2015-12-31 13:52:21 -08:00
Pranav K 7d5a68b9ae Reacting to IHtmlContentBuilder changes 2015-12-31 11:52:26 -08:00
Eilon Lipton e88f90bba0 Add link to ASP.NET MVC Boilerplate 2015-12-31 11:41:12 -08:00
Ryan Nowak 51564d04c0 Remove a test that tests Dictionary
This test is coupled to Dictionary<>'s error message. We don't need this.
2015-12-30 16:55:51 -08:00
Kiran Challa 7a955bcbc0 FormatFilter overrides content type set explicitly by the developer 2015-12-30 13:20:56 -08:00
Pranav K aab051a20f Rename DictionaryBasedValueProvider to RouteValueProvider
Fixes #3629
2015-12-29 18:51:47 -08:00
Pranav K 2b9dd76535 Make RazorViewEngineOptions.FileProvider a list instead of a single item
Fixes #3806
2015-12-29 14:47:15 -08:00