* Fix Http/3 and mark multiplexed factory as experimental
* mark apis as internal and delete quic samples
* Remove extra public api
* Mark kestrel server as obsolete
* Fixing obsoletion and improved message
* Revert "Fixing obsoletion and improved message"
This reverts commit acdae8713d467264b4b3762b56fb4b882fa9127d.
* Revert "Mark kestrel server as obsolete"
This reverts commit fbd861f53afe93951b1f9cd004859551e085952d.
* Internalize SocketCOnnectionFactory
* nit
* fixup
Create new instances of List<T> with an appropriate capacity for the items that will be added.
Use Array.Empty<T>() where appropriate, rather than create an empty list and then return it.
* Updates to IdentityServer 4.0.4
* Updates templates with the new migrations.
* Fixes a small configuration bug that required the configuration for the key to be specified.
* Updates the error url in IdentityServer config to match our template defaults.
* Add support for model binding DateTime as UTC
Fixes https://github.com/dotnet/aspnetcore/issues/11584
* Make test work in other TZs
* Changes per PR comments
* Cleanup unused exception code path, fix doc comments
* Clean up usage of variables
* Adjust logging to be consistent
* Apply suggestions from code review
[master] Update dependencies from dotnet/efcore dotnet/runtime
- Updates:
- System.ComponentModel.Annotations: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- System.Diagnostics.DiagnosticSource: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- System.Diagnostics.EventLog: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.Logging: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.Logging.Abstractions: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.Logging.Configuration: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.Logging.Console: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.Logging.Debug: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.Logging.EventLog: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.Logging.EventSource: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.Logging.TraceSource: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.Options: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.Options.ConfigurationExtensions: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.Options.DataAnnotations: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.Primitives: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.Internal.Transport: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.Http: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.Hosting: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.Caching.Abstractions: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.Caching.Memory: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.Configuration: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.Configuration.Abstractions: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.Configuration.Binder: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.Configuration.CommandLine: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.Configuration.EnvironmentVariables: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.Configuration.FileExtensions: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.Configuration.Ini: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.Configuration.Json: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.Configuration.UserSecrets: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.Configuration.Xml: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.DependencyInjection: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.DependencyInjection.Abstractions: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.DependencyModel: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.FileProviders.Abstractions: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.FileProviders.Composite: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.FileProviders.Physical: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.FileSystemGlobbing: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.HostFactoryResolver.Sources: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Extensions.Hosting.Abstractions: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.NETCore.App.Runtime.win-x64: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.NETCore.Platforms: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Win32.Registry: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.Win32.SystemEvents: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.NETCore.App.Internal: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Microsoft.NETCore.App.Ref: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- System.Drawing.Common: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- System.Text.Encodings.Web: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- System.Text.Json: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- System.Threading.Channels: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- System.Windows.Extensions: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- System.ServiceProcess.ServiceController: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- System.Security.Principal.Windows: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- System.IO.Pipelines: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- System.Net.Http.Json: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- System.Net.Http.WinHttpHandler: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- System.Net.WebSockets.WebSocketProtocol: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- System.Reflection.Metadata: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- System.Resources.Extensions: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- System.Runtime.CompilerServices.Unsafe: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- System.Security.AccessControl: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- System.Security.Cryptography.Cng: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- System.Security.Cryptography.Pkcs: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- System.Security.Cryptography.Xml: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- System.Security.Permissions: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
- Updates:
- Microsoft.EntityFrameworkCore.Tools: from 5.0.0-rc.1.20412.5 to 5.0.0-rc.1.20414.11
- Microsoft.EntityFrameworkCore.SqlServer: from 5.0.0-rc.1.20412.5 to 5.0.0-rc.1.20414.11
- dotnet-ef: from 5.0.0-rc.1.20412.5 to 5.0.0-rc.1.20414.11
- Microsoft.EntityFrameworkCore: from 5.0.0-rc.1.20412.5 to 5.0.0-rc.1.20414.11
- Microsoft.EntityFrameworkCore.Relational: from 5.0.0-rc.1.20412.5 to 5.0.0-rc.1.20414.11
- Microsoft.EntityFrameworkCore.Sqlite: from 5.0.0-rc.1.20412.5 to 5.0.0-rc.1.20414.11
- Microsoft.EntityFrameworkCore.InMemory: from 5.0.0-rc.1.20412.5 to 5.0.0-rc.1.20414.11
- Skip failing gRPC tests
- Skip more tests to avoid #24902
- try just removing "http" theory data
- Skip all `HttpClientHttp2InteropTests` tests on macOS
- no theory data due to #24902 and dotnet/corefx#30492 aka dotnet/runtime#26534 (now tracked somewhere else)
- Add bogus entry to avoid empty theory data
* Add nullable annotations to SignalR.Common, SignalR.Core and Http.Connections
Contributes to https://github.com/dotnet/aspnetcore/issues/5680
* Changes per PR comments. Also add nullability to hub protocols
* Allow ".dll" extensions in BlazorWebAssemblyLazyLoad MSBuild task.
* Only allow assemblies that are specified with an extension.
Co-authored-by: Adrian Wright <adrian@compiledcoding.co.uk>
* Add tests for navigate on form submit
* Add fix for re-render after event dispatch
* Remove deferred event handling in .NET
* Only dispatch events with registered handlers once
* Use BlazorWebAssemblySDK
* Update projects to use the BlazorSDK
* Remove tasks and targets from RazorSDK
* Remove workarounds from BlazorSDK
* Fixup
* Fixup
- target project is a test project; need to undo `$(SkipTestBuild)` impact in these jobs
nit: remove a comment from DeveloperCertificates project that's irrelevant now
* Remove Internal.AspNetCore.Analyzers
This resolves build flakiness caused by referencing the analyzer:
```
2020-08-07T21:22:39.1149296Z ##[error].dotnet\sdk\5.0.100-rc.1.20379.10\Microsoft.Common.CurrentVersion.targets(4188,5): error MSB3026: (NETCORE_ENGINEERING_TELEMETRY=Build)
Could not copy "F:\workspace\_work\1\s\artifacts\obj\Internal.AspNetCore.Analyzers\Release\netstandard1.3\Internal.AspNetCore.Analyzers.dll"
to "F:\workspace\_work\1\s\artifacts\bin\Internal.AspNetCore.Analyzers\Release\netstandard1.3\Internal.AspNetCore.Analyzers.dll". Beginning retry 1 in 1000ms.
The process cannot access the file 'F:\workspace\_work\1\s\artifacts\bin\Internal.AspNetCore.Analyzers\Release\netstandard1.3\Internal.AspNetCore.Analyzers.dll' because it is being used by another process.
```
The analyzer checks if pubternal types are being exposed in public APIs. We no longer author pubternal types, so this is no longer a concern.
* Remove DisablePubternalApiCheck
* Quarantine LinkedApplicationWorks
* Quarantine flaky tests
* Quarantine CanBindTextbox_Decimal_InvalidInput
* React to NetworkException type
* One more test
* Remove LinkerWorkaround.xml
The workaround file is no longer needed, now that the underlying bugs are fixed in the dotnet/runtime libraries.
Fix#23262
* Also remove LinkerWorkaround from Components/WebAssembly
* Add guard check for cleared closest DOM element
* Update src/Components/Web.JS/src/Rendering/BrowserRenderer.ts
Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
* Quarantine falky test ServerEventTest.EventDuringBatchRendering_CanTriggerDOMEvents
Blazor's E2E testing uses a much shorter timeout after a test failure. This test run had several test failures, but most of these appear to be the result of
an incredibly short timeot. This PR quarantines the one test that appears to be a genuine failure and also increases the timeout duration for after test failure.
* Quarantine ServerExecutionTests.ServerGlobalizationTest.CanSetCultureAndParseCultureSensitiveNumbersAndDates
* Add workaround for deprecated overload in authentication scenarios
* Respond to feedback from peer review
* Use explicit version in Version.props
* Temporarily disable NU1065 warning
* Always use latest package version
* Add a middleware for browser refresh.
* Introduce a middleware that can connect to the dotnet-watch change server
* dotnet-watch: Inject the middleware in 3.1 or apps using start hooks \ hosting startup
https://github.com/dotnet/aspnetcore/issues/23412
* Update src/Tools/dotnet-watch/BrowserRefresh/src/StartupHook.cs
* Changes per PR comments
* Add a test for reading the script
* Changes per PR comments
* Updates docs
* Fixup test
* Add project ref
* Put back InternalCalls
* Removing .NET profiling calls
* Remove JS side profiling
Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
* Turn on nullability annotations for public types in M.A.Hosting
* Turn on nullability annotations for Microsoft.AspNetCore and
Microsoft.AspNetCore.Server.Abstractions
Contributes to https://github.com/dotnet/aspnetcore/issues/5680
- #20818, fix e.g. references to Microsoft.Web.Xdt.Extensions in our packages
- make `@(Reference)` items much more broadly applicable
- emit an error when `@(ProjectReference)` is used instead of `@(Reference)`
- then get rid of the errors (!!)
- rename a couple of projects to match their assembly names
- then regenerate the `@(ProjectReferenceProvider)` items
- switch intersection approach from Exclude / Exclude to Copy / Update / Copy
Projects of particular interest:
- src/DefaultBuilder/src/Microsoft.AspNetCore.csproj
- honouring metadata left e.g. Microsoft.AspNetCore.Components.WebAssembly.DevServer package unchanged
- removed redundant metadata after that confirmation
- src/Razor/tools/Microsoft.AspNetCore.Razor.Internal.Transport/
- content of this package unchanged but metadata avoids extra work
- add a comment about the extra work
- src/SiteExtensions/LoggingAggregate/src/Microsoft.AspNetCore.AzureAppServices.SiteExtension/
- success! removes Microsoft.Web.Xdt.Extensions dependency from the package
- src/SiteExtensions/Runtime/Microsoft.AspNetCore.Runtime.SiteExtension.pkgproj
- add a `Condition` to avoid an ordering issue I hit here
- src/Tools/Extensions.ApiDescription.Server/src/
- avoid errors the new build ordering and timing caused
Separately, up the timeout in the `<DownloadFile />` task
- hit repeated timeouts downloading dotnet-runtime-5.0.0-rc.1.20370.4-win-x64.zip
nits:
- remove dupe `@(Reference)` item in Microsoft.AspNetCore.Components.WebAssembly.DevServer.csproj
- remove useless `%(ProjectReference.IsImplicitlyDefined)` metadata as well as its misspellings
- remove extra spaces from ProjectReferences.props
- clean up a few comments in ResolveReferences.targets
* !fixup! Correct other references to renamed projects
Using the full gc sometimes leads to an infinite recursion resulting
in a browser freeze. This was noted as part of running Blazor's benchmarks.
This is being addressed in rc1, in the meanwhile this reverts the behavior to 3.2 defaults.
Browser freezes when using a Blazor WASM application.
Yes. Full GC on is new to WASM on .NET Core
Low. Off by default is the behavior we had in 3.2.
* Implement CopyToAsync in the FileBufferingReadStream
- overrride Span and Memory overloads and implement array overloads in terms of those overloads.
- Implemented CopyToAsync (but not CopyTo)
- Added tests
Fixes#24032
- Annotated UseMiddleware and UseStartup to preserve constructors and public methods.
- Annotated UseHub and MapHub preserve constructors and public methods.
- Added a test to verify UseStartup and UseMiddleware works
- The linker.xml preserves constructors all of the types that are registered in DI. This should be removed once we get the linker friendly DI changes.
The output of the declaration file for Razor components are unaffected by all inputs other than the input .razor file.
Consequently we can avoid regenerating these files if the output is newer than the input. This is the same heuristic we apply to Blazor WebAsssembly's
compression artifacts.
This PR combines these two improvements for a ~90ms (10%) improvement in the inner loop.
```
17 ms GenerateBlazorWebAssemblyBootJson 1 calls
22 ms Copy 8 calls
39 ms ProcessFrameworkReferences 1 calls
40 ms RazorTagHelper 1 calls
51 ms ResolveAssemblyReference 1 calls
70 ms GetFileHash 1 calls
80 ms RazorGenerate 2 calls
111 ms Csc 2 calls
Time Elapsed 00:00:00.95
```
```
17 ms GenerateBlazorWebAssemblyBootJson 1 calls
21 ms Copy 8 calls
37 ms ProcessFrameworkReferences 1 calls
51 ms ResolveAssemblyReference 1 calls
70 ms Csc 1 calls
72 ms GetFileHash 1 calls
79 ms RazorGenerate 2 calls
Time Elapsed 00:00:00.86
```
In after: Csc calls reduced to one, RazorTagHelper call removed.