38f9b9abdb
[SignalR] Fix new flaky test ( #23326 )
2020-06-24 17:53:30 -07:00
ac291877c7
Remove WebAssemblyHttpHandler ref-assembly package ( #23245 )
...
* Remove WebAssemblyHttpHandler ref-assembly package
Fixes https://github.com/dotnet/aspnetcore/issues/22283
* Fixup
2020-06-24 23:58:18 +00:00
c19f3d29ca
Only look-up Cache-Control once ( #23329 )
...
Only look-up the Cache-Control header once, rather than twice if non-empty.
2020-06-24 22:48:36 +00:00
cd9da1c350
Fixup kestrel config tests after feedback ( #23308 )
2020-06-24 12:59:33 -07:00
dad1ca68d7
Make RequestServices work for cloned longpolling HttpContext ( #23014 )
2020-06-24 12:29:11 -07:00
5155e11120
Two minor perf tweaks in CORS and Localization middleware ( #23190 )
...
* Use char instead of char[] for string.Split
Use the newer overload for string.Split() that accepts a char instead of creating a char array.
* Remove redundant bounds check
Remove redundant bounds check for count of exactly 1 as that has already been checked to be true by the previous check.
2020-06-24 07:17:33 -07:00
e34469482c
Make Kestrel config case-insensitive for certificates ( #23268 )
...
* Make Kestrel config case-insensitive for certificates
* Move tests to ConfigurationReaderTests
2020-06-24 06:40:38 +00:00
cc15b1bb43
[SignalR] Implement IConnectionLifetimeFeature ( #20604 )
2020-06-23 22:14:12 -07:00
30472b113e
Merge branch 'master' into merge/release/5.0-preview7-to-master
2020-06-23 20:38:38 -07:00
f6a6e4bd07
Replat blazor on net5 ( #23078 )
...
* Replat blazor on net5
* Make all e2e tests pass
* Fixup
* Update js files
* Fixups
* Fixup
* Fixup
* Skip globalization tests
* Undo workarounds
* PR feedback
* Update dependencies from https://github.com/dotnet/runtime build 20200622.6
System.ComponentModel.Annotations , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging , Microsoft.Extensions.Internal.Transport , Microsoft.Extensions.Http , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Configuration.Xml , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry , Microsoft.Win32.SystemEvents , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Ref , System.Drawing.Common , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.Channels , System.Windows.Extensions , System.Security.Principal.Windows , System.Security.Permissions , System.Security.Cryptography.Xml , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Net.WebSockets.WebSocketProtocol , System.Reflection.Metadata , System.Runtime.CompilerServices.Unsafe , System.Security.Cryptography.Cng , System.Security.Cryptography.Pkcs
From Version 5.0.0-preview.7.20321.2 -> To Version 5.0.0-preview.7.20322.6
* Update js file
* Fix version
* Fixup
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
2020-06-23 18:19:55 -07:00
7aa91ffd62
SpaProxy: Fix proxying of WebSocket protocol ( #23250 )
2020-06-23 16:20:00 -07:00
f5709b4080
Add nullable annotations to Microsoft.AspNetCore.Mvc.Abstractions ( #22993 )
...
* Add nullable annotations to Microsoft.AspNetCore.Mvc.Abstractions
Contributes to https://github.com/dotnet/aspnetcore/issues/5680
* Changes per PR comments
* Changes per PR comments
* Fixup
2020-06-23 22:56:25 +00:00
a1c226e4f3
[SignalR] Move to generic host ( #22602 )
2020-06-23 10:46:03 -07:00
baf7e6c4d6
Add support for optional FromBody parameters ( #22634 ) ( #23246 )
...
* Add support for optional FromBody parameters (#22634 )
* Add support for optional FromBody parameters
Fixes https://github.com/dotnet/aspnetcore/issues/6878
* Fixup nullable
* Changes per API review
* Fixup doc comment (#23229 )
2020-06-23 08:06:14 -07:00
6a4d79cfb8
Fix java pack on local builds ( #23237 )
2020-06-22 20:21:13 -07:00
26cc3b43a2
Unquarantine Tests ( #23098 )
...
Found a bunch of tests running for 30+ days with 100% pass rate.
2020-06-22 17:54:52 -07:00
93e9e1f9e1
Fix urls of @microsoft/dotnet-js-interop package ( #23239 )
2020-06-22 16:42:21 -07:00
94941438d3
Add TagBuilder copy constructor ( #10955 ) ( #22729 )
...
Co-authored-by: Filip Staffa <git@filipstaffa.net>
2020-06-22 15:43:25 -07:00
827751ffe1
Fixup doc comment ( #23229 )
2020-06-22 15:39:39 -07:00
ce80965454
HPackDecoder performance ( #23083 )
2020-06-23 09:20:06 +12:00
efeb8508dc
Fix: 'https://' is also supported as scheme. ( #23194 )
2020-06-22 13:26:30 -07:00
f7d2fac8a2
Add support for optional FromBody parameters ( #22634 )
...
* Add support for optional FromBody parameters
Fixes https://github.com/dotnet/aspnetcore/issues/6878
* Fixup nullable
* Changes per API review
2020-06-22 19:11:55 +00:00
c97a0020d8
Use implicit logging scope for Activity ( #22376 )
...
* Revert "Hoist activity fields to the logging scope (#11211 )"
This reverts commit f7a2d3c26c
2020-06-22 10:12:22 -07:00
36be16b640
Fix binding <select> to a null value ( #23221 )
2020-06-22 17:27:02 +01:00
adbedd2cfb
Render aria-invalid if the state is invalid ( #23131 )
...
* Render aria-invalid if the state is invalid
Co-authored-by: Pranav K <prkrishn@hotmail.com>
2020-06-21 21:43:29 -07:00
8541bf6c98
Flow endpoint and httpcontext always from authz middleware ( #22672 )
2020-06-19 18:14:47 -07:00
4d7a79ad64
Change HttpSys default client cert mode to Allow Cert #14840 ( #23162 )
2020-06-19 16:34:56 -07:00
724c2e75a7
Add nullable annotations to Microsoft.AspNetCore.Components ( #22944 )
...
* Add nullable for Microsoft.AspNetCore.Components
Contributes to https://github.com/dotnet/aspnetcore/issues/5680
* Fixup
2020-06-19 18:38:37 +00:00
52de5ee4df
Fix up rendering for select elements with options component ( #22978 )
...
* Fix up rendering for select elements with options component
* Commit updated compiled JS
* Update test case with more scenarios
2020-06-19 08:43:05 -07:00
a77e68f1c5
Kestrel Endpoints' "SslProtocols" settable via config ( #22663 ) ( #22910 )
2020-06-19 08:09:56 -07:00
bb92c602d8
Fix Windows 7/8 Kestrel tests ( #23069 )
2020-06-19 00:24:21 -07:00
f3b370c1ac
Annotate Authorization.Core, Authorization.Policy with nullable ( #22990 )
...
Contributes to https://github.com/dotnet/aspnetcore/issues/5680
2020-06-18 23:43:35 +00:00
a173be28fb
Add support for <BlazorWebAssemblyLazyLoad /> item group ( #23071 )
...
* Add support for <BlazorLazyLoad /> item group
* Respond to feedback from peer review
2020-06-18 16:05:34 -07:00
ab7f3f2018
Enable `/warnAsError` ( #23072 )
...
* Enable `/warnAsError` in Windows builds
- already enabled in non-Windows builds because override existed only in build.ps1
* Allow some warnings related to closed issues
- common `<NoWarn>$(NoWarn);CS1591</NoWarn>` case unchanged
- /Directory.Build.props ensures that warning remains a warning but doesn't hide it
* !fixup! Root build.sh _does_ disable warnings as errors
- variable eng/common/tools.sh uses named `warn_as_error`
2020-06-18 15:59:34 -07:00
6abc3c759f
Fix Kestrel HTTP/2 debug assert failure ( #23062 )
2020-06-18 15:13:18 -07:00
f627352387
Fix authorization setup in Razor pages template ( #23029 )
2020-06-18 13:30:08 -07:00
214df1c8ef
Merge pull request #22902 from dotnet-maestro-bot/merge/release/3.1-to-master
...
[automated] Merge branch 'release/3.1' => 'master'
2020-06-18 12:24:36 -07:00
a44c1ad78c
Fix null reference errors in tests ( #23091 )
...
Fixes https://github.com/dotnet/aspnetcore/issues/22992
2020-06-18 11:05:54 -07:00
cbb8c6d915
Update FormsTest.cs
2020-06-18 09:48:40 -07:00
c83fd8951a
Add sharedfx and targeting pack tests ( #23045 )
...
* Add test for assembly versions
* Add test for framework list
* Add some hardcoded lists for sharedfx and targeting pack content
2020-06-17 17:06:04 -07:00
45e6571649
Downgrade or throw when HTTP/2 over TLS is configured on older Windows versions ( #22859 )
...
HTTP/2 over TLS is not compatible with Windows versions strictly older than Windows 10 or Windows Server 2016. Update kestrel to:
- Downgrade to HTTP/1.1 when Http1AndHttp2 is configured.
- Throw NotSupportedException when Http2 is configured.
- Allow HTTP/2 over TLS to be enabled if AppContext switch Microsoft.AspNetCore.Server.Kestrel.EnableWindows81Http2 is set. This allows users who have configured cipher suites on Windows 8.1 and Windows Server 2012 R2 to continue using HTTP/2 over TLS.
2020-06-17 16:50:48 -07:00
7a82a48a20
Fix build issues in Blazor WASM template tests ( #23052 )
2020-06-17 15:31:00 -07:00
855a73816d
Update Microsoft.AspNetCore.Server.HttpSys.FunctionalTests.csproj
2020-06-17 13:54:53 -07:00
c5b7eab345
Update Microsoft.AspNetCore.Server.HttpSys.csproj
2020-06-17 13:53:19 -07:00
c4c6e25a06
Add missing doc files and cleanup nits ( #22931 )
...
* nit: Remove useless `$(HasReferenceAssembly)` settings
- set in /Directory.Build.targets
- `true` only in `$(IsAspNetCoreApp)` projects
* nit: Remove useless `$(CompileUsingReferenceAssemblies)` settings
- no current versioning differences between ref/ and src/ assemblies when targeting default TFM
* Add more `$(GenerateDocumentationFile)` settings
- increases the number of generated doc files, mostly without problems
- !fixup! correct typo in `DebugProxyHost` doc comments
- was not generating a doc file before
- remove previous (ineffective) src/Components/Directory.Build.targets setting
- nit: remove a duplicate `$(GenerateDocumentationFile)` setting
* nit: Remove useless `$(IsPackable)` settings
- only analyzers and implementation projects are packable by default
- main use case for explicit setting is projects shipping only in shared framework
- conditional setting in src/Mvc/Directory.Build.props just subset logic in /Directory.Build.targets
* nit: Remove useless `$(IsProjectReferenceProvider)` settings
- only implementation projects are providers by default
* nit: Remove useless `$(IsTestAssetProject)` settings
- set in src/Mvc/test/WebSites/Directory.Build.props
* !fixup! Looks like `InProcessNewShimWebSite` must compile w/o ref/ assemblies
- restore `$(CompileUsingReferenceAssemblies)` in this one project
2020-06-17 13:04:45 -07:00
538c462c05
Enable Helix tests for Microsoft.AspNetCore.Mvc.Razor.Extensions.* projects.
...
- Enabled Helix for:
- `Microsoft.AspNetCore.Mvc.Razor.Extensions.Test`
- `Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X.Test`
- `Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X.Test`
- These tests depended on our MVC shim project's deps.json's to exist in the test bin directory during publish. Therefore added an additional target copy over those assets at publish time.
- There were some tests that were relying on source positions from a string to match a runtime generated source position. In Helix dll's are built on Windows (string's get compiled with \r\n) and then deployed to potentially non-Windows boxes resulting in mismatches of expectations. To address this I changed the test that had this dependency to dynamically generate the input string.
- Our common language test project used to rely on test files being on disk. At some point in the past those test files started being embedded in the assembly but we maintained directory checking logic to ensure various directories existed on disk (no longe required). Changed the logic to not enforce directories to be on disk (they aren't in Helix) and instead only rely on the embedded TestFiles.
dotnet/aspnetcore#22100
2020-06-17 11:49:49 -07:00
952a19682d
Quarantine failing test ( #23044 )
2020-06-17 18:49:43 +00:00
632aa8a95c
[master] Update dependencies from dotnet/runtime ( #23040 )
...
* Update dependencies from https://github.com/dotnet/runtime build 20200617.2
System.ComponentModel.Annotations , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging , Microsoft.Extensions.Internal.Transport , Microsoft.Extensions.Http , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Configuration.Xml , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry , Microsoft.Win32.SystemEvents , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Ref , System.Drawing.Common , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.Channels , System.Windows.Extensions , System.Security.Principal.Windows , System.Security.Permissions , System.Security.Cryptography.Xml , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Net.WebSockets.WebSocketProtocol , System.Reflection.Metadata , System.Runtime.CompilerServices.Unsafe , System.Security.Cryptography.Cng , System.Security.Cryptography.Pkcs
From Version 5.0.0-preview.7.20315.3 -> To Version 5.0.0-preview.7.20317.2
* null
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: BrennanConroy <brecon@microsoft.com>
2020-06-17 18:46:34 +00:00
b8de65dbac
Update Microsoft.AspNetCore.Shared.Tests.csproj
2020-06-17 11:18:22 -07:00
bccaa41ca8
Update Http2Utilities.cs
2020-06-17 11:17:35 -07:00
Brennan
Pranav K
Martin Costello
William Godbe
Stephan Troyer
Tanay Parikh
Ivan Zub
Filip Staffa
James Newton-King
ccvca
Sourabh Shirhatti
Steve Sanderson
Artak
Hao Kung
Chris Ross
Safia Abdalla
John Luo
Doug Bunting
Stephen Halter
Justin Kotalik
N. Taylor Mullen
dotnet-maestro[bot]