* Separate MessagePackHubProtocol into its own package
* Remove gitignore
* Maybe undo this later
* More factoring
* Get gradle test working
* Get gradle test working
* Get rid of version.java
* Separate build.gradle files for all
* Create separate javaproj's for everything
* Fix warnings
* Resolve conflicts
* Fixup gitignore
* Feedback, fix error
* Fix error
* Change package name
* Fix folder structure
* Skip helix tests, fix .gitignore
* Make TransferFormat private
- mostly duplicates #25217
- update `BaselineGenerator` to produce baselines useful in 6.0 (too)
- update Baseline.Designer.props using new generator (matching 3.1.7 release)
- always suppress references expressed only in `*.nuspec` files
- needed even in servicing builds
- restore warning and errors about removed references (new for 5.0)
- adjust exclusions to handle `@(_ProjectReferenceByAssemblyName)` removal
nit: do not generate empty `<ItemGroup />` elements
* Correct `@(SuppressBaselineReference)` items
- remove out-of-date `@(SuppressBaselineReference)` items
- either 3.1.7 baselines we're using don't include reference or still using package
- fix some comments and `Condition` attributes to make remainder easy to find
- add missing `@(SuppressBaselineReference)` items
* Add net461 TFM to netstandard2.0 projects
* Fix a couple of errors
* Fix some errors
* Get rid of Sockets reference
* Respond to feedback
* net461 -> property
* Fixup clientSample
* Remove net461 from analyzers/razor
* Remove net461 from test projects
* Feedback
* Add net461 test configs
* Remove some incompatible test configs
* Fix test
* Implement ParseMessages for java messagePack client
* Fix some spacing & syntax
* Implement write
* Tab -> Spaces
* MessagePacker -> MessageBufferPacker
* Tabs -> Spaces
* Tabs -> Spaces
* InvocationMessage may not include streamIDs
* Only 1 ctor per message type
* Fixup HubConnection.java
* Change return type of parseMessages to List
* Fix HubConnection
* Check for primitive value before returning
* Implement length header prefix
* Minor fixes
* Use ByteBuffer to read length header
* Add case for Char
* Close unpacker
* Typo
* Override onMessage w/ ByteString
* Change OKHttpWebSocketWrapper
* Account for nil InvocationId
* Change interface & MessagePack impl
* Update JsonHubProtocol
* Use ByteBuffer
* Fixup HubConnection
* Fixup more stuff
* Convert more stuff to ByteBuffer
* Account for ReadOnly
* Spacing
* No need to reset ByteBuffer when setting position
* Add Protocol to HubConnection ctor
* Set default, make stuff public
* Fixup tests
* More test cleanup
* Spacing
* only grab remaining buffer bytes in json
* Last test fixes
* Get rid of some unused imports
* First round of msgpack tests
* Flip condition
* Respond to feedback
* Spacing
* More tests
* Add test for primitives
* Add more tests, start using msgpack-jackson
* Fix build.gradle
* Remove debug prints
* Start using Type instead of Class
* Add overloads for Type, make messagePack readValue() more efficient
* Apply feedback, add some tests
* Add some tests, fix some tests
* Fix tests for real
* Add a whole buncha tests
* Add TestUtils change that I didn't commit yesterday
* Respond to some feedback
* Add a couple Json tests
* Apply more feedback
* Move readonly fix to msgpack
* Minor optimization
* Fixup some javadocs
* Respond to feedback
* Remove TypeReference, make Protocols private again
* Feedback
Create new instances of List<T> with an appropriate capacity for the items that will be added.
Use Array.Empty<T>() where appropriate, rather than create an empty list and then return it.
* Add nullable annotations to SignalR.Common, SignalR.Core and Http.Connections
Contributes to https://github.com/dotnet/aspnetcore/issues/5680
* Changes per PR comments. Also add nullability to hub protocols
- Annotated UseMiddleware and UseStartup to preserve constructors and public methods.
- Annotated UseHub and MapHub preserve constructors and public methods.
- Added a test to verify UseStartup and UseMiddleware works
- The linker.xml preserves constructors all of the types that are registered in DI. This should be removed once we get the linker friendly DI changes.
* Remove all ref/ projects
* Remove GenAPI infrastructure
* Remove notion of a reference assembly project
- remove `$(IsReferenceAssemblyProject)`, `$(ReferenceReferenceAssemblies)` and `$(ReferenceImplementationAssemblies)`
- remove unnecessary `$(NoWarn)` settings
nits:
- remove a few misleading comments
- wrap some long lines
* Move .0 package version workaround into Versions.props
- touch up SharedFramework.External.props
* Expose `%(LatestPackageReference.RTMVersion)` metadata
- automate use of properties in the `@(LatestPackageReference)` item group to make this maintainable
- add a couple of special cases at the bottom of eng/Dependencies.props
- add one more `$(...PackageVersion)` property to avoid yet-another special case
* Enable Roslyn reference assemblies
- exclude ref/ assembly from packages other than targeting pack
- update Microsoft.AspNetCore.App.Ref.csproj
- `%(IsReferenceAssembly)` and `%(ReferenceGrouping)` metadata no longer relevant
- only ref/ assemblies are in `@(ReferencePathWithRefAssemblies)` item group
nits:
- remove now-unnecessary workaround
- issues with TFM transition are behind us
- clean up Microsoft.AspNetCore.App.Runtime.csproj slightly
- use `GeneratePathProperty="true"`
- reorder item / property settings for meta-expansion
- correct spelling errors and phrasing in comments
* Update documentation to reflect recent changes
- remove CrossRepoBreakingChanges.md; was tied to old TeamCity infrastructure
- also much less relevant given repo merges
- adjust details and examples in ReferenceResolution.md
- reflect repo merges, Dependencies.props changes, and current Maestro++ channels
- add a few more details e.g. specific files where Version.Details.xml versions are used
* !fixup! Remove another irrelevant doc file
* !fixup! Address PR review suggestions
- convert a couple of warnings to errors
- use consistent casing for Microsoft.NETCore.App.Runtime.* packages
- reduce `%(LatestPackageReference.Version)` metadata special cases
- add and improve comments e.g.
- improve comments about `$(*V0PackageVersion)` properties
- improve placement of comments about item removal in ResolveReferences.targets
- confirmed `$(*V0PackageVersion)` property list is complete
nits:
- fix solution example in ReferenceResolution.md
- remove item group definition for `@(LatestPackageReference)`
- remove `%(LatestPackageReference.VersionName)` metadata after use; large item group
- similarly, remove `%(LatestPackageReference.RTMVersion)` when not needed; just complicates `Condition`s
When I squash, I must remember this fixes
- #14801
- dotnet/aspnetcore-internal#2693
* Actually use `%(LatestPackageReference.RTMVersion)` metadata
- gather RTM package references in a new project
- a (very) separate project to work around package conflict resolution
- empty `Test` target works around Arcade's testing approach
- new target in ResolveReferences.targets updates relevant assembly paths to use the RTM packages
- done as soon as possible after `ResolvePackageAssets` determines the paths
- done for all compilation inputs, not just ref/ assemblies
* nit: Remove useless `$(HasReferenceAssembly)` settings
- set in /Directory.Build.targets
- `true` only in `$(IsAspNetCoreApp)` projects
* nit: Remove useless `$(CompileUsingReferenceAssemblies)` settings
- no current versioning differences between ref/ and src/ assemblies when targeting default TFM
* Add more `$(GenerateDocumentationFile)` settings
- increases the number of generated doc files, mostly without problems
- !fixup! correct typo in `DebugProxyHost` doc comments
- was not generating a doc file before
- remove previous (ineffective) src/Components/Directory.Build.targets setting
- nit: remove a duplicate `$(GenerateDocumentationFile)` setting
* nit: Remove useless `$(IsPackable)` settings
- only analyzers and implementation projects are packable by default
- main use case for explicit setting is projects shipping only in shared framework
- conditional setting in src/Mvc/Directory.Build.props just subset logic in /Directory.Build.targets
* nit: Remove useless `$(IsProjectReferenceProvider)` settings
- only implementation projects are providers by default
* nit: Remove useless `$(IsTestAssetProject)` settings
- set in src/Mvc/test/WebSites/Directory.Build.props
* !fixup! Looks like `InProcessNewShimWebSite` must compile w/o ref/ assemblies
- restore `$(CompileUsingReferenceAssemblies)` in this one project
The second `VarInt` example has `0x80 0x25` is represented as (`%10000000 %00101001`) which when decoded becomes 0x1480 (5248)
When trying to implement `VarInt` encoding and decoding myself I found that `0x25` is actually `%00100101` instead of `%00101001` which causes the final decoded `VarInt` to be incorrect.
The proper hex value for the binary `%00101001` is `0x29`
Stephen Halter
Brennan
William Godbe
Doug Bunting
Martin Costello
Pranav K
David Fowler
Levi Broderick
dotnet-maestro[bot]
Safia Abdalla
Adrian Wright
Vasilev Pyotr
Kevin Pilch
pagan-gerbil
Hao Kung
Tanay Parikh
Luke Pfeiffer