Commit Graph

37360 Commits

Author SHA1 Message Date
Stephen Halter 132a1ad31b
Remove capture of "this" from local function (#7467) 2019-02-14 00:21:39 -08:00
Nate McMaster 94109e6655
Add package override manifest to the targeting pack (#7555) 2019-02-13 19:32:47 -08:00
Ryan Nowak f2a1a4542e
Introduce dynamic endpoints and fix #7011 (#7445)
* Add IDynamicEndpointMetadata for dynamic endpoints

* Use a dynamic endpoint policy for pages
2019-02-13 18:52:07 -08:00
Pranav K 27e54a1b7a Skipping flaky test 2019-02-13 16:45:36 -08:00
Pranav K 9053bc6e29 Re-enable skipped runtime compilation tests 2019-02-13 16:45:36 -08:00
BrennanConroy 9de42d516e
Copy Kestrel perf changes (#7480) 2019-02-13 16:31:37 -08:00
Chris Ross d1aa53721b
Add launchSettings.json to worker template (#7550)
* Add launchSettings.json to worker template #7545
* Switch back to the Web SDK
2019-02-13 15:54:15 -08:00
Sébastien Ros 519e6bbb7c Update benchmarks.yml (#7558) 2019-02-13 15:46:48 -08:00
John Luo 3bd10a0fdf
Fix repo root in restore.sh (#7521) 2019-02-13 15:01:30 -08:00
Nate McMaster 338de4710a
Automatically set 'PrivateAssets=All' for .Sources references (#7539)
When a `<Reference>` is named `*.Sources`, set PrivateAssets=All (exclude from generated nuspec) and IncludeAssets=ContentFiles (only consume content files, not .dll's)
2019-02-13 14:31:15 -08:00
Pranav K cddbc2e888
Improve Components error handling (#7165)
* Improve Components error handling

* Change event handlers IHandleEvent, IHandleAfterEvent to be async.
* Return faulted tasks to Renderer instead of handling exceptions in ComponentBase
* Use ILogger in RemoteRenderer, and log to console in WebAssemblyRenderer
* Cleaning up touched files

Fixes https://github.com/aspnet/AspNetCore/issues/4964
2019-02-13 14:22:46 -08:00
Doug Bunting 758ba235fa Touch up component detection
- run only on success of previous steps
2019-02-13 11:32:17 -08:00
Mikael Mengistu 3d3ad96206
SignalR Java Client LongPolling Transport (#6856) 2019-02-13 10:27:07 -08:00
Nate McMaster 2ac4619635
Replace custom targets for generating assembly attributes and source control info by using SDK features (#7504) 2019-02-13 10:22:03 -08:00
Chris Ross 06d7fe73a9
Implement ITlsHandshakeFeature for HttpSys (#7284) 2019-02-13 08:39:45 -08:00
Nate McMaster 3fd8a97af2
Add targets to generate the list of shared framework assemblies from project property (#7510)
Changes:
* Add support for a property, `IsAspNetCoreApp`, in the .csproj file of assemblies which are part of the shared framework. 
* Remove unused dependencies
* Remove reference which have become part of 'netcoreapp3.0'
2019-02-12 23:00:19 -08:00
Doug Bunting 5bbf7109a5
Fail `ComplexTypeModelBinder` after `CanCreateModel(...)` in some cases (#6793)
- #4802 and #6616
- also reduces the impact incorrect metadata as in #4939
- postpone some property binding in `ComplexTypeModelBinder`
2019-02-12 22:15:43 -08:00
Pavel Krymets de74a0e2f0
Don't rely on the defaults for IntDir (#7513) 2019-02-12 21:26:11 -08:00
Hao Kung 9ab72f6202
Skip flaky Components test on Helix (#7488) 2019-02-12 21:15:28 -08:00
BrennanConroy 1c6651a1ae
Fixup handshake logic and layering (#7470) 2019-02-12 17:06:56 -08:00
Chris Ross 8f72b87981
Enable docker for the worker template #6817 (#7508) 2019-02-12 15:09:27 -08:00
Pranav K 173b2f91fb
Trim Async suffix on action names (#7420)
Fixes https://github.com/aspnet/AspNetCore/issues/4849
2019-02-12 13:30:38 -08:00
Javier Calvarro Nelson 6827bb7443
[Templating] Razor class library for components (#7461)
* [Components] Razor class library for components
* Updates the Razor Class Library to be a portable components library by
  default.
* Adds an option to support the old RCL that includes support for Views
  and pages.
* Usage:
  * `dotnet new razorclasslib` produces the same traditional Razor Class Library.
  * `dotnet new razorclasslib -s false` produces a Razor Class Library without views and pages support.
2019-02-12 06:08:11 -08:00
David Fowler c1bc210e8e
Fix returning buffered data after stream is drained (#7476)
- Change TryRead to return the buffer if the Stream is completed
2019-02-11 20:45:15 -08:00
Chris Ross 05923e9151
Get worker tempalte showing up in VS (#7478) 2019-02-11 20:25:17 -08:00
Ryan Nowak acd1cf3251
Update MVC/Routing Startup Experience (#7425)
* Relayer MvcEndpointDataSource

Separates the statefulness of the data source from the business logic of
how endpoints are created.

I'm separating these concerns because one of the next steps will split
the MvcEndpointDataSource into two data sources.

* Simplify MvcEndpointInfo

Removing things that are unused and leftovers from the 2.2 design of
this feature.

* Remove per-route conventions

Removes the ability to target endpoint conventions
per-conventional-route. This was a neat idea but we have no plans to
ship it for now.

Simplified MvcEndpointInfo and renamed it to reflect its new purpose.

* Remove filtering from MvcEndpointDataSource

This was neat-o but we're not going to ship it like this. We're going to
implement filtering in another place. Putting this in the data source is
pretty clumsy and doesn't work with features like application parts that
need to be baked in addservices

* Simplify ActionEndpointFactory

* Split up data sources

* Use UseRouting in functional tests

I've rejiggered our functional tests to de-emphasize UseMvc(...) and
only use it when we're specifically testing the old scenarios.
UseMvc(...) won't appear in templates in 3.0 so it's legacy.

* Update templates

* Add minor PR feedback

* one more
2019-02-11 19:18:05 -08:00
Justin Kotalik 2a9caa0343
AsTask => GetAsTask() (#7468)
* AsTask => GetAsTask()

* Another spot

* Another spot
2019-02-11 16:55:28 -08:00
Daniel Roth 2e1aa139f7
Update metadata for the Blazor VSIX (#7473) 2019-02-11 16:55:09 -08:00
dotnet-maestro-bot 98be5a3ca5 Fix flaky process output reading for dotnet-watch tests (#7173) (#7403) 2019-02-11 16:47:58 -08:00
Ryan Nowak c5d8f8c34e Update CORS package.json and friends
This is what NPM wants to do - why argue?
2019-02-11 16:19:27 -08:00
Ryan Nowak 5a291d0bc0 Fix #4212 area ambient value page->controller
This change enhances our ambient value logic to also deal with required
values. In 2.2 we introduced a 'required values' semantic to allow route
values to appear "to the left" of a route pattern for the purpose of
ambient values copying. This is a complicated way of saying "when you
like to a different endpoint then discard the ambient values".

What we didn't consider is that some ambient values are special (like
area). So basically, we'll allow an ambient value to be used if it's
part of the required values - even if we've already decided to discard
the ambient values.

This is a pretty surgical fix and only affected the desired scenario
based on tests.

-----

I also removed an optimization that I think is broken. I put an earlier
optimization in place that attempted to count ambient values as they
were "seen" to try and avoid some extra copying. This copying loop has a
cost even if it no-ops which is what I was trying to prevent.

Unfortunately since we added 'required values' - it's now possible for
an ambient value to be double-counted, which makes this optimization
incorrect.
2019-02-11 15:58:33 -08:00
Pranav K 88ae930fad
Remove obsolete APIs from MVC (#7444)
* Remove obsolete APIs from MVC
Fixes https://github.com/aspnet/AspNetCore/issues/7322
2019-02-11 15:27:38 -08:00
Justin Kotalik e5f31f264c Another spot 2019-02-11 15:10:30 -08:00
N. Taylor Mullen dfddc4e8ff [MVC] Remove obsolete APIs
- Removed ViewsFeatureProvider
- Removed PageArgumentBinder and its internal implementation DefaultPageArgumentBinder.
- Removed corresponding test classes/methods for all the above.
- Reacted to class/member changes in dependencies.

#7326
2019-02-11 14:56:30 -08:00
Chris Ross 597c8434d5
Background Worker template (#7401) 2019-02-11 14:53:50 -08:00
Justin Kotalik 371c29577b Another spot 2019-02-11 14:42:02 -08:00
Justin Kotalik 84cdac952a AsTask => GetAsTask() 2019-02-11 13:58:25 -08:00
Chris Ross abd2a61bdb
Update Extensions dependencies (#7397) 2019-02-11 13:18:22 -08:00
David Fowler a5ba735a0f
Remove PlatformBenchmarks from sln (#7440) 2019-02-11 12:38:20 -08:00
Pavel Krymets 037a5b0231
Add more logging to a failing tests and move dumps to logs directory (#7462) 2019-02-11 12:14:05 -08:00
David Fowler 476a1827f4
Made changes to stream <-> pipe adapters (#7407)
- Use the array pool by default when the shared memory pool is specified for both the StreamPipeReader and StreamPipeWriter
- Support allocating unpooled memory if the StreamPipeWriter is asked for memory outside of the max pool size
2019-02-11 11:15:36 -08:00
Ben Adams 3276870d6a Remove unnecessary Flush (#7424) 2019-02-11 11:02:00 -08:00
Ben Adams 6d42ff7c38 Don't write empty data for Flush (#7415) 2019-02-11 11:01:36 -08:00
Javier Calvarro Nelson dbf746d210
[Antiforgery][Components][CORS] Remove obsolete APIs (#7459)
#7325
#7319
#7324
2019-02-11 10:38:31 -08:00
Doug Bunting 58e6d78549 Suppress Razor warnings about missing doc comments 2019-02-11 10:35:48 -08:00
Artak 7c9959934a Fixed a type reference in a doc comment.
Fixes #7416
2019-02-11 09:06:34 -08:00
Ben Adams 704094b199 Use C#7.3's ReadOnlySpan<byte> optimization for static data (#7422) 2019-02-11 07:40:40 -08:00
Martin Costello 762206a5d8 Fix typo in package description (#7435)
Fix incorrect spelling of "storage".
2019-02-10 16:25:57 -08:00
David Fowler 3be85751d5
Make Hosting.sln compile in vs (#7431) 2019-02-10 16:24:33 -08:00
kishanAnem c1ce7b9a77 ValidationSummary doesn't display property errors if ModelState and ModelMetadata meets the specific conditions #4831
Hi @dougbu

I removed test which is naming conflicts.
and closing #7221 PR
2019-02-09 13:11:07 -08:00