Commit Graph

1166 Commits

Author SHA1 Message Date
Ryan Nowak 08b83fefc3 Some cleanup of action invoker and related code
The action invoker no longer needs access to model metadata or to the
input formatter selector. This change removes the same as constructor
parameters and cleans up tests which use the invoker.
2015-01-12 16:44:39 -08:00
Ryan Nowak 61d9c2cbf8 fix build break 2015-01-12 14:36:21 -08:00
Ryan Nowak 5ac5c53c09 Adding Resource Filters
This is a new filter stage that surrounds the existing model binding,
action, and result parts of the pipeline. Resource Filters run after
Authorization Filters.

The other major change is to support one of the primary scenarios for
Resource Filters. We want a filter to be able to modify the inputs the
model binding (formatters, model binders, value providers, etc) -- this
means that those changes need to be held on a context object and preserved
so that they can be used in the controller.

So, IActionBindingContextProvider is removed - the ActionBindingContext
will be created by the invoker. For now it will be part of the action
context.
2015-01-12 14:18:20 -08:00
stanislavromanov 990473aebc Change remark for FlushAsync method. close #1721 2015-01-12 14:07:58 -08:00
Ajay Bhargav Baaskaran 3dedef422a Merged compiler/resources with Compiler/Resources 2015-01-12 13:29:37 -08:00
Ajay Bhargav Baaskaran 191af4a5a9 added activation tests for tag helpers 2015-01-12 12:51:41 -08:00
Hao Kung 63940bee87 Fix doc comments 2015-01-12 11:47:08 -08:00
Hao Kung 157b633758 React to IContextAccessor -> IScopedInstance 2015-01-12 10:25:21 -08:00
Youngjune Hong f8cb519c2f Adding the functional tests for MvcTagHelpers (1) 2015-01-08 17:23:42 -08:00
Ajay Bhargav Baaskaran 52a984c52d react to aspnet/HttpAbstractions#146 changes 2015-01-07 17:53:35 -08:00
Doug Bunting 6df288bce7 Correct StyleCop violations
- StyleCop working again (handles C# 6.0 additions) though only locally for me
- disable some new rules:
 - ConstFieldNamesMustBeginWithUpperCaseLetter
 - InstanceReadonlyElementsMustAppearBeforeInstanceNonReadonlyElements
 - StaticReadonlyElementsMustAppearBeforeStaticNonReadonlyElements
 - StaticReadonlyFieldsMustBeginWithUpperCaseLetter
 - PrefixCallsCorrectly
- correct remaining violations
 - lots of long lines for example
 - use more `var`; some manual updates since StyleCop doesn't check seemingly-unused blocks

nit: remove new trailing whitespace (was paranoid about adding it w/ fixes)
2015-01-06 16:23:57 -08:00
Kiran Challa 227f564098 Logging functional tests using ElmLogger 2015-01-06 16:16:12 -08:00
Ryan Nowak 0a473b0600 Remove ParameterModel.IsOptional
The ParameterModel and ParameterDescriptor have had a notion of
optionality for a while now, even though all parameters are treated as
'optional' in MVC.

This change removes these settings. Optionality for overloading in webapi
compat shim is reimplemented via a new binder metadata.
2015-01-06 15:22:13 -08:00
Ryan Nowak fb21b736ee Issue #1754 - Change List to IList in application model 2015-01-06 15:16:04 -08:00
sornaks 5262dfd577 Adding SerializableError - a serializable container for the purpose of output conneg. 2015-01-06 14:07:45 -08:00
Ajay Bhargav Baaskaran 51567194dc deleted duplicate action results in WebapiCompatShim 2015-01-06 11:07:22 -08:00
Troy Dai bc6833ee72 Fix build break 2015-01-06 11:01:20 -08:00
Kiran Challa 391816eb71 [Fixes #1713]WebApiCompatShim doesn't work with Transfer Encoding: chunked 2015-01-05 21:52:13 -08:00
Bruce Bowyer-Smyth af9e9f9113 Remove boxing of chars when concatenated with strings 2015-01-05 19:05:14 -08:00
Bruce Bowyer-Smyth 95ae4cb3a5 Use optimal StringComparison for symbol strings 2015-01-05 18:50:55 -08:00
Pranav K f649fb45c8 Adding TestConfiguration to NoFun.sln to avoid it from modifying the sln
on open
2015-01-05 13:42:41 -08:00
Ajay Bhargav Baaskaran eb7283fced added BadRequest and Created Action Results with related unit and functional tests. 2015-01-05 11:07:42 -08:00
Kirthi Krishnamraju 9ea5350271 Added more coverage in functional tests for FlushAsync 2015-01-05 10:36:37 -08:00
Pranav K 68fcb2bfca Temporarily disabling running
UpdateVehicle_WithXml_BindsBodyServicesAndHeaders until we get a
resolution for DataContractSerializer behaving differently in CoreCLR.
2015-01-05 10:15:27 -08:00
Pranav K 487c5464c0 Adding reference to Roslyn to unbreak build 2015-01-03 07:31:27 -08:00
Pranav K 110ee28e3e Adding support for flowing compilation settings to views
Fixes #871
2015-01-02 15:34:52 -08:00
Pranav K 62b9db93b6 Removing unused code from UnclassifiedCodeSpanConstructor to fix build 2015-01-02 14:34:57 -08:00
Ryan Nowak e2a4b1ec72 Remove IsActionNameMatchRequired
This change removes IsActionNameMatchRequired from the action model. The
WebAPI shim uses a custom route data constraint to get the same effect.
2014-12-31 15:21:50 -08:00
Ryan Nowak ae9fc793ec Adding IRouteConstraintProvider and supporting it on actions
This change adds an interface for the functionality provide by
RouteConstraintAttribute, and adds support for configuration constraints
on actions/action-model.
2014-12-31 14:50:33 -08:00
Ryan Nowak 5dfd27e51f Removing dead code in sample 2014-12-31 11:26:49 -08:00
riande db96104985 removed App_data per [Mvc] Remove App_Data from MvcSample.Web Startup (#1716) 2014-12-31 11:09:03 -08:00
Ajay Bhargav Baaskaran a818240d8a React to aspnet/Razor#263 changes 2014-12-23 16:34:13 -08:00
N. Taylor Mullen 6afd8710fa React to aspnet/Razor#207 changes. 2014-12-22 10:58:23 -08:00
Pranav K 9df8a1e73f Reacting to FileSystem changes v2 2014-12-19 18:10:57 -08:00
Pranav K c6eaf00b02 Reacting to FileSystem changes 2014-12-19 17:38:29 -08:00
SonjaKhan c936ae80ca Logging assemblies, controllers, and actions 2014-12-18 10:52:20 -08:00
Ajay Bhargav Baaskaran 04c37a8d51 added few taghelper functional tests 2014-12-17 16:31:24 -08:00
Pranav K 50d9beae17 Merge branch 'release' into dev 2014-12-17 16:11:22 -08:00
Pranav K 2a57f93117 Updating Razor to not use K.Roslyn 2014-12-17 14:48:57 -08:00
Pranav K 22ac7c45e5 Update Mvc to use official xunit runner 2014-12-17 11:27:07 -08:00
sornaks 07043ce1a9 Merge branch 'release' into dev 2014-12-16 14:52:16 -08:00
Kai Ruhnau e0beec90f4 Fixed folder name casing of Compiler/* 2014-12-16 12:32:35 -08:00
Pranav K ce8d840cc6 Adding additional functional tests for ModelBinding 2014-12-16 12:25:37 -08:00
sornaks 1570e198ef Bug #1354 - ViewComponent View() fails on CoreCLR with IEnumerable<> passed in.
Fix - When the model is passed in to a View, ViewDataDictionary sets it. During this process, we recurse through all the properties and create FastPropertyGetters for each of them. In this case, since it is an enumerable, the properties which we recurse through are not the elements of the collection but the properties of the Enumerable instead. i.e - Enumerable.Current. Creating getters for these properties are not necessary. The fix moves the property iteration step to a place where the properties are actually requested.
- Splitting TypeInformation class into two and separating their caches appropriately.
2014-12-16 12:19:38 -08:00
Pranav K e078076408 Adding functional test for RazorViewEngineOptions.FileSystem 2014-12-16 12:08:40 -08:00
Saar Cohen d3344f0766 Changed hard coded argument string in the throw to use nameof 2014-12-15 18:59:12 -08:00
Ryan Nowak 6390bad0d3 Adding a pattern for returning 'unhandled' exception information via
middleware.

This should be used where posssible instead of throwing an exception and
catching in a test, as that only works in memory.
2014-12-15 16:29:08 -08:00
Ryan Nowak 1a617eb533 Fix an inadvertent 204 in activator tests
On a web server, this test ends up giving back a 204 because of the MVC
behavior when an action is declared to return void. The fix is to use
EmptyResult.
2014-12-15 11:18:39 -08:00
Pranav K ba5712c824 Merge branch 'release' into dev 2014-12-12 16:56:54 -08:00
DamianEdwards 263e75c8a6 Update tests for Razor Tag Helpers Unique ID feature:
- aspnet/razor#241
2014-12-12 16:27:41 -08:00