9c47796ec0
Merge pull request #312 from benaadams/MemoryPoolIterator2-GetString
...
Reduce GetString allocs and conversions
2015-11-16 20:13:38 -08:00
4dc4346fca
Reduce GetString allocs and conversions
2015-11-17 03:46:09 +00:00
f7a5c38f65
Follow common pattern for implementing IHttpRequestLifetimeFeature
2015-11-16 16:03:55 -08:00
b73e42b617
Abort request on any write failure
2015-11-16 16:03:53 -08:00
874bd29ce1
Throw IOExceptions instead of ODEs after a request is aborted
2015-11-16 16:03:51 -08:00
062caf16be
Support for IHttpRequestLifetimeFeature
2015-11-16 16:03:50 -08:00
1cbb273b0d
Corrected Exception messages
2015-11-16 16:03:48 -08:00
5e883827e0
Explain why dispose can't be used
2015-11-16 16:03:46 -08:00
f60f6c92ca
Stop streams on finish
...
Can't use dispose (or close) as can be disposed too early by user code
Resolves #263
2015-11-16 16:03:44 -08:00
5774cf9f1e
Merge pull request #390 from benaadams/stack2queue
...
ConcurrentStack -> ConcurrentQueue
2015-11-16 15:36:29 -08:00
7ba0f7da19
Merge pull request #377 from benaadams/legacy
...
Result -> GetAwaiter().GetResult() for legacy
2015-11-16 12:13:45 -08:00
e3a62ff09f
Merge pull request #335 from benaadams/used-pool-array
...
Consume body without allocating or reading
2015-11-16 11:47:18 -08:00
8941d4b620
Disconnect is Debug not Error
...
Resolves #392
2015-11-16 17:44:24 +00:00
7691a7cc23
Improved Send100 Check
2015-11-16 06:43:49 +00:00
ecc439555e
Reuse ReadAsync for Consume
2015-11-15 22:27:39 +00:00
1589b54018
Early bail, completed tasks+Interlocked
2015-11-15 21:56:20 +00:00
f089abd337
Consume in single call
2015-11-15 21:39:36 +00:00
f48e6ba51a
Add Async in method name
2015-11-15 21:28:36 +00:00
f7bdc5a4e9
Skip non-consumed rather than reading
2015-11-15 21:28:33 +00:00
bd6e181d93
ConcurrentStack -> ConcurrentQueue
2015-11-15 21:17:14 +00:00
2e2dfd87c1
Fix byte[] array allocation in IsDarwin
2015-11-14 22:55:25 -08:00
a3a49d21b8
Reset Frame.Scheme on each request ( #366 ).
2015-11-13 16:05:10 -08:00
96c1668c54
Result -> GetAwaiter().GetResult() for legacy
2015-11-13 20:08:59 +00:00
558b0ae643
statics to instance
2015-11-13 20:08:11 +00:00
d82c571831
Trim exposed KestrelThread api
2015-11-13 20:08:11 +00:00
a95318c616
Network thread count defaults
2015-11-13 20:00:32 +00:00
59a95f43a3
Set NoDelay as default
...
Resolves #374
2015-11-13 19:33:24 +00:00
52fe469688
Update project.json
2015-11-12 22:59:34 -08:00
fc346f7768
Avoid some closure allocations in SocketOutput
2015-11-12 17:08:44 -08:00
59cdd60af6
Don't pre-complete too many writes
2015-11-12 17:08:43 -08:00
6b995362f1
Merge branch 'benaadams/odd-sync' into dev
2015-11-12 16:47:27 -08:00
983997ab9c
Merge branch 'nickcraver/cancellation' into dev
2015-11-12 16:15:59 -08:00
9958427db7
Merge branch 'benaadams/result-getawaiter' into dev
2015-11-12 16:05:50 -08:00
0ead24680d
Merge branch 'benaadams/reduce-log-boxing' into dev
2015-11-12 16:01:06 -08:00
fdfd7dcf36
Merge branch 'benaadams/Task.Run-QueueUserWorkItem' into dev
2015-11-12 15:51:42 -08:00
86e1924cad
Remove System beta tag in project.json for coreclr packages.
2015-11-12 12:23:45 -08:00
a45a671b22
Make ReadAsync state overload 451 only and private.
2015-11-11 18:55:56 -05:00
e5ff33eda2
Remove UvAsyncHandle.DangerousClose
...
- This should stop the AVs we've been seeing in some of our test runs
2015-11-11 15:24:09 -08:00
0500043cc9
.Result -> .GetAwaiter().GetResult()
2015-11-11 09:46:56 +00:00
d1221e82c1
Pass cancellation tokens down consistently
...
I'm assuming these are oversights since the usage is inconsistent.
Otherwise this served only as a mild waste of time :)
2015-11-10 22:58:19 -05:00
bdbd9ae7a6
Merge branch 'benaadams/socketoutput-tasks' into dev
2015-11-10 15:55:10 -08:00
d32937eafe
Add tests for non-immediate byte counting
2015-11-10 23:17:40 +00:00
34cec3448d
SocketOutput to Tasks
2015-11-10 19:53:43 +00:00
d0bdede709
Update the reference link in comments of SockAddr
2015-11-10 11:11:32 -08:00
d9c15e0180
Add references to socket in comments
2015-11-10 10:37:12 -08:00
344c821f83
Remove sync block->task
...
await rather than synchronously blocking and then returning a
Task.FromResult
2015-11-10 18:23:44 +00:00
d08b83a1c7
Fix get IPAddress for Darwin
2015-11-10 10:04:10 -08:00
c0f82765aa
Move logging to new style
2015-11-10 10:43:51 +00:00
a2c4e3a654
Task.Run -> ThreadPool.QueueUserWorkItem
...
Task.Run eventually ends up being QueueUserWorkItem.
The returned task is ignored, so no added goodness.
Short running item.
Cut out the middleman
2015-11-10 07:28:17 +00:00
278bd9c962
Completed Task opt
2015-11-09 04:32:08 +00:00
9d19eed88f
Merge branch 'benaadams/memorypool2-allocate' into dev
2015-11-05 12:16:43 -08:00
bb9f83186b
Remove unused parameter from ListenerSecondary.ReadStartCallback
2015-11-05 12:09:50 -08:00
fff28990fe
Ensure ListenerSecondary buffer isn't double freed or freed too early
...
- Call buf_init in StartAsync so we have access to a KestrelThread
2015-11-04 16:21:29 -08:00
74f08c16df
Merge branch 'benaadams/listenersecondary-allocs' into dev
2015-11-04 15:34:42 -08:00
3e7969cefe
Move handle creation to constructor
2015-11-04 22:44:30 +00:00
272ce27c79
Merge branch 'benaadams/delegates' into dev
2015-11-04 14:21:13 -08:00
5cef608e52
Dispose _ptr
2015-11-04 22:20:51 +00:00
22dfd31261
More readable loop condition
2015-11-04 22:04:19 +00:00
35bbddf9b5
Merge branch 'benaadams/listener-primary-alloc' into dev
2015-11-04 10:14:52 -08:00
04b2885f10
Merge branch 'benaadams/listener-allocation' into dev
2015-11-04 10:12:33 -08:00
f4be290d4a
Merge branch 'benaadams/connection-allocs' into dev
2015-11-04 10:08:36 -08:00
cc84097016
Listener - remove closure allocation
2015-11-04 12:36:32 +00:00
1d4b9d6633
ListenerPrimary - reduce closure allocation
...
Still captures string pipeName
2015-11-04 12:33:51 +00:00
d104e8a08d
Reduce delegate allocation
2015-11-04 12:31:44 +00:00
34c1a671f0
ListenerSecondary - reduce closure allocation
2015-11-04 12:20:00 +00:00
5ae1c4ecb2
MemoryPool2 Allocate returns newest
...
Rather than a while loop on Allocate; return last memory block created
rather than returning it to the pool and checking if one can be removed.
2015-11-04 08:37:12 +00:00
c113c0d3a2
Don't alloc array per header
...
i.e `new StringValues(string)` rather than `new StringValues(new [] {
string } )`
2015-11-04 07:11:55 +00:00
889a24278d
Merge branch 'release' into dev
2015-11-02 17:36:41 -08:00
eaee76dfeb
Strong name everything.
2015-11-02 16:16:55 -08:00
ea6f6b10dc
Don't capture connection on closure
2015-11-01 13:27:17 +00:00
b466c3b7d7
Reacting to Hosting changes
2015-10-30 14:19:55 -07:00
fe654598f6
Merge branch 'release' into dev
2015-10-29 14:30:02 -07:00
85202b0174
Merge branch 'benaadams/read-to-null-buffer' into release
2015-10-29 12:24:40 -07:00
1722150ee9
Do nothing in KestrelThread.Stop if libuv fails to load
...
This prevents DllNotFoundExceptions from being masked by NullReferenceExceptions
2015-10-29 12:21:25 -07:00
e9a6061023
Make Frame implements IHttpConnectionFeature
...
Provide RemoteIPAddress as well as RemotePort
2015-10-29 10:08:35 -07:00
bdadc8a3da
Move comment into loop, remove noop
2015-10-28 22:44:35 +00:00
4bba074d77
Read to null buffer
...
Read to null buffer rather than Stream.Null as the CopyToAsync will
create a `new byte[]` on each call
bc14660885/src/mscorlib/src/System/IO/Stream.cs (L218)bc14660885/src/mscorlib/src/System/IO/Stream.cs (L48)
2015-10-28 08:53:11 +00:00
c1b21b89d5
Removing dependency on Microsoft.Extensions.PlatformAbstractions
2015-10-27 01:40:28 -07:00
d4853f9b7c
Switching to using the built-in loading of native libs
2015-10-27 01:13:21 -07:00
fb01ea3918
Consume the full request body when the app does not
2015-10-26 11:13:07 -07:00
094b8efbf8
Properly handle headers with empty values
2015-10-25 01:40:22 -07:00
52f4fa91e3
Unescape string in memory
...
1. In place unescape;
1. UTF-8 verification;
2. MemoryPoolIterator2.Put
3. Tests
2015-10-23 15:26:59 -07:00
f88631efb3
React to breaking changes in StringValues
2015-10-23 15:05:09 -07:00
eb2c3a1ce8
Rename Microsoft.Runtime.Abstractions to Microsoft.Extensions.PlatformAbstractions
2015-10-22 18:22:05 -07:00
dea782163d
Updating packages to use generations
2015-10-22 15:18:49 -07:00
a1e4e022b9
Clean up
2015-10-21 22:08:03 -07:00
f8fd2f9ac9
React to hosting changes
2015-10-21 10:23:53 -07:00
8f0d1179ab
Allow Nagle’s algorithm to be disabled via IKestrelServerInformation.NoDelay
2015-10-19 12:44:21 -07:00
c809beec18
Don't allocate Exceptions unnecessarily
...
- Allocate Exceptions in the ReadStart callbacks if necessary instead
of in UvStreamHandle.
- This also fixes a bug in ListenerSecondary where it should have
previously been looking at the error code instead of the read count.
#237
2015-10-16 15:25:37 -07:00
8e818e3549
Address PR feedback
2015-10-15 16:52:37 -07:00
7b315d2470
Close connection gracefully in Frame.ProduceEnd
...
- Try sending a FIN before closing the socket
- Don't attempt to send a FIN twice for the same connection
2015-10-15 15:35:40 -07:00
513abb4561
Log errors in OnStarting and OnCompleted
2015-10-15 15:35:38 -07:00
b98425d3b1
Log unhandled exceptions thrown from the AppFunc
2015-10-15 15:35:36 -07:00
7c27c5c0e7
Better handle blocks not taken taken from slabs
...
- If the block needs to be larger than 4032 bytes it won't be backed by a slab
2015-10-14 16:05:35 -07:00
6aaa3cbe06
Use IApplicationLifetime.StopApplication instead of
...
IApplicationShutdown.
React to hosting changes 374526b270
2015-10-14 01:09:11 -07:00
ef38f5589d
React to hosting changes to IApplicationLifetime
2015-10-14 00:46:18 -07:00
cfe6e22a29
React to IHeaderDictionary changes.
2015-10-12 09:29:34 -07:00
3eec43a0c3
Move static BitCount method to base class
...
- Updated comment to point to a specific commit in corefx
- This is more consistent with AppendValue since BitCount doesn't need
to be generated
2015-10-09 17:27:33 -07:00
a33a5d0f1b
Merge branch 'benaadams/bitcount-fast' into dev
2015-10-09 17:17:03 -07:00
78177e7082
Fixing rebase errors
2015-10-09 13:26:34 -07:00
6ae0f5d505
PR feedback - code formatting
2015-10-09 13:19:10 -07:00
29b0b124ee
Moving non-changing methods into .cs partial
2015-10-09 13:19:09 -07:00
ccfeef6353
All features to have backing object
2015-10-09 13:18:32 -07:00
8f41e47eca
Remove bitfield for locally implemented interface items
...
Only generate type statics for cached features
2015-10-09 13:18:09 -07:00
3c20053d9a
Don used cached typeof for tests
2015-10-09 13:15:39 -07:00
56893df7f9
Don't iterate overriden features twice
2015-10-09 13:11:48 -07:00
cbc3b4e6f5
PR Feedback
...
* Sorting namespaces
* Removing `as` casting for Frame's implemented interfaces
2015-10-09 13:10:27 -07:00
dc0eb679ae
Updating unit tests for Frame IFeatureCollection update
2015-10-09 13:09:37 -07:00
71fc2bf2e5
Rough implementation of feature collection optimization
2015-10-09 13:09:35 -07:00
6b0fa776ca
More comment clarity
2015-10-09 12:16:54 -07:00
47973541b5
Remove redundant cast
2015-10-09 12:16:53 -07:00
e107c47913
Add comment explanation
2015-10-09 12:16:52 -07:00
05702e81e6
more typeof caching
2015-10-09 12:16:50 -07:00
d48a27dd59
Use bitflag for override and cache typeof in statics
2015-10-09 12:16:49 -07:00
dcf591c832
Rough implementation of feature collection optimization
2015-10-09 12:16:48 -07:00
0c1b05ce2d
Merge branch 'release' into dev
2015-10-08 16:40:13 -07:00
6f506ba988
subsequent block has data - IsEnd is false
...
Resolves #249
2015-10-08 16:18:47 -07:00
24c0a8e142
Fix MemoryPoolIterator2.CopyTo's block traversal
...
- This fix prevents large request streams from being corrupted
#234
2015-10-08 16:16:41 -07:00
9d251cdb54
subsequent block has data - IsEnd is false
...
Resolves #249
2015-10-08 18:13:22 -04:00
0b36382448
Merge pull request #236 from benaadams/sanitize-loops
...
Sanitize loops
2015-10-08 10:05:17 -07:00
0a297688b4
Use Jit recongised, standard loop construct
...
For bounds check elimination.
Convey intent more clearly; eliminate bounds checks
2015-10-08 12:31:21 -04:00
4250d35347
PR feeback
2015-10-08 01:11:41 -04:00
05418dd18a
Use corefx implementation
2015-10-07 16:51:10 -04:00
8bf2c814d6
Add BitCount LongExtensions
2015-10-07 12:23:20 -04:00
1f50f4c2a8
#231 bind to IPv6Any, add functional tests.
2015-10-05 16:13:11 -07:00
2f3a00625a
Initial work to support HTTPS using SslStream
...
- Add extension method "UseKestrelHttps" to IApplicationBuilder
2015-10-05 03:15:18 -07:00
49451fb11e
Renaming Microsoft.Framework.* -> Microsoft.Extensions.*
2015-10-03 15:44:45 -07:00
6d3e5d3bf2
Merge branch 'benaadams/fastpath-header-enumerator' into dev
2015-09-28 12:21:58 -07:00
d2f282f54f
Consuming Libuv from NuGet package
...
Fixes #50
2015-09-26 18:00:50 -07:00
e3f141fcde
#227 Fix OverflowException in MemoryPool
2015-09-26 06:56:54 -07:00
f0137b7b9e
Bind to specific IP addresses if provided with any
...
This still only applies to IPv4.
#98
2015-09-25 16:26:01 -07:00
1718b69f22
Fast path header enumerator
...
Use strongly typed enumerable as interface's allocates.
2015-09-26 00:16:42 +01:00
a7b65efa75
CR feedback
2015-09-25 14:59:47 -07:00
3c2408db68
Fix tests after rebase
2015-09-25 14:59:47 -07:00
7c46b2bd3b
Use a timer to generate the value for the Date header in responses:
...
- Doing it on each request is expensive
- The Timer is started when the first request comes in and fires every second
- Every request flips a bool so the Timer knows requests are coming in
- The Timer stops itself after a period of no requests coming in (10 seconds)
- #163
2015-09-25 14:59:47 -07:00
5070b8073e
Temporarily commenting out the Debug.Assert of block freeing
...
Unit tests using ad-hoc contexts aren't guaranteed to dispose pools.
That's kinda making unit tests fail, more or less, because Debug...
2015-09-25 14:17:09 -07:00
318f3b7145
Changing Trace.Assert to Debug.Assert
...
* Also Debug.Assert for unreturned memory blocks
2015-09-25 13:01:54 -07:00
f740616573
disposedValue changed to _disposedValue
...
Boilerplate code didn't have _
2015-09-25 12:49:30 -07:00
c42dace9e6
consts looked like local vars
2015-09-25 12:49:30 -07:00
0adbbd0217
Using the well-known-header field without checking set bit
2015-09-25 12:49:29 -07:00
dc902f5fc4
Update SocketOutput to not call QueueUserWorkItem unnecessarily
2015-09-25 12:49:28 -07:00
789d5b3595
Writes which are not immediate always return completed tasks
...
They must always be followed with Writes which are immediate, and
returning an incomplete task put them in a state where the callback
might not have been initiated.
2015-09-25 12:49:27 -07:00
5e678fdbaa
Adding volatile keyword to stopping boolean
2015-09-25 12:49:27 -07:00
99fc7e4e50
Moving the Start/Stop logic into Frame.
...
Also formalizes the relationship between the function's Task and
how it relates to graceful shutdown. Specifically how it relates
to finishing the requests currently in progress.
2015-09-25 12:49:26 -07:00
f89a586b75
Removing boilerplate-generated #region
2015-09-25 12:49:25 -07:00
37f7dfd01f
Typo in comments
2015-09-25 12:49:25 -07:00
c424b8437c
Renaming based on PR feedback
2015-09-25 12:49:24 -07:00
844c791b16
Processing function should return Task
2015-09-25 12:49:23 -07:00
091084cfe2
Refactoring MemoryPool class locations
...
Moving Iterator out into its own file rather than being a nested class
Moving pool classes into Infrastructure namespace instead of Http
2015-09-25 12:49:23 -07:00
13defc5a32
Initialize Memory2 in ListenerContext
...
Better than initializing from multiple other classes
2015-09-25 12:49:22 -07:00
David Fowler
Ben Adams
Stephen Halter
Troy Dai
Cesar Blum Silveira
Murat Girgin
N. Taylor Mullen
Nick Craver
John Luo
moozzyk
Ryan Nowak
Pavel Krymets
Pranav K
Chris R
Louis DeJardin
damianedwards