huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Prefer StringComparison over StringComparer when not using comparers (#870)

This commit is contained in:
James Newton-King 2018-10-18 11:55:33 +13:00 committed by GitHub
parent 5c31f1f455
commit e51da32e9d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Microsoft.AspNetCore.Routing/Internal/LinkGenerationDecisionTree.cs
View File

@ -164,9 +164,10 @@ namespace Microsoft.AspNetCore.Routing.Internal
return x.IsFallbackMatch.CompareTo(y.IsFallbackMatch); return x.IsFallbackMatch.CompareTo(y.IsFallbackMatch);
} }
return StringComparer.Ordinal.Compare( return string.Compare(
x.Match.Entry.RouteTemplate.TemplateText, x.Match.Entry.RouteTemplate.TemplateText,
y.Match.Entry.RouteTemplate.TemplateText); y.Match.Entry.RouteTemplate.TemplateText,
StringComparison.Ordinal);
} }
} }

2
src/Microsoft.AspNetCore.Routing/Matching/HttpMethodMatcherPolicy.cs
View File

@ -285,7 +285,7 @@ namespace Microsoft.AspNetCore.Routing.Matching
{ {
for (var i = 0; i < httpMethods.Count; i++) for (var i = 0; i < httpMethods.Count; i++)
{ {
if (StringComparer.OrdinalIgnoreCase.Equals(httpMethods[i], httpMethod)) if (string.Equals(httpMethods[i], httpMethod, StringComparison.OrdinalIgnoreCase))
{ {
return true; return true;
} }