From e51da32e9d8f2744d9dacd0946b64a851881b3e8 Mon Sep 17 00:00:00 2001 From: James Newton-King Date: Thu, 18 Oct 2018 11:55:33 +1300 Subject: [PATCH] Prefer StringComparison over StringComparer when not using comparers (#870) --- .../Internal/LinkGenerationDecisionTree.cs | 5 +++-- .../Matching/HttpMethodMatcherPolicy.cs | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/Microsoft.AspNetCore.Routing/Internal/LinkGenerationDecisionTree.cs b/src/Microsoft.AspNetCore.Routing/Internal/LinkGenerationDecisionTree.cs index 6242198a46..f276bf0658 100644 --- a/src/Microsoft.AspNetCore.Routing/Internal/LinkGenerationDecisionTree.cs +++ b/src/Microsoft.AspNetCore.Routing/Internal/LinkGenerationDecisionTree.cs @@ -164,9 +164,10 @@ namespace Microsoft.AspNetCore.Routing.Internal return x.IsFallbackMatch.CompareTo(y.IsFallbackMatch); } - return StringComparer.Ordinal.Compare( + return string.Compare( x.Match.Entry.RouteTemplate.TemplateText, - y.Match.Entry.RouteTemplate.TemplateText); + y.Match.Entry.RouteTemplate.TemplateText, + StringComparison.Ordinal); } } diff --git a/src/Microsoft.AspNetCore.Routing/Matching/HttpMethodMatcherPolicy.cs b/src/Microsoft.AspNetCore.Routing/Matching/HttpMethodMatcherPolicy.cs index b03c307a21..f1ec26d67d 100644 --- a/src/Microsoft.AspNetCore.Routing/Matching/HttpMethodMatcherPolicy.cs +++ b/src/Microsoft.AspNetCore.Routing/Matching/HttpMethodMatcherPolicy.cs @@ -285,7 +285,7 @@ namespace Microsoft.AspNetCore.Routing.Matching { for (var i = 0; i < httpMethods.Count; i++) { - if (StringComparer.OrdinalIgnoreCase.Equals(httpMethods[i], httpMethod)) + if (string.Equals(httpMethods[i], httpMethod, StringComparison.OrdinalIgnoreCase)) { return true; }