huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Try re-enabling CancellationToken tests for StreamAdapters (#6755)

This commit is contained in:
Justin Kotalik 2019-02-08 10:10:38 -08:00 committed by GitHub
parent 45ecfad074
commit e3d0dc0a96
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Http/Http/test/StreamPipeReaderTests.cs
View File

@ -148,7 +148,7 @@ namespace System.IO.Pipelines.Tests
Assert.NotEqual(readResult, readResult2); Assert.NotEqual(readResult, readResult2);
} }
[Fact(Skip = "https://github.com/aspnet/AspNetCore/issues/4621")] [Fact]
public async Task ReadCanBeCancelledViaProvidedCancellationToken() public async Task ReadCanBeCancelledViaProvidedCancellationToken()
{ {
var pipeReader = new StreamPipeReader(new HangingStream()); var pipeReader = new StreamPipeReader(new HangingStream());
@ -157,7 +157,7 @@ namespace System.IO.Pipelines.Tests
await Assert.ThrowsAsync<TaskCanceledException>(async () => await pipeReader.ReadAsync(cts.Token)); await Assert.ThrowsAsync<TaskCanceledException>(async () => await pipeReader.ReadAsync(cts.Token));
} }
[Fact(Skip = "https://github.com/aspnet/AspNetCore/issues/4621")] [Fact]
public async Task ReadCanBeCanceledViaCancelPendingReadWhenReadIsAsync() public async Task ReadCanBeCanceledViaCancelPendingReadWhenReadIsAsync()
{ {
var pipeReader = new StreamPipeReader(new HangingStream()); var pipeReader = new StreamPipeReader(new HangingStream());

4
src/Http/Http/test/StreamPipeWriterTests.cs
View File

@ -133,7 +133,7 @@ namespace System.IO.Pipelines.Tests
} }
} }
[Fact(Skip = "https://github.com/aspnet/AspNetCore/issues/4621")] [Fact]
public async Task CancelPendingFlushBetweenWritesAllDataIsPreserved() public async Task CancelPendingFlushBetweenWritesAllDataIsPreserved()
{ {
Stream = new SingleWriteStream(); Stream = new SingleWriteStream();
@ -206,7 +206,7 @@ namespace System.IO.Pipelines.Tests
Assert.True(flushResult.IsCanceled); Assert.True(flushResult.IsCanceled);
} }
[Fact(Skip = "https://github.com/aspnet/AspNetCore/issues/4621")] [Fact]
public async Task CancelPendingFlushLostOfCancellationsNoDataLost() public async Task CancelPendingFlushLostOfCancellationsNoDataLost()
{ {
var writeSize = 16; var writeSize = 16;